Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Fixed date range parameter widget can overflow in embed flows (#68724)

Sébastien13af38d9ca88
diff --git a/.loki/reference/chrome_laptop_Components_Parameters_ParameterValueWidget_Default.png b/.loki/reference/chrome_laptop_Components_Parameters_ParameterValueWidget_Default.png
new file mode 100644
index 00000000000..cd59c9bfc4e
Binary files /dev/null and b/.loki/reference/chrome_laptop_Components_Parameters_ParameterValueWidget_Default.png differ
diff --git a/frontend/src/metabase/parameters/components/FormattedParameterValue/FormattedParameterValue.tsx b/frontend/src/metabase/parameters/components/FormattedParameterValue/FormattedParameterValue.tsx
index 84951641243..dd092ac3527 100644
--- a/frontend/src/metabase/parameters/components/FormattedParameterValue/FormattedParameterValue.tsx
+++ b/frontend/src/metabase/parameters/components/FormattedParameterValue/FormattedParameterValue.tsx
@@ -90,7 +90,7 @@ function FormattedParameterValue({
);
};
- if (isStringParameter(parameter)) {
+ if (isStringParameter(parameter) || isDateParameter(parameter)) {
const hasLongValue = typeof first === "string" && first.length > 80;
return (
<Ellipsified
diff --git a/frontend/src/metabase/parameters/components/ParameterValueWidget.stories.tsx b/frontend/src/metabase/parameters/components/ParameterValueWidget.stories.tsx
new file mode 100644
index 00000000000..7752480f1b8
--- /dev/null
+++ b/frontend/src/metabase/parameters/components/ParameterValueWidget.stories.tsx
@@ -0,0 +1,58 @@
+// @ts-expect-error There is no type definition
+import createAsyncCallback from "@loki/create-async-callback";
+import { Box } from "@mantine/core";
+import { useArgs } from "@storybook/preview-api";
+import type { StoryFn } from "@storybook/react";
+import { userEvent, within } from "@storybook/test";
+
+import { ReduxProvider } from "__support__/storybook";
+import { createMockParameter } from "metabase-types/api/mocks";
+
+import {
+ ParameterValueWidget,
+ type ParameterValueWidgetProps,
+} from "./ParameterValueWidget";
+
+export default {
+ title: "Components/Parameters/ParameterValueWidget",
+ component: ParameterValueWidget,
+};
+
+const Template: StoryFn<ParameterValueWidgetProps> = (args) => {
+ const [{ value }, updateArgs] = useArgs();
+
+ const setValue = (value: string | number | null) => {
+ updateArgs({ value });
+ };
+
+ return (
+ <ReduxProvider>
+ <Box maw={220} p={100}>
+ <ParameterValueWidget {...args} value={value} setValue={setValue} />
+ </Box>
+ <Box pos="absolute" w={500} h={200} />
+ </ReduxProvider>
+ );
+};
+
+export const Default = {
+ render: Template,
+
+ args: {
+ value: "2025-12-16~2025-12-19",
+ parameter: createMockParameter({ id: "test-field", type: "date" }),
+ },
+
+ play: async ({ canvasElement }: { canvasElement: HTMLCanvasElement }) => {
+ const asyncCallback = createAsyncCallback();
+ const canvas = within(canvasElement);
+
+ // To force the tooltip to show up
+ await userEvent.hover(
+ (await canvas.findByText("December 16, 2025 - December 19, 2025"))
+ .parentElement!,
+ );
+
+ asyncCallback();
+ },
+};
diff --git a/frontend/src/metabase/parameters/components/ParameterValueWidget.tsx b/frontend/src/metabase/parameters/components/ParameterValueWidget.tsx
index 89fbe34b065..5593563d3f4 100644
--- a/frontend/src/metabase/parameters/components/ParameterValueWidget.tsx
+++ b/frontend/src/metabase/parameters/components/ParameterValueWidget.tsx
@@ -261,6 +261,7 @@ export const ParameterValueWidget = ({
data-testid="parameter-value-widget-target"
onClick={toggle}
className={CS.cursorPointer}
+ maw="100%"
>
<Sortable
id={parameter.id}
@@ -280,7 +281,12 @@ export const ParameterValueWidget = ({
<div
className={CS.mr1}
style={
- isStringParameter(parameter) ? { maxWidth: "190px" } : {}
+ isStringParameter(parameter)
+ ? { maxWidth: "190px" }
+ : {
+ overflow: "hidden",
+ textOverflow: "ellipsis",
+ }
}
>
<FormattedParameterValue
diff --git a/frontend/src/metabase/parameters/components/ParameterValueWidgetTrigger.tsx b/frontend/src/metabase/parameters/components/ParameterValueWidgetTrigger.tsx
index 1c9550f1916..f2ffca88f95 100644
--- a/frontend/src/metabase/parameters/components/ParameterValueWidgetTrigger.tsx
+++ b/frontend/src/metabase/parameters/components/ParameterValueWidgetTrigger.tsx
@@ -65,6 +65,7 @@ function ParameterValueWidgetTriggerInner(
[S.selected]: hasValue,
})}
aria-label={ariaLabel}
+ maw="100%"
{...attributes}
>
{children}