Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Fix: UXW-2171 Prevents "Edit Query" from clearing name on chart (#65224)

Brad Anderson1447fa0e958d
diff --git a/e2e/test/scenarios/documents/documents.cy.spec.ts b/e2e/test/scenarios/documents/documents.cy.spec.ts
index 38a82fa2f5d..d205ec41934 100644
--- a/e2e/test/scenarios/documents/documents.cy.spec.ts
+++ b/e2e/test/scenarios/documents/documents.cy.spec.ts
@@ -714,6 +714,31 @@ H.describeWithSnowplowEE("documents", () => {
H.getDocumentCard("Orders").should("exist");
});
+ it("should support renaming cards", () => {
+ cy.log("Add card");
+ H.documentContent().click();
+ H.addToDocument("/", false);
+ H.commandSuggestionItem("Chart").click();
+ H.commandSuggestionDialog()
+ .findByText(PRODUCTS_COUNT_BY_CATEGORY_PIE.name)
+ .click();
+
+ cy.log("Rename card");
+ cy.findByTestId("card-embed-title").realHover();
+ cy.icon("pencil").click();
+ cy.realType("New name{enter}");
+
+ cy.log("Edit query");
+ H.openDocumentCardMenu("New name");
+ H.popover().findByText("Edit Query").click();
+ H.removeSummaryGroupingField({ field: "Category" });
+ H.addSummaryGroupingField({ field: "Price" });
+ H.modal().findByRole("button", { name: "Save and use" }).click();
+
+ cy.log("Assert new name is preserved");
+ H.getDocumentCard("New name").should("exist");
+ });
+
it("should support resizing cards", () => {
H.documentContent().click();
H.addToDocument("/", false);
diff --git a/enterprise/frontend/src/metabase-enterprise/rich_text_editing/tiptap/extensions/CardEmbed/CardEmbedNode.tsx b/enterprise/frontend/src/metabase-enterprise/rich_text_editing/tiptap/extensions/CardEmbed/CardEmbedNode.tsx
index b206f67e284..2d506228a9d 100644
--- a/enterprise/frontend/src/metabase-enterprise/rich_text_editing/tiptap/extensions/CardEmbed/CardEmbedNode.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/rich_text_editing/tiptap/extensions/CardEmbed/CardEmbedNode.tsx
@@ -884,7 +884,6 @@ export const CardEmbedComponent = memo(
onSave={(result) => {
updateAttributes({
id: result.card_id,
- name: null,
});
setIsModifyModalOpen(false);
}}
@@ -897,7 +896,6 @@ export const CardEmbedComponent = memo(
onSave={(result) => {
updateAttributes({
id: result.card_id,
- name: null,
});
setIsModifyModalOpen(false);
}}
diff --git a/enterprise/frontend/src/metabase-enterprise/rich_text_editing/tiptap/extensions/CardEmbed/ModifyQuestionModal.tsx b/enterprise/frontend/src/metabase-enterprise/rich_text_editing/tiptap/extensions/CardEmbed/ModifyQuestionModal.tsx
index 91384d27fc8..f03c7bd2d64 100644
--- a/enterprise/frontend/src/metabase-enterprise/rich_text_editing/tiptap/extensions/CardEmbed/ModifyQuestionModal.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/rich_text_editing/tiptap/extensions/CardEmbed/ModifyQuestionModal.tsx
@@ -22,7 +22,7 @@ interface ModifyQuestionModalProps {
card: Card;
isOpen: boolean;
onClose: () => void;
- onSave: (result: { card_id: number; name: string }) => void;
+ onSave: (result: { card_id: number }) => void;
}
export const ModifyQuestionModal = ({
@@ -110,7 +110,7 @@ export const ModifyQuestionModal = ({
}),
);
- onSave({ card_id: newCardId, name: card.name });
+ onSave({ card_id: newCardId });
onClose();
} catch (error) {
console.error("Failed to save modified question:", error);
diff --git a/enterprise/frontend/src/metabase-enterprise/rich_text_editing/tiptap/extensions/CardEmbed/NativeQueryModal.tsx b/enterprise/frontend/src/metabase-enterprise/rich_text_editing/tiptap/extensions/CardEmbed/NativeQueryModal.tsx
index 9cbd2c82cab..04a04cfcf35 100644
--- a/enterprise/frontend/src/metabase-enterprise/rich_text_editing/tiptap/extensions/CardEmbed/NativeQueryModal.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/rich_text_editing/tiptap/extensions/CardEmbed/NativeQueryModal.tsx
@@ -33,7 +33,7 @@ interface NativeQueryModalProps {
card: Card;
isOpen: boolean;
onClose: () => void;
- onSave: (result: { card_id: number; name: string }) => void;
+ onSave: (result: { card_id: number }) => void;
initialDataset?: Dataset;
}
@@ -231,7 +231,7 @@ export const NativeQueryModal = ({
}),
);
- onSave({ card_id: newCardId, name: card.name });
+ onSave({ card_id: newCardId });
onClose();
}, [modifiedQuestion, card, dispatch, onSave, onClose]);