Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Allow medallion values on read (#69158)

Dan Stone14d95aaf440d
diff --git a/src/metabase/warehouse_schema/models/table.clj b/src/metabase/warehouse_schema/models/table.clj
index 4edfec00404..ab11ebf6e7b 100644
--- a/src/metabase/warehouse_schema/models/table.clj
+++ b/src/metabase/warehouse_schema/models/table.clj
@@ -111,10 +111,25 @@
:status-code 400}))))
(some-> value name))})
+(def ^:private transform-data-layer
+ {:in (:in mi/transform-keyword)
+ :out (comp (some-fn data-layers
+ ;; some databases may retain prior medallion values
+ ;; this is due to race conditions with migrations (migration runs can contend with running writes)
+ ;; e.g. we saw the prior values retained for the sync of a new search index table in stats.
+ ;; we might later have a second migration and risk removing this map or find a better way
+ ;; to make breaking enum migrations.
+ {:copper :hidden
+ :bronze :final
+ :silver :final
+ :gold :final}
+ identity)
+ (:out mi/transform-keyword))})
+
(t2/deftransforms :model/Table
{:entity_type mi/transform-keyword
:visibility_type mi/transform-keyword
- :data_layer (mi/transform-validator mi/transform-keyword (partial mi/assert-optional-enum data-layers))
+ :data_layer (mi/transform-validator transform-data-layer (partial mi/assert-optional-enum data-layers))
:field_order mi/transform-keyword
:data_source (mi/transform-validator mi/transform-keyword (partial mi/assert-optional-enum data-sources))
;; Warning: by using a transform to handle unexpected enum values, serialization becomes lossy