The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Fixed dancing MB (#71211)
Sébastien1827c0c37de2
diff --git a/e2e/support/helpers/embedding-sdk-component-testing/component-embedding-sdk-helpers.tsx b/e2e/support/helpers/embedding-sdk-component-testing/component-embedding-sdk-helpers.tsxindex cc9bb914c54..45487de064d 100644--- a/e2e/support/helpers/embedding-sdk-component-testing/component-embedding-sdk-helpers.tsx+++ b/e2e/support/helpers/embedding-sdk-component-testing/component-embedding-sdk-helpers.tsx@@ -45,15 +45,17 @@ export function mountSdkContent(}const reactNode = (- <MetabaseProvider- {...sdkProviderProps}- authConfig={{- ...DEFAULT_SDK_AUTH_PROVIDER_CONFIG,- ...sdkProviderProps?.authConfig,- }}- >- {children}- </MetabaseProvider>+ <div style={{ height: 800 }}>+ <MetabaseProvider+ {...sdkProviderProps}+ authConfig={{+ ...DEFAULT_SDK_AUTH_PROVIDER_CONFIG,+ ...sdkProviderProps?.authConfig,+ }}+ >+ {children}+ </MetabaseProvider>+ </div>);if (strictMode) {diff --git a/frontend/src/embedding-sdk-bundle/components/public/dashboard/SdkDashboardStyleWrapper.module.css b/frontend/src/embedding-sdk-bundle/components/public/dashboard/SdkDashboardStyleWrapper.module.cssindex d41bbf66067..1d0dfff9e6c 100644--- a/frontend/src/embedding-sdk-bundle/components/public/dashboard/SdkDashboardStyleWrapper.module.css+++ b/frontend/src/embedding-sdk-bundle/components/public/dashboard/SdkDashboardStyleWrapper.module.css@@ -1,4 +1,5 @@.SdkDashboardStyleWrapper {- min-height: 100vh;+ min-height: 100%;background-color: var(--mb-color-bg-dashboard);+ scrollbar-gutter: stable;}diff --git a/frontend/src/metabase/app-embed-sdk.tsx b/frontend/src/metabase/app-embed-sdk.tsxindex 41e3895ef1c..473ca17c7c5 100644--- a/frontend/src/metabase/app-embed-sdk.tsx+++ b/frontend/src/metabase/app-embed-sdk.tsx@@ -30,6 +30,8 @@ import { SdkIframeEmbedRoute } from "metabase/embedding/embedding-iframe-sdk/comfunction _init() {document.body.style.margin = "0";document.body.style.backgroundColor = "transparent";+ document.documentElement.style.overflow = "hidden";+ document.documentElement.style.height = "100vh";const rootElement = document.getElementById("root");diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk/components/SdkIframeEmbedRoute.module.css b/frontend/src/metabase/embedding/embedding-iframe-sdk/components/SdkIframeEmbedRoute.module.cssindex ea9b8453ed5..0f93d8edb53 100644--- a/frontend/src/metabase/embedding/embedding-iframe-sdk/components/SdkIframeEmbedRoute.module.css+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk/components/SdkIframeEmbedRoute.module.css@@ -2,11 +2,11 @@display: grid;width: 100%;grid-template-columns: 1fr;- grid-template-rows: 1fr;+ grid-template-rows: minmax(0, 1fr);}.Container:has(.BrandingFooter) {- grid-template-rows: 1fr auto;+ grid-template-rows: minmax(0, 1fr) auto;}.Dashboard {diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk/components/SdkIframeEmbedRoute.tsx b/frontend/src/metabase/embedding/embedding-iframe-sdk/components/SdkIframeEmbedRoute.tsxindex 11480181c6f..2c3891d2737 100644--- a/frontend/src/metabase/embedding/embedding-iframe-sdk/components/SdkIframeEmbedRoute.tsx+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk/components/SdkIframeEmbedRoute.tsx@@ -105,7 +105,7 @@ export const SdkIframeEmbedRoute = () => {isLocalHost={embedSettings._isLocalhost}><Stack- mih="100vh"+ h="100vh"className={SdkIframeEmbedRouteS.Container}style={{backgroundColor: adjustedTheme?.colors?.background,