The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Fix missing translation in guest embed filters (#70583)
Sébastien186c9dca6539
diff --git a/e2e/test/scenarios/admin/i18n/content-translation/dashboards.cy.spec.ts b/e2e/test/scenarios/admin/i18n/content-translation/dashboards.cy.spec.tsindex c16757ca2e2..29cf0bc5686 100644--- a/e2e/test/scenarios/admin/i18n/content-translation/dashboards.cy.spec.ts+++ b/e2e/test/scenarios/admin/i18n/content-translation/dashboards.cy.spec.ts@@ -805,6 +805,82 @@ describe("scenarios > content translation > static embeds > dashboards", () => {});});});++ it("translates selected static-list filter label in guest embed", () => {+ const staticListFilter = {+ name: "Number",+ slug: "number",+ id: "static-list-id",+ type: "number/=",+ sectionId: "number",+ values_source_type: "static-list" as const,+ values_source_config: {+ values: [+ ["1", "Gadget"],+ ["2", "Widget"],+ ],+ },+ };++ cy.signInAsAdmin();+ H.createQuestionAndDashboard({+ questionDetails: {+ name: "Expression Question",+ query: {+ "source-table": PEOPLE_ID,+ },+ },+ dashboardDetails: {+ parameters: [staticListFilter as any], // current API isn't set to accept string[][] as values+ enable_embedding: true,+ embedding_params: {+ [staticListFilter.slug]: "enabled",+ },+ },+ }).then(({ body: { id, card_id, dashboard_id } }) => {+ // Map the parameter to an expression column so the filter widget+ // is visible, but hasFields() returns false (testing the tc()+ // fix in FormattedParameterValue)+ cy.request("PUT", `/api/dashboard/${dashboard_id}`, {+ dashcards: [+ {+ id,+ card_id,+ row: 0,+ col: 0,+ size_x: 24,+ size_y: 9,+ parameter_mappings: [+ {+ parameter_id: staticListFilter.id,+ card_id,+ target: [+ "dimension",+ ["expression", "Thing", { "base-type": "type/Integer" }],+ { "stage-number": 0 },+ ],+ },+ ],+ },+ ],+ });++ H.visitEmbeddedPage(+ {+ resource: { dashboard: dashboard_id as number },+ params: {},+ },+ {+ setFilters: { [staticListFilter.slug]: "1" },+ additionalHashOptions: {+ locale: "de",+ },+ },+ );++ H.filterWidget().findByText("Gerät").should("be.visible");+ });+ });});});diff --git a/frontend/src/metabase/parameters/components/FormattedParameterValue/FormattedParameterValue.tsx b/frontend/src/metabase/parameters/components/FormattedParameterValue/FormattedParameterValue.tsxindex dd092ac3527..767d3c316fb 100644--- a/frontend/src/metabase/parameters/components/FormattedParameterValue/FormattedParameterValue.tsx+++ b/frontend/src/metabase/parameters/components/FormattedParameterValue/FormattedParameterValue.tsx@@ -2,6 +2,7 @@ import { t } from "ttag";import { Ellipsified } from "metabase/common/components/Ellipsified";import { useSetting } from "metabase/common/hooks";+import { useTranslateContent } from "metabase/i18n/hooks";import { ParameterFieldWidgetValue } from "metabase/parameters/components/widgets/ParameterFieldWidget/ParameterFieldWidgetValue/ParameterFieldWidgetValue";import { formatParameterValue } from "metabase/parameters/utils/formatting";import type { UiParameter } from "metabase-lib/v1/parameters/types";@@ -42,6 +43,7 @@ function FormattedParameterValue({placeholder,isPopoverOpen = false,}: FormattedParameterValueProps) {+ const tc = useTranslateContent();const formattingSettings = useSetting("custom-formatting");if (parameterHasNoDisplayValue(value)) {@@ -80,7 +82,7 @@ function FormattedParameterValue({if (label) {return (<span>- {formatParameterValue(label, parameter, formattingSettings)}+ {formatParameterValue(tc(label), parameter, formattingSettings)}</span>);}