Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Fix failing Loki test caused by #82684 (#82713)

Kevin Kelleher188c8f412f70
diff --git a/frontend/src/metabase/viz-core/lib/remapping.ts b/frontend/src/metabase/viz-core/lib/remapping.ts
index e5bd366360a..43248bac0ee 100644
--- a/frontend/src/metabase/viz-core/lib/remapping.ts
+++ b/frontend/src/metabase/viz-core/lib/remapping.ts
@@ -9,7 +9,7 @@ import type {
const getRemapping = (col: RemappingHydratedDatasetColumn) => {
// copy existing entries so this is idempotent, without mutating the caller's Map
- if (col.remapping) {
+ if (col.remapping instanceof Map) {
return new Map(col.remapping);
}
if (col.remapped_to != null) {
diff --git a/frontend/src/metabase/viz-core/lib/remapping.unit.spec.ts b/frontend/src/metabase/viz-core/lib/remapping.unit.spec.ts
index 86f60813ca4..f332066e9c6 100644
--- a/frontend/src/metabase/viz-core/lib/remapping.unit.spec.ts
+++ b/frontend/src/metabase/viz-core/lib/remapping.unit.spec.ts
@@ -1,4 +1,4 @@
-import type { DatasetData } from "metabase-types/api";
+import type { DatasetColumn, DatasetData } from "metabase-types/api";
import {
createMockColumn,
createMockDatasetData,
@@ -82,6 +82,17 @@ describe("extractRemappedColumns", () => {
);
});
+ it("does not throw when remapping is a JSON-serialized empty object", () => {
+ const data = remappedCategoryData();
+ data.cols[0] = createMockColumn({
+ ...data.cols[0],
+ // JSON.stringify(Map) is always {}; storybook/loki fixtures have this shape
+ remapping: {} as DatasetColumn["remapping"],
+ });
+
+ expect(() => extractRemappedColumns(data)).not.toThrow();
+ });
+
it("does not mutate the input column's remapping Map", () => {
const existingRemapping = new Map([[1, "Type A"]]);
const data = remappedCategoryData();