Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Ensure mage -test runs every test namespace (#82051)

Chris Truter18f216de52f9
diff --git a/mage/test/mage/core_test.clj b/mage/test/mage/core_test.clj
index 6ca8321c14e..580311cdb06 100644
--- a/mage/test/mage/core_test.clj
+++ b/mage/test/mage/core_test.clj
@@ -22,6 +22,7 @@
[mage.merge-yaml-migrations-test]
[mage.modules-test]
[mage.project-tests-test]
+ [mage.quick-test-runner-test]
[mage.shell-test]
[mage.token-scan-test]
[mage.util :as u]
@@ -29,6 +30,28 @@
(set! *warn-on-reflection* true)
+;; Documented in its own namespace as manual-only: it creates temporary git repositories and branches.
+(def ^:private not-run-by-mage-test
+ '#{mage.merge-yaml-migrations-integration-test})
+
+(defn- test-namespaces-on-disk []
+ (let [root (fs/path u/project-root-directory "mage" "test")]
+ (into #{}
+ (map (fn [path]
+ (-> (str (fs/relativize root path))
+ (str/replace #"\.clj$" "")
+ (str/replace "_" "-")
+ (str/replace "/" ".")
+ symbol)))
+ (fs/glob root "**/*_test.clj"))))
+
+(deftest every-test-namespace-is-loaded-test
+ (testing "every mage test namespace is required, so `mage -test` actually runs it"
+ (let [missing (sort (remove find-ns (apply disj (test-namespaces-on-disk) not-run-by-mage-test)))]
+ (is (empty? missing)
+ (str "Add these to this namespace's :require. `mage -test` runs `run-all-tests`, which only sees "
+ "loaded namespaces, so nothing else reports them: " (str/join ", " missing))))))
+
(deftest bin-mage-has-help-test
(doseq [help-cmds [[] [" "] [" "] ["-h"] ["--help"] [" -h"] [" --help"] [" -h"] [" --help"]]
:let [cmd (str "./bin/mage " (str/join " " help-cmds))
diff --git a/mage/test/mage/runtests.clj b/mage/test/mage/runtests.clj
deleted file mode 100644
index 7ffd1113eaa..00000000000
--- a/mage/test/mage/runtests.clj
+++ /dev/null
@@ -1,18 +0,0 @@
-(ns mage.runtests
- (:require
- [clojure.test :as t]))
-
-(set! *warn-on-reflection* true)
-
-(def ^:private test-ns
- ['mage.core-test
- 'mage.quick-test-runner-test
- 'mage.start-db-test])
-
-(when (= *file* (System/getProperty "babashka.file"))
- (doseq [tns test-ns]
- (println "Requiring test namespace:" tns)
- (require tns)
- (println "Running tests in namespace:" tns)
- (t/run-tests tns))
- :ok)
diff --git a/mage/test/mage/start_db_test.clj b/mage/test/mage/start_db_test.clj
deleted file mode 100644
index f4440ca236e..00000000000
--- a/mage/test/mage/start_db_test.clj
+++ /dev/null
@@ -1,7 +0,0 @@
-(ns mage.start-db-test
- (:require
- [clojure.test :refer [deftest testing is]]))
-
-(deftest start-db-tests
- (testing "DB starts"
- (is "TODO add tests here")))