The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Re-enable starburst driver CI (#83781)
technomancy19d48d916961
diff --git a/.github/workflows/drivers.yml b/.github/workflows/drivers.ymlindex 1f0ba65922c..6a24ef5d3f7 100644--- a/.github/workflows/drivers.yml+++ b/.github/workflows/drivers.yml@@ -51,6 +51,7 @@ jobs:sparksql-should-run: ${{ steps.driver-decisions.outputs.sparksql-should-run }}sqlite-should-run: ${{ steps.driver-decisions.outputs.sqlite-should-run }}sqlserver-should-run: ${{ steps.driver-decisions.outputs.sqlserver-should-run }}+ starburst-should-run: ${{ steps.driver-decisions.outputs.starburst-should-run }}vertica-should-run: ${{ steps.driver-decisions.outputs.vertica-should-run }}steps:- name: Checkout repository@@ -1160,33 +1161,35 @@ jobs:upload-logs: ${{ steps.test-driver.outcome == 'failure' }}logs-artifact-suffix: ${{ matrix.job.name }} ${{ matrix.version.name }}- # TODO(dpsutton, 2025-08-20): Re-enable starburst when we figure out why it randomly dies in CI- # be-tests-starburst-ee:- # needs: determine-driver-skips- # if: ${{ !inputs.skip && !(needs.determine-driver-skips.outputs.skip == 'true') }}- # runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}- # timeout-minutes: 40- # env:- # CI: 'true'- # DRIVERS: starburst- # services:- # starburst:- # image: trinodb/trino:latest- # env:- # CATALOG_MANAGEMENT: dynamic- # ports:- # - "8080:8080"- # name: Starburst- # steps:- # - uses: actions/checkout@v7- # - name: Make plugins directory- # run: mkdir plugins- # - name: Test Starburst driver- # uses: ./.github/actions/test-driver- # with:- # junit-name: 'be-tests-starburst-ee'- # test-args: >-- # :only-tags [:mb/driver-tests]+ be-tests-starburst-ee:+ needs: determine-driver-skips+ if: ${{ needs.determine-driver-skips.outputs.starburst-should-run == 'true' }}+ # trino is a memory hog and frequently runs out of memory on 16GB runners.+ # note that running out of memory manifests as random job cancellations+ # that give no indication of memory being the root cause of the problem.+ runs-on: ubuntu-latest-8-cores+ timeout-minutes: 40+ env:+ CI: 'true'+ DRIVERS: starburst+ services:+ starburst:+ image: trinodb/trino:latest+ env:+ CATALOG_MANAGEMENT: dynamic+ ports:+ - "8080:8080"+ name: Starburst+ steps:+ - uses: actions/checkout@v7+ - name: Test Starburst driver+ id: test-driver+ uses: ./.github/actions/test-driver+ with:+ junit-name: 'be-tests-starburst-ee'+ test-args: >-+ :only-tags [:mb/driver-tests]+ :exclude-tags [:mb/transforms-python-test]login-to-ecr:needs: determine-driver-skips@@ -1239,8 +1242,6 @@ jobs:name: Verticasteps:- uses: actions/checkout@v7- - name: Make plugins directory- run: mkdir plugins- name: Test Vertica driverid: test-driveruses: ./.github/actions/test-driver@@ -1276,7 +1277,7 @@ jobs:- be-tests-sqlite-ee- be-tests-sqlserver- be-tests-vertica-ee- # - be-tests-starburst-ee+ - be-tests-starburst-eeruns-on: ${{ vars.SLIM_RUNNER_KEY }}timeout-minutes: 5name: drivers-tests-resultdiff --git a/bb.edn b/bb.ednindex 441d5bf4d56..42b1f6f1679 100644--- a/bb.edn+++ b/bb.edn@@ -141,7 +141,7 @@["./bin/mage start-db postgres latest --port 5555" "start postgres on a custom port"]]:requires [[mage.start-db :as start-db]]:arg-schema [:tuple- [:enum :postgres :mysql :mariadb :mongo :clickhouse :sqlserver :oracle]+ [:enum :postgres :mysql :mariadb :mongo :clickhouse :sqlserver :oracle :starburst][:enum :oldest :latest]]:options [["-p" "--port PORT" "Override the default host port for the container" :parse-fn Integer/parseInt]]:db-info {:postgres {:ports {:oldest 5432 :latest 5433} :eol-url "https://endoflife.date/api/postgres.json"}@@ -151,6 +151,7 @@:sqlserver {:ports {:oldest 1433 :latest 1434} :eol-url "https://endoflife.date/api/mssqlserver.json"}:oracle {:ports {:oldest 1521 :latest 1522} :eol-url "https://endoflife.date/api/oracle-database.json"};; some databases aren't on endoflife.date+ :starburst {:ports {:oldest 8084 :latest 8085} :eol-url nil}:clickhouse {:ports {:oldest 8124 :latest 8123} :eol-url nil}}:usage-fn start-db/usage:task (task!diff --git a/mage/src/mage/modules.clj b/mage/src/mage/modules.cljindex 25a76501171..290fb3a5278 100644--- a/mage/src/mage/modules.clj+++ b/mage/src/mage/modules.clj@@ -457,6 +457,7 @@:sparksql:sqlite:sqlserver+ :starburst:vertica])(def ^:private driver-directory->drivers@@ -474,8 +475,7 @@"snowflake" [:snowflake]"sparksql" [:sparksql]"sqlserver" [:sqlserver]- ;; starburst tests are currently disabled in drivers.yml- ;; "starburst" [:starburst]+ "starburst" [:starburst]"vertica" [:vertica]})(defn- drivers-with-file-changesdiff --git a/mage/src/mage/start_db.clj b/mage/src/mage/start_db.cljindex 295d853dea5..11540f2c1b2 100644--- a/mage/src/mage/start_db.clj+++ b/mage/src/mage/start_db.clj@@ -157,6 +157,14 @@"gvenzl/oracle-free:latest"(str "gvenzl/oracle-xe:" resolved-version))])+(defmethod docker-cmd :starburst+ [_db container-name resolved-version port]+ ["docker" "run" "-d"+ "-p" (str "127.0.0.1:" port ":8080")+ "-e" "CATALOG_MANAGEMENT=dynamic"+ "--name" container-name+ (str "trinodb/trino:" resolved-version)])+;; Client command stuff:(defmulti ^:private client-cmddiff --git a/modules/drivers/starburst/src/metabase/driver/starburst.clj b/modules/drivers/starburst/src/metabase/driver/starburst.cljindex 76af24925d7..d44177b2e57 100644--- a/modules/drivers/starburst/src/metabase/driver/starburst.clj+++ b/modules/drivers/starburst/src/metabase/driver/starburst.clj@@ -78,7 +78,9 @@:native-pivot-tables true:now true:database-routing true- :connection-impersonation true}]+ :connection-impersonation true+ :jdbc/set-query-timeout false+ :regex/lookaheads-and-lookbehinds false}](defmethod driver/database-supports? [:starburst feature] [_ _ _] supported?))(defn- format-field@@ -522,7 +524,8 @@(defmethod driver/describe-database* :starburst[driver database]- (let [{:keys [catalog schema]} (driver.conn/effective-details database)]+ (let [{:keys [catalog schema]} (driver.conn/effective-details database)+ catalog (u/lower-case-en catalog)](sql-jdbc.execute/do-with-connection-with-optionsdriverdatabasediff --git a/modules/drivers/starburst/test/metabase/test/data/starburst.clj b/modules/drivers/starburst/test/metabase/test/data/starburst.cljindex d4a2b9daa3b..46a9a5e1a92 100644--- a/modules/drivers/starburst/test/metabase/test/data/starburst.clj+++ b/modules/drivers/starburst/test/metabase/test/data/starburst.clj@@ -30,6 +30,8 @@(defmethod driver/database-supports? [:starburst :test/creates-db-on-connect] [_ _ _] true)(defmethod driver/database-supports? [:starburst :metabase.query-processor.string-extracts-test/concat-non-string-args] [_ _ _] false)(defmethod driver/database-supports? [:starburst :metabase.query-processor.alternative-date-test/yyyymmddhhss-binary-timestamps] [_ _ _] false)+;; tests for impersonation require creating roles, which trino doesn't support+(defmethod driver/database-supports? [:starburst :connection-impersonation] [_ _ _] false)(doseq [[base-type db-type] {:type/BigInteger "BIGINT":type/Boolean "BOOLEAN"