The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Stop the metabot viewing-context tests from depending on absent entity ids (#82248)
Romeo Van Snick1c5ba041d63d
diff --git a/test/metabase/metabot/agent/user_context_test.clj b/test/metabase/metabot/agent/user_context_test.cljindex a79aa389746..42a31c8234a 100644--- a/test/metabase/metabot/agent/user_context_test.clj+++ b/test/metabase/metabot/agent/user_context_test.clj@@ -13,6 +13,11 @@[metabase.test :as mt][toucan2.core :as t2]))+(def ^:private absent-entity-id+ "An id that no test fixture allocates. `format-entity` then gets a 404 and renders the entity from the+ fields the caller supplies. An id that does exist can instead give a 403, which renders nothing."+ Integer/MAX_VALUE)+(deftest ^:parallel format-current-time-test(testing "formats time from context with timezone"(let [context {:current_time_with_timezone "2024-01-15T14:30:00-05:00"}@@ -146,7 +151,7 @@(deftest ^:parallel format-viewing-context-test-2a(testing "formats table entity"(let [context {:user_is_viewing [{:type "table"- :id 123+ :id absent-entity-id:name "users":description "User accounts"}]}result (user-context/format-viewing-context context)]@@ -158,7 +163,7 @@(deftest ^:parallel format-viewing-context-test-2b(testing "formats model entity"(let [context {:user_is_viewing [{:type "model"- :id 456+ :id absent-entity-id:name "Revenue Model":description "Daily revenue metrics"}]}result (user-context/format-viewing-context context)]@@ -169,7 +174,7 @@(deftest ^:parallel format-viewing-context-test-2c(testing "formats question entity"(let [context {:user_is_viewing [{:type "question"- :id Integer/MAX_VALUE+ :id absent-entity-id:name "Top Customers"}]}result (user-context/format-viewing-context context)](is (some? result))@@ -179,7 +184,7 @@(deftest ^:parallel format-viewing-context-test-2d(testing "formats metric entity"(let [context {:user_is_viewing [{:type "metric"- :id (dec Integer/MAX_VALUE)+ :id absent-entity-id:name "Total Revenue"}]}result (user-context/format-viewing-context context)](is (some? result))@@ -189,7 +194,7 @@(deftest ^:parallel format-viewing-context-test-2e(testing "formats dashboard entity"(let [context {:user_is_viewing [{:type "dashboard"- :id (- Integer/MAX_VALUE 2)+ :id absent-entity-id:name "Executive Dashboard"}]}result (user-context/format-viewing-context context)](is (some? result))@@ -199,7 +204,7 @@(deftest ^:parallel format-viewing-context-test-2f(testing "handles keyword types in viewing context"(let [context {:user_is_viewing [{:type :table- :id 321+ :id absent-entity-id:name "orders"}]}result (user-context/format-viewing-context context)](is (some? result))@@ -214,8 +219,8 @@(deftest ^:parallel format-viewing-context-test-2h(testing "handles multiple viewing items"- (let [context {:user_is_viewing [{:type "table" :id 321 :name "users"}- {:type "question" :id 2 :name "Top Users"}]}+ (let [context {:user_is_viewing [{:type "table" :id absent-entity-id :name "users"}+ {:type "question" :id absent-entity-id :name "Top Users"}]}result (user-context/format-viewing-context context)](is (some? result))(is (re-find #"users" result))