Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Update minimum App DB versions (#70446)

Ben Grabow1ccf800deee4
diff --git a/.github/workflows/app-db.yml b/.github/workflows/app-db.yml
index ec1aca87042..eddb2055cec 100644
--- a/.github/workflows/app-db.yml
+++ b/.github/workflows/app-db.yml
@@ -20,9 +20,9 @@ jobs:
fail-fast: false
matrix:
version:
- - name: MariaDB 10.2
- junit-name: be-tests-mariadb-10-2-ee
- image: circleci/mariadb:10.2.23
+ - name: MariaDB 10.6
+ junit-name: be-tests-mariadb-10-6-ee
+ image: circleci/mariadb:10.6
env:
enable-ssl-tests: 'false'
- name: MariaDB Latest
@@ -100,7 +100,7 @@ jobs:
MB_MYSQL_SSL_TEST_USER: metabase
MB_MYSQL_SSL_TEST_PASSWORD: ${{ secrets.MYSQL_RDS_SSL_INSTANCE_PASSWORD }}
# for historic reasons (I don't want to mess around with required jobs) the job name should be something like
- # "be-tests-mariadb-10-2-ee (0)"
+ # "be-tests-mariadb-10-6-ee (0)"
name: "${{ matrix.version.name }} ${{ matrix.job.name }}"
steps:
- uses: actions/checkout@v4
@@ -134,9 +134,9 @@ jobs:
fail-fast: false
matrix:
version:
- - name: MySQL 8.0
- junit-name: be-tests-mysql-8-0-ee
- image: cimg/mysql:8.0
+ - name: MySQL 8.4
+ junit-name: be-tests-mysql-8-4-ee
+ image: cimg/mysql:8.4
env:
enable-ssl-tests: 'false'
enable-aws-iam-tests: 'false'
@@ -224,7 +224,7 @@ jobs:
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_AURORA_IAM_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_AURORA_IAM_SECRET_ACCESS_KEY }}
# for historic reasons (I don't want to mess around with required jobs) the job name should be something like
- # "be-tests-mariadb-10-2-ee (0)"
+ # "be-tests-mariadb-10-6-ee (0)"
name: "${{ matrix.version.name }} ${{ matrix.job.name }}"
steps:
- uses: actions/checkout@v4
@@ -258,9 +258,9 @@ jobs:
fail-fast: false
matrix:
version:
- - name: Postgres 12.x
+ - name: Postgres 14.x
junit-name: postgres-ee
- docker-image: postgres:12-alpine
+ docker-image: postgres:14-alpine
env:
enable-ssl-tests: 'false'
enable-aws-iam-tests: 'false'
diff --git a/.github/workflows/cross-branch-migrations.yml b/.github/workflows/cross-branch-migrations.yml
index 4a20476721a..d38fe102a16 100644
--- a/.github/workflows/cross-branch-migrations.yml
+++ b/.github/workflows/cross-branch-migrations.yml
@@ -38,7 +38,7 @@ jobs:
base-ref: ${{ env.BASE_REF }}
head-ref: ${{ env.HEAD_REF }}
- migrations-postgres-12-ee:
+ migrations-postgres-14-ee:
runs-on: ubuntu-22.04
timeout-minutes: 10
env:
@@ -50,7 +50,7 @@ jobs:
MB_DB_USER: circle_test
services:
postgres:
- image: postgres:12-alpine
+ image: postgres:14-alpine
ports:
- "5432:5432"
env:
@@ -90,7 +90,7 @@ jobs:
base-ref: ${{ env.BASE_REF }}
head-ref: ${{ env.HEAD_REF }}
- migrations-mysql-8-0-ee:
+ migrations-mysql-8-4-ee:
runs-on: ubuntu-22.04
timeout-minutes: 10
env:
@@ -102,7 +102,7 @@ jobs:
MB_DB_USER: root
services:
mysql:
- image: cimg/mysql:8.0
+ image: cimg/mysql:8.4
ports:
- "3306:3306"
steps:
@@ -138,7 +138,7 @@ jobs:
base-ref: ${{ env.BASE_REF }}
head-ref: ${{ env.HEAD_REF }}
- migrations-mariadb-10-2-ee:
+ migrations-mariadb-10-6-ee:
runs-on: ubuntu-22.04
timeout-minutes: 10
env:
@@ -150,7 +150,7 @@ jobs:
MB_DB_USER: root
services:
mariadb:
- image: circleci/mariadb:10.2.23
+ image: circleci/mariadb:10.6
ports:
- "3306:3306"
steps:
diff --git a/.github/workflows/drivers-stress-test.yml b/.github/workflows/drivers-stress-test.yml
index fa360ae778a..8283acda7f0 100644
--- a/.github/workflows/drivers-stress-test.yml
+++ b/.github/workflows/drivers-stress-test.yml
@@ -109,7 +109,7 @@ jobs:
junit-name: 'be-tests-druid-ee'
test-args: ":only ${{ inputs.test }} :times ${{ inputs.times }}"
- be-tests-mariadb-10-2-ee:
+ be-tests-mariadb-10-6-ee:
if: inputs.driver == 'Maria DB'
runs-on: ubuntu-22.04
timeout-minutes: 90
@@ -124,15 +124,15 @@ jobs:
MB_MYSQL_TEST_USER: root
services:
mariadb:
- image: circleci/mariadb:10.2.23
+ image: circleci/mariadb:10.6
ports:
- "3306:3306"
steps:
- uses: actions/checkout@v4
- - name: Test MariaDB driver (10.2)
+ - name: Test MariaDB driver (10.6)
uses: ./.github/actions/test-driver
with:
- junit-name: 'be-tests-mariadb-10-2-ee'
+ junit-name: 'be-tests-mariadb-10-6-ee'
test-args: ":only ${{ inputs.test }} :times ${{ inputs.times }}"
be-tests-mariadb-latest-ee:
@@ -298,7 +298,7 @@ jobs:
junit-name: 'be-tests-mongo-latest-ee'
test-args: ":only ${{ inputs.test }} :times ${{ inputs.times }}"
- be-tests-mysql-8-0-ee:
+ be-tests-mysql-8-4-ee:
if: inputs.driver == 'MySQL'
runs-on: ubuntu-22.04
timeout-minutes: 90
@@ -313,15 +313,15 @@ jobs:
MB_MYSQL_TEST_USER: root
services:
mysql:
- image: cimg/mysql:8.0
+ image: cimg/mysql:8.4
ports:
- "3306:3306"
steps:
- uses: actions/checkout@v4
- - name: Test MySQL driver (8.0)
+ - name: Test MySQL driver (8.4)
uses: ./.github/actions/test-driver
with:
- junit-name: 'be-tests-mysql-8-0-ee'
+ junit-name: 'be-tests-mysql-8-4-ee'
test-args: ":only ${{ inputs.test }} :times ${{ inputs.times }}"
be-tests-mysql-latest-ee:
@@ -438,7 +438,7 @@ jobs:
MB_POSTGRESQL_TEST_USER: mb_test
services:
postgres:
- image: postgres:12-alpine
+ image: postgres:14-alpine
ports:
- "5432:5432"
env:
@@ -447,7 +447,7 @@ jobs:
POSTGRES_HOST_AUTH_METHOD: trust
steps:
- uses: actions/checkout@v4
- - name: Test Postgres driver (12)
+ - name: Test Postgres driver (14)
uses: ./.github/actions/test-driver
with:
junit-name: 'be-tests-postgres-ee'
diff --git a/.github/workflows/drivers.yml b/.github/workflows/drivers.yml
index f79a2af0aec..ce6a8ccf614 100644
--- a/.github/workflows/drivers.yml
+++ b/.github/workflows/drivers.yml
@@ -561,9 +561,9 @@ jobs:
fail-fast: false
matrix:
version:
- - name: MariaDB 10.2
- junit-name: be-tests-mariadb-10-2-ee
- image: circleci/mariadb:10.2.23
+ - name: MariaDB 10.6
+ junit-name: be-tests-mariadb-10-6-ee
+ image: circleci/mariadb:10.6
env:
enable-ssl-tests: 'false'
enable-aws-iam-tests: 'false'
@@ -573,9 +573,9 @@ jobs:
env:
enable-ssl-tests: 'false'
enable-aws-iam-tests: 'false'
- - name: MySQL 8.0
- junit-name: be-tests-mysql-8-0-ee
- image: mysql:8.0
+ - name: MySQL 8.4
+ junit-name: be-tests-mysql-8-4-ee
+ image: mysql:8.4
env:
enable-ssl-tests: 'false'
enable-aws-iam-tests: 'false'
@@ -988,9 +988,9 @@ jobs:
fail-fast: false
matrix:
version:
- - name: Postgres 12.x
+ - name: Postgres 14.x
junit-name: postgres-ee
- docker-image: postgres:12-alpine
+ docker-image: postgres:14-alpine
env:
enable-ssl-tests: 'false'
enable-aws-iam-tests: 'false'
diff --git a/.github/workflows/semantic-search.yml b/.github/workflows/semantic-search.yml
index aa3c711e28b..f4fdb821260 100644
--- a/.github/workflows/semantic-search.yml
+++ b/.github/workflows/semantic-search.yml
@@ -75,9 +75,9 @@ jobs:
fail-fast: false
matrix:
version:
- - name: MariaDB 10.2 with pgvector pg17
- junit-name: semantic-search-tests-mariadb-10-2
- mariadb-image: circleci/mariadb:10.2.23
+ - name: MariaDB 10.6 with pgvector pg17
+ junit-name: semantic-search-tests-mariadb-10-6
+ mariadb-image: circleci/mariadb:10.6
pgvector-image: pgvector/pgvector:pg17
- name: MariaDB Latest with pgvector pg17
junit-name: semantic-search-tests-mariadb-latest
@@ -149,9 +149,9 @@ jobs:
fail-fast: false
matrix:
version:
- - name: MySQL 8.0 with pgvector pg17
- junit-name: semantic-search-tests-mysql-8-0
- mysql-image: cimg/mysql:8.0
+ - name: MySQL 8.4 with pgvector pg17
+ junit-name: semantic-search-tests-mysql-8-4
+ mysql-image: cimg/mysql:8.4
pgvector-image: pgvector/pgvector:pg17
- name: MySQL Latest with pgvector pg17
junit-name: semantic-search-tests-mysql-latest
@@ -223,9 +223,9 @@ jobs:
fail-fast: false
matrix:
version:
- - name: Postgres 12.x with pgvector pg17
- junit-name: semantic-search-tests-postgres-12
- postgres-image: postgres:12-alpine
+ - name: Postgres 14.x with pgvector pg17
+ junit-name: semantic-search-tests-postgres-14
+ postgres-image: postgres:14-alpine
pgvector-image: pgvector/pgvector:pg17
- name: Postgres Latest with pgvector pg17
junit-name: semantic-search-tests-postgres-latest
diff --git a/resources/metabase/app_db/supported-db-versions.edn b/resources/metabase/app_db/supported-db-versions.edn
index 3f943179886..56135e45a45 100644
--- a/resources/metabase/app_db/supported-db-versions.edn
+++ b/resources/metabase/app_db/supported-db-versions.edn
@@ -2,6 +2,6 @@
;; Documentation reference:
;; https://www.metabase.com/docs/latest/installation-and-operation/migrating-from-h2#supported-databases-for-storing-your-metabase-application-data
{:h2 {:major 2 :minor 1 :patch 214}
- :postgres {:major 12 :minor 0 :patch 0}
- :mysql {:major 8 :minor 0 :patch 17}
- :mariadb {:major 10 :minor 2 :patch 2}}
+ :postgres {:major 14 :minor 0 :patch 0}
+ :mysql {:major 8 :minor 4 :patch 0}
+ :mariadb {:major 10 :minor 6 :patch 0}}
diff --git a/test/metabase/app_db/setup_test.clj b/test/metabase/app_db/setup_test.clj
index b9fab74c2dd..ff88e02eaa0 100644
--- a/test/metabase/app_db/setup_test.clj
+++ b/test/metabase/app_db/setup_test.clj
@@ -29,40 +29,16 @@
(deftest supported-app-db-version?-test
(testing "Should be able to check if an app DB is a supported version"
- (testing "for H2"
- (is (true? (#'mdb.setup/supported-app-db-version? :h2 {:major 2 :minor 1 :patch 214})))
- (is (true? (#'mdb.setup/supported-app-db-version? :h2 {:major 3 :minor 1 :patch 214})))
- (is (true? (#'mdb.setup/supported-app-db-version? :h2 {:major 2 :minor 2 :patch 0})))
- (is (true? (#'mdb.setup/supported-app-db-version? :h2 {:major 3 :minor 0 :patch 0})))
- (is (false? (#'mdb.setup/supported-app-db-version? :h2 {:major 2 :minor 1 :patch 213})))
- (is (false? (#'mdb.setup/supported-app-db-version? :h2 {:major 2 :minor 0 :patch 214})))
- (is (false? (#'mdb.setup/supported-app-db-version? :h2 {:major 1 :minor 1 :patch 214}))))
- (testing "for postgres"
- (is (true? (#'mdb.setup/supported-app-db-version? :postgres {:major 12 :minor 0 :patch 0})))
- (is (true? (#'mdb.setup/supported-app-db-version? :postgres {:major 13 :minor 0 :patch 0})))
- (is (true? (#'mdb.setup/supported-app-db-version? :postgres {:major 12 :minor 1 :patch 0})))
- (is (true? (#'mdb.setup/supported-app-db-version? :postgres {:major 12 :minor 1 :patch 1})))
- (is (false? (#'mdb.setup/supported-app-db-version? :postgres {:major 11 :minor 0 :patch 0})))
- (is (false? (#'mdb.setup/supported-app-db-version? :postgres {:major 12 :minor -1 :patch 0})))
- (is (false? (#'mdb.setup/supported-app-db-version? :postgres {:major 12 :minor 0 :patch -1}))))
-
- (testing "for mysql"
- (is (true? (#'mdb.setup/supported-app-db-version? :mysql {:major 8 :minor 0 :patch 17})))
- (is (true? (#'mdb.setup/supported-app-db-version? :mysql {:major 9 :minor 0 :patch 17})))
- (is (true? (#'mdb.setup/supported-app-db-version? :mysql {:major 8 :minor 1 :patch 17})))
- (is (true? (#'mdb.setup/supported-app-db-version? :mysql {:major 8 :minor 0 :patch 18})))
- (is (false? (#'mdb.setup/supported-app-db-version? :mysql {:major 7 :minor 0 :patch 17})))
- (is (false? (#'mdb.setup/supported-app-db-version? :mysql {:major 8 :minor -1 :patch 17})))
- (is (false? (#'mdb.setup/supported-app-db-version? :mysql {:major 8 :minor 0 :patch 16}))))
-
- (testing "for mariadb"
- (is (true? (#'mdb.setup/supported-app-db-version? :mariadb {:major 10 :minor 2 :patch 2})))
- (is (true? (#'mdb.setup/supported-app-db-version? :mariadb {:major 11 :minor 2 :patch 2})))
- (is (true? (#'mdb.setup/supported-app-db-version? :mariadb {:major 10 :minor 3 :patch 2})))
- (is (true? (#'mdb.setup/supported-app-db-version? :mariadb {:major 10 :minor 2 :patch 3})))
- (is (false? (#'mdb.setup/supported-app-db-version? :mariadb {:major 9 :minor 2 :patch 2})))
- (is (false? (#'mdb.setup/supported-app-db-version? :mariadb {:major 10 :minor 1 :patch 2})))
- (is (false? (#'mdb.setup/supported-app-db-version? :mariadb {:major 10 :minor 2 :patch 1}))))))
+ (letfn [(test-supported-versions [db expected-min-version]
+ (doseq [diff [nil {:major 1} {:minor 1} {:patch 1}]]
+ (is (true? (#'mdb.setup/supported-app-db-version? db (merge-with + expected-min-version diff)))))
+ (doseq [diff [{:major -1} {:minor -1} {:patch -1}]]
+ (is (false? (#'mdb.setup/supported-app-db-version? db (merge-with + expected-min-version diff))))))]
+
+ (test-supported-versions :h2 {:major 2 :minor 1 :patch 214})
+ (test-supported-versions :postgres {:major 14 :minor 0 :patch 0})
+ (test-supported-versions :mysql {:major 8 :minor 4 :patch 0})
+ (test-supported-versions :mariadb {:major 10 :minor 6 :patch 0}))))
(deftest parse-db-version-test
(testing "Can parse H2 version strings"