The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Metics Homepage: Right side panel (UXW-4238) (#74809)
Andrei Chernykh1d39f46f11c8
diff --git a/e2e/test/scenarios/data-studio/data-studio-metrics.cy.spec.ts b/e2e/test/scenarios/data-studio/data-studio-metrics.cy.spec.tsindex d95f145e9e4..54490f68918 100644--- a/e2e/test/scenarios/data-studio/data-studio-metrics.cy.spec.ts+++ b/e2e/test/scenarios/data-studio/data-studio-metrics.cy.spec.ts@@ -74,15 +74,15 @@ describe("scenarios > data studio > library > metrics", () => {});H.DataStudio.Metrics.aboutPageDescriptionSidebar().within(() => {- cy.findByText("Last edited by Bobby Tables").should("be.visible");+ cy.findByText(/^Last updated/).should("be.visible");+ cy.findByText("Source").should("be.visible");cy.findByText("Sample Database").should("be.visible");-cy.findByText("Orders").should("be.visible");- cy.findByText("Source table").should("be.visible");- cy.findByText("Dependencies").should("be.visible");- cy.findByText("Dependents").should("be.visible");+ cy.findByText("Relationships").should("be.visible");+ cy.findByText("No dependencies").should("be.visible");+ cy.findByText("No charts use this metric").should("be.visible");});cy.log("Ensure chart is visible");diff --git a/e2e/test/scenarios/metrics/metric-page.cy.spec.ts b/e2e/test/scenarios/metrics/metric-page.cy.spec.tsindex 535d0f03a01..f548f647958 100644--- a/e2e/test/scenarios/metrics/metric-page.cy.spec.ts+++ b/e2e/test/scenarios/metrics/metric-page.cy.spec.ts@@ -62,8 +62,8 @@ describe("scenarios > metrics > metric page", () => {H.MetricPage.aboutPage().should("be.visible");H.MetricPage.aboutPageDescriptionSidebar().within(() => {cy.findByText("Total number of orders").should("be.visible");+ cy.findByText("Source").should("be.visible");cy.findByText("Sample Database").should("be.visible");- cy.findByText("Source table").should("be.visible");cy.findByText("Orders").should("be.visible");});@@ -396,8 +396,9 @@ describe("scenarios > metrics > metric page", () => {});H.MetricPage.aboutPageDescriptionSidebar().within(() => {- cy.findByText("Dependencies").should("be.visible");- cy.findByText("Dependents").should("be.visible");+ cy.findByText("Relationships").should("be.visible");+ cy.findByText("No dependencies").should("be.visible");+ cy.findByText("No charts use this metric").should("be.visible");});H.MetricPage.dependenciesTab().click();diff --git a/enterprise/frontend/src/metabase-enterprise/data-studio/library/metrics/urls.ts b/enterprise/frontend/src/metabase-enterprise/data-studio/library/metrics/urls.tsindex 7301cc9c8ae..72f9496259f 100644--- a/enterprise/frontend/src/metabase-enterprise/data-studio/library/metrics/urls.ts+++ b/enterprise/frontend/src/metabase-enterprise/data-studio/library/metrics/urls.ts@@ -8,4 +8,5 @@ export const dataStudioMetricUrls: MetricUrls = {dependencies: Urls.dataStudioMetricDependencies,history: Urls.dataStudioMetricHistory,database: (databaseId) => Urls.dataStudioData({ databaseId }),+ table: (_databaseId, tableId) => Urls.dataStudioTable(tableId),};diff --git a/enterprise/frontend/src/metabase-enterprise/dependencies/pages/DependencyGraphPage/DependencyGraphPage.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/dependencies/pages/DependencyGraphPage/DependencyGraphPage.unit.spec.tsxindex db2ea0368f8..79ee0c65375 100644--- a/enterprise/frontend/src/metabase-enterprise/dependencies/pages/DependencyGraphPage/DependencyGraphPage.unit.spec.tsx+++ b/enterprise/frontend/src/metabase-enterprise/dependencies/pages/DependencyGraphPage/DependencyGraphPage.unit.spec.tsx@@ -1,7 +1,7 @@import { Route } from "react-router";import {- setupDependecyGraphEndpoint,+ setupDependencyGraphEndpoint,setupRecentViewsAndSelectionsEndpoints,} from "__support__/server-mocks";import { renderWithProviders, screen } from "__support__/ui";@@ -12,7 +12,7 @@ import { DependencyGraphPage } from "./DependencyGraphPage";describe("DependencyGraphPage", () => {beforeEach(() => {- setupDependecyGraphEndpoint(createMockDependencyGraph());+ setupDependencyGraphEndpoint(createMockDependencyGraph());setupRecentViewsAndSelectionsEndpoints([], ["selections"]);});it("should show an app switcher if there is no context", async () => {diff --git a/frontend/src/metabase-types/api/icon.ts b/frontend/src/metabase-types/api/icon.tsindex f1adb5bde2a..3340fb54ba7 100644--- a/frontend/src/metabase-types/api/icon.ts+++ b/frontend/src/metabase-types/api/icon.ts@@ -72,6 +72,7 @@ export type IconName =| "database"| "database_routing"| "dependencies"+ | "dependent"| "data_studio"| "dash"| "dashboard"diff --git a/frontend/src/metabase/metrics/components/MetricHeader/MetricTabs/MetricTabs.tsx b/frontend/src/metabase/metrics/components/MetricHeader/MetricTabs/MetricTabs.tsxindex 3d8a103b948..0f2ab83cc45 100644--- a/frontend/src/metabase/metrics/components/MetricHeader/MetricTabs/MetricTabs.tsx+++ b/frontend/src/metabase/metrics/components/MetricHeader/MetricTabs/MetricTabs.tsx@@ -10,6 +10,7 @@ import { isNumericMetric } from "metabase/metrics/utils/validation";import { PLUGIN_DEPENDENCIES } from "metabase/plugins";import { useSelector } from "metabase/redux";import { getMetadata } from "metabase/selectors/metadata";+import { getUserIsAdmin, getUserIsAnalyst } from "metabase/selectors/user";import * as Lib from "metabase-lib";import type Metadata from "metabase-lib/v1/metadata/Metadata";import type { Card } from "metabase-types/api";@@ -26,9 +27,12 @@ export function MetricTabs({ card, urls }: MetricTabsProps) {const { data: metric } = useGetMetricQuery(card.id);const hasDimensions =metric?.dimensions != null && metric.dimensions.length > 0;+ const canSeeDependencies = useSelector(+ (state) => getUserIsAdmin(state) || getUserIsAnalyst(state),+ );const tabs = useMemo(- () => getTabs(card, metadata, urls, hasDimensions),- [card, metadata, urls, hasDimensions],+ () => getTabs(card, metadata, urls, hasDimensions, canSeeDependencies),+ [card, metadata, urls, hasDimensions, canSeeDependencies],);return <PaneHeaderTabs tabs={tabs} />;}@@ -38,6 +42,7 @@ function getTabs(metadata: Metadata,urls: MetricUrls,hasDimensions: boolean,+ canSeeDependencies: boolean,): PaneHeaderTab[] {const tabs: PaneHeaderTab[] = [{@@ -63,7 +68,7 @@ function getTabs(});}- if (PLUGIN_DEPENDENCIES.isEnabled) {+ if (PLUGIN_DEPENDENCIES.isEnabled && canSeeDependencies) {tabs.push({label: t`Dependencies`,to: urls.dependencies(card.id),diff --git a/frontend/src/metabase/metrics/components/MetricHeader/MetricTabs/MetricTabs.unit.spec.tsx b/frontend/src/metabase/metrics/components/MetricHeader/MetricTabs/MetricTabs.unit.spec.tsxindex 306b43091f9..91b11b3ea19 100644--- a/frontend/src/metabase/metrics/components/MetricHeader/MetricTabs/MetricTabs.unit.spec.tsx+++ b/frontend/src/metabase/metrics/components/MetricHeader/MetricTabs/MetricTabs.unit.spec.tsx@@ -2,13 +2,14 @@ import { setupEnterprisePlugins } from "__support__/enterprise";import { setupMetricEndpoint } from "__support__/server-mocks/metric";import { mockSettings } from "__support__/settings";import { createMockEntitiesState } from "__support__/store";-import { renderWithProviders, waitFor } from "__support__/ui";+import { renderWithProviders, screen, waitFor } from "__support__/ui";import { createMockState } from "metabase/redux/store/mocks";import type { Card } from "metabase-types/api";import {createMockCard,createMockField,createMockTokenFeatures,+ createMockUser,} from "metabase-types/api/mocks";import {createMockMetric,@@ -33,6 +34,7 @@ describe("MetricTabs", () => {mockSettings({"token-features": createMockTokenFeatures({cache_granular_controls: true,+ dependencies: true,}),});setupEnterprisePlugins();@@ -42,10 +44,12 @@ describe("MetricTabs", () => {card: cardOverrides,hasDimensions = true,hasDataPermissions = true,+ role = "consumer",}: {card?: Partial<Card>;hasDimensions?: boolean;hasDataPermissions?: boolean;+ role?: "admin" | "analyst" | "consumer";} = {}) {const card = createMockCard({type: "metric",@@ -63,6 +67,10 @@ describe("MetricTabs", () => {setupMetricEndpoint(metric);const state = createMockState({+ currentUser: createMockUser({+ is_superuser: role === "admin",+ is_data_analyst: role === "analyst",+ }),entities: createMockEntitiesState({databases: hasDataPermissions ? [createSampleDatabase()] : [],questions: [card],@@ -121,4 +129,26 @@ describe("MetricTabs", () => {expect(getTabLabels()).toEqual(["About", "History"]);});});++ describe("Dependencies tab (role-gated)", () => {+ it("shows for admins", async () => {+ setup({ role: "admin" });+ await waitFor(() => {+ expect(getTabLabels()).toContain("Dependencies");+ });+ });++ it("shows for data analysts", async () => {+ setup({ role: "analyst" });+ await waitFor(() => {+ expect(getTabLabels()).toContain("Dependencies");+ });+ });++ it("is hidden for consumers", async () => {+ setup({ role: "consumer" });+ await screen.findByText("About");+ expect(getTabLabels()).not.toContain("Dependencies");+ });+ });});diff --git a/frontend/src/metabase/metrics/pages/MetricAboutPage/MetricAbout/DescriptionSection/DescriptionSection.module.css b/frontend/src/metabase/metrics/pages/MetricAboutPage/MetricAbout/DescriptionSection/DescriptionSection.module.cssdeleted file mode 100644index 0f5f995e26f..00000000000--- a/frontend/src/metabase/metrics/pages/MetricAboutPage/MetricAbout/DescriptionSection/DescriptionSection.module.css+++ /dev/null@@ -1,7 +0,0 @@-.metricLink {- transition: 200ms all;-}--.metricLink:hover {- color: var(--mb-color-brand);-}diff --git a/frontend/src/metabase/metrics/pages/MetricAboutPage/MetricAbout/DescriptionSection/DescriptionSection.tsx b/frontend/src/metabase/metrics/pages/MetricAboutPage/MetricAbout/DescriptionSection/DescriptionSection.tsxindex 96ba99e384b..b651ef1a01f 100644--- a/frontend/src/metabase/metrics/pages/MetricAboutPage/MetricAbout/DescriptionSection/DescriptionSection.tsx+++ b/frontend/src/metabase/metrics/pages/MetricAboutPage/MetricAbout/DescriptionSection/DescriptionSection.tsx@@ -1,4 +1,4 @@-import { t } from "ttag";+import { jt, msgid, ngettext, t } from "ttag";import {useGetDatabaseQuery,@@ -7,17 +7,19 @@ import {} from "metabase/api";import { DateTime } from "metabase/common/components/DateTime";import { EditableText } from "metabase/common/components/EditableText";-import { Link } from "metabase/common/components/Link/Link";import { Markdown } from "metabase/common/components/Markdown";import { useMetadataToasts } from "metabase/metadata/hooks";import { PLUGIN_DEPENDENCIES } from "metabase/plugins";-import { Box, Card, Flex, Group, Icon, Stack, Text, rem } from "metabase/ui";-import { getUserName } from "metabase/utils/user";+import { useSelector } from "metabase/redux";+import { getUserIsAdmin, getUserIsAnalyst } from "metabase/selectors/user";+import { Box, Stack, Text, Tooltip } from "metabase/ui";+import { getRelativeTime } from "metabase/utils/time-dayjs";import type { Card as CardApiType, CardType } from "metabase-types/api";import type { MetricUrls } from "../../../../types";-import S from "./DescriptionSection.module.css";+import { MetadataCard, MetadataRow, MetadataRowLink } from "./MetadataCard";+import { MetricSubSection } from "./MetricSubSection";interface DescriptionSectionProps {card: CardApiType;@@ -28,7 +30,9 @@ export function DescriptionSection({ card, urls }: DescriptionSectionProps) {const [updateCard] = useUpdateCardMutation();const { sendSuccessToast, sendErrorToast } = useMetadataToasts();- const isDependenciesEnabled = PLUGIN_DEPENDENCIES.isEnabled;+ const canSeeRelationships =+ useSelector((state) => getUserIsAdmin(state) || getUserIsAnalyst(state)) &&+ PLUGIN_DEPENDENCIES.isEnabled;const { data: database } = useGetDatabaseQuery({ id: card.database_id! },@@ -59,11 +63,34 @@ export function DescriptionSection({ card, urls }: DescriptionSectionProps) {}};+ const hasSource = Boolean(database || table);+ const dependenciesUrl = urls.dependencies(card.id);const databaseUrl = database && urls.database?.(database.id);+ const tableUrl =+ table && card.database_id != null+ ? urls.table?.(card.database_id, table.id)+ : undefined;return (- <Stack gap={0} align="stretch" data-testid="metric-description-sidebar">- <Box data-testid="metric-description-section" p={rem(20)}>+ <Stack+ p="md"+ gap={0}+ align="stretch"+ data-testid="metric-description-sidebar"+ >+ <Text fz="lg" fw={700}>{t`About`}</Text>+ <Tooltip label={<DateTime value={card.updated_at} />} offset={8}>+ <Text+ size="sm"+ c="text-secondary"+ w="fit-content"+ mt="sm"+ data-testid="metric-last-updated"+ >+ {t`Last updated ${getRelativeTime(card.updated_at)}`}+ </Text>+ </Tooltip>+ <Box mt="md" data-testid="metric-description-section">{card.can_write ? (<EditableTextinitialValue={card.description ?? ""}@@ -79,96 +106,66 @@ export function DescriptionSection({ card, urls }: DescriptionSectionProps) {)}</Box>- <Card mx="lg" bg="background-secondary" shadow="none" radius="1rem">- <Card.Section withBorder p="md">- <Group gap="sm" mb={4}>- <Icon name="pencil" c="brand" />- <Text size="md" fw={600} lh="1rem">- <DateTime value={card.updated_at} />- </Text>- </Group>- <Text size="sm" c="text-secondary" lh="1rem" ml="1.5rem">- {card["last-edit-info"]- ? t`Last edited by ${getUserName(card["last-edit-info"])}`- : t`Last edited at`}- </Text>- </Card.Section>- {database && (- <Card.Section withBorder p="md">- <Group gap="sm" mb={4}>- <Icon name="database" c="brand" />- {databaseUrl ? (- <Link to={databaseUrl} className={S.metricLink}>- <Text size="md" fw={600} lh="1rem">+ {hasSource && (+ <MetricSubSection title={t`Source`} mt="xl">+ <MetadataCard>+ {database && (+ <MetadataRow icon="database">+ {databaseUrl ? (+ <MetadataRowLink to={databaseUrl}>{database.name}- </Text>- </Link>- ) : (- <Text size="md" fw={600} lh="1rem">- {database.name}- </Text>- )}- </Group>- <Text size="sm" c="text-secondary" lh="1rem" ml="1.5rem">- {t`Database`}- </Text>- </Card.Section>- )}- {table && (- <Card.Section withBorder p="md">- <Group gap="sm" mb={4}>- <Icon name="table" c="brand" />- <Text size="md" fw={600} lh="1rem">- {table.display_name || table.name}- </Text>- </Group>- <Text size="sm" c="text-secondary" lh="1rem" ml="1.5rem">- {t`Source table`}- </Text>- </Card.Section>- )}- </Card>-- {isDependenciesEnabled && (- <Card mx="lg" my="lg" shadow="none">- <Card.Section withBorder py={rem(12)} px="md">- <Flex justify="space-between" align="center">- <Text size="md" c="text-secondary">- {t`Dependencies`}- </Text>+ </MetadataRowLink>+ ) : (+ database.name+ )}+ </MetadataRow>+ )}+ {table && (+ <MetadataRow icon="table">+ {tableUrl ? (+ <MetadataRowLink to={tableUrl}>+ {table.display_name || table.name}+ </MetadataRowLink>+ ) : (+ (table.display_name ?? table.name)+ )}+ </MetadataRow>+ )}+ </MetadataCard>+ </MetricSubSection>+ )}++ {canSeeRelationships && (+ <MetricSubSection title={t`Relationships`} mt="xl">+ <MetadataCard>+ <MetadataRow icon="dependencies" muted={dependenciesCount === 0}>{dependenciesCount > 0 ? (- <Link to={urls.dependencies(card.id)} className={S.metricLink}>- <Text size="xl" fw={600}>- {dependenciesCount}- </Text>- </Link>- ) : (- <Text size="xl" fw={600}>- {dependenciesCount}- </Text>- )}- </Flex>- </Card.Section>- <Card.Section withBorder py={rem(12)} px="md">- <Flex justify="space-between" align="center">- <Text size="md" c="text-secondary">- {t`Dependents`}- </Text>-- {dependentsCount > 0 ? (- <Link to={urls.dependencies(card.id)} className={S.metricLink}>- <Text size="xl" fw={600}>- {dependentsCount}- </Text>- </Link>+ <MetadataRowLink to={dependenciesUrl}>+ {ngettext(+ msgid`${dependenciesCount} dependency`,+ `${dependenciesCount} dependencies`,+ dependenciesCount,+ )}+ </MetadataRowLink>) : (- <Text size="xl" fw={600}>- {dependentsCount}- </Text>+ t`No dependencies`)}- </Flex>- </Card.Section>- </Card>+ </MetadataRow>+ <MetadataRow icon="dependent" muted={dependentsCount === 0}>+ {dependentsCount > 0+ ? jt`${(+ <MetadataRowLink key="count" to={dependenciesUrl}>+ {ngettext(+ msgid`${dependentsCount} chart`,+ `${dependentsCount} charts`,+ dependentsCount,+ )}+ </MetadataRowLink>+ )} ${ngettext(msgid`uses`, `use`, dependentsCount)} this metric`+ : t`No charts use this metric`}+ </MetadataRow>+ </MetadataCard>+ </MetricSubSection>)}</Stack>);diff --git a/frontend/src/metabase/metrics/pages/MetricAboutPage/MetricAbout/DescriptionSection/DescriptionSection.unit.spec.tsx b/frontend/src/metabase/metrics/pages/MetricAboutPage/MetricAbout/DescriptionSection/DescriptionSection.unit.spec.tsxnew file mode 100644index 00000000000..f08357f9bf9--- /dev/null+++ b/frontend/src/metabase/metrics/pages/MetricAboutPage/MetricAbout/DescriptionSection/DescriptionSection.unit.spec.tsx@@ -0,0 +1,220 @@+import { Route } from "react-router";++import { setupEnterprisePlugins } from "__support__/enterprise";+import { setupDatabaseEndpoints } from "__support__/server-mocks/database";+import { setupDependencyGraphEndpoint } from "__support__/server-mocks/dependencies";+import { setupTableEndpoints } from "__support__/server-mocks/table";+import { mockSettings } from "__support__/settings";+import { renderWithProviders, screen, waitFor } from "__support__/ui";+import { createMockState } from "metabase/redux/store/mocks";+import type { Card } from "metabase-types/api";+import {+ createMockCard,+ createMockDatabase,+ createMockTable,+ createMockTokenFeatures,+ createMockUser,+} from "metabase-types/api/mocks";+import {+ createMockCardDependencyNode,+ createMockDependencyEdge,+ createMockDependencyGraph,+} from "metabase-types/api/mocks/dependencies";++import type { MetricUrls } from "../../../../types";++import { DescriptionSection } from "./DescriptionSection";++const DATABASE_ID = 42;+const TABLE_ID = 99;+const CARD_ID = 7;++const URLS: MetricUrls = {+ about: (id) => `/metric/${id}/about`,+ overview: (id) => `/metric/${id}/overview`,+ query: (id) => `/metric/${id}/query`,+ dependencies: (id) => `/metric/${id}/dependencies`,+ history: (id) => `/metric/${id}/history`,+ database: (id) => `/browse/databases/${id}`,+ table: (dbId, tableId) => `/question?db=${dbId}&table=${tableId}`,+};++type SetupOpts = {+ card?: Partial<Card>;+ role?: "admin" | "analyst" | "consumer";+ dependenciesCount?: number;+ dependentsCount?: number;+};++function setup({+ card: cardOverrides,+ role = "consumer",+ dependenciesCount = 0,+ dependentsCount = 0,+}: SetupOpts = {}) {+ setupDependencyGraphEndpoint(+ createMockDependencyGraph({+ nodes: [+ createMockCardDependencyNode({+ id: CARD_ID,+ dependents_count: { dashboard: dependentsCount },+ }),+ ],+ edges: Array.from({ length: dependenciesCount }, () =>+ createMockDependencyEdge({+ to_entity_id: CARD_ID,+ to_entity_type: "card",+ }),+ ),+ }),+ );++ const card = createMockCard({+ id: CARD_ID,+ type: "metric",+ can_write: true,+ description: "An important metric",+ database_id: DATABASE_ID,+ table_id: TABLE_ID,+ updated_at: "2026-05-20T10:00:00Z",+ ...cardOverrides,+ });++ setupDatabaseEndpoints(+ createMockDatabase({ id: DATABASE_ID, name: "Analytics warehouse" }),+ );+ setupTableEndpoints(+ createMockTable({+ id: TABLE_ID,+ db_id: DATABASE_ID,+ name: "ad_events",+ display_name: "Ad Events",+ }),+ );++ const state = createMockState({+ currentUser: createMockUser({+ is_superuser: role === "admin",+ is_data_analyst: role === "analyst",+ }),+ settings: mockSettings({+ "token-features": createMockTokenFeatures({ dependencies: true }),+ }),+ });+ // Enable the dependencies plugin via real EE init (reads the mocked settings).+ setupEnterprisePlugins();++ renderWithProviders(+ <Route+ path="/"+ component={() => <DescriptionSection card={card} urls={URLS} />}+ />,+ {+ storeInitialState: state,+ withRouter: true,+ },+ );++ return { card };+}++describe("DescriptionSection", () => {+ it("renders the About heading and last-updated subline", async () => {+ setup();+ expect(screen.getByText("About")).toBeInTheDocument();+ expect(await screen.findByTestId("metric-last-updated")).toHaveTextContent(+ /Last updated/,+ );+ });++ it("renders EditableText when the user can write", async () => {+ setup({ card: { can_write: true } });+ expect(await screen.findByTestId("editable-text")).toBeInTheDocument();+ });++ it("renders read-only Markdown when the user cannot write", () => {+ setup({ card: { can_write: false, description: "Read me" } });+ expect(screen.queryByTestId("editable-text")).not.toBeInTheDocument();+ expect(screen.getByText("Read me")).toBeInTheDocument();+ });++ it("falls back to 'No description' for an empty read-only description", () => {+ setup({ card: { can_write: false, description: null } });+ expect(screen.getByText("No description")).toBeInTheDocument();+ });++ describe("Source sub-section", () => {+ it("renders database and table rows linked to the right URLs", async () => {+ setup();++ const dbAnchor = (await screen.findByText("Analytics warehouse")).closest(+ "a",+ );+ expect(dbAnchor).toHaveAttribute(+ "href",+ `/browse/databases/${DATABASE_ID}`,+ );++ const tableAnchor = (await screen.findByText("Ad Events")).closest("a");+ expect(tableAnchor).toHaveAttribute(+ "href",+ `/question?db=${DATABASE_ID}&table=${TABLE_ID}`,+ );+ });++ it("hides the Source sub-section when no database or table is set", () => {+ setup({ card: { database_id: undefined, table_id: undefined } });+ expect(screen.queryByText("Source")).not.toBeInTheDocument();+ });+ });++ describe("Relationships sub-section", () => {+ it("is hidden for consumers", async () => {+ setup({ role: "consumer" });+ await screen.findByText("About");+ expect(screen.queryByText("Relationships")).not.toBeInTheDocument();+ });++ it("is visible for admins", async () => {+ setup({ role: "admin" });+ expect(await screen.findByText("Relationships")).toBeInTheDocument();+ });++ it("is visible for data analysts", async () => {+ setup({ role: "analyst" });+ expect(await screen.findByText("Relationships")).toBeInTheDocument();+ });++ it("shows empty-state copy when there are no dependencies or charts", async () => {+ setup({ role: "admin" });+ await waitFor(() => {+ expect(screen.getByText("No dependencies")).toBeInTheDocument();+ });+ expect(screen.getByText("No charts use this metric")).toBeInTheDocument();++ expect(+ screen.queryByRole("link", { name: /dependency|dependencies/i }),+ ).not.toBeInTheDocument();+ });++ it("uses singular verb agreement for one dependent chart", async () => {+ setup({ role: "admin", dependentsCount: 1 });+ expect(+ (await screen.findByText("1 chart")).closest("a"),+ ).toBeInTheDocument();+ expect(+ screen.getByTestId("metric-description-sidebar"),+ ).toHaveTextContent("1 chart uses this metric");+ });++ it("uses plural verb agreement for multiple dependent charts", async () => {+ setup({ role: "admin", dependentsCount: 3 });+ expect(+ (await screen.findByText("3 charts")).closest("a"),+ ).toBeInTheDocument();+ expect(+ screen.getByTestId("metric-description-sidebar"),+ ).toHaveTextContent("3 charts use this metric");+ });+ });+});diff --git a/frontend/src/metabase/metrics/pages/MetricAboutPage/MetricAbout/DescriptionSection/MetadataCard.module.css b/frontend/src/metabase/metrics/pages/MetricAboutPage/MetricAbout/DescriptionSection/MetadataCard.module.cssnew file mode 100644index 00000000000..3ac54af72e9--- /dev/null+++ b/frontend/src/metabase/metrics/pages/MetricAboutPage/MetricAbout/DescriptionSection/MetadataCard.module.css@@ -0,0 +1,47 @@+/* Spec: Orion-Alpha-5 (hsla(204, 66%, 8%, 0.02)) in light mode.+ Dark mode flips to a subtle white overlay so the card stays visible+ against the dark page bg. */+.card {+ background: hsla(204, 66%, 8%, 0.02);+ border-radius: 1rem;+ padding: 0.75rem;+ box-shadow: none;+}++[data-mantine-color-scheme="dark"] .card {+ background: hsla(0, 0%, 100%, 0.05);+}++.rows {+ position: relative;+}++/* Vertical line running through the icon column, connecting circles.+ Sits behind the icon circles, which cover it on their own footprint. */+.rows::before {+ content: "";+ position: absolute;+ left: 0.75rem; /* center of 24px (1.5rem) icon circle */+ top: 0.75rem;+ bottom: 0.75rem;+ width: 1px;+ background: var(--mb-color-border);+ pointer-events: none;+}++.iconCircle {+ position: relative;+ border-radius: 100%;+ flex-shrink: 0;+ box-shadow:+ 0 0 0 0.5px rgba(0, 0, 0, 0.1),+ 0 1px 3px 0 rgba(0, 0, 0, 0.1);+}++.text {+ color: var(--mb-color-brand);+}++.link:hover .text {+ color: var(--mb-color-text-hover);+}diff --git a/frontend/src/metabase/metrics/pages/MetricAboutPage/MetricAbout/DescriptionSection/MetadataCard.tsx b/frontend/src/metabase/metrics/pages/MetricAboutPage/MetricAbout/DescriptionSection/MetadataCard.tsxnew file mode 100644index 00000000000..71870fcfb3e--- /dev/null+++ b/frontend/src/metabase/metrics/pages/MetricAboutPage/MetricAbout/DescriptionSection/MetadataCard.tsx@@ -0,0 +1,63 @@+import type { ReactNode } from "react";++import { Link } from "metabase/common/components/Link/Link";+import { Center, Group, Icon, Paper, Stack, Text, rem } from "metabase/ui";+import type { IconName } from "metabase-types/api";++import S from "./MetadataCard.module.css";++interface MetadataCardProps {+ children: ReactNode;+}++export function MetadataCard({ children }: MetadataCardProps) {+ return (+ <Paper className={S.card}>+ <Stack gap={rem(12)} className={S.rows}>+ {children}+ </Stack>+ </Paper>+ );+}++interface MetadataRowProps {+ icon: IconName;+ children: ReactNode;+ /** Empty-state styling: muted icon and text. */+ muted?: boolean;+}++export function MetadataRow({ icon, children, muted }: MetadataRowProps) {+ const color = muted ? "text-secondary" : "text-primary";+ return (+ <Group gap={rem(10)} wrap="nowrap" align="center">+ <Center+ bg="background-primary"+ w={rem(24)}+ h={rem(24)}+ className={S.iconCircle}+ >+ <Icon name={icon} size={12} c={color} />+ </Center>+ <Text component="span" c={color}>+ {children}+ </Text>+ </Group>+ );+}++export function MetadataRowLink({+ to,+ children,+}: {+ to: string;+ children: ReactNode;+}) {+ return (+ <Link to={to} className={S.link}>+ <Text component="span" fw={600} className={S.text}>+ {children}+ </Text>+ </Link>+ );+}diff --git a/frontend/src/metabase/metrics/pages/MetricAboutPage/MetricAbout/DescriptionSection/MetricSubSection.tsx b/frontend/src/metabase/metrics/pages/MetricAboutPage/MetricAbout/DescriptionSection/MetricSubSection.tsxnew file mode 100644index 00000000000..b49480972d6--- /dev/null+++ b/frontend/src/metabase/metrics/pages/MetricAboutPage/MetricAbout/DescriptionSection/MetricSubSection.tsx@@ -0,0 +1,24 @@+import type { ReactNode } from "react";++import { Stack, type StackProps, Text, rem } from "metabase/ui";++interface MetricSubSectionProps {+ title: string;+ children: ReactNode;+ mt?: StackProps["mt"];+}++export function MetricSubSection({+ title,+ children,+ mt,+}: MetricSubSectionProps) {+ return (+ <Stack gap="sm" mt={mt}>+ <Text fz="sm" lh={rem(16)} fw={400} c="text-secondary">+ {title}+ </Text>+ {children}+ </Stack>+ );+}diff --git a/frontend/src/metabase/metrics/pages/MetricAboutPage/MetricAbout/MetricAbout.module.css b/frontend/src/metabase/metrics/pages/MetricAboutPage/MetricAbout/MetricAbout.module.cssindex 6fb31e28a1e..2b329739ad9 100644--- a/frontend/src/metabase/metrics/pages/MetricAboutPage/MetricAbout/MetricAbout.module.css+++ b/frontend/src/metabase/metrics/pages/MetricAboutPage/MetricAbout/MetricAbout.module.css@@ -16,19 +16,13 @@}.descriptionSection {- background-color: var(--mb-color-background-primary);- border: 1px solid var(--mb-color-border);- border-left: none;- border-top-right-radius: var(--default-border-radius);- border-bottom-right-radius: var(--default-border-radius);overflow: auto;}.visualizationPanel {background-color: var(--mb-color-background-primary);border: 1px solid var(--mb-color-border);- border-top-left-radius: var(--default-border-radius);- border-bottom-left-radius: var(--default-border-radius);+ border-radius: var(--default-border-radius);overflow: hidden;/* keeps the embedded visualization non-interactive (no tooltips/hover) */pointer-events: none;diff --git a/frontend/src/metabase/metrics/pages/MetricAboutPage/MetricAbout/MetricAbout.tsx b/frontend/src/metabase/metrics/pages/MetricAboutPage/MetricAbout/MetricAbout.tsxindex c15529e6648..ba2faa515ca 100644--- a/frontend/src/metabase/metrics/pages/MetricAboutPage/MetricAbout/MetricAbout.tsx+++ b/frontend/src/metabase/metrics/pages/MetricAboutPage/MetricAbout/MetricAbout.tsx@@ -1,6 +1,7 @@import { useMemo } from "react";-import { OverviewVisualization } from "metabase/data-studio/common/components/OverviewVisualization";+import { MetricCardVisualization } from "metabase/data-studio/common/components/OverviewVisualization";+import { useCardQueryData } from "metabase/data-studio/common/hooks/use-card-query-data";import { useMetricDefinition } from "metabase/metrics/common/hooks";import { isNumericMetric } from "metabase/metrics/utils/validation";import { Box, Flex, Stack } from "metabase/ui";@@ -21,6 +22,7 @@ interface MetricAboutProps {export function MetricAbout({ card, urls }: MetricAboutProps) {const { definition } = useMetricDefinition(card.id ?? null);+ const { data, isLoading } = useCardQueryData(card);const hasTimeDimension = useMemo(() =>@@ -33,7 +35,7 @@ export function MetricAbout({ card, urls }: MetricAboutProps) {);return (- <Flex className={S.root} flex={1}>+ <Flex className={S.root} flex={1} gap="md"><Box className={S.chartContainer} flex={1} mah={700}>{isNumericMetric(card) && (<Box className={S.exploreButtonOverlay}>@@ -43,7 +45,12 @@ export function MetricAbout({ card, urls }: MetricAboutProps) {{hasTimeDimension ? (<AboutVisualization card={card} />) : (- <OverviewVisualization card={card} />+ <MetricCardVisualization+ card={card}+ data={data}+ isLoading={isLoading}+ className={S.visualizationPanel}+ />)}</Box><Stack flex="0 0 360px" className={S.descriptionSection} mah={700}>diff --git a/frontend/src/metabase/metrics/pages/MetricAboutPage/MetricAbout/MetricAbout.unit.spec.tsx b/frontend/src/metabase/metrics/pages/MetricAboutPage/MetricAbout/MetricAbout.unit.spec.tsxindex 3eef4e1e25f..a21d2b4b58f 100644--- a/frontend/src/metabase/metrics/pages/MetricAboutPage/MetricAbout/MetricAbout.unit.spec.tsx+++ b/frontend/src/metabase/metrics/pages/MetricAboutPage/MetricAbout/MetricAbout.unit.spec.tsx@@ -110,7 +110,7 @@ describe("MetricAbout", () => {// Wait for the description section to render so the negative assertion// isn't trivially true (the page hasn't loaded yet).- expect(await screen.findByText("Source table")).toBeInTheDocument();+ expect(await screen.findByText("Source")).toBeInTheDocument();expect(screen.queryByTestId("explore-link")).not.toBeInTheDocument();});});diff --git a/frontend/src/metabase/metrics/types.ts b/frontend/src/metabase/metrics/types.tsindex 7cb27b72c7e..4a84862de22 100644--- a/frontend/src/metabase/metrics/types.ts+++ b/frontend/src/metabase/metrics/types.ts@@ -1,7 +1,7 @@import type { ReactNode } from "react";import type * as LibMetric from "metabase-lib/metric";-import type { Card, CardId, DatabaseId } from "metabase-types/api";+import type { Card, CardId, DatabaseId, TableId } from "metabase-types/api";export interface DimensionWithDefinition {dimension: LibMetric.DimensionMetadata;@@ -15,6 +15,7 @@ export interface MetricUrls {dependencies: (cardId: CardId) => string;history: (cardId: CardId) => string;database?: (databaseId: DatabaseId) => string;+ table?: (databaseId: DatabaseId, tableId: TableId) => string;}export interface MetricPageParams {diff --git a/frontend/src/metabase/metrics/urls.ts b/frontend/src/metabase/metrics/urls.tsindex 82102b9a8d1..55e6da391c8 100644--- a/frontend/src/metabase/metrics/urls.ts+++ b/frontend/src/metabase/metrics/urls.ts@@ -8,4 +8,6 @@ export const metricUrls: MetricUrls = {query: Urls.metricQuery,dependencies: Urls.metricDependencies,history: Urls.metricHistory,+ database: (id) => Urls.browseDatabase({ id }),+ table: (databaseId, tableId) => Urls.tableRowsQuery(databaseId, tableId),};diff --git a/frontend/src/metabase/ui/components/icons/Icon/icons/dependent.svg b/frontend/src/metabase/ui/components/icons/Icon/icons/dependent.svgnew file mode 100644index 00000000000..9ef8a5acf82--- /dev/null+++ b/frontend/src/metabase/ui/components/icons/Icon/icons/dependent.svg@@ -0,0 +1,3 @@+<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 12 12" fill="currentColor">+ <path fill-rule="evenodd" clip-rule="evenodd" d="M2.0625 0.75V1.5C2.0625 2.01777 2.48223 2.4375 3 2.4375H3.9375V1.875C3.9375 1.35723 4.35723 0.9375 4.875 0.9375H10.125C10.6428 0.9375 11.0625 1.35723 11.0625 1.875V4.125C11.0625 4.64277 10.6428 5.0625 10.125 5.0625H4.875C4.35723 5.0625 3.9375 4.64277 3.9375 4.125V3.5625H3C2.66199 3.5625 2.34404 3.47909 2.0625 3.33496V7.5C2.0625 8.01777 2.48223 8.4375 3 8.4375H3.9375V7.875C3.9375 7.35723 4.35723 6.9375 4.875 6.9375H10.125C10.6428 6.9375 11.0625 7.35723 11.0625 7.875V10.125C11.0625 10.6428 10.6428 11.0625 10.125 11.0625H4.875C4.35723 11.0625 3.9375 10.6428 3.9375 10.125V9.5625H3C1.86091 9.5625 0.9375 8.63909 0.9375 7.5V0.75H2.0625ZM5.0625 9.9375H9.9375V8.0625H5.0625V9.9375ZM5.0625 3.9375H9.9375V2.0625H5.0625V3.9375Z"/>+</svg>diff --git a/frontend/src/metabase/ui/components/icons/Icon/icons/index.ts b/frontend/src/metabase/ui/components/icons/Icon/icons/index.tsindex 18d66c7b745..2b4d5043db4 100644--- a/frontend/src/metabase/ui/components/icons/Icon/icons/index.ts+++ b/frontend/src/metabase/ui/components/icons/Icon/icons/index.ts@@ -154,6 +154,8 @@ import database_routing_component from "./database_routing.svg?component";import database_routing_source from "./database_routing.svg?source";import dependencies_component from "./dependencies.svg?component";import dependencies_source from "./dependencies.svg?source";+import dependent_component from "./dependent.svg?component";+import dependent_source from "./dependent.svg?source";import document_component from "./document.svg?component";import document_source from "./document.svg?source";import download_component from "./download.svg?component";@@ -855,6 +857,10 @@ export const Icons: Record<IconName, { component: React.VFC; source: string }> =component: dependencies_component,source: dependencies_source,},+ dependent: {+ component: dependent_component,+ source: dependent_source,+ },data_studio: {component: data_studio_component,source: data_studio_source,diff --git a/frontend/test/__support__/server-mocks/dependencies.ts b/frontend/test/__support__/server-mocks/dependencies.tsindex c496249b8b4..6c062616833 100644--- a/frontend/test/__support__/server-mocks/dependencies.ts+++ b/frontend/test/__support__/server-mocks/dependencies.ts@@ -50,6 +50,6 @@ export function setupListUnreferencedGraphNodesEndpoint(fetchMock.get("path:/api/ee/dependencies/graph/unreferenced", response);}-export function setupDependecyGraphEndpoint(response: DependencyGraph) {+export function setupDependencyGraphEndpoint(response: DependencyGraph) {fetchMock.get("path:/api/ee/dependencies/graph", response);}