The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Improved message for job failure due to routing (#68804)
Eric Normand1e3406219c00
diff --git a/enterprise/backend/src/metabase_enterprise/database_routing/common.clj b/enterprise/backend/src/metabase_enterprise/database_routing/common.cljindex 454dd5c7d2e..b9705fb6bb5 100644--- a/enterprise/backend/src/metabase_enterprise/database_routing/common.clj+++ b/enterprise/backend/src/metabase_enterprise/database_routing/common.clj@@ -24,7 +24,10 @@nilis-anonymous-user?- (throw (ex-info (tru "Anonymous users cannot access a database with routing enabled.") {:status-code 400}))+ (throw (ex-info (tru "Anonymous users cannot access a database with routing enabled.") {:status-code 400+ :database-routing-enabled true+ :database-or-id db-or-id+ :database-name (t2/select-one-fn :name :model/Database (u/the-id db-or-id))}))(= database-name "__METABASE_ROUTER__")nildiff --git a/enterprise/backend/src/metabase_enterprise/transforms/jobs.clj b/enterprise/backend/src/metabase_enterprise/transforms/jobs.cljindex a1c84a1551c..e89eec9a860 100644--- a/enterprise/backend/src/metabase_enterprise/transforms/jobs.clj+++ b/enterprise/backend/src/metabase_enterprise/transforms/jobs.clj@@ -240,7 +240,9 @@(try(transforms.job-run/fail-started-run! run-id {:message (.getMessage t)})(when (= :cron run-method)- (notify-job-failure job-id (.getMessage t)))+ (if (::transform-failure (ex-data t))+ (notify-transform-failures job-id (::failures (ex-data t)))+ (notify-job-failure job-id (.getMessage t))))(catch Exception e(log/error e "Error when failing a transform job run.")))(throw t))))diff --git a/enterprise/backend/src/metabase_enterprise/transforms/ordering.clj b/enterprise/backend/src/metabase_enterprise/transforms/ordering.cljindex 57491a75879..c9927fd162a 100644--- a/enterprise/backend/src/metabase_enterprise/transforms/ordering.clj+++ b/enterprise/backend/src/metabase_enterprise/transforms/ordering.clj@@ -12,25 +12,42 @@[metabase.lib.schema.id :as lib.schema.id][metabase.lib.schema.metadata :as lib.schema.metadata][metabase.query-processor.preprocess :as qp.preprocess]+ [metabase.util.i18n :as i18n][metabase.util.malli :as mu][toucan2.core :as t2]))(set! *warn-on-reflection* true)+(defn- database-routing-error-ex-data [^Throwable e]+ (when e+ (if (:database-routing-enabled (ex-data e))+ (ex-data e)+ (recur (.getCause e)))))+(defmethod transforms.i/table-dependencies :query- [{:keys [source]}]- (let [query (-> (:query source)- transforms.util/massage-sql-query- qp.preprocess/preprocess)- driver (-> query- lib.metadata/database- :engine)]- (if (lib/native-only-query? query)- (driver/native-query-deps driver query)- (into #{}- (map (fn [table-id]- {:table table-id}))- (lib/all-source-table-ids query)))))+ [{:keys [source] :as transform}]+ (try+ (let [query (-> (:query source)+ transforms.util/massage-sql-query+ qp.preprocess/preprocess)+ driver (-> query+ lib.metadata/database+ :engine)]+ (if (lib/native-only-query? query)+ (driver/native-query-deps driver query)+ (into #{}+ (map (fn [table-id]+ {:table table-id}))+ (lib/all-source-table-ids query))))+ (catch clojure.lang.ExceptionInfo e+ (if-some [data (database-routing-error-ex-data e)]+ (let [message (i18n/trs "Failed to run transform because the database {0} has database routing turned on. Running transforms on databases with db routing enabled is not supported." (:database-name data))]+ (throw (ex-info message+ {:metabase-enterprise.transforms.jobs/transform-failure true+ :metabase-enterprise.transforms.jobs/failures [{:metabase-enterprise.transforms.jobs/transform transform+ :metabase-enterprise.transforms.jobs/message message}]}+ e)))+ (throw e)))))(defn- dependency-map [transforms](into {}diff --git a/enterprise/backend/test/metabase_enterprise/transforms/jobs_test.clj b/enterprise/backend/test/metabase_enterprise/transforms/jobs_test.cljindex 272d8b85eb5..2619a380c9a 100644--- a/enterprise/backend/test/metabase_enterprise/transforms/jobs_test.clj+++ b/enterprise/backend/test/metabase_enterprise/transforms/jobs_test.clj@@ -10,6 +10,7 @@[metabase-enterprise.transforms.models.transform-run :as transform-run][metabase-enterprise.transforms.test-dataset :as transforms-dataset][metabase-enterprise.transforms.test-util :refer [with-transform-cleanup!]]+ [metabase.driver :as driver][metabase.lib.core :as lib][metabase.lib.metadata :as lib.metadata][metabase.notification.seed :as notification.seed]@@ -340,3 +341,52 @@(is (mt/received-email-subject? :crowberto #"The job .* had failures"))(is (mt/received-email-body? :crowberto #"transform1"))(is (mt/received-email-body? :crowberto #"transform2")))))))))))))++(deftest run-mbql-transform-anonymous-user-routing-error-test+ (mt/with-premium-features #{:database-routing :transforms}+ (mt/test-drivers (mt/normal-drivers-with-feature :transforms/table)+ (mt/dataset transforms-dataset/transforms-test+ (mt/with-model-cleanup [:model/Notification]+ (mt/with-fake-inbox+ (mt/with-model-cleanup [:model/Notification+ :model/TransformJobRun]+ (notification.seed/seed-notification!)+ (let [mp (mt/metadata-provider)+ table (t2/select-one :model/Table (mt/id :transforms_products))+ ;; generate sql for different dbs+ sql (-> (lib/query mp (lib.metadata/table mp (mt/id :transforms_products)))+ (lib/with-fields [(lib.metadata/field mp (mt/id :transforms_products :name))])+ (lib/limit 10)+ qp.compile/compile+ :query)]+ (with-transform-cleanup! [target0 {:type "table"+ :schema (:schema table)+ :name "t0"}]+ (mt/with-temp [:model/Database _destination {:engine driver/*driver*+ :router_database_id (mt/id)+ :details {:destination_database true}}+ :model/DatabaseRouter _ {:database_id (mt/id)+ :user_attribute "db_name"}+ :model/TransformTag tag {:name "test-tag"}+ :model/TransformJob job {:name "test-job"+ :schedule "0 0 * * * ? *"}+ :model/TransformJobTransformTag _ {:job_id (:id job)+ :tag_id (:id tag)+ :position 0}+ ;; independent transform+ :model/Transform t0 {:name "transform0"+ :source {:type :query+ :query (lib/native-query mp sql)}+ :creator_id (mt/user->id :crowberto)+ :target target0}+ :model/TransformTransformTag _tag0 {:transform_id (:id t0)+ :tag_id (:id tag)+ :position 0}]+ ;; NOTE: No `with-current-user` wrapper - this simulates running the transform+ ;; without a user context (e.g., from a cron job or background task).+ ;; previously this could produce the wrong error message from the QP routing middleware.+ (try+ (jobs/run-job! (:id job) {:run-method :cron})+ (catch Exception _))+ (is (mt/received-email-subject? :crowberto #"The job .* had failures"))+ (is (mt/received-email-body? :crowberto #"transform0"))))))))))))