Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Fix colors and strings in the deps sidebar (#68901)

Alexander Polyankin2062c3fb1371
diff --git a/enterprise/frontend/src/metabase-enterprise/dependencies/components/DependencyList/ListSidebar/BrokenDependentsSection/BrokenDependentsSection.tsx b/enterprise/frontend/src/metabase-enterprise/dependencies/components/DependencyList/ListSidebar/BrokenDependentsSection/BrokenDependentsSection.tsx
index f74706ad9fa..7ca2d1e48a4 100644
--- a/enterprise/frontend/src/metabase-enterprise/dependencies/components/DependencyList/ListSidebar/BrokenDependentsSection/BrokenDependentsSection.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/dependencies/components/DependencyList/ListSidebar/BrokenDependentsSection/BrokenDependentsSection.tsx
@@ -84,7 +84,7 @@ export function BrokenDependentsSection({
<Stack role="region" aria-label={getDependentErrorNodesLabel()}>
<Group justify="space-between" wrap="nowrap">
<Group gap="sm" wrap="nowrap">
- <Badge c="text-selected" bg="error">
+ <Badge variant="filled" bg="error">
{count}
</Badge>
<Title order={5}>
diff --git a/enterprise/frontend/src/metabase-enterprise/dependencies/components/DependencyList/ListSidebar/ErrorsSection/ErrorsSection.tsx b/enterprise/frontend/src/metabase-enterprise/dependencies/components/DependencyList/ListSidebar/ErrorsSection/ErrorsSection.tsx
index 56db668757e..719c397fa12 100644
--- a/enterprise/frontend/src/metabase-enterprise/dependencies/components/DependencyList/ListSidebar/ErrorsSection/ErrorsSection.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/dependencies/components/DependencyList/ListSidebar/ErrorsSection/ErrorsSection.tsx
@@ -73,7 +73,7 @@ function ErrorList({ title, items, "aria-label": ariaLabel }: ErrorListProps) {
return (
<Stack role="region" aria-label={ariaLabel}>
<Group gap="sm" wrap="nowrap">
- <Badge c="text-selected" bg="error">
+ <Badge variant="filled" bg="error">
{items.length}
</Badge>
<Title order={5}>{title}</Title>
diff --git a/enterprise/frontend/src/metabase-enterprise/dependencies/components/DependencyList/ListSidebar/FieldsSection/FieldsSection.tsx b/enterprise/frontend/src/metabase-enterprise/dependencies/components/DependencyList/ListSidebar/FieldsSection/FieldsSection.tsx
index 6ba916baa88..5b208f91cac 100644
--- a/enterprise/frontend/src/metabase-enterprise/dependencies/components/DependencyList/ListSidebar/FieldsSection/FieldsSection.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/dependencies/components/DependencyList/ListSidebar/FieldsSection/FieldsSection.tsx
@@ -32,7 +32,7 @@ export function FieldsSection({ node }: FieldsSectionProps) {
return (
<Stack role="region" aria-label={t`Fields`}>
<Group gap="sm" wrap="nowrap">
- <Badge c="text-selected" bg="brand">
+ <Badge variant="filled" bg="brand">
{fields.length}
</Badge>
<Title order={5}>{getNodeFieldsLabel(fields.length)}</Title>
diff --git a/enterprise/frontend/src/metabase-enterprise/dependencies/utils.ts b/enterprise/frontend/src/metabase-enterprise/dependencies/utils.ts
index 22b67080386..79b1208b84f 100644
--- a/enterprise/frontend/src/metabase-enterprise/dependencies/utils.ts
+++ b/enterprise/frontend/src/metabase-enterprise/dependencies/utils.ts
@@ -151,18 +151,18 @@ export function getNodeLink(node: DependencyNode): NodeLink | null {
};
case "dashboard":
return {
- label: `View this dashboard`,
+ label: t`View this dashboard`,
url: Urls.dashboard({ id: node.id, name: node.data.name }),
};
case "document":
return {
- label: `View this document`,
+ label: t`View this document`,
url: Urls.document({ id: node.id }),
};
case "sandbox":
if (node.data.table != null) {
return {
- label: `View this permission`,
+ label: t`View this permission`,
url: Urls.tableDataPermissions(
node.data.table.db_id,
node.data.table.schema,