Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Fix Snowflake python transform e2e test: explicit target schema (#74716)

Ngoc Khuat2070f40cbfe9
diff --git a/enterprise/backend/test/metabase_enterprise/transforms_python/drivers_test.clj b/enterprise/backend/test/metabase_enterprise/transforms_python/drivers_test.clj
index 610af8e1763..daf4f3ff5f6 100644
--- a/enterprise/backend/test/metabase_enterprise/transforms_python/drivers_test.clj
+++ b/enterprise/backend/test/metabase_enterprise/transforms_python/drivers_test.clj
@@ -24,7 +24,7 @@
(defn- execute-e2e-transform!
"Execute an e2e Python transform test using execute-python-transform!"
[table-name transform-code source-tables]
- (let [schema (when (#{:postgres :bigquery-cloud-sdk} driver/*driver*)
+ (let [schema (when (#{:postgres :bigquery-cloud-sdk :snowflake} driver/*driver*)
(sql.tx/session-schema driver/*driver*))
target {:type "table"
:schema schema
diff --git a/modules/drivers/snowflake/test/metabase/driver/snowflake_test.clj b/modules/drivers/snowflake/test/metabase/driver/snowflake_test.clj
index 1aa2b333d86..66a11fd80c4 100644
--- a/modules/drivers/snowflake/test/metabase/driver/snowflake_test.clj
+++ b/modules/drivers/snowflake/test/metabase/driver/snowflake_test.clj
@@ -2,6 +2,8 @@
{:clj-kondo/config '{:linters {:deprecated-var {:exclude {metabase.test.data/mbql-query {:namespaces [metabase.driver.snowflake-test]}
metabase.test.data/run-mbql-query {:namespaces [metabase.driver.snowflake-test]}}}}}}
(:require
+ [buddy.core.codecs :as codecs]
+ [buddy.core.hash :as buddy-hash]
[clojure.data :as data]
[clojure.java.jdbc :as jdbc]
[clojure.set :as set]
@@ -1486,11 +1488,16 @@
(is (true? (sql-jdbc.sync.interface/have-select-privilege?
driver/*driver* conn schema table-name))))))))))))
-(defn- get-db-priv-key [db]
+(defn- get-db-priv-key
+ "Returns a SHA-256 digest of the resolved private key file for `db`."
+ [db]
(-> (:details db)
(#'driver.snowflake/resolve-private-key)
:private_key_file
- slurp))
+ slurp
+ (.getBytes "UTF-8")
+ buddy-hash/sha256
+ codecs/bytes->hex))
(defn- get-priv-key-details [details pk-user priv-key-var]
(let [priv-key (tx/db-test-env-var-or-throw :snowflake priv-key-var)]