Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Enable codespell GH action for frontend (#68073)

Nemanja Glumac221b76041d9f
diff --git a/.codespellignore b/.codespellignore
index deb3d739d93..6dec1cec4d5 100644
--- a/.codespellignore
+++ b/.codespellignore
@@ -14,10 +14,12 @@ horizontalY
juxt
methodd
notIn
+optionA
ot
pass-thru
requestor
re-use
+re-used
ser
serieses
sortings
diff --git a/.codespellrc b/.codespellrc
index 5e5d63027d1..4e9ce2de96e 100644
--- a/.codespellrc
+++ b/.codespellrc
@@ -1,3 +1,22 @@
[codespell]
-skip = *.csv,*.edn,*.geojson,*.json,*.tsv,*.xml,docs/developers-guide/drivers/driver-tests.md,docs/developers-guide/e2e-tests.md,docs/questions/query-builder/expressions-list.md,docs/questions/visualizations/country-codes.md,e2e/test/scenarios/admin/i18n/content-translation/constants.ts,frontend/src/cljs,frontend/src/metabase/querying/expressions/tokenizer/lezer.js,frontend/src/metabase/static-viz/constants/char-sizes.ts,frontend/src/metabase/visualizations/lib/mapping_codes.ts,modules/drivers/mongo/src/metabase/driver/mongo/operators.clj
+skip =
+ *.csv,
+ *.edn,
+ *.geojson,
+ *.json,
+ *.tsv,
+ *.unit.spec.*,
+ *.xml,
+ docs/developers-guide/drivers/driver-tests.md,
+ docs/developers-guide/e2e-tests.md,
+ docs/questions/query-builder/expressions-list.md,
+ docs/questions/visualizations/country-codes.md,
+ e2e/test/scenarios/admin/i18n/content-translation/constants.ts,
+ frontend/src/cljs,
+ frontend/src/metabase/querying/expressions/tokenizer/lezer.js,
+ frontend/src/metabase/query_builder/components/NativeQueryEditor/CodeMirrorEditor/language.ts,
+ frontend/src/metabase/static-viz/constants/char-sizes.ts,
+ frontend/src/metabase/visualizations/lib/mapping_codes.ts,
+ frontend/*/mocks/*,
+ modules/drivers/mongo/src/metabase/driver/mongo/operators.clj,
ignore-words = .codespellignore
diff --git a/.github/workflows/codespell.yml b/.github/workflows/codespell.yml
index 2d962f5ea9b..91a4346cb55 100644
--- a/.github/workflows/codespell.yml
+++ b/.github/workflows/codespell.yml
@@ -18,4 +18,5 @@ jobs:
path: >-
docs
enterprise
+ frontend
modules/drivers
diff --git a/enterprise/frontend/src/metabase-enterprise/transforms/components/SchemaFormSelect/SchemaFormSelect.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/transforms/components/SchemaFormSelect/SchemaFormSelect.unit.spec.tsx
index 93803a22d6b..944a4c2cb25 100644
--- a/enterprise/frontend/src/metabase-enterprise/transforms/components/SchemaFormSelect/SchemaFormSelect.unit.spec.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/transforms/components/SchemaFormSelect/SchemaFormSelect.unit.spec.tsx
@@ -60,12 +60,12 @@ describe("SchemaFormSelect", () => {
const input = screen.getByRole("textbox");
act(() => input.focus());
- await userEvent.type(input, "fo"); // codespell:ignore fo
+ await userEvent.type(input, "fo");
expect(screen.getByText("foo")).toBeInTheDocument();
expect(screen.getByText(/Create new schema/)).toBeInTheDocument();
await userEvent.click(screen.getByText(/Create new schema/));
- expect(input).toHaveValue("fo"); // codespell:ignore fo
+ expect(input).toHaveValue("fo");
expect(
screen.getByText(
diff --git a/frontend/src/metabase/dashboard/reducers.unit.spec.js b/frontend/src/metabase/dashboard/reducers.unit.spec.js
index 21001d36466..27cc1988f71 100644
--- a/frontend/src/metabase/dashboard/reducers.unit.spec.js
+++ b/frontend/src/metabase/dashboard/reducers.unit.spec.js
@@ -215,7 +215,7 @@ describe("dashboard reducers", () => {
id: 1,
"last-edit-info": {
id: 1,
- email: "[email protected]",
+ email: "[email protected]",
first_name: "Test",
last_name: "Metabase",
timestamp: "2021-01-01T01:01:01.001",
diff --git a/frontend/src/metabase/databases/components/DatabaseForm/tests/common.unit.spec.tsx b/frontend/src/metabase/databases/components/DatabaseForm/tests/common.unit.spec.tsx
index 72a79e84f91..16c3f36ad5b 100644
--- a/frontend/src/metabase/databases/components/DatabaseForm/tests/common.unit.spec.tsx
+++ b/frontend/src/metabase/databases/components/DatabaseForm/tests/common.unit.spec.tsx
@@ -162,7 +162,7 @@ describe("DatabaseForm with provider name", () => {
});
const connectionString =
- "jdbc:postgresql://user:[email protected]:5432/mydb";
+ "jdbc:postgresql://user:[email protected]:5432/mydb";
await userEvent.type(
screen.getByLabelText("Connection string (optional)"),
connectionString,
@@ -187,7 +187,7 @@ describe("DatabaseForm with provider name", () => {
},
});
- const connectionString = "jdbc:postgresql://user:passs@localhost:5432/mydb";
+ const connectionString = "jdbc:postgresql://user:pass@localhost:5432/mydb";
await userEvent.type(
screen.getByLabelText("Connection string (optional)"),
connectionString,
diff --git a/frontend/src/metabase/documents/components/DocumentPage.unit.spec.tsx b/frontend/src/metabase/documents/components/DocumentPage.unit.spec.tsx
index 417801ae985..45b7fbe5e91 100644
--- a/frontend/src/metabase/documents/components/DocumentPage.unit.spec.tsx
+++ b/frontend/src/metabase/documents/components/DocumentPage.unit.spec.tsx
@@ -15,7 +15,7 @@ const setup = () => {
setupBookmarksEndpoints([]);
setupDocumentEndpoints(
createMockDocument({
- name: "Ends with whitepsace ",
+ name: "Ends with whitespace ",
id: 1,
can_write: true,
}),
@@ -40,7 +40,7 @@ describe("Document Page", () => {
it("should show a save button when title changes", async () => {
setup();
await waitFor(async () =>
- expect(await getDocumentTitle()).toHaveValue("Ends with whitepsace "),
+ expect(await getDocumentTitle()).toHaveValue("Ends with whitespace "),
);
await userEvent.clear(await getDocumentTitle());
@@ -55,7 +55,7 @@ describe("Document Page", () => {
// is a very easy way to get false positives in your test. Asserting that something
// doesn't exist *anymore* should be more robust
await userEvent.clear(await getDocumentTitle());
- await userEvent.type(await getDocumentTitle(), "Ends with whitepsace ");
+ await userEvent.type(await getDocumentTitle(), "Ends with whitespace ");
await waitFor(() =>
expect(
diff --git a/frontend/src/metabase/rich_text_editing/tiptap/extensions/HandleEditorDrop/HandleEditorDrop.tsx b/frontend/src/metabase/rich_text_editing/tiptap/extensions/HandleEditorDrop/HandleEditorDrop.tsx
index 1ce7d3666f8..1e4d851accb 100644
--- a/frontend/src/metabase/rich_text_editing/tiptap/extensions/HandleEditorDrop/HandleEditorDrop.tsx
+++ b/frontend/src/metabase/rich_text_editing/tiptap/extensions/HandleEditorDrop/HandleEditorDrop.tsx
@@ -204,7 +204,7 @@ export const HandleEditorDrop = Extension.create({
return new Slice(
Fragment.fromArray(transformedContent),
slice.openStart,
- slice.openEnd,
+ slice.openEnd, // codespell:ignore
);
},
},
diff --git a/frontend/src/metabase/ui/components/inputs/MultiAutocomplete/use-multi-autocomplete/use-multi-autocomplete.ts b/frontend/src/metabase/ui/components/inputs/MultiAutocomplete/use-multi-autocomplete/use-multi-autocomplete.ts
index a9133ba7cf7..901ed3dc826 100644
--- a/frontend/src/metabase/ui/components/inputs/MultiAutocomplete/use-multi-autocomplete/use-multi-autocomplete.ts
+++ b/frontend/src/metabase/ui/components/inputs/MultiAutocomplete/use-multi-autocomplete/use-multi-autocomplete.ts
@@ -400,7 +400,7 @@ function getFieldStateAfterChange(
// When pasting, we want to combine the values from the clipboard with the
// existing input value, taking the current selection into account. For example,
// if the input value is "ab<caret>c" and the user pastes "d,e,f", the
-// new values should be "abd,e,fc".
+// new values should be "abd,e,fc". | codespell:ignore
function getParsedValuesCombinedWithFieldValue(
fieldValue: string,
parsedValues: string[],
diff --git a/mage/src/mage/codespell.clj b/mage/src/mage/codespell.clj
index 0f337bfbcec..b259521f0c9 100644
--- a/mage/src/mage/codespell.clj
+++ b/mage/src/mage/codespell.clj
@@ -11,7 +11,7 @@
"docs"
#_"e2e"
"enterprise"
- #_"frontend"
+ "frontend"
"modules/drivers"
#_"src"
#_"test"])