Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Fix Horror Show fingerprint OOMs (#68391)

dpsutton2287567b12e4
diff --git a/src/metabase/sync/analyze/fingerprint.clj b/src/metabase/sync/analyze/fingerprint.clj
index 8641203c371..2ea265369c7 100644
--- a/src/metabase/sync/analyze/fingerprint.clj
+++ b/src/metabase/sync/analyze/fingerprint.clj
@@ -9,8 +9,6 @@
[metabase.driver :as driver]
[metabase.driver.util :as driver.u]
[metabase.lib.schema.metadata.fingerprint :as lib.schema.metadata.fingerprint]
- ;; legacy usage -- don't do things like this going forward
- ^{:clj-kondo/ignore [:deprecated-namespace :discouraged-namespace]} [metabase.query-processor.store :as qp.store]
[metabase.sync.interface :as i]
[metabase.sync.util :as sync-util]
[metabase.util :as u]
@@ -218,24 +216,23 @@
([database :- i/DatabaseInstance
log-progress-fn :- LogProgressFn
continue? :- [:=> [:cat ::FingerprintStats] :any]]
- (qp.store/with-metadata-provider (u/the-id database)
- (let [tables (if *refingerprint?*
- (sync-util/refingerprint-reducible-sync-tables database)
- (sync-util/reducible-sync-tables database))]
- (reduce (fn [acc table]
- (log-progress-fn (if *refingerprint?* "refingerprint-fields" "fingerprint-fields") table)
- (let [ret (fingerprint-table! table)
- new-acc (let [ret (if (:throwable ret)
- (-> ret
- (dissoc :throwable)
- (update :failed-fingerprints inc))
- ret)]
- (merge-with + acc ret))]
- (if (and (continue? new-acc) (not (sync-util/abandon-sync? ret)))
- new-acc
- (reduced new-acc))))
- (empty-stats-map 0)
- tables)))))
+ (let [tables (if *refingerprint?*
+ (sync-util/refingerprint-reducible-sync-tables database)
+ (sync-util/reducible-sync-tables database))]
+ (reduce (fn [acc table]
+ (log-progress-fn (if *refingerprint?* "refingerprint-fields" "fingerprint-fields") table)
+ (let [ret (fingerprint-table! table)
+ new-acc (let [ret (if (:throwable ret)
+ (-> ret
+ (dissoc :throwable)
+ (update :failed-fingerprints inc))
+ ret)]
+ (merge-with + acc ret))]
+ (if (and (continue? new-acc) (not (sync-util/abandon-sync? ret)))
+ new-acc
+ (reduced new-acc))))
+ (empty-stats-map 0)
+ tables))))
(mu/defn fingerprint-fields-for-db!
"Invokes [[fingerprint-table!]] on every table in `database`"