The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
default transforms impls with informative errors (#71145)
Nicola Mometto22b696265617
diff --git a/src/metabase/transforms/interface.clj b/src/metabase/transforms/interface.cljindex f788462e90e..7e195385386 100644--- a/src/metabase/transforms/interface.clj+++ b/src/metabase/transforms/interface.clj@@ -35,3 +35,11 @@{:added "0.57.0" :arglists '([transform options])}(fn [transform _options](transforms-base.i/transform->transform-type transform)))++(defmethod execute! :default+ [transform _options]+ (let [transform-type (-> transform :source :type)]+ (throw (ex-info (format "Cannot execute transform %d: no implementation for transform type %s"+ (:id transform) transform-type)+ {:transform-id (:id transform)+ :transform-type transform-type}))))diff --git a/src/metabase/transforms_base/interface.clj b/src/metabase/transforms_base/interface.cljindex 2efddae8174..c01a185a115 100644--- a/src/metabase/transforms_base/interface.clj+++ b/src/metabase/transforms_base/interface.clj@@ -5,7 +5,9 @@(query, python) must implement. The base module uses these for dispatchwithout any database writes for transform_run tracking.- For scheduled execution with transform_run tracking, see metabase.transforms.interface.")+ For scheduled execution with transform_run tracking, see metabase.transforms.interface."+ (:require+ [metabase.util.log :as log]))(defn transform->transform-type"Extract the transform type from a transform's source."@@ -74,3 +76,32 @@{:added "0.57.0" :arglists '([transform options])}(fn [transform _options](transform->transform-type transform)))++;; These defaults handle gracefully the case where transforms exist in the database with a type whose implementation+;; is not loaded (e.g. :python transforms when running without EE).++(defmethod source-db-id :default+ [transform]+ (log/warnf "No source-db-id implementation for transform type %s (id: %s)"+ (-> transform :source :type) (:id transform))+ nil)++(defmethod target-db-id :default+ [transform]+ (log/warnf "No target-db-id implementation for transform type %s (id: %s)"+ (-> transform :source :type) (:id transform))+ nil)++(defmethod table-dependencies :default+ [transform]+ (log/warnf "No table-dependencies implementation for transform type %s (id: %s)"+ (-> transform :source :type) (:id transform))+ #{})++(defmethod execute-base! :default+ [transform _options]+ (let [transform-type (-> transform :source :type)]+ (throw (ex-info (format "Cannot execute transform %d: no implementation for transform type %s"+ (:id transform) transform-type)+ {:transform-id (:id transform)+ :transform-type transform-type}))))