Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Better error logging for slackbot (#71098)

Noah Moss241e1fb1898b
diff --git a/enterprise/backend/src/metabase_enterprise/metabot_v3/agent/core.clj b/enterprise/backend/src/metabase_enterprise/metabot_v3/agent/core.clj
index 64445bf7b16..8f8f0e9016e 100644
--- a/enterprise/backend/src/metabase_enterprise/metabot_v3/agent/core.clj
+++ b/enterprise/backend/src/metabase_enterprise/metabot_v3/agent/core.clj
@@ -521,7 +521,8 @@
result))
(catch Exception e
(prometheus/inc! :metabase-metabot/agent-errors labels)
- (when-not (:api-error (ex-data e))
+ (if (:api-error (ex-data e))
+ (log/errorf "Agent loop API error: %s" (ex-message e))
(log/error e "Agent loop error"))
(rf init (error-part e)))
(finally
diff --git a/enterprise/backend/src/metabase_enterprise/slackbot/streaming.clj b/enterprise/backend/src/metabase_enterprise/slackbot/streaming.clj
index 9b23f0076e6..8e8fa5fb880 100644
--- a/enterprise/backend/src/metabase_enterprise/slackbot/streaming.clj
+++ b/enterprise/backend/src/metabase_enterprise/slackbot/streaming.clj
@@ -207,6 +207,10 @@
{:type (:data-type part)
:value (:data part)}))
+ :error
+ (when on-text
+ (on-text "Something went wrong. Please try again."))
+
nil)
nil)))]
(transduce dispatch-xf (constantly nil) nil
diff --git a/enterprise/backend/src/metabase_enterprise/sso/integrations/slack_connect.clj b/enterprise/backend/src/metabase_enterprise/sso/integrations/slack_connect.clj
index bae040fb78d..db93deb7364 100644
--- a/enterprise/backend/src/metabase_enterprise/sso/integrations/slack_connect.clj
+++ b/enterprise/backend/src/metabase_enterprise/sso/integrations/slack_connect.clj
@@ -89,7 +89,8 @@
(let [final-redirect (or (:redirect-url login-result) "/")
base-response (-> (response/redirect final-redirect)
(sso/clear-oidc-state-cookie))]
- (log/infof "Slack authentication successful for user %s" (get-in login-result [:user :email]))
+ (log/infof "Slack authentication successful for user %s"
+ (get-in login-result [:user-data :email]))
(if-let [session (:session login-result)]
(request/set-session-cookies request
base-response