The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Error for files that aren't in modules and enforce remaining modules (#76126)
Fraser24ca0fe9136f
diff --git a/eslint.config.mjs b/eslint.config.mjsindex 53b8ae9be19..11d6a25d754 100644--- a/eslint.config.mjs+++ b/eslint.config.mjs@@ -301,6 +301,8 @@ const configs = [message: "${file.type} cannot import from ${dependency.type}",},],+ // Every file frontend/src/ and enterprise/frontend/src/ must belong to a declared module.+ "boundaries/no-unknown-files": "error",},},{diff --git a/eslint.config.module-boundaries.mjs b/eslint.config.module-boundaries.mjsindex aca69668285..b54960360e8 100644--- a/eslint.config.module-boundaries.mjs+++ b/eslint.config.module-boundaries.mjs@@ -101,6 +101,8 @@ export default defineConfig([rules: boundaryRules,},],+ // Every file frontend/src/ and enterprise/frontend/src/ must belong to a declared module.+ "boundaries/no-unknown-files": "error",},},]);diff --git a/frontend/lint/module-boundaries.mjs b/frontend/lint/module-boundaries.mjsindex f08131eae60..87b1b7fc4b0 100644--- a/frontend/lint/module-boundaries.mjs+++ b/frontend/lint/module-boundaries.mjs@@ -25,7 +25,6 @@ const elements = [type: "lib",name: "types",pattern: "frontend/src/metabase-types/*/**",- enforceOutgoing: false,}),createElement({ type: "lib", name: "utils" }),@@ -49,6 +48,7 @@ const elements = [// sharedcreateElement({ type: "shared", name: "account" }),+ createElement({ type: "shared", name: "actions" }),createElement({ type: "shared", name: "api" }),createElement({ type: "shared", name: "archive" }),createElement({ type: "feature", name: "auth" }),@@ -66,7 +66,23 @@ const elements = [createElement({ type: "shared", name: "databases" }),createElement({ type: "shared", name: "detail-view" }),createElement({ type: "shared", name: "documents" }),+ createElement({+ type: "shared",+ name: "embed",+ pattern: "frontend/src/embed/**",+ }),createElement({ type: "shared", name: "embedding", enforceOutgoing: false }),+ createElement({+ type: "shared",+ name: "embedding-sdk",+ enforceOutgoing: false,+ }),+ createElement({+ type: "shared",+ name: "embedding-sdk-bundle",+ pattern: "frontend/src/embedding-sdk-bundle/**",+ enforceOutgoing: false,+ }),createElement({type: "shared",name: "embedding-ee",@@ -74,14 +90,21 @@ const elements = [}),createElement({type: "shared",- name: "embedding-sdk-package",- pattern: "enterprise/frontend/src/embedding-sdk-package/**",+ name: "embedding-sdk-ee",+ pattern: "enterprise/frontend/src/embedding-sdk-ee/**",+ enforceOutgoing: false,}),createElement({type: "shared",- name: "embedding-sdk-shared",- pattern: "frontend/src/embedding-sdk-shared/**",+ name: "embedding-sdk-package",+ pattern: "enterprise/frontend/src/embedding-sdk-package/**",}),+ ...[+ "frontend/src/embedding-sdk-shared/**",+ "frontend/src/embedding-sdk-shared/.storybook/**",+ ].map((pattern) =>+ createElement({ type: "shared", name: "embedding-sdk-shared", pattern }),+ ),createElement({ type: "shared", name: "forms" }),createElement({ type: "shared", name: "history" }),createElement({ type: "shared", name: "hoc" }),@@ -96,23 +119,25 @@ const elements = [createElement({ type: "shared", name: "metabot" }),createElement({ type: "shared", name: "metadata" }),createElement({ type: "feature", name: "models" }),+ createElement({ type: "shared", name: "nav" }),createElement({ type: "shared", name: "new" }),createElement({ type: "shared", name: "notifications" }),createElement({ type: "shared", name: "palette" }),createElement({ type: "shared", name: "parameters" }),createElement({ type: "shared", name: "plugins" }),createElement({ type: "shared", name: "pulse" }),- createElement({ type: "shared", name: "querying", enforceOutgoing: false }),+ createElement({ type: "shared", name: "querying" }),createElement({ type: "shared", name: "questions" }),createElement({ type: "shared", name: "redux" }),+ createElement({ type: "shared", name: "rich_text_editing" }),createElement({ type: "shared", name: "router" }),createElement({type: "shared",name: "schema",pattern: "frontend/src/metabase/schema.js",mode: "full",- enforceOutgoing: false,}),+ createElement({ type: "shared", name: "selectors" }),createElement({ type: "feature", name: "setup" }),createElement({ type: "shared", name: "status" }),createElement({ type: "shared", name: "styled-components" }),@@ -149,6 +174,7 @@ const elements = ["frontend/src/metabase/app-embed-sdk.tsx","frontend/src/metabase/app-main.js","frontend/src/metabase/app-embed.ts",+ "frontend/src/metabase/app-embed-mcp.tsx","frontend/src/metabase/app-public.ts","frontend/src/metabase/AppComponent.tsx","frontend/src/metabase/App.styled.tsx",@@ -180,18 +206,40 @@ const elements = [type: "app",name: "nav",pattern: "frontend/src/metabase/app/nav/**",- enforceOutgoing: true,}),// static-viz must come after the app entries rather than in the// alphabetical shared list: its entry point (static-viz/index.tsx) is app// tier, and the first matching element wins.createElement({ type: "shared", name: "static-viz" }),- // catch-all for unmoduled files - must be last++ // Loose files living directly under frontend/src/metabase that have not yet+ // been pulled into a module folder.+ ...["frontend/src/metabase/dev.ts", "frontend/src/metabase/dev-noop.ts"].map(+ (pattern) =>+ createElement({+ type: "shared",+ name: "cljs-dev-tools",+ pattern,+ mode: "full",+ }),+ ),createElement({type: "shared",- name: "other",- pattern: "frontend/src/*/**",- enforceOutgoing: false,+ name: "error-boundary",+ pattern: "frontend/src/metabase/ErrorBoundary.tsx",+ mode: "full",+ }),+ createElement({+ type: "shared",+ name: "routes-stable-id-aware",+ pattern: "frontend/src/metabase/routes-stable-id-aware.tsx",+ mode: "full",+ }),+ createElement({+ type: "shared",+ name: "redux-store",+ pattern: "frontend/src/metabase/store.js",+ mode: "full",}),];