Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

UXW-1866: UX regression on dropdown list/search with multiple values (#64605)

Stas Gavrylov25270fea3e65
diff --git a/docs/developers-guide/e2e-tests.md b/docs/developers-guide/e2e-tests.md
index c0194b8ad09..151b3096f53 100644
--- a/docs/developers-guide/e2e-tests.md
+++ b/docs/developers-guide/e2e-tests.md
@@ -173,6 +173,10 @@ Some of our tests depend on the email being set up, and require a local SMTP ser
docker run -d -p 1080:1080 -p 1025:1025 maildev/maildev:latest
```
+### Running tests that require translation dictionaries
+
+Some of the tests are checking content translation functionality. These tests require to run `./bin/i18n/build-translation-resources` command before running the tests to precompile JSON files with translations.
+
### Cypress comes with `Lodash` for free
We don't need to have [Lodash](https://lodash.com/) in our direct dependencies to be able to [use it with Cypress](https://docs.cypress.io/api/utilities/_). It is aliased with an underscore and its methods can be accessed with `Cypress._.method()`. We can use `_.times` method to stress-test a certain test (or a set of tests) locally.
diff --git a/e2e/test/scenarios/admin/i18n/content-translation/dashboards.cy.spec.ts b/e2e/test/scenarios/admin/i18n/content-translation/dashboards.cy.spec.ts
index d694f816381..29449ae1a1a 100644
--- a/e2e/test/scenarios/admin/i18n/content-translation/dashboards.cy.spec.ts
+++ b/e2e/test/scenarios/admin/i18n/content-translation/dashboards.cy.spec.ts
@@ -787,6 +787,7 @@ describe("scenarios > content translation > static embedding > dashboards", () =
// Search matches against untranslated text, hence "Fran" matching these names
cy.findByPlaceholderText("Recherche dans la liste").type("Fran");
cy.findByText(/Hammera Francite/).click();
+ cy.realPress("Escape");
cy.findByTestId("parameter-value-dropdown")
.button(/Mettre à jour le filtre/)
.click();
diff --git a/frontend/src/metabase/ui/components/inputs/MultiAutocomplete/MultiAutocomplete.unit.spec.tsx b/frontend/src/metabase/ui/components/inputs/MultiAutocomplete/MultiAutocomplete.unit.spec.tsx
index 6c5e7a42657..92297a8b390 100644
--- a/frontend/src/metabase/ui/components/inputs/MultiAutocomplete/MultiAutocomplete.unit.spec.tsx
+++ b/frontend/src/metabase/ui/components/inputs/MultiAutocomplete/MultiAutocomplete.unit.spec.tsx
@@ -372,7 +372,7 @@ describe("MultiAutocomplete", () => {
expect(queryOption("Two")).not.toBeInTheDocument();
expect(queryOption("Three")).not.toBeInTheDocument();
- await userEvent.type(input, "t");
+ await userEvent.type(input, "{backspace}{backspace}t");
expect(queryOption("One")).not.toBeInTheDocument();
expect(getOption("Two")).toBeInTheDocument();
expect(getOption("Three")).toBeInTheDocument();
@@ -380,8 +380,9 @@ describe("MultiAutocomplete", () => {
await userEvent.click(getOption("Two"));
expect(queryOption("One")).not.toBeInTheDocument();
expect(queryOption("Two")).not.toBeInTheDocument();
- expect(queryOption("Three")).not.toBeInTheDocument();
+ expect(queryOption("Three")).toBeInTheDocument();
+ await userEvent.type(input, "{backspace}");
await userEvent.paste("three");
expect(queryOption("One")).not.toBeInTheDocument();
expect(queryOption("Two")).not.toBeInTheDocument();
diff --git a/frontend/src/metabase/ui/components/inputs/MultiAutocomplete/use-multi-autocomplete/use-multi-autocomplete.ts b/frontend/src/metabase/ui/components/inputs/MultiAutocomplete/use-multi-autocomplete/use-multi-autocomplete.ts
index 1afc4acc5c2..a9133ba7cf7 100644
--- a/frontend/src/metabase/ui/components/inputs/MultiAutocomplete/use-multi-autocomplete/use-multi-autocomplete.ts
+++ b/frontend/src/metabase/ui/components/inputs/MultiAutocomplete/use-multi-autocomplete/use-multi-autocomplete.ts
@@ -231,17 +231,24 @@ export function useMultiAutocomplete({
newFieldValues,
fieldSelection,
);
+ const newFieldSelection = {
+ index: fieldSelection.index + newFieldValues.length,
+ length: 0,
+ };
+ const newFilteredOptions = getOptionsWithoutDuplicates(
+ newValues,
+ options,
+ newFieldSelection,
+ );
+
+ setFieldSelection(newFieldSelection);
+ if (newFilteredOptions.length === 0) {
+ setFieldValue("");
+ combobox.closeDropdown();
+ combobox.resetSelectedOption();
+ }
onChange(newValues);
- setFieldState({
- fieldValue: "",
- fieldSelection: {
- index: fieldSelection.index + newFieldValues.length,
- length: 0,
- },
- });
onOptionSubmit?.(value);
- combobox.closeDropdown();
- combobox.resetSelectedOption();
};
const handleWindowKeydownCapture = (event: KeyboardEvent) => {