Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Show Unknown as the engine of stubbed databases in the admin database list (#83888)

Alexander Polyankin252e46209a15
diff --git a/frontend/src/metabase/admin/databases/components/DatabaseList/DatabaseList.tsx b/frontend/src/metabase/admin/databases/components/DatabaseList/DatabaseList.tsx
index 48ee9e8e903..9733831b1c4 100644
--- a/frontend/src/metabase/admin/databases/components/DatabaseList/DatabaseList.tsx
+++ b/frontend/src/metabase/admin/databases/components/DatabaseList/DatabaseList.tsx
@@ -96,8 +96,10 @@ export const DatabaseList = ({
</Flex>
</td>
<td>
- {engines?.[database.engine ?? ""]?.["driver-name"] ??
- database.engine}
+ {database.is_stub
+ ? t`Unknown`
+ : (engines?.[database.engine ?? ""]?.["driver-name"] ??
+ database.engine)}
</td>
<td>{database.is_stub ? t`Stubbed` : t`Active`}</td>
</tr>
diff --git a/frontend/src/metabase/admin/databases/components/DatabaseList/DatabaseList.unit.spec.tsx b/frontend/src/metabase/admin/databases/components/DatabaseList/DatabaseList.unit.spec.tsx
index c029fa93009..584b207e202 100644
--- a/frontend/src/metabase/admin/databases/components/DatabaseList/DatabaseList.unit.spec.tsx
+++ b/frontend/src/metabase/admin/databases/components/DatabaseList/DatabaseList.unit.spec.tsx
@@ -55,6 +55,7 @@ describe("DatabaseListApp", () => {
await setup({ isStub: true, isAdmin: true });
expect(screen.getByText("Stubbed")).toBeInTheDocument();
+ expect(screen.getByText("Unknown")).toBeInTheDocument();
expect(screen.queryByText("Active")).not.toBeInTheDocument();
});
@@ -62,6 +63,7 @@ describe("DatabaseListApp", () => {
await setup({ isAdmin: true });
expect(screen.getByText("Active")).toBeInTheDocument();
+ expect(screen.queryByText("Unknown")).not.toBeInTheDocument();
expect(screen.queryByText("Stubbed")).not.toBeInTheDocument();
});