Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Force color on select item hover in question picker (#72353)

Nick Fitzpatrick270e297f8ba5
diff --git a/frontend/src/metabase/common/components/SelectList/SelectListItem.styled.tsx b/frontend/src/metabase/common/components/SelectList/SelectListItem.styled.tsx
index cc9fde6ec3c..0989b628758 100644
--- a/frontend/src/metabase/common/components/SelectList/SelectListItem.styled.tsx
+++ b/frontend/src/metabase/common/components/SelectList/SelectListItem.styled.tsx
@@ -12,6 +12,7 @@ export const ItemTitle = styled(Text)<TextProps>`
export const ItemIcon = styled(Icon)`
justify-self: end;
+ color: var(--mb-color-brand);
`;
const activeItemCss = css`
diff --git a/frontend/src/metabase/common/components/SelectList/SelectListItem.tsx b/frontend/src/metabase/common/components/SelectList/SelectListItem.tsx
index 26a94b3b1f7..8a2726bb1d7 100644
--- a/frontend/src/metabase/common/components/SelectList/SelectListItem.tsx
+++ b/frontend/src/metabase/common/components/SelectList/SelectListItem.tsx
@@ -45,9 +45,7 @@ export function SelectListItem({
hasLeftIcon={!!icon}
hasRightIcon={!!rightIcon}
>
- {icon && (
- <ItemIcon className={classNames.icon} c="brand" {...iconProps} />
- )}
+ {icon && <ItemIcon className={classNames.icon} {...iconProps} />}
<ItemTitle
className={classNames.label}
fw="bold"
diff --git a/frontend/src/metabase/dashboard/components/QuestionPicker/QuestionList.module.css b/frontend/src/metabase/dashboard/components/QuestionPicker/QuestionList.module.css
index 08095c285a4..c362921bd26 100644
--- a/frontend/src/metabase/dashboard/components/QuestionPicker/QuestionList.module.css
+++ b/frontend/src/metabase/dashboard/components/QuestionPicker/QuestionList.module.css
@@ -5,7 +5,7 @@
&:hover {
.QuestionListItemIcon {
- color: var(--mb-color-text-primary);
+ color: var(--mb-color-text-primary-inverse);
}
}