The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Update Measure Icon in Data Studio and Metric Explorer (#71924)
Nick Fitzpatrick277d62931703
diff --git a/enterprise/frontend/src/metabase-enterprise/data-studio/library/tables/pages/TableMeasuresPage/TableMeasures.tsx b/enterprise/frontend/src/metabase-enterprise/data-studio/library/tables/pages/TableMeasuresPage/TableMeasures.tsxindex cfed5996cb8..2d2b4715cad 100644--- a/enterprise/frontend/src/metabase-enterprise/data-studio/library/tables/pages/TableMeasuresPage/TableMeasures.tsx+++ b/enterprise/frontend/src/metabase-enterprise/data-studio/library/tables/pages/TableMeasuresPage/TableMeasures.tsx@@ -27,7 +27,7 @@ export function TableMeasures({ table }: TableMeasuresProps) {items={measures}title={t`Measures`}emptyState={{- icon: "sum",+ icon: "ruler",title: t`No measures yet`,message: t`Create a measure to define aggregations for this table.`,}}@@ -46,7 +46,7 @@ export function TableMeasures({ table }: TableMeasuresProps) {key={measure.id}name={measure.name}description={measure.definition_description}- icon="sum"+ icon="ruler"href={Urls.dataStudioPublishedTableMeasure(table.id, measure.id)}/>)}diff --git a/enterprise/frontend/src/metabase-enterprise/dependencies/utils.ts b/enterprise/frontend/src/metabase-enterprise/dependencies/utils.tsindex 455f4217273..71fca4009b4 100644--- a/enterprise/frontend/src/metabase-enterprise/dependencies/utils.ts+++ b/enterprise/frontend/src/metabase-enterprise/dependencies/utils.ts@@ -116,7 +116,7 @@ export function getNodeIconWithType(case "segment":return "segment";case "measure":- return "sum";+ return "ruler";}}diff --git a/frontend/src/metabase/metrics-viewer/components/MetricSearch/MetricSearchResults/MetricSearchResults.tsx b/frontend/src/metabase/metrics-viewer/components/MetricSearch/MetricSearchResults/MetricSearchResults.tsxindex 465665b5e4f..91c6f30aed9 100644--- a/frontend/src/metabase/metrics-viewer/components/MetricSearch/MetricSearchResults/MetricSearchResults.tsx+++ b/frontend/src/metabase/metrics-viewer/components/MetricSearch/MetricSearchResults/MetricSearchResults.tsx@@ -1,6 +1,7 @@import type React from "react";import { t } from "ttag";+import { getIcon } from "metabase/lib/icon";import { Box, Repeat, Skeleton, Stack, Text } from "metabase/ui";import type { MetricOrMeasureResult } from "../../../hooks/use-metric-measure-search";@@ -58,7 +59,7 @@ export function MetricSearchResults({ref={getRef(item)}name={item.name}slug={item.table_name ?? undefined}- icon={item.model === "metric" ? "metric" : "sum"}+ icon={getIcon(item).name}active={cursorIndex === index}onClick={() => onSelectResult(item.id, item.model)}/>