Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

test: mutation tests for column-metadata-effective-type and nest-display-name (#69328)

Eric Normand29f75c12515d
diff --git a/test/metabase/lib/field_test.cljc b/test/metabase/lib/field_test.cljc
index c9649841990..187fa9159b1 100644
--- a/test/metabase/lib/field_test.cljc
+++ b/test/metabase/lib/field_test.cljc
@@ -30,6 +30,27 @@
#?(:cljs (comment metabase.test-runner.assert-exprs.approximately-equal/keep-me))
+(deftest ^:parallel column-metadata-effective-type-test
+ (let [query (lib/query meta/metadata-provider (meta/table-metadata :orders))]
+ (testing "type-of falls back to :base-type when :effective-type is absent"
+ (let [col (dissoc (meta/field-metadata :orders :created-at) :effective-type)]
+ (is (= (:base-type col)
+ (lib/type-of query col)))))
+ (testing "type-of uses :effective-type over :base-type"
+ (let [col (assoc (meta/field-metadata :orders :total)
+ :effective-type :type/Currency
+ :base-type :type/Float)]
+ (is (= :type/Currency
+ (lib/type-of query col)))))
+ (testing "temporal extraction returns :type/Integer"
+ (let [col (lib/with-temporal-bucket (meta/field-metadata :orders :created-at) :month-of-year)]
+ (is (= :type/Integer
+ (lib/type-of query col)))))
+ (testing "temporal truncation (non-extraction) preserves effective type"
+ (let [col (lib/with-temporal-bucket (meta/field-metadata :orders :created-at) :month)]
+ (is (= (:effective-type (meta/field-metadata :orders :created-at))
+ (lib/type-of query col)))))))
+
(deftest ^:parallel ref-test
(is (=? [:field
{:base-type :type/DateTime
@@ -161,6 +182,24 @@
lib/visible-columns
(map #(lib/display-info base -1 %))))))))))
+(deftest ^:parallel nested-field-nil-parent-display-name-test
+ (testing "nested field with nil parent display-name falls back gracefully"
+ (let [child-field (assoc (meta/field-metadata :orders :created-at)
+ :id 99999
+ :parent-id 99998
+ :name "CHILD_COL"
+ :display-name "Child Col")
+ parent-field (assoc (meta/field-metadata :orders :created-at)
+ :id 99998
+ :display-name nil
+ :parent-id nil)
+ mp (lib.tu/mock-metadata-provider
+ meta/metadata-provider
+ {:fields [child-field parent-field]})
+ query (lib/query mp (meta/table-metadata :orders))]
+ (is (= "Child Col"
+ (lib/display-name query child-field))))))
+
(deftest ^:parallel nested-field-display-name-via-model-test
(testing "Nested field display names should not be doubled when querying a model (#QUE-XXXX)"
(let [;; Build a model whose result-metadata has the nested display-names (simulating what the QP produces)
@@ -743,6 +782,21 @@
(meta/field-metadata :venues :name)])
lib/fieldable-columns)))))
+(deftest ^:parallel fieldable-columns-excludes-joins-and-expressions-test
+ (testing "fieldable-columns excludes joined columns"
+ (let [query (-> (lib.tu/venues-query)
+ (lib/join (-> (lib/join-clause (meta/table-metadata :categories)
+ [(lib/= (meta/field-metadata :venues :category-id)
+ (meta/field-metadata :categories :id))])
+ (lib/with-join-fields :all))))]
+ (is (not-any? #(= :source/joins (:lib/source %))
+ (lib/fieldable-columns query)))))
+ (testing "fieldable-columns excludes expression columns"
+ (let [query (-> (lib.tu/venues-query)
+ (lib/expression "myadd" (lib/+ 1 (meta/field-metadata :venues :category-id))))]
+ (is (not-any? #(= :source/expressions (:lib/source %))
+ (lib/fieldable-columns query))))))
+
(deftest ^:parallel ref-to-joined-column-from-previous-stage-test
(let [query (-> (lib.tu/venues-query)
(lib/join (-> (lib/join-clause