Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Rename tag `@smoke` to `@prerelease` (#74264)

Nemanja Glumac2ad4b76e0309
diff --git a/.github/scripts/build-e2e-matrix.js b/.github/scripts/build-e2e-matrix.js
index 9b7b5780a36..5939265e64d 100755
--- a/.github/scripts/build-e2e-matrix.js
+++ b/.github/scripts/build-e2e-matrix.js
@@ -8,7 +8,7 @@ const specialTestConfigs = [
{
name: "oss-subset",
edition: "oss",
- tags: "@OSS @smoke+-@EE",
+ tags: "@OSS @prerelease+-@EE",
specs: DEFAULT_SPEC_PATTERN,
},
{ name: "mongo", tags: "@mongo", specs: DEFAULT_SPEC_PATTERN },
diff --git a/.github/workflows/pre-release.yml b/.github/workflows/pre-release.yml
index 98593300fff..2416fac4749 100644
--- a/.github/workflows/pre-release.yml
+++ b/.github/workflows/pre-release.yml
@@ -223,7 +223,7 @@ jobs:
CYPRESS_BROWSER: ${{ steps.cypress-prep.outputs.chrome-path }}
run: |
node e2e/runner/run_cypress_ci.js e2e \
- $CYPRESS_GREP_FLAG grepTags="@smoke+-@EE" \
+ $CYPRESS_GREP_FLAG grepTags="@prerelease+-@EE" \
--spec './e2e/test/scenarios/**/*.cy.spec.(js|ts)'
- name: Run a few important EE Cypress tests as sanity check
@@ -232,7 +232,7 @@ jobs:
CYPRESS_BROWSER: ${{ steps.cypress-prep.outputs.chrome-path }}
run: |
node e2e/runner/run_cypress_ci.js e2e \
- $CYPRESS_GREP_FLAG grepTags="@smoke+-@OSS" \
+ $CYPRESS_GREP_FLAG grepTags="@prerelease+-@OSS" \
--spec './e2e/test/scenarios/**/*.cy.spec.(js|ts)'
- name: Upload Cypress Artifacts upon failure
diff --git a/e2e/test/scenarios/admin-2/people.cy.spec.js b/e2e/test/scenarios/admin-2/people.cy.spec.js
index 31b39390064..13a64232608 100644
--- a/e2e/test/scenarios/admin-2/people.cy.spec.js
+++ b/e2e/test/scenarios/admin-2/people.cy.spec.js
@@ -122,33 +122,37 @@ describe("scenarios > admin > people", () => {
cy.findByText("A group is only as good as its members.");
});
- it("should allow admin to create new users", { tags: "@smoke" }, () => {
- const { first_name, last_name, email } = TEST_USER;
- const FULL_NAME = `${first_name} ${last_name}`;
- cy.visit("/admin/people");
- clickButton("Invite someone");
+ it(
+ "should allow admin to create new users",
+ { tags: "@prerelease" },
+ () => {
+ const { first_name, last_name, email } = TEST_USER;
+ const FULL_NAME = `${first_name} ${last_name}`;
+ cy.visit("/admin/people");
+ clickButton("Invite someone");
- // first modal
- cy.findByLabelText("First name").type(first_name);
- cy.findByLabelText("Last name").type(last_name);
- //
- cy.findByLabelText(/Email/).type(email);
- clickButton("Create");
+ // first modal
+ cy.findByLabelText("First name").type(first_name);
+ cy.findByLabelText("Last name").type(last_name);
+ //
+ cy.findByLabelText(/Email/).type(email);
+ clickButton("Create");
- // second modal
- // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usage
- cy.findByText(`${FULL_NAME} has been added`);
- // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usage
- cy.findByText("Show").click();
- // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usage
- cy.findByText("Done").click();
+ // second modal
+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usage
+ cy.findByText(`${FULL_NAME} has been added`);
+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usage
+ cy.findByText("Show").click();
+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usage
+ cy.findByText("Done").click();
- // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usage
- cy.findByText(FULL_NAME);
- cy.location().should((loc) =>
- expect(loc.pathname).to.eq("/admin/people"),
- );
- });
+ // eslint-disable-next-line metabase/no-unscoped-text-selectors -- deprecated usage
+ cy.findByText(FULL_NAME);
+ cy.location().should((loc) =>
+ expect(loc.pathname).to.eq("/admin/people"),
+ );
+ },
+ );
it("should allow admin to create new users without first name or last name (metabase#22754)", () => {
const { email } = TEST_USER;
diff --git a/e2e/test/scenarios/admin-2/whitelabel.cy.spec.js b/e2e/test/scenarios/admin-2/whitelabel.cy.spec.js
index 8733b8f0c1c..23c847395e6 100644
--- a/e2e/test/scenarios/admin-2/whitelabel.cy.spec.js
+++ b/e2e/test/scenarios/admin-2/whitelabel.cy.spec.js
@@ -163,7 +163,7 @@ describe("formatting > whitelabel", { tags: "@EE" }, () => {
describe("login page illustration", () => {
it(
"should only allow uploading a valid image files (PNG, JPG, SVG) and display on login page",
- { tags: "@smoke" },
+ { tags: "@prerelease" },
() => {
/**
* Unfortunately, we couldn't test the browser file selector with Cypress yet.
diff --git a/e2e/test/scenarios/dashboard/dashboard.cy.spec.js b/e2e/test/scenarios/dashboard/dashboard.cy.spec.js
index cd1611c5f81..c36c30d79a6 100644
--- a/e2e/test/scenarios/dashboard/dashboard.cy.spec.js
+++ b/e2e/test/scenarios/dashboard/dashboard.cy.spec.js
@@ -32,7 +32,7 @@ describe("scenarios > dashboard", () => {
});
describe("create", () => {
- it("new dashboard UI flow", { tags: "@smoke" }, () => {
+ it("new dashboard UI flow", { tags: "@prerelease" }, () => {
cy.intercept("POST", "/api/dashboard").as("createDashboard");
cy.intercept("POST", "/api/card").as("createQuestion");
diff --git a/e2e/test/scenarios/question/new.cy.spec.js b/e2e/test/scenarios/question/new.cy.spec.js
index 75de39a31d4..979f91eb034 100644
--- a/e2e/test/scenarios/question/new.cy.spec.js
+++ b/e2e/test/scenarios/question/new.cy.spec.js
@@ -343,7 +343,7 @@ describe("scenarios > question > new", () => {
it(
"should be able to save a question to a collection created on the go",
- { tags: "@smoke" },
+ { tags: "@prerelease" },
() => {
H.visitCollection(THIRD_COLLECTION_ID);
@@ -645,7 +645,7 @@ describe("scenarios > question > new", () => {
// model-less behavior
describe(
"scenarios > question > new > data picker > without models",
- { tags: ["@OSS", "@smoke"] },
+ { tags: ["@OSS", "@prerelease"] },
() => {
beforeEach(() => {
H.restore("without-models");