The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Add empty state to native query DB dropdown (#66090)
Riley Thompson2df87d3a7f35
diff --git a/frontend/src/metabase/query_builder/components/DataSelector/DataSelectorDatabasePicker/DataSelectorDatabasePicker.tsx b/frontend/src/metabase/query_builder/components/DataSelector/DataSelectorDatabasePicker/DataSelectorDatabasePicker.tsxindex c7cb249df1a..4766343f4c7 100644--- a/frontend/src/metabase/query_builder/components/DataSelector/DataSelectorDatabasePicker/DataSelectorDatabasePicker.tsx+++ b/frontend/src/metabase/query_builder/components/DataSelector/DataSelectorDatabasePicker/DataSelectorDatabasePicker.tsx@@ -83,6 +83,7 @@ const DataSelectorDatabasePicker = ({className={CS.textBrand}hasInitialFocus={hasInitialFocus}sections={sections}+ globalSearch={true}onChange={(item: Item) => onChangeDatabase(item.database)}onChangeSection={handleChangeSection}itemIsClickable={(item: Item) => !databaseIsDisabled?.(item.database)}diff --git a/frontend/src/metabase/query_builder/components/DataSelector/DataSelectorDatabasePicker/DataSelectorDatabasePicker.unit.spec.tsx b/frontend/src/metabase/query_builder/components/DataSelector/DataSelectorDatabasePicker/DataSelectorDatabasePicker.unit.spec.tsxindex a78b2f7f198..77b4bb2eac5 100644--- a/frontend/src/metabase/query_builder/components/DataSelector/DataSelectorDatabasePicker/DataSelectorDatabasePicker.unit.spec.tsx+++ b/frontend/src/metabase/query_builder/components/DataSelector/DataSelectorDatabasePicker/DataSelectorDatabasePicker.unit.spec.tsx@@ -1,3 +1,5 @@+import userEvent from "@testing-library/user-event";+import { createMockEntitiesState } from "__support__/store";import { renderWithProviders, screen } from "__support__/ui";import { checkNotNull } from "metabase/lib/types";@@ -9,18 +11,20 @@ import DataSelectorDatabasePicker from "./DataSelectorDatabasePicker";const TEST_DATABASE = createMockDatabase();-const setup = () => {+const setup = (mockDatabases = [TEST_DATABASE]) => {const state = createMockState({entities: createMockEntitiesState({- databases: [TEST_DATABASE],+ databases: mockDatabases,}),});const metadata = getMetadata(state);- const database = checkNotNull(metadata.database(TEST_DATABASE.id));+ const databases = mockDatabases.map((db) =>+ checkNotNull(metadata.database(db.id)),+ );renderWithProviders(<DataSelectorDatabasePicker- databases={[database]}+ databases={databases}onChangeDatabase={jest.fn()}onChangeSchema={jest.fn()}/>,@@ -32,4 +36,37 @@ describe("DataSelectorDatabasePicker", () => {setup();expect(screen.getByText(TEST_DATABASE.name)).toBeInTheDocument();});++ it("shows empty state when search returns no results", async () => {+ const databases = [+ createMockDatabase({ id: 1, name: "PostgreSQL Database" }),+ createMockDatabase({ id: 2, name: "MySQL Database" }),+ createMockDatabase({ id: 3, name: "H2 Database" }),+ ];+ setup(databases);++ const searchInput = screen.getByPlaceholderText("Find...");+ await userEvent.type(searchInput, "Oracle");++ expect(screen.getByText("Didn't find any results")).toBeInTheDocument();+ });++ it("shows matching databases when search has results", async () => {+ const databases = [+ createMockDatabase({ id: 1, name: "PostgreSQL Database" }),+ createMockDatabase({ id: 2, name: "MySQL Database" }),+ createMockDatabase({ id: 3, name: "H2 Database" }),+ ];+ setup(databases);++ const searchInput = screen.getByPlaceholderText("Find...");+ await userEvent.type(searchInput, "Post");++ expect(screen.getByText("PostgreSQL Database")).toBeInTheDocument();+ expect(screen.queryByText("MySQL Database")).not.toBeInTheDocument();+ expect(screen.queryByText("H2 Database")).not.toBeInTheDocument();+ expect(+ screen.queryByText("Didn't find any results"),+ ).not.toBeInTheDocument();+ });});