Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Skip extra server round-trips when loading data (#80958)

Ben Grabow2e58c450be37
diff --git a/modules/drivers/snowflake/test/metabase/test/data/snowflake.clj b/modules/drivers/snowflake/test/metabase/test/data/snowflake.clj
index 21d1f105b8a..5bd3ac9444c 100644
--- a/modules/drivers/snowflake/test/metabase/test/data/snowflake.clj
+++ b/modules/drivers/snowflake/test/metabase/test/data/snowflake.clj
@@ -249,6 +249,14 @@
[_driver _dbdef tabledef]
(load-data/maybe-add-ids-xform tabledef))
+;; Load each chunk without wrapping it in a transaction: on Snowflake `setAutoCommit` and `commit` are each a server
+;; round trip, so the default per-chunk transaction turns one INSERT into three. [[load-data/create-db!]] has already
+;; put this connection in autocommit mode, so the rows still land. No atomicity is lost - every chunk committed
+;; separately anyway, and [[dataset-rows-ok?!]] is what catches a half-loaded dataset and forces a reload.
+(defmethod load-data/do-insert! :snowflake
+ [driver conn table-identifier rows]
+ (load-data/do-insert*! driver conn table-identifier rows {:transaction? false}))
+
(defmethod sql.tx/generated-column-sql :snowflake [_ expr]
(format "AS (%s)" expr))