The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Rename Tasks page to Dependency diagnostics and update labels (#67935)
Maz Ameli2e6bb7f66986
diff --git a/e2e/support/helpers/e2e-data-studio-helpers.ts b/e2e/support/helpers/e2e-data-studio-helpers.tsindex 87ff8cf1327..269a1329f50 100644--- a/e2e/support/helpers/e2e-data-studio-helpers.ts+++ b/e2e/support/helpers/e2e-data-studio-helpers.ts@@ -131,9 +131,10 @@ export const DataStudio = {libraryPage().findAllByTestId("collection-name").contains(name),},Tasks: {- visitBrokenEntities: () => cy.visit("/data-studio/tasks/broken"),+ visitBrokenEntities: () =>+ cy.visit("/data-studio/dependency-diagnostics/broken"),visitUnreferencedEntities: () =>- cy.visit("/data-studio/tasks/unreferenced"),+ cy.visit("/data-studio/dependency-diagnostics/unreferenced"),list: () => cy.findByTestId("dependency-list"),searchInput: () => cy.findByTestId("dependency-list-search-input"),filterButton: () => cy.findByTestId("dependency-list-filter-button"),diff --git a/enterprise/frontend/src/metabase-enterprise/data-studio/app/pages/DataStudioLayout/DataStudioLayout.tsx b/enterprise/frontend/src/metabase-enterprise/data-studio/app/pages/DataStudioLayout/DataStudioLayout.tsxindex c2beafb874a..9caa7f5cd02 100644--- a/enterprise/frontend/src/metabase-enterprise/data-studio/app/pages/DataStudioLayout/DataStudioLayout.tsx+++ b/enterprise/frontend/src/metabase-enterprise/data-studio/app/pages/DataStudioLayout/DataStudioLayout.tsx@@ -148,10 +148,10 @@ function DataStudioNav({ isNavbarOpened, onNavbarToggle }: DataStudioNavProps) {)}{PLUGIN_DEPENDENCIES.isEnabled && (<DataStudioTab- label={t`Tasks`}+ label={t`Dependency diagnostics`}icon="list"- to={Urls.dataStudioTasks()}- isSelected={currentTab === "tasks"}+ to={Urls.dataStudioDependencyDiagnostics()}+ isSelected={currentTab === "dependency-diagnostics"}showLabel={isNavbarOpened}/>)}diff --git a/enterprise/frontend/src/metabase-enterprise/data-studio/app/pages/DataStudioLayout/utils.ts b/enterprise/frontend/src/metabase-enterprise/data-studio/app/pages/DataStudioLayout/utils.tsindex 0106e61b083..a544c525187 100644--- a/enterprise/frontend/src/metabase-enterprise/data-studio/app/pages/DataStudioLayout/utils.ts+++ b/enterprise/frontend/src/metabase-enterprise/data-studio/app/pages/DataStudioLayout/utils.ts@@ -6,7 +6,7 @@ type TabName =| "transforms"| "jobs"| "runs"- | "tasks"+ | "dependency-diagnostics"| "dependencies"| "glossary";@@ -16,8 +16,8 @@ export const getCurrentTab = (pathname: string): TabName => {return "glossary";case pathname.startsWith(Urls.transformJobList()):return "jobs";- case pathname.startsWith(Urls.dataStudioTasks()):- return "tasks";+ case pathname.startsWith(Urls.dataStudioDependencyDiagnostics()):+ return "dependency-diagnostics";case pathname.startsWith(Urls.dependencyGraph()):return "dependencies";case pathname.startsWith(Urls.dataStudioLibrary()):diff --git a/enterprise/frontend/src/metabase-enterprise/data-studio/app/pages/DataStudioLayout/utils.unit.spec.ts b/enterprise/frontend/src/metabase-enterprise/data-studio/app/pages/DataStudioLayout/utils.unit.spec.tsindex 1c6f3b1b80d..7d95447601e 100644--- a/enterprise/frontend/src/metabase-enterprise/data-studio/app/pages/DataStudioLayout/utils.unit.spec.ts+++ b/enterprise/frontend/src/metabase-enterprise/data-studio/app/pages/DataStudioLayout/utils.unit.spec.ts@@ -2,25 +2,28 @@ import { getCurrentTab } from "./utils";describe("getCurrentTab", () => {it.each`- pathname | expectedTab- ${"/data-studio/glossary"} | ${"glossary"}- ${"/data-studio/glossary/some-path"} | ${"glossary"}- ${"/data-studio/transforms/jobs"} | ${"jobs"}- ${"/data-studio/transforms/jobs/123"} | ${"jobs"}- ${"/data-studio/transforms/jobs/new"} | ${"jobs"}- ${"/data-studio/dependencies"} | ${"dependencies"}- ${"/data-studio/dependencies?id=1&type=card"} | ${"dependencies"}- ${"/data-studio/library"} | ${"library"}- ${"/data-studio/library/collections/123"} | ${"library"}- ${"/data-studio/library/metrics/456"} | ${"library"}- ${"/data-studio/transforms/runs"} | ${"runs"}- ${"/data-studio/transforms/runs?page=2"} | ${"runs"}- ${"/data-studio/transforms"} | ${"transforms"}- ${"/data-studio/transforms/123"} | ${"transforms"}- ${"/data-studio/transforms/new/query"} | ${"transforms"}- ${"/data-studio/data"} | ${"data"}- ${"/data-studio/data/database/1"} | ${"data"}- ${"/data-studio"} | ${"data"}+ pathname | expectedTab+ ${"/data-studio/glossary"} | ${"glossary"}+ ${"/data-studio/glossary/some-path"} | ${"glossary"}+ ${"/data-studio/transforms/jobs"} | ${"jobs"}+ ${"/data-studio/transforms/jobs/123"} | ${"jobs"}+ ${"/data-studio/transforms/jobs/new"} | ${"jobs"}+ ${"/data-studio/dependencies"} | ${"dependencies"}+ ${"/data-studio/dependencies?id=1&type=card"} | ${"dependencies"}+ ${"/data-studio/dependency-diagnostics"} | ${"dependency-diagnostics"}+ ${"/data-studio/dependency-diagnostics/broken"} | ${"dependency-diagnostics"}+ ${"/data-studio/dependency-diagnostics/unreferenced"} | ${"dependency-diagnostics"}+ ${"/data-studio/library"} | ${"library"}+ ${"/data-studio/library/collections/123"} | ${"library"}+ ${"/data-studio/library/metrics/456"} | ${"library"}+ ${"/data-studio/transforms/runs"} | ${"runs"}+ ${"/data-studio/transforms/runs?page=2"} | ${"runs"}+ ${"/data-studio/transforms"} | ${"transforms"}+ ${"/data-studio/transforms/123"} | ${"transforms"}+ ${"/data-studio/transforms/new/query"} | ${"transforms"}+ ${"/data-studio/data"} | ${"data"}+ ${"/data-studio/data/database/1"} | ${"data"}+ ${"/data-studio"} | ${"data"}`("should return '$expectedTab' for pathname '$pathname'",({ pathname, expectedTab }) => {diff --git a/enterprise/frontend/src/metabase-enterprise/data-studio/app/pages/TasksSectionLayout/TasksSectionLayout.tsx b/enterprise/frontend/src/metabase-enterprise/data-studio/app/pages/TasksSectionLayout/TasksSectionLayout.tsxindex 84a77ea16ae..7bf5e2927eb 100644--- a/enterprise/frontend/src/metabase-enterprise/data-studio/app/pages/TasksSectionLayout/TasksSectionLayout.tsx+++ b/enterprise/frontend/src/metabase-enterprise/data-studio/app/pages/TasksSectionLayout/TasksSectionLayout.tsx@@ -10,6 +10,6 @@ type TasksSectionLayoutProps = {};export function TasksSectionLayout({ children }: TasksSectionLayoutProps) {- usePageTitle(t`Tasks`);+ usePageTitle(t`Dependency diagnostics`);return <SectionLayout>{children}</SectionLayout>;}diff --git a/enterprise/frontend/src/metabase-enterprise/data-studio/routes.tsx b/enterprise/frontend/src/metabase-enterprise/data-studio/routes.tsxindex 7581f6703f8..48e096b93e4 100644--- a/enterprise/frontend/src/metabase-enterprise/data-studio/routes.tsx+++ b/enterprise/frontend/src/metabase-enterprise/data-studio/routes.tsx@@ -58,7 +58,7 @@ export function getDataStudioRoutes({getDataStudioSnippetRoutes()}</Route>{PLUGIN_DEPENDENCIES.isEnabled && (- <Route path="tasks" component={TasksSectionLayout}>+ <Route path="dependency-diagnostics" component={TasksSectionLayout}>{PLUGIN_DEPENDENCIES.getDataStudioTasksRoutes()}</Route>)}diff --git a/enterprise/frontend/src/metabase-enterprise/dependencies/components/DependencyList/ListBody/ListBody.tsx b/enterprise/frontend/src/metabase-enterprise/dependencies/components/DependencyList/ListBody/ListBody.tsxindex ff58c9cbca2..a802242d8d5 100644--- a/enterprise/frontend/src/metabase-enterprise/dependencies/components/DependencyList/ListBody/ListBody.tsx+++ b/enterprise/frontend/src/metabase-enterprise/dependencies/components/DependencyList/ListBody/ListBody.tsx@@ -22,7 +22,11 @@ export const ListBody = memo(function ListBody({onSelect,}: ListBodyProps) {const columns = useMemo(- () => getColumns({ withErrorsColumn, withDependentsCountColumn }),+ () =>+ getColumns({+ withErrorsColumn,+ withDependentsCountColumn,+ }),[withErrorsColumn, withDependentsCountColumn],);diff --git a/enterprise/frontend/src/metabase-enterprise/dependencies/components/DependencyList/ListBody/utils.tsx b/enterprise/frontend/src/metabase-enterprise/dependencies/components/DependencyList/ListBody/utils.tsxindex 7ebb5d68d95..efce4b30de8 100644--- a/enterprise/frontend/src/metabase-enterprise/dependencies/components/DependencyList/ListBody/utils.tsx+++ b/enterprise/frontend/src/metabase-enterprise/dependencies/components/DependencyList/ListBody/utils.tsx@@ -69,7 +69,7 @@ function getNodeErrorsColumn(): TreeTableColumnDef<DependencyNode> {function getNodeDependentsCountColumn(): TreeTableColumnDef<DependencyNode> {return {id: "dependents-count",- header: t`Dependents`,+ header: t`Downstream dependents`,accessorFn: (node) => getNodeDependentsCount(node),cell: ({ row }) => {const node = row.original;diff --git a/enterprise/frontend/src/metabase-enterprise/dependencies/components/DependencyList/ListHeader/ListHeader.tsx b/enterprise/frontend/src/metabase-enterprise/dependencies/components/DependencyList/ListHeader/ListHeader.tsxindex 2721124b9ae..4b0ea1df57a 100644--- a/enterprise/frontend/src/metabase-enterprise/dependencies/components/DependencyList/ListHeader/ListHeader.tsx+++ b/enterprise/frontend/src/metabase-enterprise/dependencies/components/DependencyList/ListHeader/ListHeader.tsx@@ -11,12 +11,12 @@ import {export const ListHeader = memo(function ListHeader() {const tabs: PaneHeaderTab[] = [{- label: t`Broken`,+ label: t`Broken entities`,to: Urls.dataStudioBrokenEntities(),icon: "list",},{- label: t`Unreferenced`,+ label: t`Unreferenced entities`,to: Urls.dataStudioUnreferencedEntities(),icon: "list",},@@ -24,7 +24,14 @@ export const ListHeader = memo(function ListHeader() {return (<Stack gap="md">- <Title order={1} py="sm" fz="sm" lh="1rem" fw="normal">{t`Tasks`}</Title>+ <Title+ order={1}+ py="sm"+ fz="sm"+ lh="1rem"+ fw="normal"+ c="text-secondary"+ >{t`Dependency diagnostics`}</Title><PaneHeaderTabs tabs={tabs} /></Stack>);diff --git a/frontend/src/metabase/lib/urls/data-studio.ts b/frontend/src/metabase/lib/urls/data-studio.tsindex 18c69b237f4..c4ffa0765cd 100644--- a/frontend/src/metabase/lib/urls/data-studio.ts+++ b/frontend/src/metabase/lib/urls/data-studio.ts@@ -309,14 +309,14 @@ export function dataStudioSegmentDependencies(segmentId: SegmentId) {return `${dataStudioSegment(segmentId)}/dependencies`;}-export function dataStudioTasks() {- return `${ROOT_URL}/tasks`;+export function dataStudioDependencyDiagnostics() {+ return `${ROOT_URL}/dependency-diagnostics`;}export function dataStudioBrokenEntities() {- return `${dataStudioTasks()}/broken`;+ return `${dataStudioDependencyDiagnostics()}/broken`;}export function dataStudioUnreferencedEntities() {- return `${dataStudioTasks()}/unreferenced`;+ return `${dataStudioDependencyDiagnostics()}/unreferenced`;}