The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Wait for the expression editor to take focus before pressing Escape (#83165)
Eric Normand2fef5f61f410
diff --git a/e2e/test/scenarios/custom-column/custom-column-2.cy.spec.js b/e2e/test/scenarios/custom-column/custom-column-2.cy.spec.jsindex b82721c8a69..f3fe9c52e6a 100644--- a/e2e/test/scenarios/custom-column/custom-column-2.cy.spec.js+++ b/e2e/test/scenarios/custom-column/custom-column-2.cy.spec.js@@ -398,6 +398,10 @@ describe("scenarios > question > custom column > exiting the editor", () => {});it("should be possible to close the custom expression editor by pressing Escape when it is empty", () => {+ // The editor loads lazily. Escape sent before it takes focus does not reach the popover.+ H.CustomExpressionEditor.get()+ .get(".cm-editor")+ .should("have.class", "cm-focused");cy.realPress("Escape");H.CustomExpressionEditor.get().should("not.exist");});