Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

create new embedding modules - first pr (#77263)

Nicolò Pretto31e79dc02d96
diff --git a/frontend/lint/module-boundaries.mjs b/frontend/lint/module-boundaries.mjs
index 2e7d24f8b24..da67af131d2 100644
--- a/frontend/lint/module-boundaries.mjs
+++ b/frontend/lint/module-boundaries.mjs
@@ -69,6 +69,32 @@ const elements = [
name: "embed",
pattern: "frontend/src/embed/**",
}),
+ // embedding-iframe-sdk, embedding-iframe-sdk-setup and mcp-app must come before
+ // shared/embedding: their patterns are subfolders of
+ // frontend/src/metabase/embedding/, and the first matching element wins.
+ createElement({
+ type: "shared",
+ name: "embedding-iframe-sdk",
+ pattern: "frontend/src/metabase/embedding/embedding-iframe-sdk/**",
+ enforceOutgoing: false,
+ }),
+ createElement({
+ type: "app",
+ name: "embedding-iframe-sdk-setup",
+ pattern: "frontend/src/metabase/embedding/embedding-iframe-sdk-setup/**",
+ }),
+ createElement({
+ type: "app",
+ name: "mcp-app",
+ pattern: "frontend/src/metabase/embedding/mcp/**",
+ }),
+ ...[
+ "frontend/src/metabase/app-embed-mcp.tsx",
+ "frontend/src/metabase/app-embed-mcp-public-path.ts",
+ "frontend/src/metabase/app-embed-mcp-public-path.unit.spec.ts",
+ ].map((pattern) =>
+ createElement({ type: "app", name: "mcp-app", pattern, mode: "full" }),
+ ),
createElement({ type: "shared", name: "embedding", enforceOutgoing: false }),
createElement({
type: "shared",
@@ -87,13 +113,12 @@ const elements = [
pattern: "enterprise/frontend/src/embedding/**",
}),
createElement({
- type: "shared",
+ type: "app",
name: "embedding-sdk-ee",
pattern: "enterprise/frontend/src/embedding-sdk-ee/**",
- enforceOutgoing: false,
}),
createElement({
- type: "shared",
+ type: "app",
name: "embedding-sdk-package",
pattern: "enterprise/frontend/src/embedding-sdk-package/**",
}),
@@ -156,6 +181,38 @@ const elements = [
createElement({ type: "feature", name: "dashboard" }),
createElement({ type: "feature", name: "data-studio" }),
createElement({ type: "feature", name: "documents" }),
+ // EE plugin-bootstrap files that only wire app-tier SDK modules into plugin
+ // slots, so they're app tier, not feature/enterprise. Tagged by which embedding
+ // product they belong to. Must precede the feature/enterprise element below
+ // (first match wins).
+ // TODO: physically move these into the embedding-sdk-ee / embedding-iframe-sdk-ee
+ // folders so module == folder, instead of tagging files in metabase-enterprise.
+ ...[
+ "enterprise/frontend/src/metabase-enterprise/sdk-plugins.ts",
+ "enterprise/frontend/src/metabase-enterprise/whitelabel/sdk-overrides.ts",
+ "enterprise/frontend/src/metabase-enterprise/whitelabel/sdk-overrides.unit.spec.ts",
+ ].map((pattern) =>
+ createElement({
+ type: "app",
+ name: "embedding-sdk-ee",
+ pattern,
+ mode: "full",
+ }),
+ ),
+ ...[
+ "enterprise/frontend/src/metabase-enterprise/embedding_iframe_sdk/auth-manager/AuthManager.ts",
+ "enterprise/frontend/src/metabase-enterprise/embedding_iframe_sdk/handle-link.ts",
+ "enterprise/frontend/src/metabase-enterprise/embedding_iframe_sdk/sdk-iframe-embedding-script-ee-plugins.ts",
+ "enterprise/frontend/src/metabase-enterprise/sdk-iframe-embedding-plugins.ts",
+ "enterprise/frontend/src/metabase-enterprise/sdk-iframe-embedding-script-plugins.ts",
+ ].map((pattern) =>
+ createElement({
+ type: "app",
+ name: "embedding-iframe-sdk-ee",
+ pattern,
+ mode: "full",
+ }),
+ ),
createElement({
type: "feature",
name: "enterprise",
@@ -175,9 +232,6 @@ const elements = [
"frontend/src/metabase/app-embed-sdk.tsx",
"frontend/src/metabase/app-main.js",
"frontend/src/metabase/app-embed.ts",
- "frontend/src/metabase/app-embed-mcp.tsx",
- "frontend/src/metabase/app-embed-mcp-public-path.ts",
- "frontend/src/metabase/app-embed-mcp-public-path.unit.spec.ts",
"frontend/src/metabase/app-public.ts",
"frontend/src/metabase/app-static-viz.ts",
"frontend/src/metabase/app-static-viz-cli.ts",
@@ -196,6 +250,10 @@ const elements = [
"frontend/src/metabase/routes-public.tsx",
"frontend/src/metabase/AppThemeProvider.tsx",
"frontend/src/metabase/AppColorSchemeProvider.tsx",
+ // NewModals is used very high in the hierarchy and imports the EAJS wizard that uses EAJS (app level)
+ "frontend/src/metabase/new/components/NewModals/NewModals.tsx",
+ // Its spec mounts NewModals to assert menu clicks open modals, so the test is app-tier too.
+ "frontend/src/metabase/common/components/NewItemMenu/NewItemMenu.unit.spec.tsx",
// Entry point for the static-viz bundle (server-side chart rendering in
// GraalJS) - like app.js, it composes OSS + EE code for a build artifact.
"frontend/src/metabase/static-viz/index.tsx",
diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/LegacyStaticEmbeddingModal.tsx b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/LegacyStaticEmbeddingModal.tsx
index 6fac9942605..340cfad3b27 100644
--- a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/LegacyStaticEmbeddingModal.tsx
+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/LegacyStaticEmbeddingModal.tsx
@@ -4,17 +4,9 @@ import { LoadingAndErrorWrapper } from "metabase/common/components/LoadingAndErr
import { DashboardSharingEmbeddingModal } from "metabase/embedding/components/DashboardSharingEmbeddingModal";
import { QuestionEmbedWidget } from "metabase/embedding/components/QuestionEmbedWidget";
import { useGetCurrentResource } from "metabase/embedding/embedding-iframe-sdk-setup/hooks";
-import type { SdkIframeEmbedSetupExperience } from "metabase/embedding/embedding-iframe-sdk-setup/types";
import { useOpenEmbedJsWizard } from "metabase/embedding/hooks/use-open-embed-js-wizard";
-import type { SdkIframeEmbedSetupModalInitialState } from "metabase/plugins";
-import type { Card, Dashboard, DashboardId } from "metabase-types/api";
-
-export type LegacyStaticEmbeddingModalProps = {
- experience: SdkIframeEmbedSetupExperience;
- dashboardId?: DashboardId | null;
- questionId?: string | number | null;
- parentInitialState: SdkIframeEmbedSetupModalInitialState;
-};
+import type { LegacyStaticEmbeddingModalProps } from "metabase/plugins";
+import type { Card, Dashboard } from "metabase-types/api";
export type InternalProps = LegacyStaticEmbeddingModalProps & {
onClose: () => void;
diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/types.ts b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/types.ts
index c7c8ddfd5b1..6f209657a7f 100644
--- a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/types.ts
+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/types.ts
@@ -14,12 +14,7 @@ import type {
export type { SdkIframeEmbedSetupTheme } from "metabase-types/api";
-export type SdkIframeEmbedSetupExperience =
- | "dashboard"
- | "chart"
- | "exploration"
- | "browser"
- | "metabot";
+export type { SdkIframeEmbedSetupExperience } from "metabase/plugins/oss/embedding-iframe-sdk-setup";
export type SdkIframeEmbedSetupStep =
| "select-embed-experience"
diff --git a/frontend/src/metabase/new/components/NewModals/NewModals.tsx b/frontend/src/metabase/new/components/NewModals/NewModals.tsx
index bdd183df175..88898a2da9a 100644
--- a/frontend/src/metabase/new/components/NewModals/NewModals.tsx
+++ b/frontend/src/metabase/new/components/NewModals/NewModals.tsx
@@ -9,14 +9,14 @@ import CreateCollectionModal, {
import { useInitialCollectionId } from "metabase/common/collections/hooks";
import { UpgradeModal } from "metabase/common/components/upsells/components/UpgradeModal";
import { STATIC_LEGACY_EMBEDDING_TYPE } from "metabase/embedding/constants";
-import {
- LegacyStaticEmbeddingModal,
- type LegacyStaticEmbeddingModalProps,
-} from "metabase/embedding/embedding-iframe-sdk-setup/components/LegacyStaticEmbeddingModal";
+import { LegacyStaticEmbeddingModal } from "metabase/embedding/embedding-iframe-sdk-setup/components/LegacyStaticEmbeddingModal";
import { SdkIframeEmbedSetupModal } from "metabase/embedding/embedding-iframe-sdk-setup/components/SdkIframeEmbedSetupModal";
import { PaletteShortcutsModal } from "metabase/palette/components/PaletteShortcutsModal/PaletteShortcutsModal";
import { useRegisterShortcut } from "metabase/palette/hooks/useRegisterShortcut";
-import type { SdkIframeEmbedSetupModalProps } from "metabase/plugins";
+import type {
+ LegacyStaticEmbeddingModalProps,
+ SdkIframeEmbedSetupModalProps,
+} from "metabase/plugins";
import { useDispatch, useSelector } from "metabase/redux";
import { closeModal, setOpenModal } from "metabase/redux/ui";
import type { WithRouterProps } from "metabase/router";
diff --git a/frontend/src/metabase/plugins/index.ts b/frontend/src/metabase/plugins/index.ts
index 57bb81a7d9c..0fb2629e41d 100644
--- a/frontend/src/metabase/plugins/index.ts
+++ b/frontend/src/metabase/plugins/index.ts
@@ -78,6 +78,8 @@ export {
PLUGIN_EMBEDDING_IFRAME_SDK_SETUP,
type SdkIframeEmbedSetupModalProps,
type SdkIframeEmbedSetupModalInitialState,
+ type SdkIframeEmbedSetupExperience,
+ type LegacyStaticEmbeddingModalProps,
} from "./oss/embedding-iframe-sdk-setup";
export { PLUGIN_EMBEDDING_SDK } from "./oss/embedding-sdk";
export {
diff --git a/frontend/src/metabase/plugins/oss/embedding-iframe-sdk-setup.ts b/frontend/src/metabase/plugins/oss/embedding-iframe-sdk-setup.ts
index 01617de42a0..de88144b338 100644
--- a/frontend/src/metabase/plugins/oss/embedding-iframe-sdk-setup.ts
+++ b/frontend/src/metabase/plugins/oss/embedding-iframe-sdk-setup.ts
@@ -1,3 +1,5 @@
+import type { DashboardId } from "metabase-types/api";
+
export type SdkIframeEmbedSetupModalProps = {
opened: boolean;
onClose: () => void;
@@ -11,6 +13,20 @@ export type SdkIframeEmbedSetupModalInitialState = {
useExistingUserSession?: boolean;
};
+export type SdkIframeEmbedSetupExperience =
+ | "dashboard"
+ | "chart"
+ | "exploration"
+ | "browser"
+ | "metabot";
+
+export type LegacyStaticEmbeddingModalProps = {
+ experience: SdkIframeEmbedSetupExperience;
+ dashboardId?: DashboardId | null;
+ questionId?: string | number | null;
+ parentInitialState: SdkIframeEmbedSetupModalInitialState;
+};
+
const getDefaultPluginEmbeddingIframeSdkSetup = () => ({
isEnabled: () => false,
});
diff --git a/frontend/src/metabase/redux/store/modal.ts b/frontend/src/metabase/redux/store/modal.ts
index 32196ed6765..05e1021b574 100644
--- a/frontend/src/metabase/redux/store/modal.ts
+++ b/frontend/src/metabase/redux/store/modal.ts
@@ -1,6 +1,8 @@
import type { STATIC_LEGACY_EMBEDDING_TYPE } from "metabase/embedding/constants";
-import type { LegacyStaticEmbeddingModalProps } from "metabase/embedding/embedding-iframe-sdk-setup/components/LegacyStaticEmbeddingModal";
-import type { SdkIframeEmbedSetupModalInitialState } from "metabase/plugins/oss/embedding-iframe-sdk-setup";
+import type {
+ LegacyStaticEmbeddingModalProps,
+ SdkIframeEmbedSetupModalInitialState,
+} from "metabase/plugins/oss/embedding-iframe-sdk-setup";
export type ModalName =
| null