The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Delete skipped expression popover e2e tests (#63732)
Fraser33fe7b3afe3f
diff --git a/e2e/support/helpers/e2e-custom-column-helpers.ts b/e2e/support/helpers/e2e-custom-column-helpers.tsindex ab16d1b8c9a..66431f6ce19 100644--- a/e2e/support/helpers/e2e-custom-column-helpers.ts+++ b/e2e/support/helpers/e2e-custom-column-helpers.ts@@ -71,21 +71,6 @@ export function enterCustomColumnDetails({}}-export function checkExpressionEditorHelperPopoverPosition() {- expressionEditorTextfield().then(($target) => {- const textfieldPosition = $target[0].getBoundingClientRect();-- cy.findByTestId("expression-helper-popover").then(($target) => {- const popoverPosition = $target[0].getBoundingClientRect();-- expect(textfieldPosition.top - popoverPosition.top).to.be.lessThan(- textfieldPosition.height * 2,- );- expect(textfieldPosition.left - popoverPosition.left).to.be.lessThan(10);- });- });-}-export const CustomExpressionEditor = {get() {return cy.findByTestId("custom-expression-query-editor");diff --git a/e2e/test/scenarios/custom-column/custom-column.cy.spec.js b/e2e/test/scenarios/custom-column/custom-column.cy.spec.jsindex 0456febcad6..fa5f7097650 100644--- a/e2e/test/scenarios/custom-column/custom-column.cy.spec.js+++ b/e2e/test/scenarios/custom-column/custom-column.cy.spec.js@@ -843,22 +843,6 @@ describe("scenarios > question > custom column", () => {);});- // TODO: fixme!- it(- "should render custom expression helper near the custom expression field",- { tags: "@skip" },- () => {- H.openOrdersTable({ mode: "notebook" });- cy.findByLabelText("Custom column").click();-- H.popover().within(() => {- H.enterCustomColumnDetails({ formula: "floor" });-- H.checkExpressionEditorHelperPopoverPosition();- });- },- );-it("should allow to use `if` function", () => {H.openProductsTable({ mode: "notebook" });diff --git a/e2e/test/scenarios/filters/filter.cy.spec.js b/e2e/test/scenarios/filters/filter.cy.spec.jsindex 4c178de96dd..4502b43cc00 100644--- a/e2e/test/scenarios/filters/filter.cy.spec.js+++ b/e2e/test/scenarios/filters/filter.cy.spec.js@@ -1028,24 +1028,6 @@ describe("scenarios > question > filter", () => {});});- // TODO: fixme!- it(- "should render custom expression helper near the custom expression field",- { tags: "@skip" },- () => {- H.openReviewsTable({ mode: "notebook" });- H.filter({ mode: "notebook" });-- H.expressionEditorWidget().within(() => {- cy.findByText("Custom Expression").click();-- H.enterCustomColumnDetails({ formula: "floor" });-- H.checkExpressionEditorHelperPopoverPosition();- });- },- );-it("should close the dropdown but not the popover on escape when the combobox is opened", () => {const optionName = "Abbey Satterfield";H.openPeopleTable({ mode: "notebook" });diff --git a/e2e/test/scenarios/question/summarization.cy.spec.js b/e2e/test/scenarios/question/summarization.cy.spec.jsindex a48249ce17a..f5d4f6f2b09 100644--- a/e2e/test/scenarios/question/summarization.cy.spec.js+++ b/e2e/test/scenarios/question/summarization.cy.spec.js@@ -280,24 +280,6 @@ describe("scenarios > question > summarize sidebar", () => {H.popover().contains("199 distinct values");},);-- // TODO: fixme!- it(- "should render custom expression helper near the custom expression field",- { tags: "@skip" },- () => {- H.openReviewsTable({ mode: "notebook" });- H.summarize({ mode: "notebook" });-- H.popover().within(() => {- cy.findByText("Custom Expression").click();-- H.enterCustomColumnDetails({ formula: "floor" });-- H.checkExpressionEditorHelperPopoverPosition();- });- },- );});function removeMetricFromSidebar(metricName) {