Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Keep filters header visible when details view is open (#67246)

Romeo Van Snick34996f11d31c
diff --git a/e2e/test/scenarios/visualizations-tabular/object_detail.cy.spec.js b/e2e/test/scenarios/visualizations-tabular/object_detail.cy.spec.js
index 4243e0ca5e4..46e0262b820 100644
--- a/e2e/test/scenarios/visualizations-tabular/object_detail.cy.spec.js
+++ b/e2e/test/scenarios/visualizations-tabular/object_detail.cy.spec.js
@@ -993,3 +993,36 @@ describe("Object Detail > public", () => {
});
});
});
+
+describe("issue 66957", () => {
+ beforeEach(() => {
+ H.restore();
+ cy.signInAsNormalUser();
+ H.openOrdersTable();
+ });
+
+ it("filter header should not hide when opening object details (metabase#66957)", () => {
+ H.tableInteractive().findByText("Quantity").click();
+ H.popover().findByText("Filter by this column").click();
+ H.popover().within(() => {
+ cy.findByText("2").click();
+ cy.button("Add filter").click();
+ });
+
+ H.openObjectDetail(5);
+
+ H.queryBuilderFiltersPanel()
+ .should("be.visible")
+ .findByText("Quantity is equal to 2")
+ .click();
+
+ H.popover().within(() => {
+ cy.findByText("3").click();
+ cy.button("Update filter").click();
+ });
+
+ H.queryBuilderFiltersPanel()
+ .findByText("Quantity is equal to 2 selections")
+ .should("be.visible");
+ });
+});
diff --git a/frontend/src/metabase/query_builder/components/view/ViewHeader/ViewTitleHeader.tsx b/frontend/src/metabase/query_builder/components/view/ViewHeader/ViewTitleHeader.tsx
index 94a7dc652e8..66f29d05b96 100644
--- a/frontend/src/metabase/query_builder/components/view/ViewHeader/ViewTitleHeader.tsx
+++ b/frontend/src/metabase/query_builder/components/view/ViewHeader/ViewTitleHeader.tsx
@@ -207,7 +207,6 @@ export function ViewTitleHeader({
{QuestionFiltersHeader.shouldRender({
question,
queryBuilderMode,
- isObjectDetail,
}) && (
<QuestionFiltersHeader
expanded={areFiltersExpanded}
diff --git a/frontend/src/metabase/query_builder/components/view/ViewHeader/components/QuestionFiltersHeader/QuestionFiltersHeader.tsx b/frontend/src/metabase/query_builder/components/view/ViewHeader/components/QuestionFiltersHeader/QuestionFiltersHeader.tsx
index 5160bf83619..b00eb28c600 100644
--- a/frontend/src/metabase/query_builder/components/view/ViewHeader/components/QuestionFiltersHeader/QuestionFiltersHeader.tsx
+++ b/frontend/src/metabase/query_builder/components/view/ViewHeader/components/QuestionFiltersHeader/QuestionFiltersHeader.tsx
@@ -30,20 +30,14 @@ export function QuestionFiltersHeader({
type RenderCheckOpts = {
question: Question;
queryBuilderMode: QueryBuilderMode;
- isObjectDetail: boolean;
};
-const shouldRender = ({
- question,
- queryBuilderMode,
- isObjectDetail,
-}: RenderCheckOpts) => {
+const shouldRender = ({ question, queryBuilderMode }: RenderCheckOpts) => {
const { isEditable, isNative } = Lib.queryDisplayInfo(question.query());
return (
queryBuilderMode === "view" &&
!isNative &&
isEditable &&
- !isObjectDetail &&
!question.isArchived()
);
};