The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
refactor: Migrate feedback, components, misc, upsell, illustration & admin color tokens (#76871)
Oleh K3512caf5ee31
diff --git a/.claude/skills/emotion-migrate/SKILL.md b/.claude/skills/emotion-migrate/SKILL.mdindex d41fe96efeb..67b459ec37b 100644--- a/.claude/skills/emotion-migrate/SKILL.md+++ b/.claude/skills/emotion-migrate/SKILL.md@@ -257,7 +257,7 @@ Remove the old styled file entirely. Remove all imports of it from other files.- Text: `"text-primary"`, `"text-secondary"`, `"text-disabled"`- Background: `"background_page-primary"`, `"background_page-secondary"`, `"background_surface-hover"`-- Brand: `"core-brand"`, `"error"`, `"success"`, `"warning"`+- Brand: `"core-brand"`, `"feedback-negative"`, `"feedback-positive"`, `"feedback-warning"`**Typography** (`fz`, `fw`, `lh`, `ta`, `ff`):@@ -283,7 +283,7 @@ Remove the old styled file entirely. Remove all imports of it from other files.- `--mb-color-background_page-primary`, `--mb-color-background_page-secondary`, `--mb-color-background_surface-hover`- `--mb-color-border`, `--mb-color-border-strong`, `--mb-color-border-subtle`- `--mb-color-core-brand`, `--mb-color-core-brand-hover`-- `--mb-color-error`, `--mb-color-success`, `--mb-color-warning`+- `--mb-color-feedback-negative`, `--mb-color-feedback-positive`, `--mb-color-feedback-warning`- `--mb-color-shadow`, `--mb-color-focus`- `--mb-color-accent0` through `--mb-color-accent7`diff --git a/.loki/reference/chrome_laptop_Design_System_Colors_Default.png b/.loki/reference/chrome_laptop_Design_System_Colors_Default.pngindex 8b1fcf30088..7aa82d3a9e1 100644Binary files a/.loki/reference/chrome_laptop_Design_System_Colors_Default.png and b/.loki/reference/chrome_laptop_Design_System_Colors_Default.png differdiff --git a/.loki/reference/chrome_laptop_Patterns_Upsells_Banner_Default.png b/.loki/reference/chrome_laptop_Patterns_Upsells_Banner_Default.pngindex bc68c1a78be..9dcaa739b8b 100644Binary files a/.loki/reference/chrome_laptop_Patterns_Upsells_Banner_Default.png and b/.loki/reference/chrome_laptop_Patterns_Upsells_Banner_Default.png differdiff --git a/.loki/reference/chrome_laptop_Patterns_Upsells_Banner_Dismissible.png b/.loki/reference/chrome_laptop_Patterns_Upsells_Banner_Dismissible.pngindex ebe9733c675..7cb2849398f 100644Binary files a/.loki/reference/chrome_laptop_Patterns_Upsells_Banner_Dismissible.png and b/.loki/reference/chrome_laptop_Patterns_Upsells_Banner_Dismissible.png differdiff --git a/.loki/reference/chrome_laptop_Patterns_Upsells_Banner_Large.png b/.loki/reference/chrome_laptop_Patterns_Upsells_Banner_Large.pngindex 81c1025a5cd..f6e7ba826ba 100644Binary files a/.loki/reference/chrome_laptop_Patterns_Upsells_Banner_Large.png and b/.loki/reference/chrome_laptop_Patterns_Upsells_Banner_Large.png differdiff --git a/.loki/reference/chrome_laptop_Patterns_Upsells_Banner_Secondary.png b/.loki/reference/chrome_laptop_Patterns_Upsells_Banner_Secondary.pngindex 66aa0783cf7..32fdd929217 100644Binary files a/.loki/reference/chrome_laptop_Patterns_Upsells_Banner_Secondary.png and b/.loki/reference/chrome_laptop_Patterns_Upsells_Banner_Secondary.png differdiff --git a/.loki/reference/chrome_laptop_Patterns_Upsells_Banner_With_Internal_Link.png b/.loki/reference/chrome_laptop_Patterns_Upsells_Banner_With_Internal_Link.pngindex a54ee7fcd7c..0ef74580b98 100644Binary files a/.loki/reference/chrome_laptop_Patterns_Upsells_Banner_With_Internal_Link.png and b/.loki/reference/chrome_laptop_Patterns_Upsells_Banner_With_Internal_Link.png differdiff --git a/.loki/reference/chrome_laptop_Patterns_Upsells_Banner_With_On_Click.png b/.loki/reference/chrome_laptop_Patterns_Upsells_Banner_With_On_Click.pngindex bc68c1a78be..9dcaa739b8b 100644Binary files a/.loki/reference/chrome_laptop_Patterns_Upsells_Banner_With_On_Click.png and b/.loki/reference/chrome_laptop_Patterns_Upsells_Banner_With_On_Click.png differdiff --git a/.loki/reference/chrome_laptop_Patterns_Upsells_Card_Full_Width_Variant.png b/.loki/reference/chrome_laptop_Patterns_Upsells_Card_Full_Width_Variant.pngindex a6d3b2b7e65..f77d558af9a 100644Binary files a/.loki/reference/chrome_laptop_Patterns_Upsells_Card_Full_Width_Variant.png and b/.loki/reference/chrome_laptop_Patterns_Upsells_Card_Full_Width_Variant.png differdiff --git a/.loki/reference/chrome_laptop_Patterns_Upsells_Card_Large_Full_Width_Variant.png b/.loki/reference/chrome_laptop_Patterns_Upsells_Card_Large_Full_Width_Variant.pngindex 3daab9ed779..826394d2458 100644Binary files a/.loki/reference/chrome_laptop_Patterns_Upsells_Card_Large_Full_Width_Variant.png and b/.loki/reference/chrome_laptop_Patterns_Upsells_Card_Large_Full_Width_Variant.png differdiff --git a/.loki/reference/chrome_laptop_Patterns_Upsells_Card_Large_Variant.png b/.loki/reference/chrome_laptop_Patterns_Upsells_Card_Large_Variant.pngindex 122c09ee745..e1acdbbf240 100644Binary files a/.loki/reference/chrome_laptop_Patterns_Upsells_Card_Large_Variant.png and b/.loki/reference/chrome_laptop_Patterns_Upsells_Card_Large_Variant.png differdiff --git a/.loki/reference/chrome_laptop_Patterns_Upsells_Card_Max_Width_500_Variant.png b/.loki/reference/chrome_laptop_Patterns_Upsells_Card_Max_Width_500_Variant.pngindex 198f7bbc8be..bd88545e68f 100644Binary files a/.loki/reference/chrome_laptop_Patterns_Upsells_Card_Max_Width_500_Variant.png and b/.loki/reference/chrome_laptop_Patterns_Upsells_Card_Max_Width_500_Variant.png differdiff --git a/.loki/reference/chrome_laptop_Patterns_Upsells_Card_With_Image.png b/.loki/reference/chrome_laptop_Patterns_Upsells_Card_With_Image.pngindex a6d3b2b7e65..f77d558af9a 100644Binary files a/.loki/reference/chrome_laptop_Patterns_Upsells_Card_With_Image.png and b/.loki/reference/chrome_laptop_Patterns_Upsells_Card_With_Image.png differdiff --git a/.loki/reference/chrome_laptop_Patterns_Upsells_Card_With_On_Click.png b/.loki/reference/chrome_laptop_Patterns_Upsells_Card_With_On_Click.pngindex 4bd4100c4c1..383a9746ea0 100644Binary files a/.loki/reference/chrome_laptop_Patterns_Upsells_Card_With_On_Click.png and b/.loki/reference/chrome_laptop_Patterns_Upsells_Card_With_On_Click.png differdiff --git a/.loki/reference/chrome_laptop_Patterns_Upsells_Card_Without_Image.png b/.loki/reference/chrome_laptop_Patterns_Upsells_Card_Without_Image.pngindex 261107ad6dd..f223a195f8f 100644Binary files a/.loki/reference/chrome_laptop_Patterns_Upsells_Card_Without_Image.png and b/.loki/reference/chrome_laptop_Patterns_Upsells_Card_Without_Image.png differdiff --git a/.loki/reference/chrome_laptop_Patterns_Upsells_Pill_Default.png b/.loki/reference/chrome_laptop_Patterns_Upsells_Pill_Default.pngindex 690cc45ae10..e75d1cba6d3 100644Binary files a/.loki/reference/chrome_laptop_Patterns_Upsells_Pill_Default.png and b/.loki/reference/chrome_laptop_Patterns_Upsells_Pill_Default.png differdiff --git a/.loki/reference/chrome_laptop_Patterns_Upsells_Pill_Multiline.png b/.loki/reference/chrome_laptop_Patterns_Upsells_Pill_Multiline.pngindex 328c111f877..eb6e5fec408 100644Binary files a/.loki/reference/chrome_laptop_Patterns_Upsells_Pill_Multiline.png and b/.loki/reference/chrome_laptop_Patterns_Upsells_Pill_Multiline.png differdiff --git a/.loki/reference/chrome_laptop_Patterns_Upsells_Pill_With_On_Click.png b/.loki/reference/chrome_laptop_Patterns_Upsells_Pill_With_On_Click.pngindex 690cc45ae10..e75d1cba6d3 100644Binary files a/.loki/reference/chrome_laptop_Patterns_Upsells_Pill_With_On_Click.png and b/.loki/reference/chrome_laptop_Patterns_Upsells_Pill_With_On_Click.png differdiff --git a/e2e/test/scenarios/actions/actions-in-object-detail-view.cy.spec.js b/e2e/test/scenarios/actions/actions-in-object-detail-view.cy.spec.jsindex f0be2b75d8a..b745925be32 100644--- a/e2e/test/scenarios/actions/actions-in-object-detail-view.cy.spec.js+++ b/e2e/test/scenarios/actions/actions-in-object-detail-view.cy.spec.js@@ -311,7 +311,7 @@ function assertSuccessfullUpdateToast() {H.undoToastList().last().should("be.visible")- .should("have.attr", "color", "success")+ .should("have.attr", "color", "feedback-positive").should("contain.text", "Successfully updated");}@@ -321,7 +321,7 @@ function assertSuccessfullDeleteToast() {H.undoToastList().last().should("be.visible")- .should("have.attr", "color", "success")+ .should("have.attr", "color", "feedback-positive").should("contain.text", "Successfully deleted");}diff --git a/e2e/test/scenarios/sharing/alert/alert.cy.spec.js b/e2e/test/scenarios/sharing/alert/alert.cy.spec.jsindex f34edf43096..a96a6b0d07a 100644--- a/e2e/test/scenarios/sharing/alert/alert.cy.spec.js+++ b/e2e/test/scenarios/sharing/alert/alert.cy.spec.js@@ -227,7 +227,7 @@ describe("scenarios > alert", () => {cy.button("Done").click();});cy.findByTestId("toast-undo").within(() => {- cy.root().should("have.attr", "color", "error");+ cy.root().should("have.attr", "color", "feedback-negative");cy.root().should("have.text", normalUserAlertError);});@@ -240,7 +240,7 @@ describe("scenarios > alert", () => {cy.button("Done").click();});cy.findByTestId("toast-undo").within(() => {- cy.root().should("have.attr", "color", "error");+ cy.root().should("have.attr", "color", "feedback-negative");cy.root().should("have.text", normalUserSubscriptionError);});});diff --git a/enterprise/frontend/src/embedding-sdk-package/components/private/Error/Error.tsx b/enterprise/frontend/src/embedding-sdk-package/components/private/Error/Error.tsxindex e71b8ecbadc..5cb2d824177 100644--- a/enterprise/frontend/src/embedding-sdk-package/components/private/Error/Error.tsx+++ b/enterprise/frontend/src/embedding-sdk-package/components/private/Error/Error.tsx@@ -19,7 +19,7 @@ const DefaultErrorMessage = ({ message, theme }: Props) => {background:theme?.colors?.background ?? colors["background_surface-error"],color: theme?.colors?.["text-primary"] ?? colors["text-primary"],- border: `1px solid ${theme?.colors?.error ?? colors.error}`,+ border: `1px solid ${theme?.colors?.error ?? colors["feedback-negative"]}`,borderRadius: "0.5rem",textAlign: "center",lineHeight: "1.4rem",diff --git a/enterprise/frontend/src/embedding-sdk-package/hooks/public/use-action/use-action.stories.tsx b/enterprise/frontend/src/embedding-sdk-package/hooks/public/use-action/use-action.stories.tsxindex 0524dca48c2..4a075a0a364 100644--- a/enterprise/frontend/src/embedding-sdk-package/hooks/public/use-action/use-action.stories.tsx+++ b/enterprise/frontend/src/embedding-sdk-package/hooks/public/use-action/use-action.stories.tsx@@ -58,7 +58,7 @@ const HookTemplate: StoryFn<{error ? (<Box>- <Text c="error" fw="bold">+ <Text c="feedback-negative" fw="bold">Error</Text><pre style={{ whiteSpace: "pre-wrap", margin: 0 }}>diff --git a/enterprise/frontend/src/metabase-enterprise/ai-controls/pages/MetabotCustomizationPage/MetabotIconField.tsx b/enterprise/frontend/src/metabase-enterprise/ai-controls/pages/MetabotCustomizationPage/MetabotIconField.tsxindex ce8ea00b343..926b010d7da 100644--- a/enterprise/frontend/src/metabase-enterprise/ai-controls/pages/MetabotCustomizationPage/MetabotIconField.tsx+++ b/enterprise/frontend/src/metabase-enterprise/ai-controls/pages/MetabotCustomizationPage/MetabotIconField.tsx@@ -87,7 +87,7 @@ export function MetabotIconField() {{t`Upload a custom icon for the AI agent. For best results, use an SVG or PNG with a transparent background.`}</Text>{iconError && (- <Text fz="sm" c="error" mt="xs">+ <Text fz="sm" c="feedback-negative" mt="xs">{iconError}</Text>)}diff --git a/enterprise/frontend/src/metabase-enterprise/application_permissions/constants.ts b/enterprise/frontend/src/metabase-enterprise/application_permissions/constants.tsindex aaf7a19d7aa..2e7da292fb1 100644--- a/enterprise/frontend/src/metabase-enterprise/application_permissions/constants.ts+++ b/enterprise/frontend/src/metabase-enterprise/application_permissions/constants.ts@@ -6,13 +6,13 @@ export const APPLICATION_PERMISSIONS_OPTIONS = {label: t`Yes`,value: "yes",icon: "check",- iconColor: "success",+ iconColor: "feedback-positive",},no: {// eslint-disable-next-line ttag/no-module-declaration -- see metabase#55045label: t`No`,value: "no",icon: "close",- iconColor: "danger",+ iconColor: "feedback-negative",},};diff --git a/enterprise/frontend/src/metabase-enterprise/audit_app/metabot-analytics/components/ConversationDetailPage/ConversationDetailPage.tsx b/enterprise/frontend/src/metabase-enterprise/audit_app/metabot-analytics/components/ConversationDetailPage/ConversationDetailPage.tsxindex 33079e59372..d45e1d07a12 100644--- a/enterprise/frontend/src/metabase-enterprise/audit_app/metabot-analytics/components/ConversationDetailPage/ConversationDetailPage.tsx+++ b/enterprise/frontend/src/metabase-enterprise/audit_app/metabot-analytics/components/ConversationDetailPage/ConversationDetailPage.tsx@@ -201,7 +201,7 @@ function FeedbackCard({<Badgevariant="light"bg="background_surface-error"- c="error"+ c="feedback-negative"ml="xs">{getIssueTypeLabel(feedback.issue_type)}diff --git a/enterprise/frontend/src/metabase-enterprise/audit_app/metabot-analytics/components/ConversationStatsPage/ConversationStatsPage.tsx b/enterprise/frontend/src/metabase-enterprise/audit_app/metabot-analytics/components/ConversationStatsPage/ConversationStatsPage.tsxindex c898a05c2c6..d185043f0c6 100644--- a/enterprise/frontend/src/metabase-enterprise/audit_app/metabot-analytics/components/ConversationStatsPage/ConversationStatsPage.tsx+++ b/enterprise/frontend/src/metabase-enterprise/audit_app/metabot-analytics/components/ConversationStatsPage/ConversationStatsPage.tsx@@ -408,7 +408,7 @@ export function DataComplexityHeader() {} catch (error) {sendToast({icon: "warning",- toastColor: "error",+ toastColor: "feedback-negative",message: getErrorMessage(error,t`Could not recompute data complexity.`,diff --git a/enterprise/frontend/src/metabase-enterprise/audit_app/metabot-analytics/components/ConversationStatsPage/DataComplexityCards.tsx b/enterprise/frontend/src/metabase-enterprise/audit_app/metabot-analytics/components/ConversationStatsPage/DataComplexityCards.tsxindex 759937abd4a..515bdcc5968 100644--- a/enterprise/frontend/src/metabase-enterprise/audit_app/metabot-analytics/components/ConversationStatsPage/DataComplexityCards.tsx+++ b/enterprise/frontend/src/metabase-enterprise/audit_app/metabot-analytics/components/ConversationStatsPage/DataComplexityCards.tsx@@ -124,7 +124,7 @@ function DataComplexityCard({</Stack>) : (<Stack gap={4} my="sm">- <Text c="error" fw={700}>{t`Score unavailable`}</Text>+ <Text c="feedback-negative" fw={700}>{t`Score unavailable`}</Text><Text c="text-secondary">{t`Open for component details.`}</Text></Stack>)}@@ -306,7 +306,7 @@ function DataComplexityComponentItem({</Text>{match(component).with({ error: P.nonNullable }, ({ error }) => (- <Text c="error" size="sm" role="alert">+ <Text c="feedback-negative" size="sm" role="alert">{error}</Text>))@@ -383,7 +383,7 @@ function ScoreDisplayInline({} & MantineStyleProps) {return match(score).with({ score: P.nullish }, { error: P.nonNullable }, () => (- <Text c="error" fw={700} lh="1rem" ml="auto" {...rest}>+ <Text c="feedback-negative" fw={700} lh="1rem" ml="auto" {...rest}>{withTitle ? t`Complexity score unavailable` : t`Unavailable`}</Text>))diff --git a/enterprise/frontend/src/metabase-enterprise/auth/components/SessionTimeoutSetting/SessionTimeoutSetting.tsx b/enterprise/frontend/src/metabase-enterprise/auth/components/SessionTimeoutSetting/SessionTimeoutSetting.tsxindex 555ea447366..a202ed83c53 100644--- a/enterprise/frontend/src/metabase-enterprise/auth/components/SessionTimeoutSetting/SessionTimeoutSetting.tsx+++ b/enterprise/frontend/src/metabase-enterprise/auth/components/SessionTimeoutSetting/SessionTimeoutSetting.tsx@@ -147,7 +147,7 @@ export const SessionTimeoutSetting = () => {</Flex>)}{error && (- <Text c="error" size="sm">+ <Text c="feedback-negative" size="sm">{error}</Text>)}diff --git a/enterprise/frontend/src/metabase-enterprise/auth/components/SettingsOIDCForm/SettingsOIDCForm.tsx b/enterprise/frontend/src/metabase-enterprise/auth/components/SettingsOIDCForm/SettingsOIDCForm.tsxindex ab8e5665a09..469352b3d22 100644--- a/enterprise/frontend/src/metabase-enterprise/auth/components/SettingsOIDCForm/SettingsOIDCForm.tsx+++ b/enterprise/frontend/src/metabase-enterprise/auth/components/SettingsOIDCForm/SettingsOIDCForm.tsx@@ -488,7 +488,7 @@ export function SettingsOIDCForm() {</Button><Buttonvariant="filled"- color="danger"+ color="feedback-negative"onClick={deleteModal.open}>{t`Delete configuration`}diff --git a/enterprise/frontend/src/metabase-enterprise/caching/components/InvalidateNowButton.tsx b/enterprise/frontend/src/metabase-enterprise/caching/components/InvalidateNowButton.tsxindex ae9dc496b21..4768832c8fc 100644--- a/enterprise/frontend/src/metabase-enterprise/caching/components/InvalidateNowButton.tsx+++ b/enterprise/frontend/src/metabase-enterprise/caching/components/InvalidateNowButton.tsx@@ -77,7 +77,7 @@ const InvalidateNowFormBody = ({}}disabled={wasFormRecentlyPending}variant="subtle"- c="error"+ c="feedback-negative"px="sm"leftSection={<Icon name="trash" />}label={buttonText}@@ -90,7 +90,7 @@ const InvalidateNowFormBody = ({}successLabel={<Group gap="sm" align="center">- <Icon name="check" c="success" />+ <Icon name="check" c="feedback-positive" /><Text>{t`Cache cleared`}</Text></Group>}diff --git a/enterprise/frontend/src/metabase-enterprise/caching/components/ResetButtonContainer.tsx b/enterprise/frontend/src/metabase-enterprise/caching/components/ResetButtonContainer.tsxindex c42a277a132..92a72022a98 100644--- a/enterprise/frontend/src/metabase-enterprise/caching/components/ResetButtonContainer.tsx+++ b/enterprise/frontend/src/metabase-enterprise/caching/components/ResetButtonContainer.tsx@@ -49,12 +49,12 @@ const ResetAllToDefaultButtonFormBody = () => {h="1rem"lh="1"fw="normal"- color="error"+ color="feedback-negative">{t`Reset all to default`}</Text>}activeLabel={<Loader size="xs" />}successLabel={- <Text fw="bold" lh="1" color="success">+ <Text fw="bold" lh="1" color="feedback-positive"><Group gap="xs"><Icon name="check" /> {t`Success`}</Group>diff --git a/enterprise/frontend/src/metabase-enterprise/content_translation/components/ContentTranslationConfiguration/ContentTranslationConfiguration.tsx b/enterprise/frontend/src/metabase-enterprise/content_translation/components/ContentTranslationConfiguration/ContentTranslationConfiguration.tsxindex a8c273db23e..5bf8818c10d 100644--- a/enterprise/frontend/src/metabase-enterprise/content_translation/components/ContentTranslationConfiguration/ContentTranslationConfiguration.tsx+++ b/enterprise/frontend/src/metabase-enterprise/content_translation/components/ContentTranslationConfiguration/ContentTranslationConfiguration.tsx@@ -182,13 +182,13 @@ export const ContentTranslationConfiguration = () => {</FormProvider></Group>{downloadErrorMessage && (- <Text role="alert" c="danger">+ <Text role="alert" c="feedback-negative">{downloadErrorMessage}</Text>)}{!!uploadErrorMessages.length && (<Stack gap="xs">- <Text role="alert" c="error">+ <Text role="alert" c="feedback-negative">{ngettext(msgid`We couldn't upload the file due to this error:`,`We couldn't upload the file due to these errors:`,@@ -197,7 +197,11 @@ export const ContentTranslationConfiguration = () => {</Text><List withPadding>{uploadErrorMessages.map((errorMessage) => (- <List.Item key={errorMessage} role="alert" c="danger">+ <List.Item+ key={errorMessage}+ role="alert"+ c="feedback-negative"+ >{errorMessage}</List.Item>))}@@ -346,13 +350,13 @@ const UploadForm = ({}successLabel={<Group gap="sm" role="alert">- <Icon name="check" c="success" />+ <Icon name="check" c="feedback-positive" /><Text c="inherit">{t`Dictionary uploaded`}</Text></Group>}failedLabel={<Group gap="sm" role="alert">- <Icon name="warning" c="danger" />+ <Icon name="warning" c="feedback-negative" /><Text c="inherit">{t`Could not upload dictionary`}</Text></Group>}diff --git a/enterprise/frontend/src/metabase-enterprise/custom_viz/components/BundleDropzone.module.css b/enterprise/frontend/src/metabase-enterprise/custom_viz/components/BundleDropzone.module.cssindex 32daf5517ee..5712692a769 100644--- a/enterprise/frontend/src/metabase-enterprise/custom_viz/components/BundleDropzone.module.css+++ b/enterprise/frontend/src/metabase-enterprise/custom_viz/components/BundleDropzone.module.css@@ -23,5 +23,5 @@}.dropzone.dropzoneError {- border-color: var(--mb-color-error);+ border-color: var(--mb-color-feedback-negative);}diff --git a/enterprise/frontend/src/metabase-enterprise/custom_viz/components/BundleDropzone.tsx b/enterprise/frontend/src/metabase-enterprise/custom_viz/components/BundleDropzone.tsxindex 6a779733dbb..08c19e03695 100644--- a/enterprise/frontend/src/metabase-enterprise/custom_viz/components/BundleDropzone.tsx+++ b/enterprise/frontend/src/metabase-enterprise/custom_viz/components/BundleDropzone.tsx@@ -80,7 +80,7 @@ export function BundleDropzone({ name = "file" }: { name?: string }) {)}</Box>{(rejectionMessage || showError) && (- <Text c="error" size="sm">+ <Text c="feedback-negative" size="sm">{rejectionMessage ?? error}</Text>)}diff --git a/enterprise/frontend/src/metabase-enterprise/custom_viz/components/CustomVizListItem.tsx b/enterprise/frontend/src/metabase-enterprise/custom_viz/components/CustomVizListItem.tsxindex 808deaff78d..b6387cfb9df 100644--- a/enterprise/frontend/src/metabase-enterprise/custom_viz/components/CustomVizListItem.tsx+++ b/enterprise/frontend/src/metabase-enterprise/custom_viz/components/CustomVizListItem.tsx@@ -83,7 +83,7 @@ export function CustomVizListItem({ plugin, onDelete }: Props) {</Menu.Item><Menu.ItemleftSection={<Icon name="trash" />}- color="error"+ color="feedback-negative"onClick={() => setIsConfirmOpen(true)}>{t`Remove`}diff --git a/enterprise/frontend/src/metabase-enterprise/custom_viz/components/CustomVizPluginSummary.tsx b/enterprise/frontend/src/metabase-enterprise/custom_viz/components/CustomVizPluginSummary.tsxindex 35d7fa85271..018d252df48 100644--- a/enterprise/frontend/src/metabase-enterprise/custom_viz/components/CustomVizPluginSummary.tsx+++ b/enterprise/frontend/src/metabase-enterprise/custom_viz/components/CustomVizPluginSummary.tsx@@ -36,7 +36,7 @@ export function CustomVizPluginSummary({ plugin }: Props) {</Group>)}{plugin.error_message && (- <Text size="sm" c="error">+ <Text size="sm" c="feedback-negative">{plugin.error_message}</Text>)}diff --git a/enterprise/frontend/src/metabase-enterprise/custom_viz/components/EditDevCustomVizForm.tsx b/enterprise/frontend/src/metabase-enterprise/custom_viz/components/EditDevCustomVizForm.tsxindex 2509ed91b8f..af5143fb54a 100644--- a/enterprise/frontend/src/metabase-enterprise/custom_viz/components/EditDevCustomVizForm.tsx+++ b/enterprise/frontend/src/metabase-enterprise/custom_viz/components/EditDevCustomVizForm.tsx@@ -73,12 +73,12 @@ export function EditDevCustomVizForm({ plugin }: Props) {{match(plugin.status).with("active", () => (<Group align="center" flex="0 0 auto" gap="xs">- <Icon c="success" name="check" />- <Text c="success" fw={700}>{t`Enabled`}</Text>+ <Icon c="feedback-positive" name="check" />+ <Text c="feedback-positive" fw={700}>{t`Enabled`}</Text></Group>)).with("error", () => (- <Text c="error" fw={700}>{t`Error`}</Text>+ <Text c="feedback-negative" fw={700}>{t`Error`}</Text>)).with("pending", () => (<Text@@ -98,7 +98,11 @@ export function EditDevCustomVizForm({ plugin }: Props) {/><FormErrorMessage /><Group justify="flex-end">- <Button variant="subtle" color="error" onClick={handleRemove}>+ <Button+ variant="subtle"+ color="feedback-negative"+ onClick={handleRemove}+ >{t`Disable`}</Button><FormSubmitButtondiff --git a/enterprise/frontend/src/metabase-enterprise/data-studio/library/components/LibraryEmptyState/LibraryEmptyState.tsx b/enterprise/frontend/src/metabase-enterprise/data-studio/library/components/LibraryEmptyState/LibraryEmptyState.tsxindex 1f99acac4c3..ec4ad6599c6 100644--- a/enterprise/frontend/src/metabase-enterprise/data-studio/library/components/LibraryEmptyState/LibraryEmptyState.tsx+++ b/enterprise/frontend/src/metabase-enterprise/data-studio/library/components/LibraryEmptyState/LibraryEmptyState.tsx@@ -56,7 +56,7 @@ export function LibraryEmptyState() {loading={isLoading}>{t`Create my Library`}</Button></Group>- {error && <Text c="error">{error}</Text>}+ {error && <Text c="feedback-negative">{error}</Text>}</Stack></Stack><SimpleGrid cols={2} spacing="sm">diff --git a/enterprise/frontend/src/metabase-enterprise/data-studio/library/components/UnpublishTablesModal/UnpublishTablesModal.tsx b/enterprise/frontend/src/metabase-enterprise/data-studio/library/components/UnpublishTablesModal/UnpublishTablesModal.tsxindex 303fd99d69a..cc6b44c9743 100644--- a/enterprise/frontend/src/metabase-enterprise/data-studio/library/components/UnpublishTablesModal/UnpublishTablesModal.tsx+++ b/enterprise/frontend/src/metabase-enterprise/data-studio/library/components/UnpublishTablesModal/UnpublishTablesModal.tsx@@ -140,7 +140,11 @@ function ModalBody({</Stack><Group mt="xl" gap="sm" wrap="nowrap" justify="flex-end"><Button variant="subtle" onClick={onClose}>{t`Cancel`}</Button>- <Button onClick={handleSubmit} variant="filled" color="error">+ <Button+ onClick={handleSubmit}+ variant="filled"+ color="feedback-negative"+ >{getSubmitButtonLabel(selected_table, published_downstream_tables)}</Button></Group>diff --git a/enterprise/frontend/src/metabase-enterprise/data-studio/library/snippets/components/SnippetMoreMenu/SnippetModal/ArchiveSnippetModal.tsx b/enterprise/frontend/src/metabase-enterprise/data-studio/library/snippets/components/SnippetMoreMenu/SnippetModal/ArchiveSnippetModal.tsxindex 021c872fe3a..3fd17338160 100644--- a/enterprise/frontend/src/metabase-enterprise/data-studio/library/snippets/components/SnippetMoreMenu/SnippetModal/ArchiveSnippetModal.tsx+++ b/enterprise/frontend/src/metabase-enterprise/data-studio/library/snippets/components/SnippetMoreMenu/SnippetModal/ArchiveSnippetModal.tsx@@ -61,7 +61,7 @@ export function ArchiveSnippetModal(props: ArchiveSnippetModalProps) {<Group gap="sm" justify="flex-end"><Button onClick={onClose}>{t`Cancel`}</Button><Button- color="error"+ color="feedback-negative"loading={isLoading}onClick={handleArchive}variant="filled"diff --git a/enterprise/frontend/src/metabase-enterprise/database_replication/DatabaseReplicationForm.tsx b/enterprise/frontend/src/metabase-enterprise/database_replication/DatabaseReplicationForm.tsxindex ede4fad170a..f394ad4fb59 100644--- a/enterprise/frontend/src/metabase-enterprise/database_replication/DatabaseReplicationForm.tsx+++ b/enterprise/frontend/src/metabase-enterprise/database_replication/DatabaseReplicationForm.tsx@@ -194,7 +194,7 @@ export const DatabaseReplicationForm = ({}/>{previewResponse?.errors?.invalidSchemaFiltersPattern && (- <Text c="error" fz="sm" mt="xs">+ <Text c="feedback-negative" fz="sm" mt="xs">{t`Invalid schema filters pattern`}</Text>)}diff --git a/enterprise/frontend/src/metabase-enterprise/database_replication/DatabaseReplicationSettingUp.tsx b/enterprise/frontend/src/metabase-enterprise/database_replication/DatabaseReplicationSettingUp.tsxindex 052fc664eff..4cb1219bb63 100644--- a/enterprise/frontend/src/metabase-enterprise/database_replication/DatabaseReplicationSettingUp.tsx+++ b/enterprise/frontend/src/metabase-enterprise/database_replication/DatabaseReplicationSettingUp.tsx@@ -16,13 +16,13 @@ export const DatabaseReplicationSettingUp = () => (pos="absolute"right={0}wrap="nowrap"- bg="white"+ bg="core-white"fz={0}p="sm"ta="center"style={{borderRadius: "100%",- boxShadow: `0 1px 6px 0 var(--mb-color-shadow)`,+ boxShadow: `0 1px 6px 0 var(--mb-color-shadow-default)`,}}><Loader size="xs" ml={1} mt={1} />diff --git a/enterprise/frontend/src/metabase-enterprise/database_routing/DatabaseRoutingSection/DatabaseRoutingSection.tsx b/enterprise/frontend/src/metabase-enterprise/database_routing/DatabaseRoutingSection/DatabaseRoutingSection.tsxindex 666a97f0ea3..1d2f1df38ab 100644--- a/enterprise/frontend/src/metabase-enterprise/database_routing/DatabaseRoutingSection/DatabaseRoutingSection.tsx+++ b/enterprise/frontend/src/metabase-enterprise/database_routing/DatabaseRoutingSection/DatabaseRoutingSection.tsx@@ -139,7 +139,7 @@ export const DatabaseRoutingSection = ({<Text lh="lg">{t`Enable database routing`}</Text></Label>{error ? (- <Error role="alert" color="error">+ <Error role="alert" color="feedback-negative">{getErrorMessage(error)}</Error>) : null}@@ -196,7 +196,7 @@ export const DatabaseRoutingSection = ({<Box><Label htmlFor="db-routing-user-attribute">{t`User attribute to match destination database slug`}{" "}- <Text component="span" c="error">+ <Text component="span" c="feedback-negative">*</Text></Label>diff --git a/enterprise/frontend/src/metabase-enterprise/dependencies/components/DependencyGraph/GraphNode/GraphNode.module.css b/enterprise/frontend/src/metabase-enterprise/dependencies/components/DependencyGraph/GraphNode/GraphNode.module.cssindex 2c205bfd2a3..31402ec1ea1 100644--- a/enterprise/frontend/src/metabase-enterprise/dependencies/components/DependencyGraph/GraphNode/GraphNode.module.css+++ b/enterprise/frontend/src/metabase-enterprise/dependencies/components/DependencyGraph/GraphNode/GraphNode.module.css@@ -23,7 +23,7 @@&:hover,&.selected {- color: var(--mb-color-white);+ color: var(--mb-color-core-white);background-color: var(--mb-color-core-brand);}}diff --git a/enterprise/frontend/src/metabase-enterprise/dependencies/utils.ts b/enterprise/frontend/src/metabase-enterprise/dependencies/utils.tsindex 66f5af77b1b..760eccce6ac 100644--- a/enterprise/frontend/src/metabase-enterprise/dependencies/utils.ts+++ b/enterprise/frontend/src/metabase-enterprise/dependencies/utils.ts@@ -550,7 +550,7 @@ export function getDependencyGroupTypeInfo(case "table":return { label: t`Table`, color: "core-brand" };case "transform":- return { label: t`Transform`, color: "warning" };+ return { label: t`Transform`, color: "feedback-warning" };case "snippet":return { label: t`Snippet`, color: "text-secondary" };case "dashboard":@@ -558,7 +558,10 @@ export function getDependencyGroupTypeInfo(case "document":return { label: t`Document`, color: "text-secondary" };case "sandbox":- return { label: t`Row and column security rule`, color: "error" };+ return {+ label: t`Row and column security rule`,+ color: "feedback-negative",+ };case "segment":return { label: t`Segment`, color: "accent2" };case "measure":diff --git a/enterprise/frontend/src/metabase-enterprise/dependencies/utils.unit.spec.ts b/enterprise/frontend/src/metabase-enterprise/dependencies/utils.unit.spec.tsindex 7ea9a2f0833..09f11884b62 100644--- a/enterprise/frontend/src/metabase-enterprise/dependencies/utils.unit.spec.ts+++ b/enterprise/frontend/src/metabase-enterprise/dependencies/utils.unit.spec.ts@@ -645,7 +645,10 @@ describe("getDependencyGroupTypeInfo", () => {},{groupType: "sandbox",- expected: { label: "Row and column security rule", color: "error" },+ expected: {+ label: "Row and column security rule",+ color: "feedback-negative",+ },},])("should get type info for $groupType", ({ groupType, expected }) => {expect(getDependencyGroupTypeInfo(groupType)).toEqual(expected);diff --git a/enterprise/frontend/src/metabase-enterprise/feature_level_permissions/permission-management/data-model-permission.ts b/enterprise/frontend/src/metabase-enterprise/feature_level_permissions/permission-management/data-model-permission.tsindex 3c7f15aad77..8e63f44ac00 100644--- a/enterprise/frontend/src/metabase-enterprise/feature_level_permissions/permission-management/data-model-permission.ts+++ b/enterprise/frontend/src/metabase-enterprise/feature_level_permissions/permission-management/data-model-permission.ts@@ -35,21 +35,21 @@ export const DATA_MODEL_PERMISSION_OPTIONS: Record<string, PermissionOption> = {label: t`No`,value: DataPermissionValue.NONE,icon: "close",- iconColor: "danger",+ iconColor: "feedback-negative",},edit: {// eslint-disable-next-line ttag/no-module-declaration -- see metabase#55045label: t`Yes`,value: DataPermissionValue.ALL,icon: "check",- iconColor: "success",+ iconColor: "feedback-positive",},controlled: {// eslint-disable-next-line ttag/no-module-declaration -- see metabase#55045label: t`Granular`,value: DataPermissionValue.CONTROLLED,icon: "permissions_limited",- iconColor: "warning",+ iconColor: "feedback-warning",},};diff --git a/enterprise/frontend/src/metabase-enterprise/feature_level_permissions/permission-management/details-permission.ts b/enterprise/frontend/src/metabase-enterprise/feature_level_permissions/permission-management/details-permission.tsindex f27d78a2351..5ce0d34fe30 100644--- a/enterprise/frontend/src/metabase-enterprise/feature_level_permissions/permission-management/details-permission.ts+++ b/enterprise/frontend/src/metabase-enterprise/feature_level_permissions/permission-management/details-permission.ts@@ -26,14 +26,14 @@ export const DETAILS_PERMISSION_OPTIONS: Record<string, PermissionOption> = {label: t`No`,value: DataPermissionValue.NO,icon: "close",- iconColor: "danger",+ iconColor: "feedback-negative",},yes: {// eslint-disable-next-line ttag/no-module-declaration -- see metabase#55045label: t`Yes`,value: DataPermissionValue.YES,icon: "check",- iconColor: "success",+ iconColor: "feedback-positive",},};diff --git a/enterprise/frontend/src/metabase-enterprise/feature_level_permissions/permission-management/download-permission.ts b/enterprise/frontend/src/metabase-enterprise/feature_level_permissions/permission-management/download-permission.tsindex 33df3ab4d05..adfec980162 100644--- a/enterprise/frontend/src/metabase-enterprise/feature_level_permissions/permission-management/download-permission.ts+++ b/enterprise/frontend/src/metabase-enterprise/feature_level_permissions/permission-management/download-permission.ts@@ -46,7 +46,7 @@ export const DOWNLOAD_PERMISSION_OPTIONS: Record<string, PermissionOption> = {label: t`No`,value: DataPermissionValue.NONE,icon: "close",- iconColor: "danger",+ iconColor: "feedback-negative",},limited: {// eslint-disable-next-line ttag/no-module-declaration -- see metabase#55045@@ -67,7 +67,7 @@ export const DOWNLOAD_PERMISSION_OPTIONS: Record<string, PermissionOption> = {label: t`Granular`,value: DataPermissionValue.CONTROLLED,icon: "permissions_limited",- iconColor: "warning",+ iconColor: "feedback-warning",},};diff --git a/enterprise/frontend/src/metabase-enterprise/feature_level_permissions/permission-management/transforms-permission.ts b/enterprise/frontend/src/metabase-enterprise/feature_level_permissions/permission-management/transforms-permission.tsindex 9b1c7550b33..52e55951fbc 100644--- a/enterprise/frontend/src/metabase-enterprise/feature_level_permissions/permission-management/transforms-permission.ts+++ b/enterprise/frontend/src/metabase-enterprise/feature_level_permissions/permission-management/transforms-permission.ts@@ -28,7 +28,7 @@ export const TRANSFORMS_PERMISSION_OPTIONS: Record<string, PermissionOption> = {},value: DataPermissionValue.NO,icon: "close",- iconColor: "danger",+ iconColor: "feedback-negative",},yes: {get label() {@@ -36,7 +36,7 @@ export const TRANSFORMS_PERMISSION_OPTIONS: Record<string, PermissionOption> = {},value: DataPermissionValue.YES,icon: "check",- iconColor: "success",+ iconColor: "feedback-positive",},};diff --git a/enterprise/frontend/src/metabase-enterprise/google_drive/GdriveAddDataPanel.tsx b/enterprise/frontend/src/metabase-enterprise/google_drive/GdriveAddDataPanel.tsxindex a29f3eb2ac0..64224379266 100644--- a/enterprise/frontend/src/metabase-enterprise/google_drive/GdriveAddDataPanel.tsx+++ b/enterprise/frontend/src/metabase-enterprise/google_drive/GdriveAddDataPanel.tsx@@ -83,7 +83,7 @@ const ConnectionDetails = ({<Stack gap="sm" mt="sm"><Buttonvariant="filled"- color="danger"+ color="feedback-negative"loading={isDeleteInProgress}onClick={onDelete}w={INNER_WIDTH}@@ -100,7 +100,7 @@ const ConnectionDetails = ({</Button></Stack>{deleteError && (- <Text fz="sm" c="danger">+ <Text fz="sm" c="feedback-negative">{deleteError}</Text>)}@@ -294,7 +294,7 @@ const ErrorAlert = ({return (<Alert- icon={<Icon name="warning" c="danger" />}+ icon={<Icon name="warning" c="feedback-negative" />}variant="outline"title={t`Couldn't sync Google Sheets`}w="100%"diff --git a/enterprise/frontend/src/metabase-enterprise/google_drive/GdriveConnectionModal.tsx b/enterprise/frontend/src/metabase-enterprise/google_drive/GdriveConnectionModal.tsxindex 1fc58f79403..e5758fb7e85 100644--- a/enterprise/frontend/src/metabase-enterprise/google_drive/GdriveConnectionModal.tsx+++ b/enterprise/frontend/src/metabase-enterprise/google_drive/GdriveConnectionModal.tsx@@ -199,7 +199,7 @@ function GoogleSheetsConnectModal({</Text></Box><Flex justify="space-between" align="center" mt="sm" gap="md">- <Text c="error" lh="1.2rem">+ <Text c="feedback-negative" lh="1.2rem">{errorMessage}</Text><Button@@ -244,7 +244,7 @@ function GoogleSheetsDisconnectModal({{bodyCopy}</Text><Flex w="100%" gap="sm" justify="space-between">- <Text c="error" ta="start">+ <Text c="feedback-negative" ta="start">{errorMessage}</Text><Flex justify="flex-end" gap="md">@@ -257,7 +257,7 @@ function GoogleSheetsDisconnectModal({</Button><Buttonvariant="filled"- color="danger"+ color="feedback-negative"loading={isDeletingFolderLink}onClick={onDelete}>diff --git a/enterprise/frontend/src/metabase-enterprise/google_drive/GdriveErrorMenuItem.tsx b/enterprise/frontend/src/metabase-enterprise/google_drive/GdriveErrorMenuItem.tsxindex 5028223bf9d..3b1f2128483 100644--- a/enterprise/frontend/src/metabase-enterprise/google_drive/GdriveErrorMenuItem.tsx+++ b/enterprise/frontend/src/metabase-enterprise/google_drive/GdriveErrorMenuItem.tsx@@ -12,7 +12,7 @@ export function GdriveErrorMenuItem({ error }: { error: any }) {<><Menu.Label><Flex>- <Icon name="warning" c="error" mt="xs" mr="sm" />+ <Icon name="warning" c="feedback-negative" mt="xs" mr="sm" /><Box><Text fw="bold">{t`Couldn't sync Google Sheets`}</Text><Text size="sm" c="text-secondary" maw="16rem">diff --git a/enterprise/frontend/src/metabase-enterprise/google_drive/disconnect.svg b/enterprise/frontend/src/metabase-enterprise/google_drive/disconnect.svgindex ef73185ed35..2236c753fd3 100644--- a/enterprise/frontend/src/metabase-enterprise/google_drive/disconnect.svg+++ b/enterprise/frontend/src/metabase-enterprise/google_drive/disconnect.svg@@ -4,5 +4,5 @@<path d="M35.5504 46.1558C35.8961 44.8363 37.0884 43.916 38.4525 43.916H68.4087C69.7191 43.916 70.6754 45.1552 70.3434 46.4228L66.4496 61.2882C66.1039 62.6078 64.9116 63.5281 63.5475 63.5281H34.887C32.9214 63.5281 31.4869 61.6694 31.9849 59.7679L35.5504 46.1558Z" fill="white"/><path fill-rule="evenodd" clip-rule="evenodd" d="M34.9458 45.9975C35.3635 44.403 36.8042 43.291 38.4525 43.291H68.4086C70.1285 43.291 71.3838 44.9174 70.948 46.5812L67.0541 61.4466C66.6365 63.0411 65.1957 64.1531 63.5475 64.1531H34.887C32.5119 64.1531 30.7785 61.9071 31.3803 59.6095L34.9458 45.9975ZM38.4525 44.541C37.3726 44.541 36.4286 45.2696 36.155 46.3142L32.5895 59.9263C32.1952 61.4316 33.3309 62.9031 34.887 62.9031H63.5475C64.6274 62.9031 65.5713 62.1745 65.8449 61.1299L69.7388 46.2644C69.967 45.3929 69.3095 44.541 68.4086 44.541H38.4525Z" fill="#92999E"/><circle cx="66" cy="60" r="9" fill="white" stroke="white" stroke-width="2"/>-<path fill-rule="evenodd" clip-rule="evenodd" d="M72 60C72 63.3137 69.3137 66 66 66C64.7042 66 63.5044 65.5892 62.5236 64.8908L70.8908 56.5236C71.5892 57.5044 72 58.7042 72 60ZM61.1093 63.4766L69.4766 55.1093C68.4958 54.4108 67.2959 54 66 54C62.6863 54 60 56.6863 60 60C60 61.2959 60.4108 62.4958 61.1093 63.4766ZM74 60C74 64.4183 70.4183 68 66 68C61.5817 68 58 64.4183 58 60C58 55.5817 61.5817 52 66 52C70.4183 52 74 55.5817 74 60Z" fill="var(--mb-color-error)"/>+<path fill-rule="evenodd" clip-rule="evenodd" d="M72 60C72 63.3137 69.3137 66 66 66C64.7042 66 63.5044 65.5892 62.5236 64.8908L70.8908 56.5236C71.5892 57.5044 72 58.7042 72 60ZM61.1093 63.4766L69.4766 55.1093C68.4958 54.4108 67.2959 54 66 54C62.6863 54 60 56.6863 60 60C60 61.2959 60.4108 62.4958 61.1093 63.4766ZM74 60C74 64.4183 70.4183 68 66 68C61.5817 68 58 64.4183 58 60C58 55.5817 61.5817 52 66 52C70.4183 52 74 55.5817 74 60Z" fill="var(--mb-color-feedback-negative)"/></svg>diff --git a/enterprise/frontend/src/metabase-enterprise/metabot/components/MetabotAdmin/MetabaseAIProviderSetup.tsx b/enterprise/frontend/src/metabase-enterprise/metabot/components/MetabotAdmin/MetabaseAIProviderSetup.tsxindex d74ebaa3eb0..540cfaaeb8b 100644--- a/enterprise/frontend/src/metabase-enterprise/metabot/components/MetabotAdmin/MetabaseAIProviderSetup.tsx+++ b/enterprise/frontend/src/metabase-enterprise/metabot/components/MetabotAdmin/MetabaseAIProviderSetup.tsx@@ -272,19 +272,19 @@ export function MetabaseAIProviderSetup({)}{metabaseManagedAiPurchaseError && (- <Text size="sm" c="error">+ <Text size="sm" c="feedback-negative">{metabaseManagedAiPurchaseError}</Text>)}{updateMetabotSettingsError && (- <Text size="sm" c="error">+ <Text size="sm" c="feedback-negative">{updateMetabotSettingsError}</Text>)}{removeMetabaseManagedAiError && (- <Text size="sm" c="error">+ <Text size="sm" c="feedback-negative">{removeMetabaseManagedAiError}</Text>)}diff --git a/enterprise/frontend/src/metabase-enterprise/metabot/components/MetabotAdmin/MetabotSettingUpModal.tsx b/enterprise/frontend/src/metabase-enterprise/metabot/components/MetabotAdmin/MetabotSettingUpModal.tsxindex 5cf47ed2cd5..1363e2f2cb4 100644--- a/enterprise/frontend/src/metabase-enterprise/metabot/components/MetabotAdmin/MetabotSettingUpModal.tsx+++ b/enterprise/frontend/src/metabase-enterprise/metabot/components/MetabotAdmin/MetabotSettingUpModal.tsx@@ -57,13 +57,13 @@ export function MetabotSettingUpModal({pos="absolute"right={0}wrap="nowrap"- bg="white"+ bg="core-white"fz={0}p="sm"ta="center"style={{borderRadius: "100%",- boxShadow: `0 1px 6px 0 var(--mb-color-shadow)`,+ boxShadow: `0 1px 6px 0 var(--mb-color-shadow-default)`,}}><Loader size="xs" ml={1} mt={1} />diff --git a/enterprise/frontend/src/metabase-enterprise/monitor/dependency-diagnostics/components/DiagnosticsSidebar/BrokenDependentsSection/BrokenDependentsSection.tsx b/enterprise/frontend/src/metabase-enterprise/monitor/dependency-diagnostics/components/DiagnosticsSidebar/BrokenDependentsSection/BrokenDependentsSection.tsxindex b57f0edaa0c..8a4e7aa5d58 100644--- a/enterprise/frontend/src/metabase-enterprise/monitor/dependency-diagnostics/components/DiagnosticsSidebar/BrokenDependentsSection/BrokenDependentsSection.tsx+++ b/enterprise/frontend/src/metabase-enterprise/monitor/dependency-diagnostics/components/DiagnosticsSidebar/BrokenDependentsSection/BrokenDependentsSection.tsx@@ -71,7 +71,7 @@ export function BrokenDependentsSection({<Stack role="region" aria-label={getDependentErrorNodesLabel()}><Group justify="space-between" wrap="nowrap"><Group gap="sm" wrap="nowrap">- <Badge variant="filled" bg="error">+ <Badge variant="filled" bg="feedback-negative">{count}</Badge><Title order={5}>diff --git a/enterprise/frontend/src/metabase-enterprise/monitor/dependency-diagnostics/components/DiagnosticsSidebar/ErrorsSection/ErrorsSection.tsx b/enterprise/frontend/src/metabase-enterprise/monitor/dependency-diagnostics/components/DiagnosticsSidebar/ErrorsSection/ErrorsSection.tsxindex f78074a043a..2f2fe4b1be7 100644--- a/enterprise/frontend/src/metabase-enterprise/monitor/dependency-diagnostics/components/DiagnosticsSidebar/ErrorsSection/ErrorsSection.tsx+++ b/enterprise/frontend/src/metabase-enterprise/monitor/dependency-diagnostics/components/DiagnosticsSidebar/ErrorsSection/ErrorsSection.tsx@@ -72,7 +72,7 @@ function ErrorList({ title, items, "aria-label": ariaLabel }: ErrorListProps) {return (<Stack role="region" aria-label={ariaLabel}><Group gap="sm" wrap="nowrap">- <Badge variant="filled" bg="error">+ <Badge variant="filled" bg="feedback-negative">{items.length}</Badge><Title order={5}>{title}</Title>diff --git a/enterprise/frontend/src/metabase-enterprise/remote_sync/components/ChangesLists/AllChangesView.tsx b/enterprise/frontend/src/metabase-enterprise/remote_sync/components/ChangesLists/AllChangesView.tsxindex 861cd8a7810..53c54fb6a61 100644--- a/enterprise/frontend/src/metabase-enterprise/remote_sync/components/ChangesLists/AllChangesView.tsx+++ b/enterprise/frontend/src/metabase-enterprise/remote_sync/components/ChangesLists/AllChangesView.tsx@@ -224,7 +224,7 @@ export const AllChangesView = ({ entities, title }: AllChangesViewProps) => {</Paper>{hasRemovals && (<Text- c="error"+ c="feedback-negative"fz="sm"lh="sm"mt="sm"diff --git a/enterprise/frontend/src/metabase-enterprise/remote_sync/components/CollectionSyncList/CollectionSyncList.tsx b/enterprise/frontend/src/metabase-enterprise/remote_sync/components/CollectionSyncList/CollectionSyncList.tsxindex ab7b6801b12..d507c788c11 100644--- a/enterprise/frontend/src/metabase-enterprise/remote_sync/components/CollectionSyncList/CollectionSyncList.tsx+++ b/enterprise/frontend/src/metabase-enterprise/remote_sync/components/CollectionSyncList/CollectionSyncList.tsx@@ -114,7 +114,7 @@ export const CollectionSyncList = ({}if (error) {- return <Text c="error">{error}</Text>;+ return <Text c="feedback-negative">{error}</Text>;}if (!syncRows.length) {diff --git a/enterprise/frontend/src/metabase-enterprise/remote_sync/components/GitSyncControls/BranchDropdown.tsx b/enterprise/frontend/src/metabase-enterprise/remote_sync/components/GitSyncControls/BranchDropdown.tsxindex 5edb1398f11..1b4fdde48cc 100644--- a/enterprise/frontend/src/metabase-enterprise/remote_sync/components/GitSyncControls/BranchDropdown.tsx+++ b/enterprise/frontend/src/metabase-enterprise/remote_sync/components/GitSyncControls/BranchDropdown.tsx@@ -123,7 +123,7 @@ export const BranchDropdown = ({</Flex>) : branchesError ? (<Box p="md">- <Text size="sm" c="error" ta="center">+ <Text size="sm" c="feedback-negative" ta="center">{t`Failed to load branches — check your authentication token`}</Text></Box>diff --git a/enterprise/frontend/src/metabase-enterprise/remote_sync/components/GitSyncControls/GitSyncControls.tsx b/enterprise/frontend/src/metabase-enterprise/remote_sync/components/GitSyncControls/GitSyncControls.tsxindex 2d7db588661..5e11cc9e7b3 100644--- a/enterprise/frontend/src/metabase-enterprise/remote_sync/components/GitSyncControls/GitSyncControls.tsx+++ b/enterprise/frontend/src/metabase-enterprise/remote_sync/components/GitSyncControls/GitSyncControls.tsx@@ -180,7 +180,7 @@ export const GitSyncControls = () => {}sendToast({icon: "warning",- toastColor: "error",+ toastColor: "feedback-negative",message: t`Sorry, we were unable to switch branches.`,});}diff --git a/enterprise/frontend/src/metabase-enterprise/remote_sync/components/GitSyncControls/GitSyncOptionsDropdown.tsx b/enterprise/frontend/src/metabase-enterprise/remote_sync/components/GitSyncControls/GitSyncOptionsDropdown.tsxindex f909ef23da6..ff232e01704 100644--- a/enterprise/frontend/src/metabase-enterprise/remote_sync/components/GitSyncControls/GitSyncOptionsDropdown.tsx+++ b/enterprise/frontend/src/metabase-enterprise/remote_sync/components/GitSyncControls/GitSyncOptionsDropdown.tsx@@ -36,7 +36,7 @@ export const GitSyncOptionsDropdown = ({return (<Combobox.Dropdown p={0}><Box p="md">- <Text size="sm" c="error" ta="center">+ <Text size="sm" c="feedback-negative" ta="center">{t`Failed to check for changes — check your authentication token`}</Text></Box>diff --git a/enterprise/frontend/src/metabase-enterprise/remote_sync/components/RemoteSyncAdminSettings/RemoteSyncSettingsForm.tsx b/enterprise/frontend/src/metabase-enterprise/remote_sync/components/RemoteSyncAdminSettings/RemoteSyncSettingsForm.tsxindex 5dae4a0f0c7..7e895d8df10 100644--- a/enterprise/frontend/src/metabase-enterprise/remote_sync/components/RemoteSyncAdminSettings/RemoteSyncSettingsForm.tsx+++ b/enterprise/frontend/src/metabase-enterprise/remote_sync/components/RemoteSyncAdminSettings/RemoteSyncSettingsForm.tsx@@ -296,7 +296,7 @@ export const RemoteSyncSettingsForm = (props: RemoteSyncSettingsFormProps) => {confirmButtonText: t`Continue`,confirmButtonProps: {variant: "filled",- color: "danger",+ color: "feedback-negative",},onConfirm: async () => {if (pendingConfirmationSettingsRef.current) {@@ -332,7 +332,7 @@ export const RemoteSyncSettingsForm = (props: RemoteSyncSettingsFormProps) => {confirmButtonText: t`Disable`,confirmButtonProps: {variant: "filled",- color: "danger",+ color: "feedback-negative",},onConfirm: async () => {try {@@ -555,7 +555,7 @@ export const RemoteSyncSettingsForm = (props: RemoteSyncSettingsFormProps) => {{isRemoteSyncEnabled &&!settingDetails?.[REMOTE_SYNC_KEY]?.is_env_setting && (<Button- c="error"+ c="feedback-negative"variant="subtle"size="md"w="12rem"diff --git a/enterprise/frontend/src/metabase-enterprise/remote_sync/components/SyncConflictModal/ForcePushWarning.tsx b/enterprise/frontend/src/metabase-enterprise/remote_sync/components/SyncConflictModal/ForcePushWarning.tsxindex 7177ca386ce..c781b0a74c7 100644--- a/enterprise/frontend/src/metabase-enterprise/remote_sync/components/SyncConflictModal/ForcePushWarning.tsx+++ b/enterprise/frontend/src/metabase-enterprise/remote_sync/components/SyncConflictModal/ForcePushWarning.tsx@@ -66,7 +66,7 @@ export const ForcePushWarning = ({style={{ borderRadius: "var(--mantine-radius-md)" }}><Group gap="sm" align="flex-start" wrap="nowrap">- <Icon name="warning" c="error" mt="2px" />+ <Icon name="warning" c="feedback-negative" mt="2px" /><Box>{historyRewritten && (<Text fw="bold" mb="xs">@@ -75,7 +75,7 @@ export const ForcePushWarning = ({)}<Stack gap="xs">{deletedText && (- <Text fw="bold" c="error">+ <Text fw="bold" c="feedback-negative">{deletedText}</Text>)}diff --git a/enterprise/frontend/src/metabase-enterprise/remote_sync/components/SyncConflictModal/OutOfSyncOptions.tsx b/enterprise/frontend/src/metabase-enterprise/remote_sync/components/SyncConflictModal/OutOfSyncOptions.tsxindex 5e96d1f9d7a..9b004e8804a 100644--- a/enterprise/frontend/src/metabase-enterprise/remote_sync/components/SyncConflictModal/OutOfSyncOptions.tsx+++ b/enterprise/frontend/src/metabase-enterprise/remote_sync/components/SyncConflictModal/OutOfSyncOptions.tsx@@ -129,7 +129,7 @@ const OptionGroup = ({ title, options, destructive }: OptionGroupProps) => (<Textsize="sm"fw="bold"- c={destructive ? "error" : "text-secondary"}+ c={destructive ? "feedback-negative" : "text-secondary"}mb="sm">{title}diff --git a/enterprise/frontend/src/metabase-enterprise/remote_sync/components/SyncConflictModal/SyncConflictModal.tsx b/enterprise/frontend/src/metabase-enterprise/remote_sync/components/SyncConflictModal/SyncConflictModal.tsxindex f21f08249d5..65db041db22 100644--- a/enterprise/frontend/src/metabase-enterprise/remote_sync/components/SyncConflictModal/SyncConflictModal.tsx+++ b/enterprise/frontend/src/metabase-enterprise/remote_sync/components/SyncConflictModal/SyncConflictModal.tsx@@ -243,7 +243,9 @@ export const SyncConflictModal = (props: UnsyncedWarningModalProps) => {{t`Cancel`}</Button><Button- color={optionValue === "discard" ? "error" : "core-brand"}+ color={+ optionValue === "discard" ? "feedback-negative" : "core-brand"+ }disabled={isButtonDisabled}leftSection={optionValue === "force-push" ? <Icon name="warning" /> : undefineddiff --git a/enterprise/frontend/src/metabase-enterprise/remote_sync/components/SyncProgressModal.tsx b/enterprise/frontend/src/metabase-enterprise/remote_sync/components/SyncProgressModal.tsxindex 37ac9459ad8..7e1018f9a67 100644--- a/enterprise/frontend/src/metabase-enterprise/remote_sync/components/SyncProgressModal.tsx+++ b/enterprise/frontend/src/metabase-enterprise/remote_sync/components/SyncProgressModal.tsx@@ -47,7 +47,7 @@ export function SyncProgressModal({sendToast({message,icon: "warning",- toastColor: "error",+ toastColor: "feedback-negative",});if (message.match(/no active task/i)) {diff --git a/enterprise/frontend/src/metabase-enterprise/remote_sync/components/SyncedCollectionsSidebarSection/CollectionSyncStatusBadge.tsx b/enterprise/frontend/src/metabase-enterprise/remote_sync/components/SyncedCollectionsSidebarSection/CollectionSyncStatusBadge.tsxindex a98f0ca29e0..20f47a28f53 100644--- a/enterprise/frontend/src/metabase-enterprise/remote_sync/components/SyncedCollectionsSidebarSection/CollectionSyncStatusBadge.tsx+++ b/enterprise/frontend/src/metabase-enterprise/remote_sync/components/SyncedCollectionsSidebarSection/CollectionSyncStatusBadge.tsx@@ -6,7 +6,7 @@ export const CollectionSyncStatusBadge = () => (<Tooltip label={t`Unsynced changes`}><Boxbdrs="50%"- bg="warning"+ bg="feedback-warning"h="0.5rem"w="0.5rem"mr="xs"diff --git a/enterprise/frontend/src/metabase-enterprise/remote_sync/utils.ts b/enterprise/frontend/src/metabase-enterprise/remote_sync/utils.tsindex 14c8a7dc32d..a93adf2e765 100644--- a/enterprise/frontend/src/metabase-enterprise/remote_sync/utils.ts+++ b/enterprise/frontend/src/metabase-enterprise/remote_sync/utils.ts@@ -59,15 +59,15 @@ export const getSyncStatusColor = (): ColorName => {switch (status) {case "create":- return "success";+ return "feedback-positive";case "removed":case "delete":- return "danger";+ return "feedback-negative";case "update":case "touch":return "core-blue-saturated";default:- return "info";+ return "core-info";}};diff --git a/enterprise/frontend/src/metabase-enterprise/replacement/components/SourceReplacementModal/ModalSidebar/EntitySection/EntitySection.tsx b/enterprise/frontend/src/metabase-enterprise/replacement/components/SourceReplacementModal/ModalSidebar/EntitySection/EntitySection.tsxindex 6c331fa638c..c9bc8d5592f 100644--- a/enterprise/frontend/src/metabase-enterprise/replacement/components/SourceReplacementModal/ModalSidebar/EntitySection/EntitySection.tsx+++ b/enterprise/frontend/src/metabase-enterprise/replacement/components/SourceReplacementModal/ModalSidebar/EntitySection/EntitySection.tsx@@ -18,7 +18,7 @@ export function EntitySection({ icon, error, children }: EntitySectionProps) {<Stack gap="sm" miw={0}>{children}{error && (- <Text c="error" size="sm">+ <Text c="feedback-negative" size="sm">{error}</Text>)}diff --git a/enterprise/frontend/src/metabase-enterprise/replacement/components/SourceReplacementModal/SourceReplacementModal.tsx b/enterprise/frontend/src/metabase-enterprise/replacement/components/SourceReplacementModal/SourceReplacementModal.tsxindex 53db0cf7dd8..fc796733a23 100644--- a/enterprise/frontend/src/metabase-enterprise/replacement/components/SourceReplacementModal/SourceReplacementModal.tsx+++ b/enterprise/frontend/src/metabase-enterprise/replacement/components/SourceReplacementModal/SourceReplacementModal.tsx@@ -117,7 +117,7 @@ function ModalContent({title: getConfirmTitle(dependents.length),message: t`This can't be undone.`,confirmButtonText: getConfirmSubmitLabel(dependents.length),- confirmButtonProps: { variant: "filled", color: "error" },+ confirmButtonProps: { variant: "filled", color: "feedback-negative" },onConfirm: async () => {trackReplaceDataSourceConfirmed({ triggeredFrom });await replaceSource({diff --git a/enterprise/frontend/src/metabase-enterprise/schema_viewer/components/SchemaViewer/components/Edge/SchemaViewerEdge.tsx b/enterprise/frontend/src/metabase-enterprise/schema_viewer/components/SchemaViewer/components/Edge/SchemaViewerEdge.tsxindex 3f614a8d723..49c94c26c97 100644--- a/enterprise/frontend/src/metabase-enterprise/schema_viewer/components/SchemaViewer/components/Edge/SchemaViewerEdge.tsx+++ b/enterprise/frontend/src/metabase-enterprise/schema_viewer/components/SchemaViewer/components/Edge/SchemaViewerEdge.tsx@@ -65,7 +65,7 @@ export const SchemaViewerEdge = memo(function SchemaViewerEdge(const relationship = props.data?.relationship ?? "many-to-one";const symbols = useMemo(() => getSymbolTypes(relationship), [relationship]);const stroke = selected- ? (palette.brand ?? "var(--mb-color-core-brand)")+ ? (palette["core-brand"] ?? "var(--mb-color-core-brand)"): (palette["border-neutral-strong"] ??"var(--mb-color-border-neutral-strong)");const strokeWidth = selected ? 2 : 1;diff --git a/enterprise/frontend/src/metabase-enterprise/schema_viewer/components/SchemaViewer/components/TableNode/SchemaViewerFieldRow.module.css b/enterprise/frontend/src/metabase-enterprise/schema_viewer/components/SchemaViewer/components/TableNode/SchemaViewerFieldRow.module.cssindex 27acb24a172..58681c37b15 100644--- a/enterprise/frontend/src/metabase-enterprise/schema_viewer/components/SchemaViewer/components/TableNode/SchemaViewerFieldRow.module.css+++ b/enterprise/frontend/src/metabase-enterprise/schema_viewer/components/SchemaViewer/components/TableNode/SchemaViewerFieldRow.module.css@@ -43,7 +43,7 @@width: 0.675rem;height: 0.675rem;border-radius: 50%;- background: var(--mb-color-white);+ background: var(--mb-color-core-white);border: 1px solid var(--node-border-color, var(--mb-color-border-neutral));pointer-events: none;z-index: 1;diff --git a/enterprise/frontend/src/metabase-enterprise/schema_viewer/components/SchemaViewer/components/TableNode/SchemaViewerTableNode.module.css b/enterprise/frontend/src/metabase-enterprise/schema_viewer/components/SchemaViewer/components/TableNode/SchemaViewerTableNode.module.cssindex 52aae2c67ca..998d70908dd 100644--- a/enterprise/frontend/src/metabase-enterprise/schema_viewer/components/SchemaViewer/components/TableNode/SchemaViewerTableNode.module.css+++ b/enterprise/frontend/src/metabase-enterprise/schema_viewer/components/SchemaViewer/components/TableNode/SchemaViewerTableNode.module.css@@ -5,7 +5,7 @@width: 20rem;border: 1px solid var(--node-border-color);border-radius: 0.5rem;- background: var(--mb-color-white);+ background: var(--mb-color-core-white);box-shadow: 0 0.25rem 1.25rem 0 rgba(0, 0, 0, 0.05);}diff --git a/enterprise/frontend/src/metabase-enterprise/security_center/components/AdvisoryCard/AdvisoryCard.module.css b/enterprise/frontend/src/metabase-enterprise/security_center/components/AdvisoryCard/AdvisoryCard.module.cssindex 5fa578129dc..39dcf101a74 100644--- a/enterprise/frontend/src/metabase-enterprise/security_center/components/AdvisoryCard/AdvisoryCard.module.css+++ b/enterprise/frontend/src/metabase-enterprise/security_center/components/AdvisoryCard/AdvisoryCard.module.css@@ -1,21 +1,21 @@.severityCritical {- background-color: var(--mb-color-error);- color: var(--mb-color-white);+ background-color: var(--mb-color-feedback-negative);+ color: var(--mb-color-core-white);}.severityHigh {- background-color: var(--mb-color-warning);- color: var(--mb-color-white);+ background-color: var(--mb-color-feedback-warning);+ color: var(--mb-color-core-white);}.severityMedium {- background-color: var(--mb-color-gold);+ background-color: var(--mb-color-feedback-warning);color: var(--mb-color-text-primary);}.severityLow {- background-color: var(--mb-color-success);- color: var(--mb-color-white);+ background-color: var(--mb-color-feedback-positive);+ color: var(--mb-color-core-white);}.severityNeutral {diff --git a/enterprise/frontend/src/metabase-enterprise/security_center/components/AdvisoryCard/AdvisoryCard.tsx b/enterprise/frontend/src/metabase-enterprise/security_center/components/AdvisoryCard/AdvisoryCard.tsxindex a406c820c1d..3c44af38800 100644--- a/enterprise/frontend/src/metabase-enterprise/security_center/components/AdvisoryCard/AdvisoryCard.tsx+++ b/enterprise/frontend/src/metabase-enterprise/security_center/components/AdvisoryCard/AdvisoryCard.tsx@@ -59,10 +59,10 @@ export function AdvisoryCard({</Badge>{!isAffecting && (<Group gap="xs" align="center">- <Text size="sm" c="success" fw={500}>+ <Text size="sm" c="feedback-positive" fw={500}>{t`Your instance is not affected`}</Text>- <Icon name="check_filled" c="success" size={20} />+ <Icon name="check_filled" c="feedback-positive" size={20} /></Group>)}</Group>diff --git a/enterprise/frontend/src/metabase-enterprise/security_center/components/AdvisoryList/AdvisoryList.module.css b/enterprise/frontend/src/metabase-enterprise/security_center/components/AdvisoryList/AdvisoryList.module.cssindex 74413495819..0edfbbb95ef 100644--- a/enterprise/frontend/src/metabase-enterprise/security_center/components/AdvisoryList/AdvisoryList.module.css+++ b/enterprise/frontend/src/metabase-enterprise/security_center/components/AdvisoryList/AdvisoryList.module.css@@ -19,5 +19,5 @@.countBadge {background-color: var(--mb-color-text-primary);- color: var(--mb-color-white);+ color: var(--mb-color-core-white);}diff --git a/enterprise/frontend/src/metabase-enterprise/security_center/components/NotificationChannelConfigModal/EmailChannelCard/EmailChannelCard.tsx b/enterprise/frontend/src/metabase-enterprise/security_center/components/NotificationChannelConfigModal/EmailChannelCard/EmailChannelCard.tsxindex 78fd6f6282d..3065a5dd41d 100644--- a/enterprise/frontend/src/metabase-enterprise/security_center/components/NotificationChannelConfigModal/EmailChannelCard/EmailChannelCard.tsx+++ b/enterprise/frontend/src/metabase-enterprise/security_center/components/NotificationChannelConfigModal/EmailChannelCard/EmailChannelCard.tsx@@ -63,7 +63,7 @@ export function EmailChannelCard({ isConfigured }: { isConfigured: boolean }) {/>{!config.email.sendToAllAdmins &&config.email.handler.recipients.length === 0 && (- <Text size="sm" c="error" mt="xs">+ <Text size="sm" c="feedback-negative" mt="xs">{t`At least one recipient is required.`}</Text>)}diff --git a/enterprise/frontend/src/metabase-enterprise/security_center/components/NotificationChannelConfigModal/NotificationChannelConfigModal.tsx b/enterprise/frontend/src/metabase-enterprise/security_center/components/NotificationChannelConfigModal/NotificationChannelConfigModal.tsxindex 2b534550f55..5a7ef8d3921 100644--- a/enterprise/frontend/src/metabase-enterprise/security_center/components/NotificationChannelConfigModal/NotificationChannelConfigModal.tsx+++ b/enterprise/frontend/src/metabase-enterprise/security_center/components/NotificationChannelConfigModal/NotificationChannelConfigModal.tsx@@ -39,13 +39,13 @@ export function NotificationChannelConfigModal({await save();sendToast({message: t`Notification settings saved`,- toastColor: "success",+ toastColor: "feedback-positive",});onClose();} catch {sendToast({icon: "warning",- toastColor: "error",+ toastColor: "feedback-negative",message: t`Failed to save notification settings`,});} finally {@@ -59,12 +59,12 @@ export function NotificationChannelConfigModal({await sendTestNotification(serializeNotificationConfig(config)).unwrap();sendToast({message: t`Test notification sent`,- toastColor: "success",+ toastColor: "feedback-positive",});} catch {sendToast({icon: "warning",- toastColor: "error",+ toastColor: "feedback-negative",message: t`Failed to send test notification`,});} finally {diff --git a/enterprise/frontend/src/metabase-enterprise/security_center/components/SecurityCenterBanner/SecurityCenterBanner.tsx b/enterprise/frontend/src/metabase-enterprise/security_center/components/SecurityCenterBanner/SecurityCenterBanner.tsxindex f91b7681b63..44216dd2a7d 100644--- a/enterprise/frontend/src/metabase-enterprise/security_center/components/SecurityCenterBanner/SecurityCenterBanner.tsx+++ b/enterprise/frontend/src/metabase-enterprise/security_center/components/SecurityCenterBanner/SecurityCenterBanner.tsx@@ -62,7 +62,7 @@ export function SecurityCenterBanner() {<BannercontentGroupProps={{ wrap: "nowrap" }}icon="warning_round_filled"- bg="error"+ bg="feedback-negative"body={<Text lh="inherit">{body}</Text>}py="md"/>diff --git a/enterprise/frontend/src/metabase-enterprise/security_center/components/SecurityCenterNavItem/SecurityCenterMobileNavItem.tsx b/enterprise/frontend/src/metabase-enterprise/security_center/components/SecurityCenterNavItem/SecurityCenterMobileNavItem.tsxindex 9eee73e131c..53d3243b755 100644--- a/enterprise/frontend/src/metabase-enterprise/security_center/components/SecurityCenterNavItem/SecurityCenterMobileNavItem.tsx+++ b/enterprise/frontend/src/metabase-enterprise/security_center/components/SecurityCenterNavItem/SecurityCenterMobileNavItem.tsx@@ -32,7 +32,7 @@ export function SecurityCenterMobileNavItem({w={8}h={8}miw={8}- bg="error"+ bg="feedback-negative"style={{ borderRadius: "50%", flexShrink: 0 }}data-testid="security-center-badge"/>diff --git a/enterprise/frontend/src/metabase-enterprise/security_center/components/SecurityCenterNavItem/SecurityCenterNavItem.tsx b/enterprise/frontend/src/metabase-enterprise/security_center/components/SecurityCenterNavItem/SecurityCenterNavItem.tsxindex 92628b6f9ea..a4a8d2b66dd 100644--- a/enterprise/frontend/src/metabase-enterprise/security_center/components/SecurityCenterNavItem/SecurityCenterNavItem.tsx+++ b/enterprise/frontend/src/metabase-enterprise/security_center/components/SecurityCenterNavItem/SecurityCenterNavItem.tsx@@ -32,7 +32,7 @@ export function SecurityCenterNavItem({w={8}h={8}miw={8}- bg="error"+ bg="feedback-negative"style={{ borderRadius: "50%", flexShrink: 0 }}data-testid="security-center-badge"/>diff --git a/enterprise/frontend/src/metabase-enterprise/security_center/components/SecurityCenterPage/SecurityCenterPage.tsx b/enterprise/frontend/src/metabase-enterprise/security_center/components/SecurityCenterPage/SecurityCenterPage.tsxindex 9b2a307f521..522ac69c148 100644--- a/enterprise/frontend/src/metabase-enterprise/security_center/components/SecurityCenterPage/SecurityCenterPage.tsx+++ b/enterprise/frontend/src/metabase-enterprise/security_center/components/SecurityCenterPage/SecurityCenterPage.tsx@@ -81,7 +81,7 @@ export function SecurityCenterPage({ location }: SecurityCenterPageProps = {}) {} catch {sendToast({icon: "warning_triangle_filled",- iconColor: "warning",+ iconColor: "feedback-warning",message: t`Failed to check for security advisories`,});}@@ -108,7 +108,7 @@ export function SecurityCenterPage({ location }: SecurityCenterPageProps = {}) {setIsPolling(false);sendToast({icon: "warning_triangle_filled",- iconColor: "warning",+ iconColor: "feedback-warning",message: t`Security advisory check is taking longer than expected. Results will appear when ready.`,});}diff --git a/enterprise/frontend/src/metabase-enterprise/security_center/components/UpgradeBanner/UpgradeBanner.module.css b/enterprise/frontend/src/metabase-enterprise/security_center/components/UpgradeBanner/UpgradeBanner.module.cssindex dea352a4478..b0553e5c51f 100644--- a/enterprise/frontend/src/metabase-enterprise/security_center/components/UpgradeBanner/UpgradeBanner.module.css+++ b/enterprise/frontend/src/metabase-enterprise/security_center/components/UpgradeBanner/UpgradeBanner.module.css@@ -2,12 +2,12 @@padding: var(--mantine-spacing-md) var(--mantine-spacing-lg);background-color: var(--mb-color-background_surface-warning);border-radius: var(--mantine-radius-md);- border: 1px solid var(--mb-color-warning);+ border: 1px solid var(--mb-color-feedback-warning);}.icon {flex-shrink: 0;- color: var(--mb-color-warning);+ color: var(--mb-color-feedback-warning);}.text {diff --git a/enterprise/frontend/src/metabase-enterprise/semantic_search/SearchSettingsWidget.tsx b/enterprise/frontend/src/metabase-enterprise/semantic_search/SearchSettingsWidget.tsxindex e37e71195b3..a4014776659 100644--- a/enterprise/frontend/src/metabase-enterprise/semantic_search/SearchSettingsWidget.tsx+++ b/enterprise/frontend/src/metabase-enterprise/semantic_search/SearchSettingsWidget.tsx@@ -92,7 +92,7 @@ export function SearchSettingsWidget({</Box>{response.error && (- <Text c="error">+ <Text c="feedback-negative">{getErrorMessage(response,t`Unable to fetch health status of search index.`,diff --git a/enterprise/frontend/src/metabase-enterprise/smtp-override/components/CloudSMTPConnectionCard.tsx b/enterprise/frontend/src/metabase-enterprise/smtp-override/components/CloudSMTPConnectionCard.tsxindex afe5ef56920..8b2da36f145 100644--- a/enterprise/frontend/src/metabase-enterprise/smtp-override/components/CloudSMTPConnectionCard.tsx+++ b/enterprise/frontend/src/metabase-enterprise/smtp-override/components/CloudSMTPConnectionCard.tsx@@ -76,7 +76,7 @@ export const CloudSMTPConnectionCard = () => {/>) : (<Flex gap={"md"}>- <Icon name="check" c="success" size={20} />+ <Icon name="check" c="feedback-positive" size={20} /><Stack gap={0}><TextclassName={S.cardTitle}diff --git a/enterprise/frontend/src/metabase-enterprise/support/components/SupportSettingsSection/AccessGrantList.tsx b/enterprise/frontend/src/metabase-enterprise/support/components/SupportSettingsSection/AccessGrantList.tsxindex c767a0f7cc7..763515ce4b9 100644--- a/enterprise/frontend/src/metabase-enterprise/support/components/SupportSettingsSection/AccessGrantList.tsx+++ b/enterprise/frontend/src/metabase-enterprise/support/components/SupportSettingsSection/AccessGrantList.tsx@@ -26,7 +26,7 @@ export const AccessGrantList = (props: AccessGrantListProps) => {title: t`Revoke access grant?`,message: t`This will immediately revoke the support agent's access to your instance.`,confirmButtonText: t`Revoke`,- confirmButtonProps: { color: "danger" },+ confirmButtonProps: { color: "feedback-negative" },size: "sm",onConfirm: async () => {try {diff --git a/enterprise/frontend/src/metabase-enterprise/table-editing/table-edit/EditTableDataFilterButton.module.css b/enterprise/frontend/src/metabase-enterprise/table-editing/table-edit/EditTableDataFilterButton.module.cssindex 779ccd4bdc9..b2d23fabe65 100644--- a/enterprise/frontend/src/metabase-enterprise/table-editing/table-edit/EditTableDataFilterButton.module.css+++ b/enterprise/frontend/src/metabase-enterprise/table-editing/table-edit/EditTableDataFilterButton.module.css@@ -9,7 +9,7 @@background-color: color-mix(in srgb,var(--mb-color-core-filter) 10%,- var(--mb-color-white)+ var(--mb-color-core-white));}}@@ -24,7 +24,7 @@background-color: color-mix(in srgb,var(--mb-color-core-filter) 10%,- var(--mb-color-white)+ var(--mb-color-core-white));}@@ -47,6 +47,6 @@background-color: color-mix(in srgb,var(--mb-color-core-filter) 15%,- var(--mb-color-white)+ var(--mb-color-core-white));}diff --git a/enterprise/frontend/src/metabase-enterprise/table-editing/table-edit/data-grid/TableEditingCell.module.css b/enterprise/frontend/src/metabase-enterprise/table-editing/table-edit/data-grid/TableEditingCell.module.cssindex 6b6f47a9eca..ee94d4d3b2f 100644--- a/enterprise/frontend/src/metabase-enterprise/table-editing/table-edit/data-grid/TableEditingCell.module.css+++ b/enterprise/frontend/src/metabase-enterprise/table-editing/table-edit/data-grid/TableEditingCell.module.css@@ -41,7 +41,7 @@.errorCell {background-color: var(--mb-color-background_surface-warning);- outline: 2px solid var(--mb-color-warning);+ outline: 2px solid var(--mb-color-feedback-warning);outline-offset: -2px;border-radius: 0.25rem;diff --git a/enterprise/frontend/src/metabase-enterprise/table-editing/table-edit/modals/DeleteBulkRowConfirmationModal.tsx b/enterprise/frontend/src/metabase-enterprise/table-editing/table-edit/modals/DeleteBulkRowConfirmationModal.tsxindex 7095c79572a..55cec883302 100644--- a/enterprise/frontend/src/metabase-enterprise/table-editing/table-edit/modals/DeleteBulkRowConfirmationModal.tsx+++ b/enterprise/frontend/src/metabase-enterprise/table-editing/table-edit/modals/DeleteBulkRowConfirmationModal.tsx@@ -33,7 +33,7 @@ export function DeleteBulkRowConfirmationModal({</Button><Buttonvariant="filled"- color="danger"+ color="feedback-negative"onClick={onConfirm}loading={isLoading}>diff --git a/enterprise/frontend/src/metabase-enterprise/table-editing/table-edit/modals/TableActionFormModalParameter.tsx b/enterprise/frontend/src/metabase-enterprise/table-editing/table-edit/modals/TableActionFormModalParameter.tsxindex 8a7173715bd..d346f9dfe5d 100644--- a/enterprise/frontend/src/metabase-enterprise/table-editing/table-edit/modals/TableActionFormModalParameter.tsx+++ b/enterprise/frontend/src/metabase-enterprise/table-editing/table-edit/modals/TableActionFormModalParameter.tsx@@ -36,7 +36,7 @@ export function TableActionFormModalParameter({<Text truncate maw="100%">{parameter.display_name}{!parameter.optional && (- <Text component="span" c="error">+ <Text component="span" c="feedback-negative">*</Text>)}diff --git a/enterprise/frontend/src/metabase-enterprise/table-editing/table-edit/toasts/ErrorUpdateToast.tsx b/enterprise/frontend/src/metabase-enterprise/table-editing/table-edit/toasts/ErrorUpdateToast.tsxindex 771450cc038..bf70aabfadb 100644--- a/enterprise/frontend/src/metabase-enterprise/table-editing/table-edit/toasts/ErrorUpdateToast.tsx+++ b/enterprise/frontend/src/metabase-enterprise/table-editing/table-edit/toasts/ErrorUpdateToast.tsx@@ -68,7 +68,7 @@ export const ErrorUpdateToast = ({ error }: ErrorUpdateToastProps) => {return (<Group gap="2.5rem" w="20rem"><Group gap="0.5rem">- <Icon name="warning" c="danger" size={12} />+ <Icon name="warning" c="feedback-negative" size={12} /><Textc="text-primary-inverse"fw={700}diff --git a/enterprise/frontend/src/metabase-enterprise/tenants/components/CreateTenantsOnboardingStep/CreateTenantsOnboardingStep.tsx b/enterprise/frontend/src/metabase-enterprise/tenants/components/CreateTenantsOnboardingStep/CreateTenantsOnboardingStep.tsxindex 9b788c4731d..cff0e41deb6 100644--- a/enterprise/frontend/src/metabase-enterprise/tenants/components/CreateTenantsOnboardingStep/CreateTenantsOnboardingStep.tsx+++ b/enterprise/frontend/src/metabase-enterprise/tenants/components/CreateTenantsOnboardingStep/CreateTenantsOnboardingStep.tsx@@ -100,7 +100,7 @@ export const CreateTenantsOnboardingStep = ({sendToast({icon: "check",- toastColor: "success",+ toastColor: "feedback-positive",message: t`Tenants created successfully`,});@@ -109,7 +109,7 @@ export const CreateTenantsOnboardingStep = ({} catch (error) {sendToast({icon: "warning",- toastColor: "error",+ toastColor: "feedback-negative",message: getErrorMessage(error, t`Failed to create tenants`),});}diff --git a/enterprise/frontend/src/metabase-enterprise/tenants/components/TenantsListing/TenantsListing.tsx b/enterprise/frontend/src/metabase-enterprise/tenants/components/TenantsListing/TenantsListing.tsxindex 0b5c66f52f1..787a1ed1022 100644--- a/enterprise/frontend/src/metabase-enterprise/tenants/components/TenantsListing/TenantsListing.tsx+++ b/enterprise/frontend/src/metabase-enterprise/tenants/components/TenantsListing/TenantsListing.tsx@@ -153,7 +153,7 @@ function ActionsPopover({ tenant }: ActionsPopoverProps) {</Menu.Item>{tenant.is_active ? (<Menu.Item- c="danger"+ c="feedback-negative"component={ForwardRefLink}to={Urls.deactivateTenant(tenant.id)}>@@ -161,7 +161,7 @@ function ActionsPopover({ tenant }: ActionsPopoverProps) {</Menu.Item>) : (<Menu.Item- c="danger"+ c="feedback-negative"component={ForwardRefLink}to={Urls.reactivateTenant(tenant.id)}>diff --git a/enterprise/frontend/src/metabase-enterprise/tenants/utils/colors.ts b/enterprise/frontend/src/metabase-enterprise/tenants/utils/colors.tsindex 025413204df..1a7ef718e9b 100644--- a/enterprise/frontend/src/metabase-enterprise/tenants/utils/colors.ts+++ b/enterprise/frontend/src/metabase-enterprise/tenants/utils/colors.ts@@ -2,7 +2,7 @@ import { color } from "metabase/ui/colors";import type { Tenant } from "metabase-types/api";const groupColorPalette = [- color("error"),+ color("feedback-negative"),color("accent2"),color("core-brand"),color("accent4"),diff --git a/enterprise/frontend/src/metabase-enterprise/transforms-python/components/PythonTransformEditor/PythonEditorBody/PythonEditorBody.tsx b/enterprise/frontend/src/metabase-enterprise/transforms-python/components/PythonTransformEditor/PythonEditorBody/PythonEditorBody.tsxindex c09a2c98e12..9d75ee8871e 100644--- a/enterprise/frontend/src/metabase-enterprise/transforms-python/components/PythonTransformEditor/PythonEditorBody/PythonEditorBody.tsx+++ b/enterprise/frontend/src/metabase-enterprise/transforms-python/components/PythonTransformEditor/PythonEditorBody/PythonEditorBody.tsx@@ -105,7 +105,7 @@ export function PythonEditorBody({<Buttondata-testid="accept-proposed-changes-button"variant="filled"- bg="success"+ bg="feedback-positive"px="0"w="2.5rem"onClick={onAcceptProposed}@@ -119,7 +119,7 @@ export function PythonEditorBody({w="2.5rem"px="0"variant="filled"- bg="danger"+ bg="feedback-negative"onClick={onRejectProposed}><Icon name="close" />diff --git a/enterprise/frontend/src/metabase-enterprise/transforms-python/components/PythonTransformEditor/PythonEditorResults/PythonEditorResults.tsx b/enterprise/frontend/src/metabase-enterprise/transforms-python/components/PythonTransformEditor/PythonEditorResults/PythonEditorResults.tsxindex 5decade9d50..6f950576003 100644--- a/enterprise/frontend/src/metabase-enterprise/transforms-python/components/PythonTransformEditor/PythonEditorResults/PythonEditorResults.tsx+++ b/enterprise/frontend/src/metabase-enterprise/transforms-python/components/PythonTransformEditor/PythonEditorResults/PythonEditorResults.tsx@@ -131,7 +131,7 @@ function EmptyState() {function ErrorState({ error }: { error: string }) {return (- <Stack gap="sm" h="100%" p="md" c="error" className={S.error}>+ <Stack gap="sm" h="100%" p="md" c="feedback-negative" className={S.error}><Group fw="bold" gap="sm"><Icon name="warning" />{t`Error`}@@ -157,7 +157,12 @@ function ResultsFooter({if (executionResult.error) {return (<Flex className={S.footer} gap="xs" align="center" px="md" py="md">- <Icon size="1rem" style={{ flexShrink: 0 }} name="warning" c="error" />+ <Icon+ size="1rem"+ style={{ flexShrink: 0 }}+ name="warning"+ c="feedback-negative"+ /><Textc="text-primary"ml="xs"@@ -177,7 +182,7 @@ function ResultsFooter({size="1rem"style={{ flexShrink: 0 }}name="check_filled"- c="success"+ c="feedback-positive"/><Text fw="bold" c="text-primary" lh="xs">{t`Done`}</Text><Textdiff --git a/enterprise/frontend/src/metabase-enterprise/transforms/upsells/components/TransformsSettingUpModal.tsx b/enterprise/frontend/src/metabase-enterprise/transforms/upsells/components/TransformsSettingUpModal.tsxindex de809367121..194e119f8dd 100644--- a/enterprise/frontend/src/metabase-enterprise/transforms/upsells/components/TransformsSettingUpModal.tsx+++ b/enterprise/frontend/src/metabase-enterprise/transforms/upsells/components/TransformsSettingUpModal.tsx@@ -65,13 +65,13 @@ export const TransformsSettingUpModal = ({pos="absolute"right={0}wrap="nowrap"- bg="white"+ bg="core-white"fz={0}p="sm"ta="center"style={{borderRadius: "100%",- boxShadow: `0 1px 6px 0 var(--mb-color-shadow)`,+ boxShadow: `0 1px 6px 0 var(--mb-color-shadow-default)`,}}><Loader size="xs" ml={1} mt={1} />diff --git a/enterprise/frontend/src/metabase-enterprise/upload_management/UploadManagementTable.tsx b/enterprise/frontend/src/metabase-enterprise/upload_management/UploadManagementTable.tsxindex 8260d647e8a..42ca973e8e0 100644--- a/enterprise/frontend/src/metabase-enterprise/upload_management/UploadManagementTable.tsx+++ b/enterprise/frontend/src/metabase-enterprise/upload_management/UploadManagementTable.tsx@@ -120,7 +120,11 @@ export function UploadManagementTable() {selectedItems.length,);- sendToast({ message, toastColor: "error", icon: "warning" });+ sendToast({+ message,+ toastColor: "feedback-negative",+ icon: "warning",+ });} else if (result.length > 0) {const message = ngettext(msgid`1 table deleted`,diff --git a/enterprise/frontend/src/metabase-enterprise/whitelabel/components/ColorSettings/ColorSettings.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/whitelabel/components/ColorSettings/ColorSettings.unit.spec.tsxindex 559405a41f8..0ffc3677a12 100644--- a/enterprise/frontend/src/metabase-enterprise/whitelabel/components/ColorSettings/ColorSettings.unit.spec.tsx+++ b/enterprise/frontend/src/metabase-enterprise/whitelabel/components/ColorSettings/ColorSettings.unit.spec.tsx@@ -33,13 +33,13 @@ describe("ColorSettings", () => {Color(color("core-summarize")).hex(),);await userEvent.clear(input);- await userEvent.type(input, color("error"));+ await userEvent.type(input, color("feedback-negative"));expect(onChange).toHaveBeenLastCalledWith({brand: color("core-filter"),/* Needs to convert this to hex because the input is transform to hex,* but we want to use hsla for our new colors, this is to allow better text search. */- summarize: Color(color("error")).hex(),+ summarize: Color(color("feedback-negative")).hex(),accent1: textMediumHex,});});diff --git a/enterprise/frontend/src/metabase-enterprise/whitelabel/components/IllustrationWidget/IllustrationWidget.tsx b/enterprise/frontend/src/metabase-enterprise/whitelabel/components/IllustrationWidget/IllustrationWidget.tsxindex 34e36f2cecd..59480353734 100644--- a/enterprise/frontend/src/metabase-enterprise/whitelabel/components/IllustrationWidget/IllustrationWidget.tsx+++ b/enterprise/frontend/src/metabase-enterprise/whitelabel/components/IllustrationWidget/IllustrationWidget.tsx@@ -182,7 +182,7 @@ export function IllustrationWidget({<Box data-testid={`${name}-setting`}><SettingHeader id={name} title={title} description={description} />{errorMessage && (- <Text size="sm" c="error" mb="sm">+ <Text size="sm" c="feedback-negative" mb="sm">{errorMessage}</Text>)}diff --git a/enterprise/frontend/src/metabase-enterprise/whitelabel/components/IllustrationWidget/ImageUploadWidget.tsx b/enterprise/frontend/src/metabase-enterprise/whitelabel/components/IllustrationWidget/ImageUploadWidget.tsxindex 315e5c6d919..2a75043cf2b 100644--- a/enterprise/frontend/src/metabase-enterprise/whitelabel/components/IllustrationWidget/ImageUploadWidget.tsx+++ b/enterprise/frontend/src/metabase-enterprise/whitelabel/components/IllustrationWidget/ImageUploadWidget.tsx@@ -87,7 +87,7 @@ export function ImageUploadWidget({description={descriptionProp ?? description}/>{errorMessage && (- <Text size="sm" c="error" mb="sm">+ <Text size="sm" c="feedback-negative" mb="sm">{errorMessage}</Text>)}diff --git a/enterprise/frontend/src/metabase-enterprise/workspaces/components/WorkspaceDatabaseSection/WorkspaceDatabaseSection.tsx b/enterprise/frontend/src/metabase-enterprise/workspaces/components/WorkspaceDatabaseSection/WorkspaceDatabaseSection.tsxindex 94087e04e43..659ac1c1493 100644--- a/enterprise/frontend/src/metabase-enterprise/workspaces/components/WorkspaceDatabaseSection/WorkspaceDatabaseSection.tsx+++ b/enterprise/frontend/src/metabase-enterprise/workspaces/components/WorkspaceDatabaseSection/WorkspaceDatabaseSection.tsx@@ -52,7 +52,7 @@ export function WorkspaceDatabaseSection({if (error) {sendToast({message: t`Failed to enable Workspaces`,- toastColor: "error",+ toastColor: "feedback-negative",icon: "warning",});}@@ -71,7 +71,7 @@ export function WorkspaceDatabaseSection({if (error) {sendToast({message: t`Failed to remove connection`,- toastColor: "error",+ toastColor: "feedback-negative",});}},@@ -137,7 +137,11 @@ export function WorkspaceDatabaseSection({: t`Add admin connection`}</Button>{hasAdminConnection && (- <Button variant="filled" color="error" onClick={handleRemove}>+ <Button+ variant="filled"+ color="feedback-negative"+ onClick={handleRemove}+ >{t`Remove admin connection`}</Button>)}diff --git a/enterprise/frontend/src/metabase-enterprise/workspaces/pages/CurrentWorkspacePage/DeleteSection/DeleteSection.tsx b/enterprise/frontend/src/metabase-enterprise/workspaces/pages/CurrentWorkspacePage/DeleteSection/DeleteSection.tsxindex 2b3a7fff983..dec300a33d9 100644--- a/enterprise/frontend/src/metabase-enterprise/workspaces/pages/CurrentWorkspacePage/DeleteSection/DeleteSection.tsx+++ b/enterprise/frontend/src/metabase-enterprise/workspaces/pages/CurrentWorkspacePage/DeleteSection/DeleteSection.tsx@@ -20,7 +20,7 @@ export function DeleteSection() {<Code key="config">{CONFIG_FILENAME}</Code>)} will remain — you can re-enter the workspace at any time by uploading it again.`,confirmButtonText: t`Leave workspace`,- confirmButtonProps: { color: "danger" },+ confirmButtonProps: { color: "feedback-negative" },onConfirm: async () => {await deleteInstance().unwrap();trackWorkspaceInstanceLeave();@@ -38,7 +38,11 @@ export function DeleteSection() {<Text maw="40rem">{t`Stop remapping transform tables on this instance.`}</Text>- <Button color="error" variant="filled" onClick={handleClick}>+ <Button+ color="feedback-negative"+ variant="filled"+ onClick={handleClick}+ >{t`Leave workspace`}</Button></Group>diff --git a/enterprise/frontend/src/metabase-enterprise/workspaces/pages/WorkspaceListPage/DeleteWorkspaceModal/DeleteWorkspaceModal.tsx b/enterprise/frontend/src/metabase-enterprise/workspaces/pages/WorkspaceListPage/DeleteWorkspaceModal/DeleteWorkspaceModal.tsxindex a2e99ddfa58..6086324e1e4 100644--- a/enterprise/frontend/src/metabase-enterprise/workspaces/pages/WorkspaceListPage/DeleteWorkspaceModal/DeleteWorkspaceModal.tsx+++ b/enterprise/frontend/src/metabase-enterprise/workspaces/pages/WorkspaceListPage/DeleteWorkspaceModal/DeleteWorkspaceModal.tsx@@ -96,7 +96,7 @@ function DeleteWorkspaceForm({sendToast({message: result.message,icon: "warning",- toastColor: "error",+ toastColor: "feedback-negative",timeout: null,});}@@ -132,7 +132,7 @@ function DeleteWorkspaceForm({<FormSubmitButtonlabel={t`Delete workspace`}variant="filled"- color="danger"+ color="feedback-negative"disabled={isLoading}/></Group>diff --git a/enterprise/frontend/src/metabase-enterprise/writable_connection/components/WritableConnectionInfoSection/WritableConnectionInfoSection.tsx b/enterprise/frontend/src/metabase-enterprise/writable_connection/components/WritableConnectionInfoSection/WritableConnectionInfoSection.tsxindex ffcb48bbc56..b1966a179bb 100644--- a/enterprise/frontend/src/metabase-enterprise/writable_connection/components/WritableConnectionInfoSection/WritableConnectionInfoSection.tsx+++ b/enterprise/frontend/src/metabase-enterprise/writable_connection/components/WritableConnectionInfoSection/WritableConnectionInfoSection.tsx@@ -84,7 +84,11 @@ export function WritableConnectionInfoSection({<><DatabaseInfoSectionDivider condensed /><Group>- <Button variant="filled" color="error" onClick={handleRemove}>+ <Button+ variant="filled"+ color="feedback-negative"+ onClick={handleRemove}+ >{t`Remove writable connection`}</Button></Group>diff --git a/frontend/src/embedding-sdk-bundle/components/private/SdkUsageProblem/SdkUsageProblemBanner.tsx b/frontend/src/embedding-sdk-bundle/components/private/SdkUsageProblem/SdkUsageProblemBanner.tsxindex 72e5d64c267..aab5b969b6d 100644--- a/frontend/src/embedding-sdk-bundle/components/private/SdkUsageProblem/SdkUsageProblemBanner.tsx+++ b/frontend/src/embedding-sdk-bundle/components/private/SdkUsageProblem/SdkUsageProblemBanner.tsx@@ -58,7 +58,7 @@ export const SdkUsageProblemBanner = ({data-testid="sdk-usage-problem-indicator"i-should-be-flex="true">- <Flex bg="white" px="sm" className={S.Logo} align="center">+ <Flex bg="core-white" px="sm" className={S.Logo} align="center"><DefaultLogoIcon height={24} /></Flex>diff --git a/frontend/src/embedding-sdk-bundle/lib/theme/get-embedding-theme.unit.spec.ts b/frontend/src/embedding-sdk-bundle/lib/theme/get-embedding-theme.unit.spec.tsindex ab171082d21..7b60e1214c8 100644--- a/frontend/src/embedding-sdk-bundle/lib/theme/get-embedding-theme.unit.spec.ts+++ b/frontend/src/embedding-sdk-bundle/lib/theme/get-embedding-theme.unit.spec.ts@@ -52,7 +52,9 @@ describe("Transform Embedding Theme Override", () => {"background_surface-disabled": expect.arrayContaining(["pink"]),"text-primary-inverse": expect.arrayContaining(["white"]),white: expect.arrayContaining(["white"]),+ "core-white": expect.arrayContaining(["white"]),focus: expect.arrayContaining(["blue"]),+ "input-focus": expect.arrayContaining(["blue"]),},other: {fontSize: "2rem",diff --git a/frontend/src/metabase/account/notifications/components/ArchiveModal/ArchiveModal.tsx b/frontend/src/metabase/account/notifications/components/ArchiveModal/ArchiveModal.tsxindex 7be97d2b3bc..4a697482531 100644--- a/frontend/src/metabase/account/notifications/components/ArchiveModal/ArchiveModal.tsx+++ b/frontend/src/metabase/account/notifications/components/ArchiveModal/ArchiveModal.tsx@@ -52,7 +52,7 @@ function ArchiveNotificationModal({<Buttonkey="submit"variant="filled"- color="error"+ color="feedback-negative"onClick={handleArchiveClick}>{getSubmitMessage(type, hasUnsubscribed)}diff --git a/frontend/src/metabase/account/notifications/components/UnsubscribeModal/UnsubscribeModal.tsx b/frontend/src/metabase/account/notifications/components/UnsubscribeModal/UnsubscribeModal.tsxindex 95d4bde4247..71a930193d0 100644--- a/frontend/src/metabase/account/notifications/components/UnsubscribeModal/UnsubscribeModal.tsx+++ b/frontend/src/metabase/account/notifications/components/UnsubscribeModal/UnsubscribeModal.tsx@@ -55,7 +55,7 @@ function UnsubscribeModal({<Buttonkey="submit"variant="filled"- color="error"+ color="feedback-negative"onClick={handleUnsubscribeClick}>{t`Unsubscribe`}diff --git a/frontend/src/metabase/account/notifications/containers/ArchiveAlertModal/DeleteAlertModal.tsx b/frontend/src/metabase/account/notifications/containers/ArchiveAlertModal/DeleteAlertModal.tsxindex ed8a6288950..73661c990e1 100644--- a/frontend/src/metabase/account/notifications/containers/ArchiveAlertModal/DeleteAlertModal.tsx+++ b/frontend/src/metabase/account/notifications/containers/ArchiveAlertModal/DeleteAlertModal.tsx@@ -48,7 +48,7 @@ export const DeleteAlertModal = ({if (result.error) {sendToast({icon: "warning",- toastColor: "error",+ toastColor: "feedback-negative",message: t`An error occurred`,});return;diff --git a/frontend/src/metabase/account/notifications/containers/UnsubscribeAlertModal/UnsubscribeAlertModal.tsx b/frontend/src/metabase/account/notifications/containers/UnsubscribeAlertModal/UnsubscribeAlertModal.tsxindex f1a4ecf8afa..8662b6b2fe9 100644--- a/frontend/src/metabase/account/notifications/containers/UnsubscribeAlertModal/UnsubscribeAlertModal.tsx+++ b/frontend/src/metabase/account/notifications/containers/UnsubscribeAlertModal/UnsubscribeAlertModal.tsx@@ -45,7 +45,7 @@ export const UnsubscribeAlertModal = ({if (result.error) {sendToast({icon: "warning",- toastColor: "error",+ toastColor: "feedback-negative",message: t`An error occurred`,});return;diff --git a/frontend/src/metabase/actions/actions.ts b/frontend/src/metabase/actions/actions.tsindex 96b4d5f56f3..a2f53474b39 100644--- a/frontend/src/metabase/actions/actions.ts+++ b/frontend/src/metabase/actions/actions.ts@@ -26,7 +26,7 @@ export const executeAction =);const message = getActionExecutionMessage(action, result);- dispatch(addUndo({ message, toastColor: "success" }));+ dispatch(addUndo({ message, toastColor: "feedback-positive" }));return { success: true, message };} catch (error) {const message = getActionErrorMessage(error);diff --git a/frontend/src/metabase/actions/containers/ActionCreator/FormCreator/FormCreator.styled.tsx b/frontend/src/metabase/actions/containers/ActionCreator/FormCreator/FormCreator.styled.tsxindex be249dff673..38c84883271 100644--- a/frontend/src/metabase/actions/containers/ActionCreator/FormCreator/FormCreator.styled.tsx+++ b/frontend/src/metabase/actions/containers/ActionCreator/FormCreator/FormCreator.styled.tsx@@ -24,8 +24,8 @@ export const FieldSettingsButtonsContainer = styled.div`export const WarningBanner = styled.div`padding: var(--mantine-spacing-md);- border: 1px solid var(--mb-color-warning);+ border: 1px solid var(--mb-color-feedback-warning);border-radius: var(--mantine-spacing-sm);- background: ${() => alpha("warning", 0.1)};+ background: ${() => alpha("feedback-warning", 0.1)};line-height: 1.25rem;`;diff --git a/frontend/src/metabase/actions/containers/ActionCreator/FormCreator/OptionEditor.styled.tsx b/frontend/src/metabase/actions/containers/ActionCreator/FormCreator/OptionEditor.styled.tsxindex 29eb9c9cfab..d570b026c76 100644--- a/frontend/src/metabase/actions/containers/ActionCreator/FormCreator/OptionEditor.styled.tsx+++ b/frontend/src/metabase/actions/containers/ActionCreator/FormCreator/OptionEditor.styled.tsx@@ -20,7 +20,7 @@ export const AddMorePrompt = styled.div<{ isVisible: boolean }>`export const ErrorMessage = styled.div`text-align: center;font-size: 0.875rem;- color: var(--mb-color-error);+ color: var(--mb-color-feedback-negative);`;export const TextArea = styled.textarea`diff --git a/frontend/src/metabase/actions/utils.ts b/frontend/src/metabase/actions/utils.tsindex 4e8aef2a561..2e27637dfb5 100644--- a/frontend/src/metabase/actions/utils.ts+++ b/frontend/src/metabase/actions/utils.ts@@ -310,14 +310,15 @@ export const getSubmitButtonColor = (action: WritebackAction,): ButtonProps["color"] => {if (isImplicitDeleteAction(action)) {- return "error";+ return "feedback-negative";}return match(action.visualization_settings?.submitButtonColor).returnType<ButtonProps["color"]>()- .with("danger", () => "error")- .with("success", "warning", (color) => color)- .otherwise(() => "brand");+ .with("danger", () => "feedback-negative")+ .with("success", () => "feedback-positive")+ .with("warning", () => "feedback-warning")+ .otherwise(() => "core-brand");};export const getSubmitButtonLabel = (action: WritebackAction): string => {diff --git a/frontend/src/metabase/admin/ai/AIProviderSettingsSection.tsx b/frontend/src/metabase/admin/ai/AIProviderSettingsSection.tsxindex 9fae0696f45..5d4ddb86e93 100644--- a/frontend/src/metabase/admin/ai/AIProviderSettingsSection.tsx+++ b/frontend/src/metabase/admin/ai/AIProviderSettingsSection.tsx@@ -41,7 +41,11 @@ export function AIProviderSettingsSection({ id }: { id?: string }) {<Badgecirclesize="12"- bg={hasCredentialsError ? "error" : "success"}+ bg={+ hasCredentialsError+ ? "feedback-negative"+ : "feedback-positive"+ }mr="sm"/>)}diff --git a/frontend/src/metabase/admin/ai/MetabotAdminSuggestedPrompts.tsx b/frontend/src/metabase/admin/ai/MetabotAdminSuggestedPrompts.tsxindex 82fd0ddb08c..1a349a2892e 100644--- a/frontend/src/metabase/admin/ai/MetabotAdminSuggestedPrompts.tsx+++ b/frontend/src/metabase/admin/ai/MetabotAdminSuggestedPrompts.tsx@@ -163,7 +163,7 @@ export const MetabotPromptSuggestionPane = ({}emptyBody={error ? (- <Center my="lg" fw="bold" c="danger">+ <Center my="lg" fw="bold" c="feedback-negative">{t`Something went wrong.`}</Center>) : data?.total === 0 ? (diff --git a/frontend/src/metabase/admin/ai/MetabotSlackSetup.tsx b/frontend/src/metabase/admin/ai/MetabotSlackSetup.tsxindex 299bb79979e..030c112e097 100644--- a/frontend/src/metabase/admin/ai/MetabotSlackSetup.tsx+++ b/frontend/src/metabase/admin/ai/MetabotSlackSetup.tsx@@ -215,7 +215,10 @@ export function MetabotSlackSetup() {/></ConnectionDetails><Flex justify="flex-end">- <Button c="danger" onClick={handleOpen}>{t`Remove`}</Button>+ <Button+ c="feedback-negative"+ onClick={handleOpen}+ >{t`Remove`}</Button></Flex></>))diff --git a/frontend/src/metabase/admin/app/components/DeprecationNotice/DeprecationNotice.module.css b/frontend/src/metabase/admin/app/components/DeprecationNotice/DeprecationNotice.module.cssindex aae35bbb5a1..d44d03a44d4 100644--- a/frontend/src/metabase/admin/app/components/DeprecationNotice/DeprecationNotice.module.css+++ b/frontend/src/metabase/admin/app/components/DeprecationNotice/DeprecationNotice.module.css@@ -23,5 +23,5 @@}.NoticeCloseIcon:hover {- color: var(--mb-color-admin-navbar);+ color: var(--mb-color-navbar-admin);}diff --git a/frontend/src/metabase/admin/databases/components/DatabaseConnectionHealthInfo.tsx b/frontend/src/metabase/admin/databases/components/DatabaseConnectionHealthInfo.tsxindex 6f1df04f5e2..8b14cf2c3df 100644--- a/frontend/src/metabase/admin/databases/components/DatabaseConnectionHealthInfo.tsx+++ b/frontend/src/metabase/admin/databases/components/DatabaseConnectionHealthInfo.tsx@@ -26,7 +26,7 @@ export const DatabaseConnectionHealthInfo = ({return match(healthQuery).with({ currentData: { status: "ok" } },- () => ({ message: t`Connected`, color: "success" }) as const,+ () => ({ message: t`Connected`, color: "feedback-positive" }) as const,).with({ isUninitialized: true },@@ -40,7 +40,11 @@ export const DatabaseConnectionHealthInfo = ({).with({ currentData: { status: "error" } },- (q) => ({ message: q.currentData.message, color: "danger" }) as const,+ (q) =>+ ({+ message: q.currentData.message,+ color: "feedback-negative",+ }) as const,).with({ isError: true },diff --git a/frontend/src/metabase/admin/databases/components/DatabaseDangerZoneSection/DatabaseDangerZoneSection.tsx b/frontend/src/metabase/admin/databases/components/DatabaseDangerZoneSection/DatabaseDangerZoneSection.tsxindex a561a78672e..3fcdc747390 100644--- a/frontend/src/metabase/admin/databases/components/DatabaseDangerZoneSection/DatabaseDangerZoneSection.tsx+++ b/frontend/src/metabase/admin/databases/components/DatabaseDangerZoneSection/DatabaseDangerZoneSection.tsx@@ -54,7 +54,7 @@ export const DatabaseDangerZoneSection = ({<><Buttonvariant="filled"- color="danger"+ color="feedback-negative"onClick={saveFieldsModal.open}>{t`Discard saved field values`}</Button><ConfirmModal@@ -71,7 +71,7 @@ export const DatabaseDangerZoneSection = ({<><Buttonvariant="filled"- color="danger"+ color="feedback-negative"onClick={deleteDbModal.open}>{t`Remove this database`}</Button><DeleteDatabaseModaldiff --git a/frontend/src/metabase/admin/databases/components/DatabaseFeatureComponents/DatabaseFeatureComponents.module.css b/frontend/src/metabase/admin/databases/components/DatabaseFeatureComponents/DatabaseFeatureComponents.module.cssindex 243e132e0de..061daf95be0 100644--- a/frontend/src/metabase/admin/databases/components/DatabaseFeatureComponents/DatabaseFeatureComponents.module.css+++ b/frontend/src/metabase/admin/databases/components/DatabaseFeatureComponents/DatabaseFeatureComponents.module.css@@ -15,7 +15,7 @@.error {line-height: 1.4;margin-top: 0;- color: var(--mb-color-error);- border-left: 3px solid var(--mb-color-error);+ color: var(--mb-color-feedback-negative);+ border-left: 3px solid var(--mb-color-feedback-negative);padding-left: 12px;}diff --git a/frontend/src/metabase/admin/databases/components/DeleteDatabaseModel/DeleteDatabaseModal.tsx b/frontend/src/metabase/admin/databases/components/DeleteDatabaseModel/DeleteDatabaseModal.tsxindex aef0828379d..115a892ac2a 100644--- a/frontend/src/metabase/admin/databases/components/DeleteDatabaseModel/DeleteDatabaseModal.tsx+++ b/frontend/src/metabase/admin/databases/components/DeleteDatabaseModel/DeleteDatabaseModal.tsx@@ -188,13 +188,13 @@ export const DeleteDatabaseModal = ({</DeleteDatabaseModalSection><Flex gap="sm" justify="flex-end" align="center">{errorMessage && (- <Box c="error" px="md">+ <Box c="feedback-negative" px="md">{errorMessage}</Box>)}<Button type="button" onClick={onClose}>{t`Cancel`}</Button><Button- color="error"+ color="feedback-negative"variant="filled"type="submit"disabled={!canDelete}diff --git a/frontend/src/metabase/admin/datamodel/components/FormInput/FormInput.styled.tsx b/frontend/src/metabase/admin/datamodel/components/FormInput/FormInput.styled.tsxindex 2ae079f84e4..769624aabb9 100644--- a/frontend/src/metabase/admin/datamodel/components/FormInput/FormInput.styled.tsx+++ b/frontend/src/metabase/admin/datamodel/components/FormInput/FormInput.styled.tsx@@ -12,6 +12,7 @@ export const FormInputRoot = styled.input<FormInputRootProps>`width: 100%;&:not(:focus) {- border-color: ${(props) => props.touched && props.error && color("error")};+ border-color: ${(props) =>+ props.touched && props.error && color("feedback-negative")};}`;diff --git a/frontend/src/metabase/admin/datamodel/components/FormTextArea/FormTextArea.styled.tsx b/frontend/src/metabase/admin/datamodel/components/FormTextArea/FormTextArea.styled.tsxindex ac48429fb75..f5c8c5cd1f4 100644--- a/frontend/src/metabase/admin/datamodel/components/FormTextArea/FormTextArea.styled.tsx+++ b/frontend/src/metabase/admin/datamodel/components/FormTextArea/FormTextArea.styled.tsx@@ -12,6 +12,7 @@ export const FormTextAreaRoot = styled.textarea<FormTextAreaRootProps>`width: 100%;&:not(:focus) {- border-color: ${(props) => props.touched && props.error && color("error")};+ border-color: ${(props) =>+ props.touched && props.error && color("feedback-negative")};}`;diff --git a/frontend/src/metabase/admin/datamodel/components/SegmentActionSelect.module.css b/frontend/src/metabase/admin/datamodel/components/SegmentActionSelect.module.cssindex fd9930f94df..1197f016c8a 100644--- a/frontend/src/metabase/admin/datamodel/components/SegmentActionSelect.module.css+++ b/frontend/src/metabase/admin/datamodel/components/SegmentActionSelect.module.css@@ -1,9 +1,9 @@.dangerItem {- color: var(--mb-color-error);+ color: var(--mb-color-feedback-negative);}/* double classname for specificity */.dangerItem.dangerItem:hover {- background-color: var(--mb-color-error);+ background-color: var(--mb-color-feedback-negative);color: var(--mb-color-text-primary-inverse);}diff --git a/frontend/src/metabase/admin/datamodel/components/SegmentRetireModal.tsx b/frontend/src/metabase/admin/datamodel/components/SegmentRetireModal.tsxindex 3ddfff099cb..2055796c096 100644--- a/frontend/src/metabase/admin/datamodel/components/SegmentRetireModal.tsx+++ b/frontend/src/metabase/admin/datamodel/components/SegmentRetireModal.tsx@@ -31,7 +31,11 @@ export function SegmentRetireModal({</Text><Flex justify="flex-end" gap="sm"><Button onClick={onClose}>{t`Cancel`}</Button>- <Button color="danger" variant="filled" onClick={handleRetire}>+ <Button+ color="feedback-negative"+ variant="filled"+ onClick={handleRetire}+ >{t`Retire`}</Button></Flex>diff --git a/frontend/src/metabase/admin/embedding/components/ThemeEditor/EditorPanel.tsx b/frontend/src/metabase/admin/embedding/components/ThemeEditor/EditorPanel.tsxindex 25b3f8f54b1..e40fe1f087e 100644--- a/frontend/src/metabase/admin/embedding/components/ThemeEditor/EditorPanel.tsx+++ b/frontend/src/metabase/admin/embedding/components/ThemeEditor/EditorPanel.tsx@@ -249,7 +249,7 @@ export function EditorPanel({<Buttonmt="lg"variant="subtle"- color="error"+ color="feedback-negative"px={0}leftSection={<Icon name="trash" size={16} />}onClick={onDelete}diff --git a/frontend/src/metabase/admin/embedding/components/ThemeListing/DeleteThemeModal.tsx b/frontend/src/metabase/admin/embedding/components/ThemeListing/DeleteThemeModal.tsxindex 085d35b63f9..21aff1fdb75 100644--- a/frontend/src/metabase/admin/embedding/components/ThemeListing/DeleteThemeModal.tsx+++ b/frontend/src/metabase/admin/embedding/components/ThemeListing/DeleteThemeModal.tsx@@ -23,7 +23,7 @@ export function DeleteThemeModal({{t`Cancel`}</Button>- <Button variant="filled" color="error" onClick={onDelete}>+ <Button variant="filled" color="feedback-negative" onClick={onDelete}>{t`Delete`}</Button></Flex>diff --git a/frontend/src/metabase/admin/embedding/components/ThemeListing/EmbeddingThemeCard.tsx b/frontend/src/metabase/admin/embedding/components/ThemeListing/EmbeddingThemeCard.tsxindex f89c5130f5d..33cd6ba879c 100644--- a/frontend/src/metabase/admin/embedding/components/ThemeListing/EmbeddingThemeCard.tsx+++ b/frontend/src/metabase/admin/embedding/components/ThemeListing/EmbeddingThemeCard.tsx@@ -83,7 +83,7 @@ const EmbeddingThemeActionMenu = ({</Menu.Item><Menu.Item- c="error"+ c="feedback-negative"onClick={(e: React.MouseEvent) => {e.stopPropagation();onDelete(theme.id);diff --git a/frontend/src/metabase/admin/people/colors.ts b/frontend/src/metabase/admin/people/colors.tsindex a0072991b9d..bf7d3680fce 100644--- a/frontend/src/metabase/admin/people/colors.ts+++ b/frontend/src/metabase/admin/people/colors.ts@@ -6,7 +6,7 @@ export const userToColor = (user: User) => {};const groupColorPalette = [- color("error"),+ color("feedback-negative"),color("accent2"),color("core-brand"),color("accent4"),diff --git a/frontend/src/metabase/admin/people/components/GroupsListing.tsx b/frontend/src/metabase/admin/people/components/GroupsListing.tsxindex 455fd3d8978..bc24921fc4b 100644--- a/frontend/src/metabase/admin/people/components/GroupsListing.tsx+++ b/frontend/src/metabase/admin/people/components/GroupsListing.tsx@@ -154,7 +154,7 @@ function ActionsPopover({<Menu.Item onClick={() => onEditGroupClicked(group)}>{t`Edit Name`}</Menu.Item>- <Menu.Item c="danger" onClick={openModal}>+ <Menu.Item c="feedback-negative" onClick={openModal}>{t`Remove Group`}</Menu.Item></Menu.Dropdown>diff --git a/frontend/src/metabase/admin/people/components/PeopleListRow.tsx b/frontend/src/metabase/admin/people/components/PeopleListRow.tsxindex e5f0e362f7c..488d73f820b 100644--- a/frontend/src/metabase/admin/people/components/PeopleListRow.tsx+++ b/frontend/src/metabase/admin/people/components/PeopleListRow.tsx@@ -162,7 +162,7 @@ export const PeopleListRow = ({<Menu.Itemcomponent={ForwardRefLink}to={Urls.deactivateUser(user)}- c="danger"+ c="feedback-negative">{t`Deactivate user`}</Menu.Item>diff --git a/frontend/src/metabase/admin/people/containers/UserPasswordResetModal.tsx b/frontend/src/metabase/admin/people/containers/UserPasswordResetModal.tsxindex 6726d619c85..454a2dbeed2 100644--- a/frontend/src/metabase/admin/people/containers/UserPasswordResetModal.tsx+++ b/frontend/src/metabase/admin/people/containers/UserPasswordResetModal.tsx@@ -134,7 +134,7 @@ const UserPasswordResetModalInner = ({onClick={handleGetResetLink}>{t`Get reset link`}</Button><Button- color="danger"+ color="feedback-negative"variant="filled"onClick={handleResetConfirm}>{t`Reset password`}</Button>diff --git a/frontend/src/metabase/admin/performance/components/ModelPersistenceConfiguration.tsx b/frontend/src/metabase/admin/performance/components/ModelPersistenceConfiguration.tsxindex 0d855903cdd..9a5956ec29d 100644--- a/frontend/src/metabase/admin/performance/components/ModelPersistenceConfiguration.tsx+++ b/frontend/src/metabase/admin/performance/components/ModelPersistenceConfiguration.tsx@@ -96,7 +96,7 @@ export const ModelPersistenceConfiguration = () => {} catch (e) {sendToast({icon: "warning",- toastColor: "error",+ toastColor: "feedback-negative",message: t`An error occurred`,});} finally {diff --git a/frontend/src/metabase/admin/performance/hooks/useInvalidateTarget.tsx b/frontend/src/metabase/admin/performance/hooks/useInvalidateTarget.tsxindex cb005645af1..01b83eaf518 100644--- a/frontend/src/metabase/admin/performance/hooks/useInvalidateTarget.tsx+++ b/frontend/src/metabase/admin/performance/hooks/useInvalidateTarget.tsx@@ -35,7 +35,7 @@ export const useInvalidateTarget = (addUndo({icon: "warning",message: e.data.message,- toastColor: "error",+ toastColor: "feedback-negative",dismissIconColor: "text-primary-inverse",}),);diff --git a/frontend/src/metabase/admin/permissions/components/CollectionPermissionsHelp/CollectionPermissionsHelp.tsx b/frontend/src/metabase/admin/permissions/components/CollectionPermissionsHelp/CollectionPermissionsHelp.tsxindex 35e29b56fe1..c3065b9bbc1 100644--- a/frontend/src/metabase/admin/permissions/components/CollectionPermissionsHelp/CollectionPermissionsHelp.tsx+++ b/frontend/src/metabase/admin/permissions/components/CollectionPermissionsHelp/CollectionPermissionsHelp.tsx@@ -18,21 +18,21 @@ export const CollectionPermissionsHelp = () => {<Stack gap={16} mt="1rem"><PermissionHelpDescriptionicon="check"- iconColor="success"+ iconColor="feedback-positive"name={t`Curate`}description={t`The group can view, save, edit, pin, and archive items in the collection.`}/><PermissionHelpDescriptionicon="permissions_limited"- iconColor="warning"+ iconColor="feedback-warning"name={t`View`}description={t`The group can view items in a collection.`}/><PermissionHelpDescriptionicon="close"- iconColor="error"+ iconColor="feedback-negative"name={t`No access`}description={t`The group won't even see the collection listed.`}/>diff --git a/frontend/src/metabase/admin/permissions/components/DataPermissionsHelp/DataPermissionsHelp.tsx b/frontend/src/metabase/admin/permissions/components/DataPermissionsHelp/DataPermissionsHelp.tsxindex c217af72c5b..0c8273ea3a3 100644--- a/frontend/src/metabase/admin/permissions/components/DataPermissionsHelp/DataPermissionsHelp.tsx+++ b/frontend/src/metabase/admin/permissions/components/DataPermissionsHelp/DataPermissionsHelp.tsx@@ -54,19 +54,19 @@ export const DataPermissionsHelp = () => {<Stack gap="1rem" py="1rem"><PermissionHelpDescriptionicon="eye"- iconColor="success"+ iconColor="feedback-positive"name={t`Can view`}description={t`The group can view all data for that database.`}/><PermissionHelpDescriptionicon="permissions_limited"- iconColor="warning"+ iconColor="feedback-warning"name={t`Granular`}description={t`The group can view select schemas and tables. Can be combined with user attributes to enable row and column security to control what data each person can view.`}/><PermissionHelpDescriptionicon="database"- iconColor="warning"+ iconColor="feedback-warning"name={t`Impersonated (Pro)`}description={t`The group can view data based on the database role you specify with a user attribute (manually or via SSO).`}/>@@ -80,7 +80,7 @@ export const DataPermissionsHelp = () => {)}<PermissionHelpDescriptionicon="close"- iconColor="danger"+ iconColor="feedback-negative"name={t`Blocked (Pro)`}description={t`The group cannot view any data from the data source, even if they have collection access to view questions or dashboards that draw from that data.`}/>@@ -97,7 +97,7 @@ export const DataPermissionsHelp = () => {<Stack gap="1rem" py="1rem"><PermissionHelpDescriptionicon="check"- iconColor="success"+ iconColor="feedback-positive"name={t`Can view`}description={t`The group can view all data for that schema or table.`}/>@@ -117,7 +117,7 @@ export const DataPermissionsHelp = () => {/><PermissionHelpDescriptionicon="close"- iconColor="danger"+ iconColor="feedback-negative"name={t`Blocked (Pro)`}description={<>@@ -152,26 +152,26 @@ export const DataPermissionsHelp = () => {<Stack gap="1rem" py="1rem"><PermissionHelpDescriptionicon="check"- iconColor="success"+ iconColor="feedback-positive"name={t`Query builder and native`}description={t`The group can use both the query builder and the native code editor to create questions and models.`}/><PermissionHelpDescriptionicon="permissions_limited"- iconColor="warning"+ iconColor="feedback-warning"name={t`Query builder only`}description={t`The group can use the query builder to create questions and models.`}/><PermissionHelpDescriptionicon="permissions_limited"- iconColor="warning"+ iconColor="feedback-warning"name={t`Granular`}description={t`The group can use the query builder to create questions and models for select schemas and tables.`}/><PermissionHelpDescriptionicon="close"- iconColor="danger"+ iconColor="feedback-negative"name={t`No`}description={t`The group cannot create or edit questions, including drill-through.`}/>diff --git a/frontend/src/metabase/admin/permissions/components/FilterableTree/FilterableTree.styled.tsx b/frontend/src/metabase/admin/permissions/components/FilterableTree/FilterableTree.styled.tsxindex a7abe428411..26c51bc4fd2 100644--- a/frontend/src/metabase/admin/permissions/components/FilterableTree/FilterableTree.styled.tsx+++ b/frontend/src/metabase/admin/permissions/components/FilterableTree/FilterableTree.styled.tsx@@ -34,12 +34,12 @@ export const AdminTreeNode = styled(Tree.Node)`// user whitelabelling, this is somewhat safe (and consistent with what is in the admin header nav)props.isSelected ? "var(--mantine-color-white)" : color("text-secondary")};background-color: ${(props) =>- props.isSelected ? color("admin-navbar") : "unset"};+ props.isSelected ? color("navbar-admin") : "unset"};&:hover {background-color: ${(props) =>props.isSelected- ? color("admin-navbar")- : color("admin-navbar-secondary")};+ ? color("navbar-admin")+ : color("navbar-admin-secondary")};}`;diff --git a/frontend/src/metabase/admin/permissions/components/PermissionsSelect/PermissionsSelect.unit.spec.tsx b/frontend/src/metabase/admin/permissions/components/PermissionsSelect/PermissionsSelect.unit.spec.tsxindex 12300f7dccf..ee76c0ec444 100644--- a/frontend/src/metabase/admin/permissions/components/PermissionsSelect/PermissionsSelect.unit.spec.tsx+++ b/frontend/src/metabase/admin/permissions/components/PermissionsSelect/PermissionsSelect.unit.spec.tsx@@ -16,7 +16,7 @@ const options: PermissionOption[] = [label: "Allowed",value: DataPermissionValue.ALL,icon: "check",- iconColor: "success",+ iconColor: "feedback-positive",},{label: "Limited",@@ -28,7 +28,7 @@ const options: PermissionOption[] = [label: "No access",value: DataPermissionValue.NONE,icon: "close",- iconColor: "warning",+ iconColor: "feedback-warning",},];diff --git a/frontend/src/metabase/admin/permissions/components/PermissionsTable/PermissionsTable.styled.tsx b/frontend/src/metabase/admin/permissions/components/PermissionsTable/PermissionsTable.styled.tsxindex 7ac5d78f716..bcc3e0cdc61 100644--- a/frontend/src/metabase/admin/permissions/components/PermissionsTable/PermissionsTable.styled.tsx+++ b/frontend/src/metabase/admin/permissions/components/PermissionsTable/PermissionsTable.styled.tsx@@ -82,7 +82,7 @@ export const EntityNameLink = styled(Link)`display: inline;font-weight: 700;text-decoration: underline;- color: ${() => color("admin-navbar-inverse")};+ color: ${() => color("navbar-admin-inverse")};`;export const HintIcon = styled(diff --git a/frontend/src/metabase/admin/permissions/constants/collections-permissions.ts b/frontend/src/metabase/admin/permissions/constants/collections-permissions.tsindex b24638b51e5..ca5887d41c4 100644--- a/frontend/src/metabase/admin/permissions/constants/collections-permissions.ts+++ b/frontend/src/metabase/admin/permissions/constants/collections-permissions.ts@@ -8,18 +8,18 @@ export const COLLECTION_OPTIONS: Record<string, PermissionOption> = {label: t`Curate`,value: DataPermissionValue.WRITE,icon: "check",- iconColor: "success",+ iconColor: "feedback-positive",},read: {label: t`View`,value: DataPermissionValue.READ,icon: "eye",- iconColor: "warning",+ iconColor: "feedback-warning",},none: {label: t`No access`,value: DataPermissionValue.NONE,icon: "close",- iconColor: "danger",+ iconColor: "feedback-negative",},};diff --git a/frontend/src/metabase/admin/permissions/constants/data-permissions.tsx b/frontend/src/metabase/admin/permissions/constants/data-permissions.tsxindex e83b3d30bd2..5050e3b6fce 100644--- a/frontend/src/metabase/admin/permissions/constants/data-permissions.tsx+++ b/frontend/src/metabase/admin/permissions/constants/data-permissions.tsx@@ -8,13 +8,13 @@ export const DATA_PERMISSION_OPTIONS: Record<string, PermissionOption> = {label: t`Can view`,value: DataPermissionValue.UNRESTRICTED,icon: "eye",- iconColor: "success",+ iconColor: "feedback-positive",},controlled: {label: t`Granular`,value: DataPermissionValue.CONTROLLED,icon: "permissions_limited",- iconColor: "warning",+ iconColor: "feedback-warning",},noSelfServiceDeprecated: {label: t`No self-service (Deprecated)`,@@ -26,18 +26,18 @@ export const DATA_PERMISSION_OPTIONS: Record<string, PermissionOption> = {label: t`No`,value: DataPermissionValue.NO,icon: "close",- iconColor: "danger",+ iconColor: "feedback-negative",},queryBuilder: {label: t`Query builder only`,value: DataPermissionValue.QUERY_BUILDER,icon: "permissions_limited",- iconColor: "warning",+ iconColor: "feedback-warning",},queryBuilderAndNative: {label: t`Query builder and native`,value: DataPermissionValue.QUERY_BUILDER_AND_NATIVE,icon: "check",- iconColor: "success",+ iconColor: "feedback-positive",},};diff --git a/frontend/src/metabase/admin/permissions/selectors/data-permissions/group-sidebar.unit.spec.ts b/frontend/src/metabase/admin/permissions/selectors/data-permissions/group-sidebar.unit.spec.tsindex 7c81c14ac5f..0af2ac98661 100644--- a/frontend/src/metabase/admin/permissions/selectors/data-permissions/group-sidebar.unit.spec.ts+++ b/frontend/src/metabase/admin/permissions/selectors/data-permissions/group-sidebar.unit.spec.ts@@ -76,13 +76,13 @@ describe("getGroupsDataPermissionEditor", () => {expect(accessPermission.options).toEqual([{icon: "eye",- iconColor: "success",+ iconColor: "feedback-positive",label: "Can view",value: DataPermissionValue.UNRESTRICTED,},{icon: "permissions_limited",- iconColor: "warning",+ iconColor: "feedback-warning",label: "Granular",value: DataPermissionValue.CONTROLLED,},@@ -102,25 +102,25 @@ describe("getGroupsDataPermissionEditor", () => {label: `Query builder and native`,value: DataPermissionValue.QUERY_BUILDER_AND_NATIVE,icon: "check",- iconColor: "success",+ iconColor: "feedback-positive",},{label: `Query builder only`,value: DataPermissionValue.QUERY_BUILDER,icon: "permissions_limited",- iconColor: "warning",+ iconColor: "feedback-warning",},{label: `Granular`,value: DataPermissionValue.CONTROLLED,icon: "permissions_limited",- iconColor: "warning",+ iconColor: "feedback-warning",},{label: `No`,value: DataPermissionValue.NO,icon: "close",- iconColor: "danger",+ iconColor: "feedback-negative",},]);diff --git a/frontend/src/metabase/admin/settings/auth/components/AuthCard/AuthCard.styled.tsx b/frontend/src/metabase/admin/settings/auth/components/AuthCard/AuthCard.styled.tsxindex 7cbe2b3a259..05fd590cee8 100644--- a/frontend/src/metabase/admin/settings/auth/components/AuthCard/AuthCard.styled.tsx+++ b/frontend/src/metabase/admin/settings/auth/components/AuthCard/AuthCard.styled.tsx@@ -35,7 +35,7 @@ interface CardBadgeProps {export const CardBadge = styled.div<CardBadgeProps>`color: ${(props) =>- props.isEnabled ? color("core-brand") : color("danger")};+ props.isEnabled ? color("core-brand") : color("feedback-negative")};background-color: ${(props) =>props.isEnabled? "var(--mb-color-background_surface-brand-subtle)"diff --git a/frontend/src/metabase/admin/settings/components/ApiKeys/DeleteApiKeyModal.tsx b/frontend/src/metabase/admin/settings/components/ApiKeys/DeleteApiKeyModal.tsxindex 460a37404e4..c3aaaf6cbe7 100644--- a/frontend/src/metabase/admin/settings/components/ApiKeys/DeleteApiKeyModal.tsx+++ b/frontend/src/metabase/admin/settings/components/ApiKeys/DeleteApiKeyModal.tsx@@ -34,13 +34,13 @@ export const DeleteApiKeyModal = ({<FormErrorMessage /><Group justify="flex-end"><Button- color="error"+ color="feedback-negative"onClick={onClose}>{t`No, don't delete`}</Button><FormSubmitButtonlabel={t`Delete API key`}variant="filled"- color="error"+ color="feedback-negative"/></Group></Stack>diff --git a/frontend/src/metabase/admin/settings/components/CloudPanel/MigrationCreationError.tsx b/frontend/src/metabase/admin/settings/components/CloudPanel/MigrationCreationError.tsxindex d30bd2cf4e3..337ed0cdd9d 100644--- a/frontend/src/metabase/admin/settings/components/CloudPanel/MigrationCreationError.tsx+++ b/frontend/src/metabase/admin/settings/components/CloudPanel/MigrationCreationError.tsx@@ -16,7 +16,7 @@ export const MigrationCreationError = ({return (<MigrationCard><Flex gap="md">- <LargeIconContainer color={color("error")}>+ <LargeIconContainer color={color("feedback-negative")}><Icon size="1.5rem" name="warning" /></LargeIconContainer><Box>diff --git a/frontend/src/metabase/admin/settings/components/CloudPanel/MigrationError.tsx b/frontend/src/metabase/admin/settings/components/CloudPanel/MigrationError.tsxindex 7a7578e1e17..d6e7a42948b 100644--- a/frontend/src/metabase/admin/settings/components/CloudPanel/MigrationError.tsx+++ b/frontend/src/metabase/admin/settings/components/CloudPanel/MigrationError.tsx@@ -25,7 +25,7 @@ export const MigrationError = ({<><MigrationCard><Flex gap="md">- <LargeIconContainer color={color("error")}>+ <LargeIconContainer color={color("feedback-negative")}><Icon size="1.5rem" name="warning" /></LargeIconContainer><Box>diff --git a/frontend/src/metabase/admin/settings/components/CloudPanel/MigrationInProgress.tsx b/frontend/src/metabase/admin/settings/components/CloudPanel/MigrationInProgress.tsxindex 76de96a8b57..0b97d8a899e 100644--- a/frontend/src/metabase/admin/settings/components/CloudPanel/MigrationInProgress.tsx+++ b/frontend/src/metabase/admin/settings/components/CloudPanel/MigrationInProgress.tsx@@ -98,7 +98,7 @@ export const MigrationInProgress = ({<Buttonmt="md"onClick={openModal}- c="error"+ c="feedback-negative">{t`Cancel migration`}</Button><Buttonmt="md"@@ -123,7 +123,7 @@ export const MigrationInProgress = ({<Flex justify="end" mt="3.5rem"><Buttonvariant="filled"- color="error"+ color="feedback-negative"onClick={handleCancelMigration}>{t`Cancel migration`}</Button></Flex>diff --git a/frontend/src/metabase/admin/settings/components/CloudPanel/MigrationSuccess.tsx b/frontend/src/metabase/admin/settings/components/CloudPanel/MigrationSuccess.tsxindex a2991e09776..f6446023574 100644--- a/frontend/src/metabase/admin/settings/components/CloudPanel/MigrationSuccess.tsx+++ b/frontend/src/metabase/admin/settings/components/CloudPanel/MigrationSuccess.tsx@@ -31,7 +31,7 @@ export const MigrationSuccess = ({<><MigrationCard><Flex gap="md">- <LargeIconContainer color={color("success")}>+ <LargeIconContainer color={color("feedback-positive")}><Icon size="1.5rem" name="check" /></LargeIconContainer>diff --git a/frontend/src/metabase/admin/settings/components/Email/BaseSMTPConnectionForm.tsx b/frontend/src/metabase/admin/settings/components/Email/BaseSMTPConnectionForm.tsxindex 7725024f3d0..4ba402b3326 100644--- a/frontend/src/metabase/admin/settings/components/Email/BaseSMTPConnectionForm.tsx+++ b/frontend/src/metabase/admin/settings/components/Email/BaseSMTPConnectionForm.tsx@@ -124,7 +124,7 @@ export const BaseSMTPConnectionForm = ({if (result.error) {sendToast({icon: "warning",- toastColor: "error",+ toastColor: "feedback-negative",message: isErrorWithMessage(result.error)? result.error.data.message: t`Error clearing email settings`,@@ -151,7 +151,7 @@ export const BaseSMTPConnectionForm = ({} catch (error) {sendToast({icon: "warning",- toastColor: "error",+ toastColor: "feedback-negative",message: getErrorMessage(error, t`Error updating email settings`),});diff --git a/frontend/src/metabase/admin/settings/components/UploadSettings/UploadSettingsForm.tsx b/frontend/src/metabase/admin/settings/components/UploadSettings/UploadSettingsForm.tsxindex 32f3ddcc235..3d10ad9fff8 100644--- a/frontend/src/metabase/admin/settings/components/UploadSettings/UploadSettingsForm.tsx+++ b/frontend/src/metabase/admin/settings/components/UploadSettings/UploadSettingsForm.tsx@@ -253,7 +253,7 @@ export function UploadSettingsFormView({actionFn={handleDisableUploads}type="button"variant="filled"- color="error"+ color="feedback-negative"useLoadingSpinner/>)@@ -275,7 +275,7 @@ export function UploadSettingsFormView({</Flex>{!hasValidDatabases && <NoValidDatabasesMessage />}{errorMessage && (- <Text c="danger" mt="md">+ <Text c="feedback-negative" mt="md">{errorMessage}</Text>)}diff --git a/frontend/src/metabase/admin/settings/components/widgets/CustomGeoJSONWidget.tsx b/frontend/src/metabase/admin/settings/components/widgets/CustomGeoJSONWidget.tsxindex 42ff008f15f..730a8e5dabc 100644--- a/frontend/src/metabase/admin/settings/components/widgets/CustomGeoJSONWidget.tsx+++ b/frontend/src/metabase/admin/settings/components/widgets/CustomGeoJSONWidget.tsx@@ -228,7 +228,7 @@ const ListMaps = ({ maps, onEditMap, onDeleteMap }: ListMapsProps) => {<td className={AdminS.TableActions}><Buttonvariant="filled"- color="danger"+ color="feedback-negative"onClick={() => setMapIdToDelete(mapId)}>{t`Remove`}</Button></td>diff --git a/frontend/src/metabase/admin/settings/components/widgets/GroupMappingsWidget/DeleteGroupMappingModal/DeleteGroupMappingModal.tsx b/frontend/src/metabase/admin/settings/components/widgets/GroupMappingsWidget/DeleteGroupMappingModal/DeleteGroupMappingModal.tsxindex 85b18986e98..01392ed6ab9 100644--- a/frontend/src/metabase/admin/settings/components/widgets/GroupMappingsWidget/DeleteGroupMappingModal/DeleteGroupMappingModal.tsx+++ b/frontend/src/metabase/admin/settings/components/widgets/GroupMappingsWidget/DeleteGroupMappingModal/DeleteGroupMappingModal.tsx@@ -89,7 +89,11 @@ export const DeleteGroupMappingModal = ({<Group justify="flex-end"><Button onClick={onHide}>{t`Cancel`}</Button>- <Button variant="filled" color="error" onClick={handleConfirm}>+ <Button+ variant="filled"+ color="feedback-negative"+ onClick={handleConfirm}+ >{submitButtonLabels[value]}</Button></Group>diff --git a/frontend/src/metabase/admin/settings/components/widgets/GroupMappingsWidget/GroupMappingsWidgetView.tsx b/frontend/src/metabase/admin/settings/components/widgets/GroupMappingsWidget/GroupMappingsWidgetView.tsxindex 320d41ecb5e..d19bafd929e 100644--- a/frontend/src/metabase/admin/settings/components/widgets/GroupMappingsWidget/GroupMappingsWidgetView.tsx+++ b/frontend/src/metabase/admin/settings/components/widgets/GroupMappingsWidget/GroupMappingsWidgetView.tsx@@ -231,7 +231,7 @@ export function GroupMappingsWidgetView({)}</Flex>{saveError && (- <Text c="error" fw="bold" m="sm">+ <Text c="feedback-negative" fw="bold" m="sm">{saveError}</Text>)}diff --git a/frontend/src/metabase/admin/settings/components/widgets/GroupMappingsWidget/MappingRow/MappingRow.module.css b/frontend/src/metabase/admin/settings/components/widgets/GroupMappingsWidget/MappingRow/MappingRow.module.cssindex 9bedf8036e7..5de311a61ae 100644--- a/frontend/src/metabase/admin/settings/components/widgets/GroupMappingsWidget/MappingRow/MappingRow.module.css+++ b/frontend/src/metabase/admin/settings/components/widgets/GroupMappingsWidget/MappingRow/MappingRow.module.css@@ -3,5 +3,5 @@}.deleteButton:hover {- color: var(--mb-color-danger);+ color: var(--mb-color-feedback-negative);}diff --git a/frontend/src/metabase/admin/settings/components/widgets/SendTestEmailWidget.tsx b/frontend/src/metabase/admin/settings/components/widgets/SendTestEmailWidget.tsxindex a3441664cd1..782a16732e3 100644--- a/frontend/src/metabase/admin/settings/components/widgets/SendTestEmailWidget.tsx+++ b/frontend/src/metabase/admin/settings/components/widgets/SendTestEmailWidget.tsx@@ -20,12 +20,12 @@ export function SendTestEmailWidget() {await sendTestEmail().unwrap();sendToast({message: t`Email sent!`,- toastColor: "success",+ toastColor: "feedback-positive",});} catch (error) {sendToast({icon: "warning",- toastColor: "error",+ toastColor: "feedback-negative",message: getTestEmailErrorMessage(error),});}@@ -37,7 +37,7 @@ export function SendTestEmailWidget() {<Textrole="alert"aria-label={getTestEmailErrorMessage(sendTestEmailResult.error)}- color="error"+ color="feedback-negative"mb="1rem">{getTestEmailErrorMessage(sendTestEmailResult.error)}diff --git a/frontend/src/metabase/admin/settings/components/widgets/SiteUrlWidget.tsx b/frontend/src/metabase/admin/settings/components/widgets/SiteUrlWidget.tsxindex 5f6b4de2335..d62feba70a1 100644--- a/frontend/src/metabase/admin/settings/components/widgets/SiteUrlWidget.tsx+++ b/frontend/src/metabase/admin/settings/components/widgets/SiteUrlWidget.tsx@@ -57,7 +57,7 @@ export function SiteUrlWidget() {placeholder={"http://example.com"}/>{errorMessage && (- <Text size="sm" color="danger" mt="sm">+ <Text size="sm" color="feedback-negative" mt="sm">{errorMessage}</Text>)}diff --git a/frontend/src/metabase/admin/settings/slack/SlackBugReportChannelInput.tsx b/frontend/src/metabase/admin/settings/slack/SlackBugReportChannelInput.tsxindex 6c99a964336..4179f54875a 100644--- a/frontend/src/metabase/admin/settings/slack/SlackBugReportChannelInput.tsx+++ b/frontend/src/metabase/admin/settings/slack/SlackBugReportChannelInput.tsx@@ -36,7 +36,7 @@ export const SlackBugReportChannelInput = () => {await updateSlackSettings({ "slack-bug-report-channel": value }).unwrap();sendToast({message: t`Slack bug report channel updated`,- toastColor: "success",+ toastColor: "feedback-positive",});} catch (err) {setError(getSlackError(err));diff --git a/frontend/src/metabase/admin/settings/slack/SlackSetup.tsx b/frontend/src/metabase/admin/settings/slack/SlackSetup.tsxindex aad3d58e3e4..3da748058a3 100644--- a/frontend/src/metabase/admin/settings/slack/SlackSetup.tsx+++ b/frontend/src/metabase/admin/settings/slack/SlackSetup.tsx@@ -54,7 +54,7 @@ const SlackConnectionStatus = ({<Badgecirclesize="12"- bg={isValid ? "success" : "error"}+ bg={isValid ? "feedback-positive" : "feedback-negative"}style={{ flexShrink: 0 }}/><Text>@@ -85,7 +85,10 @@ const SlackConnectionStatus = ({)}</Flex>- <Button c="danger" onClick={handleOpen}>{t`Disconnect`}</Button>+ <Button+ c="feedback-negative"+ onClick={handleOpen}+ >{t`Disconnect`}</Button></Flex><ConfirmModalopened={isOpened}diff --git a/frontend/src/metabase/api/utils/settings.ts b/frontend/src/metabase/api/utils/settings.tsindex 39204446b81..baf8cff5322 100644--- a/frontend/src/metabase/api/utils/settings.ts+++ b/frontend/src/metabase/api/utils/settings.ts@@ -62,7 +62,11 @@ export const useAdminSetting = <SettingName extends EnterpriseSettingKey>(if (response.error) {const message = getErrorMessage(response.error, t`Error saving ${key}`);- sendToast({ message, icon: "warning", toastColor: "danger" });+ sendToast({+ message,+ icon: "warning",+ toastColor: "feedback-negative",+ });} else {sendToast({ message: t`Changes saved` });}@@ -89,7 +93,11 @@ export const useAdminSetting = <SettingName extends EnterpriseSettingKey>((response.error as { data?: { message: string } })?.data?.message ||t`Error saving settings`;- sendToast({ message, icon: "warning", toastColor: "danger" });+ sendToast({+ message,+ icon: "warning",+ toastColor: "feedback-negative",+ });} else {sendToast({ message: t`Changes saved`, icon: "check_filled" });}@@ -148,7 +156,11 @@ export const useAdminSettings = <(response.error as { data?: { message: string } })?.data?.message ||t`Error saving settings`;- sendToast({ message, icon: "warning", toastColor: "danger" });+ sendToast({+ message,+ icon: "warning",+ toastColor: "feedback-negative",+ });} else {sendToast({ message: t`Changes saved`, icon: "check_filled" });}diff --git a/frontend/src/metabase/archive/components/ArchivedEntityBanner/ArchivedEntityBanner.tsx b/frontend/src/metabase/archive/components/ArchivedEntityBanner/ArchivedEntityBanner.tsxindex 88d4bdcf70a..8cac1fc5cd1 100644--- a/frontend/src/metabase/archive/components/ArchivedEntityBanner/ArchivedEntityBanner.tsx+++ b/frontend/src/metabase/archive/components/ArchivedEntityBanner/ArchivedEntityBanner.tsx@@ -40,7 +40,7 @@ export const ArchivedEntityBanner = ({<Boxpx="1.5rem"py=".75rem"- bg="error"+ bg="feedback-negative"w="100%"data-testid="archive-banner">diff --git a/frontend/src/metabase/auth/components/AuthButton/AuthButton.styled.tsx b/frontend/src/metabase/auth/components/AuthButton/AuthButton.styled.tsxindex d1253f4a78c..42b8b878bd7 100644--- a/frontend/src/metabase/auth/components/AuthButton/AuthButton.styled.tsx+++ b/frontend/src/metabase/auth/components/AuthButton/AuthButton.styled.tsx@@ -18,7 +18,7 @@ export const CardLink = styled(TextLink)`align-items: center;padding: 1.25rem;background-color: var(--mb-color-background_page-primary);- box-shadow: 0 3px 10px var(--mb-color-shadow);+ box-shadow: 0 3px 10px var(--mb-color-shadow-default);border-radius: 6px;`;diff --git a/frontend/src/metabase/auth/components/AuthLayout/AuthLayout.styled.tsx b/frontend/src/metabase/auth/components/AuthLayout/AuthLayout.styled.tsxindex b611751e2b5..0c00e1449bd 100644--- a/frontend/src/metabase/auth/components/AuthLayout/AuthLayout.styled.tsx+++ b/frontend/src/metabase/auth/components/AuthLayout/AuthLayout.styled.tsx@@ -24,7 +24,7 @@ export const LayoutCard = styled.div`margin-top: 1.5rem;padding: 2.5rem 1.5rem;background-color: var(--mb-color-background_page-primary);- box-shadow: 0 1px 15px var(--mb-color-shadow);+ box-shadow: 0 1px 15px var(--mb-color-shadow-default);border-radius: 6px;${breakpointMinSmall} {diff --git a/frontend/src/metabase/auth/components/GoogleButton/GoogleButton.tsx b/frontend/src/metabase/auth/components/GoogleButton/GoogleButton.tsxindex 885065662e4..2d23285a7d4 100644--- a/frontend/src/metabase/auth/components/GoogleButton/GoogleButton.tsx+++ b/frontend/src/metabase/auth/components/GoogleButton/GoogleButton.tsx@@ -95,7 +95,7 @@ export const GoogleButton = ({ redirectUrl, isCard }: GoogleButtonProps) => {{errors.length > 0 && (<Box mt="1rem">{errors.map((error, index) => (- <Box c="error" ta="center" key={index}>+ <Box c="feedback-negative" ta="center" key={index}>{error}</Box>))}diff --git a/frontend/src/metabase/browse/components/BrowseTable.module.css b/frontend/src/metabase/browse/components/BrowseTable.module.cssindex 06b46754aa9..b80b34a0968 100644--- a/frontend/src/metabase/browse/components/BrowseTable.module.css+++ b/frontend/src/metabase/browse/components/BrowseTable.module.css@@ -2,13 +2,13 @@cursor: pointer;&:focus {- outline: 2px solid var(--mb-color-focus);+ outline: 2px solid var(--mb-color-input-focus);}}.tableRowSkeleton {&:focus {- outline: 2px solid var(--mb-color-focus);+ outline: 2px solid var(--mb-color-input-focus);}&:hover {@@ -26,7 +26,7 @@}&:focus {- outline: 2px solid var(--mb-color-focus);+ outline: 2px solid var(--mb-color-input-focus);button,a {@@ -41,7 +41,7 @@}&:focus {- outline: 2px solid var(--mb-color-focus);+ outline: 2px solid var(--mb-color-input-focus);button,a {diff --git a/frontend/src/metabase/browse/databases/BrowseDatabases.tsx b/frontend/src/metabase/browse/databases/BrowseDatabases.tsxindex 557c386a82a..d359eeaf5e9 100644--- a/frontend/src/metabase/browse/databases/BrowseDatabases.tsx+++ b/frontend/src/metabase/browse/databases/BrowseDatabases.tsx@@ -84,7 +84,7 @@ export const BrowseDatabases = () => {const CardImageWrapper = ({ database }: { database: string }) => {return (<Box- bg="white"+ bg="core-white"h="xl"w="xl"className={CS.rounded}diff --git a/frontend/src/metabase/browse/tables/TableBrowser/TableBrowserInner.tsx b/frontend/src/metabase/browse/tables/TableBrowser/TableBrowserInner.tsxindex a6382281821..d963f237d2a 100644--- a/frontend/src/metabase/browse/tables/TableBrowser/TableBrowserInner.tsx+++ b/frontend/src/metabase/browse/tables/TableBrowser/TableBrowserInner.tsx@@ -157,7 +157,7 @@ const TableBrowserItemButtons = ({to={`/auto/dashboard/table/${tableId}`}size="sm"tooltip={t`X-ray this table`}- color="warning"+ color="feedback-warning"aria-label={t`X-ray this table`}onClick={trackBrowseXRayClicked}>diff --git a/frontend/src/metabase/collections/components/CollectionContent/CollectionContentView.tsx b/frontend/src/metabase/collections/components/CollectionContent/CollectionContentView.tsxindex 6398475efe3..b6f5792cc8b 100644--- a/frontend/src/metabase/collections/components/CollectionContent/CollectionContentView.tsx+++ b/frontend/src/metabase/collections/components/CollectionContent/CollectionContentView.tsx@@ -165,7 +165,7 @@ export const CollectionContentView = ({if (rejected.length > 1) {sendToast({message: t`Please upload files individually`,- toastColor: "error",+ toastColor: "feedback-negative",icon: "warning",});return;@@ -186,7 +186,7 @@ export const CollectionContentView = ({sendToast({message: errorMessage,- toastColor: "error",+ toastColor: "feedback-negative",icon: "warning",});},diff --git a/frontend/src/metabase/comments/components/Discussion/Discussion.tsx b/frontend/src/metabase/comments/components/Discussion/Discussion.tsxindex cf8ece893c6..7293d56f367 100644--- a/frontend/src/metabase/comments/components/Discussion/Discussion.tsx+++ b/frontend/src/metabase/comments/components/Discussion/Discussion.tsx@@ -62,7 +62,7 @@ export const Discussion = ({if (error) {sendToast({icon: "warning_triangle_filled",- iconColor: "warning",+ iconColor: "feedback-warning",message: t`Failed to send comment`,});}@@ -78,7 +78,7 @@ export const Discussion = ({if (error) {sendToast({icon: "warning_triangle_filled",- iconColor: "warning",+ iconColor: "feedback-warning",message: t`Failed to delete comment`,});}@@ -93,7 +93,7 @@ export const Discussion = ({if (error) {sendToast({icon: "warning_triangle_filled",- iconColor: "warning",+ iconColor: "feedback-warning",message: t`Failed to resolve comment`,});}@@ -108,7 +108,7 @@ export const Discussion = ({if (error) {sendToast({icon: "warning_triangle_filled",- iconColor: "warning",+ iconColor: "feedback-warning",message: t`Failed to unresolve comment`,});}@@ -126,7 +126,7 @@ export const Discussion = ({if (error) {sendToast({icon: "warning_triangle_filled",- iconColor: "warning",+ iconColor: "feedback-warning",message: t`Failed to update comment`,});}@@ -164,7 +164,7 @@ export const Discussion = ({if (error) {sendToast({icon: "warning_triangle_filled",- iconColor: "warning",+ iconColor: "feedback-warning",message: errorMessage,});}diff --git a/frontend/src/metabase/common/collections/components/CollectionRowMenu/CollectionRowMenu.tsx b/frontend/src/metabase/common/collections/components/CollectionRowMenu/CollectionRowMenu.tsxindex f26747a9e49..d2ea527af33 100644--- a/frontend/src/metabase/common/collections/components/CollectionRowMenu/CollectionRowMenu.tsx+++ b/frontend/src/metabase/common/collections/components/CollectionRowMenu/CollectionRowMenu.tsx@@ -184,7 +184,7 @@ export function CollectionRowMenu(props: CollectionRowMenuProps) {<Menu.ItemleftSection={<Icon name="archive" />}onClick={onArchiveClick}- c="error"+ c="feedback-negative">{t`Archive`}</Menu.Item>diff --git a/frontend/src/metabase/common/collections/components/QuestionMoveConfirmModal.tsx b/frontend/src/metabase/common/collections/components/QuestionMoveConfirmModal.tsxindex 0bf230b6558..a8fa52b592f 100644--- a/frontend/src/metabase/common/collections/components/QuestionMoveConfirmModal.tsx+++ b/frontend/src/metabase/common/collections/components/QuestionMoveConfirmModal.tsx@@ -159,7 +159,7 @@ export const QuestionMoveConfirmModal = ({</List><Flex justify="space-between" mt="1rem">- <Text c="error">{errorMessage}</Text>+ <Text c="feedback-negative">{errorMessage}</Text><Flex justify="end" gap="1rem"><Button variant="subtle" onClick={onClose}>{t`Cancel`}diff --git a/frontend/src/metabase/common/components/ActionButton/ActionButton.tsx b/frontend/src/metabase/common/components/ActionButton/ActionButton.tsxindex 59608c1d0c7..6ca0678f5ca 100644--- a/frontend/src/metabase/common/components/ActionButton/ActionButton.tsx+++ b/frontend/src/metabase/common/components/ActionButton/ActionButton.tsx@@ -116,9 +116,9 @@ export const ActionButton = forwardRef<ActionButtonHandle, ActionButtonProps>(const actionStatus = active ? "pending" : (result ?? "idle");const resultProps: Partial<ButtonProps> =result === "success"- ? { variant: "filled", color: "success" }+ ? { variant: "filled", color: "feedback-positive" }: result === "failed"- ? { variant: "filled", color: "error" }+ ? { variant: "filled", color: "feedback-negative" }: {};return (@@ -135,7 +135,11 @@ export const ActionButton = forwardRef<ActionButtonHandle, ActionButtonProps>({active ? (useLoadingSpinner ? (<Center px="2rem">- <Loader size="sm" color="white" data-testid="loading-indicator" />+ <Loader+ size="sm"+ color="core-white"+ data-testid="loading-indicator"+ /></Center>) : (activeTextdiff --git a/frontend/src/metabase/common/components/Alert/Alert.styled.tsx b/frontend/src/metabase/common/components/Alert/Alert.styled.tsxindex 3cf0c00b3f0..4011ff1e11a 100644--- a/frontend/src/metabase/common/components/Alert/Alert.styled.tsx+++ b/frontend/src/metabase/common/components/Alert/Alert.styled.tsx@@ -16,8 +16,8 @@ interface AlertRootProps {const colorsByVariant = {border: {info: "var(--mb-color-background_page-tertiary)",- error: color("error"),- warning: color("warning"),+ error: color("feedback-negative"),+ warning: color("feedback-warning"),},background: {info: "var(--mb-color-background_page-secondary)",@@ -26,8 +26,8 @@ const colorsByVariant = {},icon: {info: color("text-primary"),- error: color("error"),- warning: color("warning"),+ error: color("feedback-negative"),+ warning: color("feedback-warning"),},};diff --git a/frontend/src/metabase/common/components/ArchiveModal/ArchiveModal.tsx b/frontend/src/metabase/common/components/ArchiveModal/ArchiveModal.tsxindex 30a9b2fd976..93568cae17a 100644--- a/frontend/src/metabase/common/components/ArchiveModal/ArchiveModal.tsx+++ b/frontend/src/metabase/common/components/ArchiveModal/ArchiveModal.tsx@@ -54,7 +54,7 @@ export const ArchiveModal = ({</Box><Button onClick={onClose}>{t`Cancel`}</Button><FormSubmitButton- color="error"+ color="feedback-negative"variant="filled"label={archiveButtonLabel}activeLabel={archiveButtonLabel}diff --git a/frontend/src/metabase/common/components/Banner/Banner.stories.tsx b/frontend/src/metabase/common/components/Banner/Banner.stories.tsxindex e5acc04ceb8..48b8fbbed16 100644--- a/frontend/src/metabase/common/components/Banner/Banner.stories.tsx+++ b/frontend/src/metabase/common/components/Banner/Banner.stories.tsx@@ -38,7 +38,7 @@ export const NonClosable = {render: (args: BannerProps) => <Banner {...args} />,args: {closable: false,- bg: "var(--mb-color-success)",+ bg: "var(--mb-color-feedback-positive)",body: (<Text lh="inherit" c="text-primary-inverse">This is a bannerdiff --git a/frontend/src/metabase/common/components/Breadcrumb/Breadcrumb.module.css b/frontend/src/metabase/common/components/Breadcrumb/Breadcrumb.module.cssindex 709a945bf55..24f3bf48880 100644--- a/frontend/src/metabase/common/components/Breadcrumb/Breadcrumb.module.css+++ b/frontend/src/metabase/common/components/Breadcrumb/Breadcrumb.module.css@@ -5,7 +5,7 @@.content {--color: var(--mb-color-text-disabled);- --active-color: var(--mb-color-brand);+ --active-color: var(--mb-color-core-brand);}.icon,diff --git a/frontend/src/metabase/common/components/BucketPickerPopover/BucketPickerPopover.tsx b/frontend/src/metabase/common/components/BucketPickerPopover/BucketPickerPopover.tsxindex 20430479f57..3b34164dadb 100644--- a/frontend/src/metabase/common/components/BucketPickerPopover/BucketPickerPopover.tsx+++ b/frontend/src/metabase/common/components/BucketPickerPopover/BucketPickerPopover.tsx@@ -99,7 +99,7 @@ export function BucketPickerPopover({h="auto"py={0}variant="subtle"- color="white"+ color="core-white"classNames={{ label: S.triggerButtonLabel }}><Ellipsified>{triggerLabel}</Ellipsified>diff --git a/frontend/src/metabase/common/components/BulkActionBar/BulkActionBar.module.css b/frontend/src/metabase/common/components/BulkActionBar/BulkActionBar.module.cssindex 12677e5e071..5e5ed70795a 100644--- a/frontend/src/metabase/common/components/BulkActionBar/BulkActionBar.module.css+++ b/frontend/src/metabase/common/components/BulkActionBar/BulkActionBar.module.css@@ -44,7 +44,7 @@var(--mb-color-background_page-primary),transparent 100%);- background-color: var(--mb-color-error);+ background-color: var(--mb-color-feedback-negative);}&:disabled:hover {diff --git a/frontend/src/metabase/common/components/CodeMirror/CodeMirror.module.css b/frontend/src/metabase/common/components/CodeMirror/CodeMirror.module.cssindex 01152c4fc1b..fe4a225a2e3 100644--- a/frontend/src/metabase/common/components/CodeMirror/CodeMirror.module.css+++ b/frontend/src/metabase/common/components/CodeMirror/CodeMirror.module.css@@ -56,7 +56,7 @@}.cm-selectionBackground {- background: var(--mb-color-focus) !important;+ background: var(--mb-color-input-focus) !important;border-radius: 1px;}diff --git a/frontend/src/metabase/common/components/ColorRange/ColorRange.stories.tsx b/frontend/src/metabase/common/components/ColorRange/ColorRange.stories.tsxindex 7e3ee14ab88..82652a47879 100644--- a/frontend/src/metabase/common/components/ColorRange/ColorRange.stories.tsx+++ b/frontend/src/metabase/common/components/ColorRange/ColorRange.stories.tsx@@ -17,7 +17,7 @@ export const Default = {render: Template,args: {- colors: [color("white"), color("core-brand")],+ colors: [color("core-white"), color("core-brand")],},};@@ -25,7 +25,7 @@ export const Inverted = {render: Template,args: {- colors: [color("core-brand"), color("white")],+ colors: [color("core-brand"), color("core-white")],},};@@ -33,6 +33,10 @@ export const ThreeColors = {render: Template,args: {- colors: [color("error"), color("white"), color("success")],+ colors: [+ color("feedback-negative"),+ color("core-white"),+ color("feedback-positive"),+ ],},};diff --git a/frontend/src/metabase/common/components/ColorRangeSelector/ColorRangeSelector.stories.tsx b/frontend/src/metabase/common/components/ColorRangeSelector/ColorRangeSelector.stories.tsxindex 29137817186..aa87b09525d 100644--- a/frontend/src/metabase/common/components/ColorRangeSelector/ColorRangeSelector.stories.tsx+++ b/frontend/src/metabase/common/components/ColorRangeSelector/ColorRangeSelector.stories.tsx@@ -27,7 +27,7 @@ export const Default = {render: Template,args: {- value: [color("white"), color("core-brand")],+ value: [color("core-white"), color("core-brand")],colors: [color("core-brand"),color("core-summarize"),@@ -40,15 +40,23 @@ export const WithColorRanges = {render: Template,args: {- value: [color("white"), color("core-brand")],+ value: [color("core-white"), color("core-brand")],colors: [color("core-brand"),color("core-summarize"),color("core-filter"),],colorRanges: [- [color("error"), color("white"), color("success")],- [color("error"), color("warning"), color("success")],+ [+ color("feedback-negative"),+ color("core-white"),+ color("feedback-positive"),+ ],+ [+ color("feedback-negative"),+ color("feedback-warning"),+ color("feedback-positive"),+ ],],},};@@ -57,7 +65,7 @@ export const WithColorMapping = {render: Template,args: {- value: [color("white"), color("core-brand")],+ value: [color("core-white"), color("core-brand")],colors: [color("core-brand"),color("core-summarize"),@@ -66,17 +74,17 @@ export const WithColorMapping = {colorMapping: {[color("core-brand")]: [color("core-brand"),- color("white"),+ color("core-white"),color("core-brand"),],[color("core-summarize")]: [color("core-summarize"),- color("white"),- color("error"),+ color("core-white"),+ color("feedback-negative"),],[color("core-filter")]: [color("core-filter"),- color("white"),+ color("core-white"),color("core-filter"),],},diff --git a/frontend/src/metabase/common/components/ColorRangeSelector/ColorRangeSelector.unit.spec.tsx b/frontend/src/metabase/common/components/ColorRangeSelector/ColorRangeSelector.unit.spec.tsxindex 923ca7a4998..6400c65fed1 100644--- a/frontend/src/metabase/common/components/ColorRangeSelector/ColorRangeSelector.unit.spec.tsx+++ b/frontend/src/metabase/common/components/ColorRangeSelector/ColorRangeSelector.unit.spec.tsx@@ -9,18 +9,22 @@ import { getColorRangeLabel } from "./ColorRangeToggle";// Color components only speak hex, so we need to convert the values we use for testing to hexconst color = (name: string) => Color(libColors(name)).hex();-const DEFAULT_VALUE = [color("white"), color("core-brand")];+const DEFAULT_VALUE = [color("core-white"), color("core-brand")];const DEFAULT_COLORS = [color("core-brand"),color("core-summarize"),color("core-filter"),];-const WHITE_COLOR_RANGE = [color("error"), color("white"), color("success")];+const WHITE_COLOR_RANGE = [+ color("feedback-negative"),+ color("core-white"),+ color("feedback-positive"),+];const WARNING_COLOR_RANGE = [- color("error"),- color("warning"),- color("success"),+ color("feedback-negative"),+ color("feedback-warning"),+ color("feedback-positive"),];function setup() {diff --git a/frontend/src/metabase/common/components/ConfirmModal/ConfirmModal.tsx b/frontend/src/metabase/common/components/ConfirmModal/ConfirmModal.tsxindex 05f8b82cd00..c85233c6d98 100644--- a/frontend/src/metabase/common/components/ConfirmModal/ConfirmModal.tsx+++ b/frontend/src/metabase/common/components/ConfirmModal/ConfirmModal.tsx@@ -55,7 +55,11 @@ export const ConfirmModal = ({{content ? <Text>{content}</Text> : null}<Text>{message}</Text><Flex align="center" justify="space-between" gap="md">- {errorMessage ? <Text c="danger">{errorMessage} </Text> : <div />}+ {errorMessage ? (+ <Text c="feedback-negative">{errorMessage} </Text>+ ) : (+ <div />+ )}<Flex align="center" justify="flex-end" gap="md">{closeButtonText && (<Button {...closeButtonProps} onClick={onClose}>@@ -63,7 +67,7 @@ export const ConfirmModal = ({</Button>)}<Button- color="danger"+ color="feedback-negative"variant="filled"{...confirmButtonProps}disabled={confirmButtonProps.disabled || confirming}diff --git a/frontend/src/metabase/common/components/CopyButton/CopyButton.module.css b/frontend/src/metabase/common/components/CopyButton/CopyButton.module.cssindex d8f0bc0980b..fb4121d1148 100644--- a/frontend/src/metabase/common/components/CopyButton/CopyButton.module.css+++ b/frontend/src/metabase/common/components/CopyButton/CopyButton.module.css@@ -1,6 +1,6 @@.CopyButton {&:focus {- outline: 2px solid var(--mb-color-focus);+ outline: 2px solid var(--mb-color-input-focus);border-radius: var(--mantine-radius-xs);}}diff --git a/frontend/src/metabase/common/components/EntityIdCard/EntityIdCard.module.css b/frontend/src/metabase/common/components/EntityIdCard/EntityIdCard.module.cssindex 214a21742af..16c2da90f7e 100644--- a/frontend/src/metabase/common/components/EntityIdCard/EntityIdCard.module.css+++ b/frontend/src/metabase/common/components/EntityIdCard/EntityIdCard.module.css@@ -20,6 +20,6 @@cursor: pointer;&:focus {- outline: 2px solid var(--mb-color-focus);+ outline: 2px solid var(--mb-color-input-focus);}}diff --git a/frontend/src/metabase/common/components/EntityItem/EntityItem.module.css b/frontend/src/metabase/common/components/EntityItem/EntityItem.module.cssindex d81ca2f8ea6..f7b94ac3494 100644--- a/frontend/src/metabase/common/components/EntityItem/EntityItem.module.css+++ b/frontend/src/metabase/common/components/EntityItem/EntityItem.module.css@@ -3,11 +3,11 @@}.menuItem:hover:not([data-disabled="true"]) {- color: var(--mb-color-brand) !important;+ color: var(--mb-color-core-brand) !important;background-color: var(--mb-color-background_page-secondary) !important;}.dangerItem:hover:not([data-disabled="true"]) {- color: var(--mb-color-danger) !important;+ color: var(--mb-color-feedback-negative) !important;background-color: var(--mb-color-background_surface-error) !important;}diff --git a/frontend/src/metabase/common/components/FileInput/FileInput.styled.tsx b/frontend/src/metabase/common/components/FileInput/FileInput.styled.tsxindex c4503b15286..30713e321e9 100644--- a/frontend/src/metabase/common/components/FileInput/FileInput.styled.tsx+++ b/frontend/src/metabase/common/components/FileInput/FileInput.styled.tsx@@ -43,7 +43,7 @@ export const InputButton = styled.span`user-select: none;${InputField}:focus + & {- outline: 2px solid var(--mb-color-focus);+ outline: 2px solid var(--mb-color-input-focus);}${InputField}:not(:focus-visible) + & {diff --git a/frontend/src/metabase/common/components/FormErrorMessage/FormErrorMessage.styled.tsx b/frontend/src/metabase/common/components/FormErrorMessage/FormErrorMessage.styled.tsxindex 444bba9784e..db8db922aba 100644--- a/frontend/src/metabase/common/components/FormErrorMessage/FormErrorMessage.styled.tsx+++ b/frontend/src/metabase/common/components/FormErrorMessage/FormErrorMessage.styled.tsx@@ -6,6 +6,6 @@ interface ErrorMessageRootProps {}export const ErrorMessageRoot = styled.div<ErrorMessageRootProps>`- color: var(--mb-color-error);+ color: var(--mb-color-feedback-negative);margin-top: ${(props) => !props.inline && "1rem"};`;diff --git a/frontend/src/metabase/common/components/FormField/FormField.styled.tsx b/frontend/src/metabase/common/components/FormField/FormField.styled.tsxindex 0d1554b87b2..4d359380911 100644--- a/frontend/src/metabase/common/components/FormField/FormField.styled.tsx+++ b/frontend/src/metabase/common/components/FormField/FormField.styled.tsx@@ -32,7 +32,7 @@ interface FieldLabelProps {export const FieldLabel = styled.label<FieldLabelProps>`display: block;color: ${(props) =>- props.hasError ? color("error") : color("text-secondary")};+ props.hasError ? color("feedback-negative") : color("text-secondary")};font-size: 0.77rem;font-weight: 900;`;@@ -57,7 +57,7 @@ export const FieldLabelContainer = styled.div<FieldLabelContainerProps>``;export const FieldLabelError = styled.span`- color: var(--mb-color-error);+ color: var(--mb-color-feedback-negative);`;export const FieldDescription = styled.div`diff --git a/frontend/src/metabase/common/components/Glossary/Glossary.module.css b/frontend/src/metabase/common/components/Glossary/Glossary.module.cssindex 187fe9fb43a..f6ffad45475 100644--- a/frontend/src/metabase/common/components/Glossary/Glossary.module.css+++ b/frontend/src/metabase/common/components/Glossary/Glossary.module.css@@ -62,5 +62,5 @@.inputError {border: none;padding-inline: 0 !important;- color: var(--mb-color-error) !important;+ color: var(--mb-color-feedback-negative) !important;}diff --git a/frontend/src/metabase/common/components/HelpCard/HelpCard.styled.tsx b/frontend/src/metabase/common/components/HelpCard/HelpCard.styled.tsxindex 3b384dffcb9..21dfa16b610 100644--- a/frontend/src/metabase/common/components/HelpCard/HelpCard.styled.tsx+++ b/frontend/src/metabase/common/components/HelpCard/HelpCard.styled.tsx@@ -12,7 +12,7 @@ const CardRootMixin = css`border: 1px solid var(--mb-color-border-neutral);border-radius: 0.375rem;background-color: var(--mb-color-background_page-primary);- box-shadow: 0 1px 6px var(--mb-color-shadow);+ box-shadow: 0 1px 6px var(--mb-color-shadow-default);box-sizing: border-box;`;diff --git a/frontend/src/metabase/common/components/Input/Input.styled.tsx b/frontend/src/metabase/common/components/Input/Input.styled.tsxindex df07aa7d523..1e22f06b61d 100644--- a/frontend/src/metabase/common/components/Input/Input.styled.tsx+++ b/frontend/src/metabase/common/components/Input/Input.styled.tsx@@ -86,7 +86,7 @@ export const InputField = styled.input<InputProps>`${(props) =>props.hasError &&css`- border-color: var(--mb-color-error);+ border-color: var(--mb-color-feedback-negative);`};${(props) =>diff --git a/frontend/src/metabase/common/components/LighthouseIllustration/Lighthouse.module.css b/frontend/src/metabase/common/components/LighthouseIllustration/Lighthouse.module.cssindex 97a57ef5b30..8bd336aa64f 100644--- a/frontend/src/metabase/common/components/LighthouseIllustration/Lighthouse.module.css+++ b/frontend/src/metabase/common/components/LighthouseIllustration/Lighthouse.module.css@@ -9,7 +9,7 @@.LighthouseColors {--illustration-primary: var(--mb-color-core-brand);- --illustration-secondary: var(--mb-color-illustration-brand-secondary);+ --illustration-secondary: var(--mb-color-illustration-secondary-brand);--illustration-background: var(--mb-color-background_page-primary);}diff --git a/frontend/src/metabase/common/components/MetabotLogo/MetabotLogo.module.css b/frontend/src/metabase/common/components/MetabotLogo/MetabotLogo.module.cssindex e001ac0cc67..9680b7dcb3a 100644--- a/frontend/src/metabase/common/components/MetabotLogo/MetabotLogo.module.css+++ b/frontend/src/metabase/common/components/MetabotLogo/MetabotLogo.module.css@@ -1,15 +1,15 @@.MetabotLogo {--metabot-face: var(--mb-color-core-brand);- --metabot-face-bg: var(--mb-color-illustration-brand-tertiary);- --metabot-buttons-bg: var(--mb-color-illustration-brand-secondary);+ --metabot-face-bg: var(--mb-color-illustration-tertiary-brand);+ --metabot-buttons-bg: var(--mb-color-illustration-secondary-brand);--metabot-outline: var(--mb-color-core-brand);- --metabot-body: var(--mb-color-illustration-brand-secondary);+ --metabot-body: var(--mb-color-illustration-secondary-brand);--metabot-frames: var(--metabot-face);[data-mantine-color-scheme="dark"] & {--metabot-face: var(--mb-color-background_page-secondary);--metabot-face-bg: var(--mb-color-core-brand);- --metabot-buttons-bg: var(--mb-color-illustration-brand-secondary);+ --metabot-buttons-bg: var(--mb-color-illustration-secondary-brand);--metabot-frames: var(--mb-color-background_page-primary);}}diff --git a/frontend/src/metabase/common/components/MoveQuestionsIntoDashboardsModal/ConfirmMoveDashboardQuestionCandidatesModal.tsx b/frontend/src/metabase/common/components/MoveQuestionsIntoDashboardsModal/ConfirmMoveDashboardQuestionCandidatesModal.tsxindex 4b675f4d830..cede2174c9f 100644--- a/frontend/src/metabase/common/components/MoveQuestionsIntoDashboardsModal/ConfirmMoveDashboardQuestionCandidatesModal.tsx+++ b/frontend/src/metabase/common/components/MoveQuestionsIntoDashboardsModal/ConfirmMoveDashboardQuestionCandidatesModal.tsx@@ -102,7 +102,7 @@ export const ConfirmMoveDashboardQuestionCandidatesModal = ({.with({ fetchError: P.not(P.nullish) }, ({ fetchError }) => {return (<Flex justify="center" py="19rem">- <Text color="error" size="1.25rem" px="md">+ <Text color="feedback-negative" size="1.25rem" px="md">{fetchError instanceof Error? (fetchError?.message ?? defaultErrMsg): defaultErrMsg}@@ -135,7 +135,7 @@ export const ConfirmMoveDashboardQuestionCandidatesModal = ({px="1.25rem">{mutationError ? (- <Text color="error">+ <Text color="feedback-negative">{mutationError instanceof Error? (mutationError?.message ?? defaultErrMsg): defaultErrMsg}@@ -150,7 +150,7 @@ export const ConfirmMoveDashboardQuestionCandidatesModal = ({variant="filled"onClick={onConfirm}disabled={ctaDisabled}- color={mutationError ? "error" : "core-brand"}+ color={mutationError ? "feedback-negative" : "core-brand"}>{t`Move these questions`}</Button>diff --git a/frontend/src/metabase/common/components/OnboardingStepper/OnboardingStepper.module.css b/frontend/src/metabase/common/components/OnboardingStepper/OnboardingStepper.module.cssindex 70a7e586c50..c8b4a0f4a8e 100644--- a/frontend/src/metabase/common/components/OnboardingStepper/OnboardingStepper.module.css+++ b/frontend/src/metabase/common/components/OnboardingStepper/OnboardingStepper.module.css@@ -99,7 +99,7 @@.StepNumberIcon {width: 1rem;height: 1rem;- color: var(--mb-color-success);+ color: var(--mb-color-feedback-positive);}.StepLockIcon {diff --git a/frontend/src/metabase/common/components/Pickers/EntityPicker/components/ButtonBar.tsx b/frontend/src/metabase/common/components/Pickers/EntityPicker/components/ButtonBar.tsxindex a449ad17932..d7acc218e72 100644--- a/frontend/src/metabase/common/components/Pickers/EntityPicker/components/ButtonBar.tsx+++ b/frontend/src/metabase/common/components/Pickers/EntityPicker/components/ButtonBar.tsx@@ -76,7 +76,7 @@ export const ButtonBar = ({<NewDashboardDialog /></Flex>{error && (- <Text c="error" px="md" lh="1rem">+ <Text c="feedback-negative" px="md" lh="1rem">{error}</Text>)}diff --git a/frontend/src/metabase/common/components/RevisionHistoryTimeline/RevisionHistoryTimeline.tsx b/frontend/src/metabase/common/components/RevisionHistoryTimeline/RevisionHistoryTimeline.tsxindex 72e5b1959c8..dcc82034747 100644--- a/frontend/src/metabase/common/components/RevisionHistoryTimeline/RevisionHistoryTimeline.tsx+++ b/frontend/src/metabase/common/components/RevisionHistoryTimeline/RevisionHistoryTimeline.tsx@@ -47,7 +47,7 @@ export function RevisionHistoryTimeline({dispatch(addUndo({icon: "warning",- toastColor: "error",+ toastColor: "feedback-negative",message: getErrorMessage(error,t`Failed to revert to previous version.`,@@ -141,7 +141,7 @@ function EventIconCircle({ icon }: EventIconCircleProps) {return (<Center w={24} h={24} className={S.iconCircle} bg="core-brand">- <Icon name={icon.name} c="white" size={12} />+ <Icon name={icon.name} c="core-white" size={12} /></Center>);}diff --git a/frontend/src/metabase/common/components/RevisionHistoryTimeline/RevisionHistoryTimeline.unit.spec.tsx b/frontend/src/metabase/common/components/RevisionHistoryTimeline/RevisionHistoryTimeline.unit.spec.tsxindex 367dcca1ae4..3178864d177 100644--- a/frontend/src/metabase/common/components/RevisionHistoryTimeline/RevisionHistoryTimeline.unit.spec.tsx+++ b/frontend/src/metabase/common/components/RevisionHistoryTimeline/RevisionHistoryTimeline.unit.spec.tsx@@ -53,7 +53,7 @@ describe("RevisionHistoryTimeline", () => {expect(store.getState().undo).toHaveLength(1);});expect(store.getState().undo[0]).toMatchObject({- toastColor: "error",+ toastColor: "feedback-negative",icon: "warning",message: "Cannot revert: missing card",});@@ -72,7 +72,7 @@ describe("RevisionHistoryTimeline", () => {expect(store.getState().undo).toHaveLength(1);});expect(store.getState().undo[0]).toMatchObject({- toastColor: "error",+ toastColor: "feedback-negative",icon: "warning",message: "Failed to revert to previous version.",});diff --git a/frontend/src/metabase/common/components/SearchResult/SearchResult.tsx b/frontend/src/metabase/common/components/SearchResult/SearchResult.tsxindex dd27b56cb89..096d94dea92 100644--- a/frontend/src/metabase/common/components/SearchResult/SearchResult.tsx+++ b/frontend/src/metabase/common/components/SearchResult/SearchResult.tsx@@ -225,7 +225,7 @@ export function SearchResult({<Group wrap="nowrap" gap="sm" data-testid="result-description"><Dividersize="md"- color="focus"+ color="input-focus"orientation="vertical"bdrs="xs"/>diff --git a/frontend/src/metabase/common/components/SelectButton/SelectButton.styled.tsx b/frontend/src/metabase/common/components/SelectButton/SelectButton.styled.tsxindex 7060b5fe56a..434ba14faca 100644--- a/frontend/src/metabase/common/components/SelectButton/SelectButton.styled.tsx+++ b/frontend/src/metabase/common/components/SelectButton/SelectButton.styled.tsx@@ -43,7 +43,7 @@ export const SelectButtonRoot = styled.button<SelectButtonRootProps>`&:focus {border-color: var(--mb-color-core-brand);- outline: 2px solid var(--mb-color-focus);+ outline: 2px solid var(--mb-color-input-focus);}&:not(:focus-visible) {diff --git a/frontend/src/metabase/common/components/Sidebar/Sidebar.tsx b/frontend/src/metabase/common/components/Sidebar/Sidebar.tsxindex 7a5fedf19c5..e9b66337e26 100644--- a/frontend/src/metabase/common/components/Sidebar/Sidebar.tsx+++ b/frontend/src/metabase/common/components/Sidebar/Sidebar.tsx@@ -55,7 +55,7 @@ export function Sidebar({<ButtonleftSection={<Icon name="trash" />}variant="subtle"- color="error"+ color="feedback-negative"disabled={isRemoveDisabled}onClick={onRemove}style={{ paddingLeft: 0, paddingRight: 0 }}diff --git a/frontend/src/metabase/common/components/TextArea/TextArea.styled.tsx b/frontend/src/metabase/common/components/TextArea/TextArea.styled.tsxindex 8dd22f47fd9..dd96aff1230 100644--- a/frontend/src/metabase/common/components/TextArea/TextArea.styled.tsx+++ b/frontend/src/metabase/common/components/TextArea/TextArea.styled.tsx@@ -42,7 +42,7 @@ export const TextAreaRoot = styled.textarea<TextAreaRootProps>`${(props) =>props.hasError &&css`- border-color: var(--mb-color-error);+ border-color: var(--mb-color-feedback-negative);`};${(props) =>diff --git a/frontend/src/metabase/common/components/Toggle/Toggle.styled.tsx b/frontend/src/metabase/common/components/Toggle/Toggle.styled.tsxindex 331e95470b4..c0376c5623e 100644--- a/frontend/src/metabase/common/components/Toggle/Toggle.styled.tsx+++ b/frontend/src/metabase/common/components/Toggle/Toggle.styled.tsx@@ -61,7 +61,7 @@ export const ToggleRoot = styled.input<ToggleRootProps>`transform: translateX(${getTranslateX});background-color: var(--mb-color-background_page-primary);transition: transform 0.3s;- box-shadow: 2px 2px 6px var(--mb-color-shadow);+ box-shadow: 2px 2px 6px var(--mb-color-shadow-default);}${focusOutlineStyle("core-brand")};diff --git a/frontend/src/metabase/common/components/TokenFieldItem/TokenFieldItem.styled.ts b/frontend/src/metabase/common/components/TokenFieldItem/TokenFieldItem.styled.tsindex 47450dac4d9..c52a03d34b1 100644--- a/frontend/src/metabase/common/components/TokenFieldItem/TokenFieldItem.styled.ts+++ b/frontend/src/metabase/common/components/TokenFieldItem/TokenFieldItem.styled.ts@@ -11,7 +11,9 @@ export const TokenFieldItem = styled.li<{height: 46px;border-radius: 0.5rem;color: ${({ isValid }) =>- isValid ? `var(--mb-color-text-primary-inverse)` : `var(--mb-color-error)`};+ isValid+ ? `var(--mb-color-text-primary-inverse)`+ : `var(--mb-color-feedback-negative)`};background-color: var(--mb-color-core-brand);`;@@ -22,7 +24,8 @@ export const TokenFieldAddon = styled.a<{display: flex;align-items: center;margin-left: 0.5rem;- color: ${({ isValid }) => (isValid ? "" : `var(--mb-color-error)`)};+ color: ${({ isValid }) =>+ isValid ? "" : `var(--mb-color-feedback-negative)`};&:hover {color: var(--mb-color-text-brand-hover);diff --git a/frontend/src/metabase/common/components/Unsubscribe.styled.tsx b/frontend/src/metabase/common/components/Unsubscribe.styled.tsxindex a48a04db348..3b2ada7d19d 100644--- a/frontend/src/metabase/common/components/Unsubscribe.styled.tsx+++ b/frontend/src/metabase/common/components/Unsubscribe.styled.tsx@@ -42,7 +42,7 @@ export const LayoutCard = styled.div`margin-top: 1.5rem;padding: 2.5rem 1.5rem;background-color: var(--mb-color-background_page-primary);- box-shadow: 0 1px 15px var(--mb-color-shadow);+ box-shadow: 0 1px 15px var(--mb-color-shadow-default);border-radius: 6px;min-height: 20rem;min-width: 35rem;diff --git a/frontend/src/metabase/common/components/dnd/ItemDragSource.tsx b/frontend/src/metabase/common/components/dnd/ItemDragSource.tsxindex 64d2f3ecf1d..e910350071f 100644--- a/frontend/src/metabase/common/components/dnd/ItemDragSource.tsx+++ b/frontend/src/metabase/common/components/dnd/ItemDragSource.tsx@@ -154,7 +154,7 @@ export function ItemDragSource(props: ItemDragSourceProps) {sendToast({message: getErrorMessage(error),icon: "warning_triangle_filled",- iconColor: "warning",+ iconColor: "feedback-warning",});return (<DragSourceComponentdiff --git a/frontend/src/metabase/common/components/upsells/UpsellCard.module.css b/frontend/src/metabase/common/components/upsells/UpsellCard.module.cssindex a5b8e5a9b24..27c6c1b45ea 100644--- a/frontend/src/metabase/common/components/upsells/UpsellCard.module.css+++ b/frontend/src/metabase/common/components/upsells/UpsellCard.module.css@@ -3,7 +3,7 @@.UpsellCardComponent {border-radius: 0.5rem;overflow: hidden;- border: 1px solid var(--mb-color-upsell-secondary);+ border: 1px solid var(--mb-color-background_surface-brand-subtle);background-color: var(--mb-color-background_page-primary);.MainStack {diff --git a/frontend/src/metabase/common/components/upsells/components/UpgradeModal/UpgradeModalError.tsx b/frontend/src/metabase/common/components/upsells/components/UpgradeModal/UpgradeModalError.tsxindex 2f3ec8cfae5..ce11419bb82 100644--- a/frontend/src/metabase/common/components/upsells/components/UpgradeModal/UpgradeModalError.tsx+++ b/frontend/src/metabase/common/components/upsells/components/UpgradeModal/UpgradeModalError.tsx@@ -14,10 +14,10 @@ export function UpgradeModalError({ onClose }: UpgradeModalErrorProps) {justify="center"w={64}h={64}- bg="error"+ bg="feedback-negative"style={{ borderRadius: "50%" }}>- <Icon name="warning" c="white" size={32} />+ <Icon name="warning" c="core-white" size={32} /></Flex><Stack align="center" gap="xs">diff --git a/frontend/src/metabase/common/components/upsells/components/UpgradeModal/UpgradeModalLoading.tsx b/frontend/src/metabase/common/components/upsells/components/UpgradeModal/UpgradeModalLoading.tsxindex ba9ea73f082..e8454b76333 100644--- a/frontend/src/metabase/common/components/upsells/components/UpgradeModal/UpgradeModalLoading.tsx+++ b/frontend/src/metabase/common/components/upsells/components/UpgradeModal/UpgradeModalLoading.tsx@@ -65,10 +65,10 @@ export function UpgradeModalLoading({justify="center"w={64}h={64}- bg="success"+ bg="feedback-positive"style={{ borderRadius: "50%" }}>- <Icon name="check" c="white" size={32} />+ <Icon name="check" c="core-white" size={32} /></Flex><Stack align="center" gap="xs">diff --git a/frontend/src/metabase/common/components/upsells/components/UpsellCta.module.css b/frontend/src/metabase/common/components/upsells/components/UpsellCta.module.cssindex 7328c7107eb..e9cdcf9870b 100644--- a/frontend/src/metabase/common/components/upsells/components/UpsellCta.module.css+++ b/frontend/src/metabase/common/components/upsells/components/UpsellCta.module.css@@ -10,12 +10,12 @@padding: 0.25rem 0.5rem;border-radius: 0.5rem;color: var(--mb-color-text-primary-inverse);- background-color: var(--mb-color-metabase-brand);+ background-color: var(--mb-color-core-metabase_brand);text-decoration: none;cursor: pointer;&:hover {- background-color: var(--mb-color-metabase-brand-hover);+ background-color: var(--mb-color-core-metabase_brand-hover);}&.Medium {diff --git a/frontend/src/metabase/common/components/upsells/components/UpsellGem.module.css b/frontend/src/metabase/common/components/upsells/components/UpsellGem.module.cssindex d7f4e3f7aff..79b58e1c92e 100644--- a/frontend/src/metabase/common/components/upsells/components/UpsellGem.module.css+++ b/frontend/src/metabase/common/components/upsells/components/UpsellGem.module.css@@ -1,5 +1,5 @@.UpsellGem {- color: var(--mb-color-upsell-gem);+ color: var(--mb-color-core-brand);flex-shrink: 0;}diff --git a/frontend/src/metabase/common/components/upsells/components/UpsellPill.module.css b/frontend/src/metabase/common/components/upsells/components/UpsellPill.module.cssindex 6081750066d..df59276cf5c 100644--- a/frontend/src/metabase/common/components/upsells/components/UpsellPill.module.css+++ b/frontend/src/metabase/common/components/upsells/components/UpsellPill.module.css@@ -9,13 +9,13 @@text-decoration: none;padding: 0.25rem 0.75rem;border-radius: 2rem;- border: 1px solid var(--mb-color-upsell-secondary);- color: var(--mb-color-upsell-primary);+ border: 1px solid var(--mb-color-background_surface-brand-subtle);+ color: var(--mb-color-background_surface-brand-strong);cursor: pointer;&:hover {- background-color: var(--mb-color-upsell-secondary);+ background-color: var(--mb-color-background_surface-brand-subtle);color: var(--mb-color-text-primary);- border: 1px solid var(--mb-color-upsell-primary);+ border: 1px solid var(--mb-color-background_surface-brand-strong);}}diff --git a/frontend/src/metabase/common/components/upsells/components/Upsells.module.css b/frontend/src/metabase/common/components/upsells/components/Upsells.module.cssindex e1f30e2e6ee..b3aff641d41 100644--- a/frontend/src/metabase/common/components/upsells/components/Upsells.module.css+++ b/frontend/src/metabase/common/components/upsells/components/Upsells.module.css@@ -1,6 +1,6 @@.SecondaryCTALink {display: inline;- color: var(--mb-color-metabase-brand);+ color: var(--mb-color-core-metabase_brand);font-weight: 700;margin-left: 0.25rem;}diff --git a/frontend/src/metabase/css/admin.module.css b/frontend/src/metabase/css/admin.module.cssindex 759e43a192c..5fb8a369d01 100644--- a/frontend/src/metabase/css/admin.module.css+++ b/frontend/src/metabase/css/admin.module.css@@ -52,7 +52,7 @@border-radius: var(--default-border-radius);width: 266px;min-height: 300px;- box-shadow: inset -1px -1px 3px var(--mb-color-shadow);+ box-shadow: inset -1px -1px 3px var(--mb-color-shadow-default);padding-bottom: 0.75em;}@@ -98,7 +98,7 @@margin-right: -0.5em;padding-left: 1.5em;padding-right: 1.5em;- box-shadow: 0 1px 2px var(--mb-color-shadow);+ box-shadow: 0 1px 2px var(--mb-color-shadow-default);}.AdminListSection {diff --git a/frontend/src/metabase/css/components/buttons.module.css b/frontend/src/metabase/css/components/buttons.module.cssindex 1b688622ce4..ec25ef50faa 100644--- a/frontend/src/metabase/css/components/buttons.module.css+++ b/frontend/src/metabase/css/components/buttons.module.css@@ -76,19 +76,19 @@.ButtonWarning {color: var(--mb-color-text-primary-inverse);- background: var(--mb-color-error);- border-color: var(--mb-color-error);+ background: var(--mb-color-feedback-negative);+ border-color: var(--mb-color-feedback-negative);}.ButtonWarning:hover {color: var(--mb-color-text-primary-inverse);- border-color: var(--mb-color-error);- background-color: var(--mb-color-error);+ border-color: var(--mb-color-feedback-negative);+ background-color: var(--mb-color-feedback-negative);}.ButtonWarning:focus-visible {border-color: var(--mb-color-background_page-primary);- outline-color: var(--mb-color-error);+ outline-color: var(--mb-color-feedback-negative);}.ButtonCancel {@@ -148,7 +148,7 @@}.ButtonGroup .ButtonActive {- background-color: var(--mb-color-success);+ background-color: var(--mb-color-feedback-positive);color: var(--mb-color-text-primary-inverse);}@@ -177,37 +177,37 @@}.ButtonDanger {- background-color: var(--mb-color-error);- border-color: var(--mb-color-error);+ background-color: var(--mb-color-feedback-negative);+ border-color: var(--mb-color-feedback-negative);color: var(--mb-color-text-primary-inverse);}.ButtonDanger:hover {color: white;- background-color: var(--mb-color-error);- border-color: var(--mb-color-error);+ background-color: var(--mb-color-feedback-negative);+ border-color: var(--mb-color-feedback-negative);}.ButtonDanger:focus-visible {border-color: var(--mb-color-background_page-primary);- outline-color: var(--mb-color-error);+ outline-color: var(--mb-color-feedback-negative);}.ButtonSuccess {- background-color: var(--mb-color-success);- border-color: var(--mb-color-success);+ background-color: var(--mb-color-feedback-positive);+ border-color: var(--mb-color-feedback-positive);color: var(--mb-color-text-primary-inverse);}.ButtonSuccess:hover {- background-color: var(--mb-color-success);- border-color: var(--mb-color-success);+ background-color: var(--mb-color-feedback-positive);+ border-color: var(--mb-color-feedback-positive);color: var(--mb-color-text-primary-inverse);}.ButtonSuccess:focus-visible {border-color: var(--mb-color-background_page-primary);- outline-color: var(--mb-color-success);+ outline-color: var(--mb-color-feedback-positive);}.ButtonFullWidth {diff --git a/frontend/src/metabase/css/components/form.module.css b/frontend/src/metabase/css/components/form.module.cssindex 0e0608fd780..f1cdc7cc933 100644--- a/frontend/src/metabase/css/components/form.module.css+++ b/frontend/src/metabase/css/components/form.module.css@@ -16,7 +16,7 @@}.FormField.FormFieldError {- color: var(--mb-color-error);+ color: var(--mb-color-feedback-negative);}.FormLabel {@@ -40,7 +40,7 @@}.FormField.FormFieldError .FormInput {- border-color: var(--mb-color-error);+ border-color: var(--mb-color-feedback-negative);}.noFocus:focus {diff --git a/frontend/src/metabase/css/components/list.module.css b/frontend/src/metabase/css/components/list.module.cssindex 0ed29fedb42..7ae1c13e475 100644--- a/frontend/src/metabase/css/components/list.module.css+++ b/frontend/src/metabase/css/components/list.module.css@@ -20,7 +20,7 @@.ListSectionHeaderCursor {border-radius: 8px;- outline: 2px solid var(--mb-color-focus);+ outline: 2px solid var(--mb-color-input-focus);outline-offset: -4px;}@@ -50,7 +50,7 @@}.ListItemCursor {- outline: 2px solid var(--mb-color-focus);+ outline: 2px solid var(--mb-color-input-focus);}.ListItemCursor:not(.ListItemDisabled),diff --git a/frontend/src/metabase/css/core/bordered.module.css b/frontend/src/metabase/css/core/bordered.module.cssindex 9a9945d9426..8baccba619e 100644--- a/frontend/src/metabase/css/core/bordered.module.css+++ b/frontend/src/metabase/css/core/bordered.module.css@@ -49,7 +49,7 @@}.borderSuccess {- border-color: var(--mb-color-success) !important;+ border-color: var(--mb-color-feedback-positive) !important;}.borderBrand {diff --git a/frontend/src/metabase/css/core/colors.module.css b/frontend/src/metabase/css/core/colors.module.cssindex 9b3ff5f78a8..4235ed1ca09 100644--- a/frontend/src/metabase/css/core/colors.module.css+++ b/frontend/src/metabase/css/core/colors.module.css@@ -31,17 +31,17 @@/** Non-whitelabeled Metabase brand color */.textMetabaseBrand {- color: var(--mb-color-metabase-brand);+ color: var(--mb-color-core-metabase_brand);}.textSuccess {- color: var(--mb-color-success);+ color: var(--mb-color-feedback-positive);}/* error */.textError {- color: var(--mb-color-error);+ color: var(--mb-color-feedback-negative);}.textSlate {diff --git a/frontend/src/metabase/css/core/link.module.css b/frontend/src/metabase/css/core/link.module.cssindex acf3e6e7cbf..a8fce5ade76 100644--- a/frontend/src/metabase/css/core/link.module.css+++ b/frontend/src/metabase/css/core/link.module.css@@ -13,7 +13,7 @@}.link:focus {- outline: 2px solid var(--mb-color-focus);+ outline: 2px solid var(--mb-color-input-focus);}.link:focus:not(:focus-visible) {diff --git a/frontend/src/metabase/css/core/shadow.module.css b/frontend/src/metabase/css/core/shadow.module.cssindex 3bf2b878c0a..bdf03eec4b2 100644--- a/frontend/src/metabase/css/core/shadow.module.css+++ b/frontend/src/metabase/css/core/shadow.module.css@@ -1,3 +1,3 @@.shadowed {- box-shadow: 0 2px 2px var(--mb-color-shadow);+ box-shadow: 0 2px 2px var(--mb-color-shadow-default);}diff --git a/frontend/src/metabase/css/dashboard.module.css b/frontend/src/metabase/css/dashboard.module.cssindex 65dfacac682..c222e306c64 100644--- a/frontend/src/metabase/css/dashboard.module.css+++ b/frontend/src/metabase/css/dashboard.module.css@@ -46,7 +46,7 @@/* .react-draggable*, .react-resizable* are 3rd party library classes */.DashEditing .DashCard:global(.react-draggable-dragging) .Card {- box-shadow: 3px 3px 8px var(--mb-color-shadow);+ box-shadow: 3px 3px 8px var(--mb-color-shadow-default);}.BrandColorResizeHandle :global(.react-resizable-handle::after) {diff --git a/frontend/src/metabase/css/reset.module.css b/frontend/src/metabase/css/reset.module.cssindex 386d2d30093..a6a11170680 100644--- a/frontend/src/metabase/css/reset.module.css+++ b/frontend/src/metabase/css/reset.module.css@@ -43,7 +43,7 @@a,[role="button"] {&:focus-visible {- outline: 2px solid var(--mb-color-focus);+ outline: 2px solid var(--mb-color-input-focus);}}diff --git a/frontend/src/metabase/dashboard/actions/actions.ts b/frontend/src/metabase/dashboard/actions/actions.tsindex c253e9f5524..2aecab45410 100644--- a/frontend/src/metabase/dashboard/actions/actions.ts+++ b/frontend/src/metabase/dashboard/actions/actions.ts@@ -62,7 +62,7 @@ export const executeRowAction = async ({if (shouldToast) {dispatch(addUndo({- toastColor: "success",+ toastColor: "feedback-positive",message,}),);@@ -76,7 +76,7 @@ export const executeRowAction = async ({dispatch(addUndo({icon: "warning",- toastColor: "error",+ toastColor: "feedback-negative",message,}),);diff --git a/frontend/src/metabase/dashboard/components/ActionViz/ActionButtonView.tsx b/frontend/src/metabase/dashboard/components/ActionViz/ActionButtonView.tsxindex f0704aba0f1..03a8051d274 100644--- a/frontend/src/metabase/dashboard/components/ActionViz/ActionButtonView.tsx+++ b/frontend/src/metabase/dashboard/components/ActionViz/ActionButtonView.tsx@@ -14,8 +14,8 @@ const BUTTON_VARIANT_PROPS: Record<> = {default: { variant: "default" },primary: { variant: "filled" },- danger: { variant: "filled", color: "error" },- success: { variant: "filled", color: "success" },+ danger: { variant: "filled", color: "feedback-negative" },+ success: { variant: "filled", color: "feedback-positive" },borderless: { variant: "subtle" },};@@ -47,7 +47,7 @@ function ActionButtonView({className={S.actionButton}p={0}h={isFullHeight ? "100%" : undefined}- bd={focus ? "2px solid var(--mb-color-focus)" : undefined}+ bd={focus ? "2px solid var(--mb-color-input-focus)" : undefined}variant={buttonVariant}color={color}disabled={!!disabled}diff --git a/frontend/src/metabase/dashboard/components/ActionViz/ActionParameterMapping.styled.tsx b/frontend/src/metabase/dashboard/components/ActionViz/ActionParameterMapping.styled.tsxindex 8249838219c..9ba85181562 100644--- a/frontend/src/metabase/dashboard/components/ActionViz/ActionParameterMapping.styled.tsx+++ b/frontend/src/metabase/dashboard/components/ActionViz/ActionParameterMapping.styled.tsx@@ -12,7 +12,8 @@ interface ParameterFormLabelProps {}export const ParameterFormLabel = styled.label<ParameterFormLabelProps>`- color: ${(props) => (props.error ? color("error") : color("text-secondary"))};+ color: ${(props) =>+ props.error ? color("feedback-negative") : color("text-secondary")};font-size: 0.75rem;display: flex;gap: var(--mantine-spacing-sm);diff --git a/frontend/src/metabase/dashboard/components/DashCard/DashCardParameterMapper/DashCardParameterMapper.module.css b/frontend/src/metabase/dashboard/components/DashCard/DashCardParameterMapper/DashCardParameterMapper.module.cssindex 389b45537f7..17b96df2e3e 100644--- a/frontend/src/metabase/dashboard/components/DashCard/DashCardParameterMapper/DashCardParameterMapper.module.css+++ b/frontend/src/metabase/dashboard/components/DashCard/DashCardParameterMapper/DashCardParameterMapper.module.css@@ -51,8 +51,8 @@}&.invalid {- border-color: var(--mb-color-error);- background-color: var(--mb-color-error);+ border-color: var(--mb-color-feedback-negative);+ background-color: var(--mb-color-feedback-negative);color: var(--mb-color-text-primary-inverse);}}diff --git a/frontend/src/metabase/dashboard/components/DashboardInfoSidebar/DashboardInfoSidebar.tsx b/frontend/src/metabase/dashboard/components/DashboardInfoSidebar/DashboardInfoSidebar.tsxindex dcaf139634e..b8d346a6c0f 100644--- a/frontend/src/metabase/dashboard/components/DashboardInfoSidebar/DashboardInfoSidebar.tsx+++ b/frontend/src/metabase/dashboard/components/DashboardInfoSidebar/DashboardInfoSidebar.tsx@@ -206,7 +206,7 @@ const OverviewTab = ({onBlur={handleDescriptionBlur}/>{!!descriptionError && (- <Text color="error" size="xs" mt="xs">+ <Text color="feedback-negative" size="xs" mt="xs">{descriptionError}</Text>)}diff --git a/frontend/src/metabase/dashboard/components/DashboardLeaveConfirmationModal/DashboardLeaveConfirmationModal.tsx b/frontend/src/metabase/dashboard/components/DashboardLeaveConfirmationModal/DashboardLeaveConfirmationModal.tsxindex c6255841c35..f2439200768 100644--- a/frontend/src/metabase/dashboard/components/DashboardLeaveConfirmationModal/DashboardLeaveConfirmationModal.tsx+++ b/frontend/src/metabase/dashboard/components/DashboardLeaveConfirmationModal/DashboardLeaveConfirmationModal.tsx@@ -40,7 +40,7 @@ export const DashboardLeaveConfirmationModal = withRouter(title: t`Discard your changes?`,message: t`Your changes haven’t been saved, so you’ll lose them if you navigate away.`,actionBtn: {- color: "danger" as const,+ color: "feedback-negative" as const,message: t`Discard changes`,},};diff --git a/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/AddEditSidebar/DeleteSubscriptionAction.tsx b/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/AddEditSidebar/DeleteSubscriptionAction.tsxindex a8301f74c0d..bf28091dd76 100644--- a/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/AddEditSidebar/DeleteSubscriptionAction.tsx+++ b/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/AddEditSidebar/DeleteSubscriptionAction.tsx@@ -121,7 +121,7 @@ export function DeleteSubscriptionAction({<Flex justify="flex-end" gap="sm"><Button onClick={closeModal}>{t`Cancel`}</Button><Button- color={confirmed ? "danger" : undefined}+ color={confirmed ? "feedback-negative" : undefined}variant="filled"onClick={handleDelete}disabled={!confirmed}diff --git a/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/PulsesListSidebar.module.css b/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/PulsesListSidebar.module.cssindex 98345c2f79f..5c9ae270a93 100644--- a/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/PulsesListSidebar.module.css+++ b/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/PulsesListSidebar.module.css@@ -6,6 +6,6 @@cursor: pointer;&:hover {- background-color: var(--mb-color-brand);+ background-color: var(--mb-color-core-brand);}}diff --git a/frontend/src/metabase/dashboard/components/ParameterSettings/ParameterSettings.module.css b/frontend/src/metabase/dashboard/components/ParameterSettings/ParameterSettings.module.cssindex 87f2b0aa2cd..fc8b117f0b1 100644--- a/frontend/src/metabase/dashboard/components/ParameterSettings/ParameterSettings.module.css+++ b/frontend/src/metabase/dashboard/components/ParameterSettings/ParameterSettings.module.css@@ -3,7 +3,7 @@}.SettingLabelError {- color: var(--mb-color-error);+ color: var(--mb-color-feedback-negative);}.SettingValueWidget {diff --git a/frontend/src/metabase/dashboard/containers/AutomaticDashboardApp/AutomaticDashboardApp.tsx b/frontend/src/metabase/dashboard/containers/AutomaticDashboardApp/AutomaticDashboardApp.tsxindex b191f8ff6e8..35803916b3d 100644--- a/frontend/src/metabase/dashboard/containers/AutomaticDashboardApp/AutomaticDashboardApp.tsx+++ b/frontend/src/metabase/dashboard/containers/AutomaticDashboardApp/AutomaticDashboardApp.tsx@@ -145,7 +145,7 @@ const AutomaticDashboardAppInner = () => {<ActionButtonclassName={cx(CS.mlAuto, CS.textNoWrap)}variant="filled"- color="success"+ color="feedback-positive"// The dashboard isn't always loaded when the header first// renders. Without this guard, "Save this" is clickable while// `dashboard` is undefined, which fires a false `x-ray_saved`diff --git a/frontend/src/metabase/dashboard/visualizations/LinkViz/LinkViz.styled.tsx b/frontend/src/metabase/dashboard/visualizations/LinkViz/LinkViz.styled.tsxindex 501e8e88682..6f3a7961d20 100644--- a/frontend/src/metabase/dashboard/visualizations/LinkViz/LinkViz.styled.tsx+++ b/frontend/src/metabase/dashboard/visualizations/LinkViz/LinkViz.styled.tsx@@ -66,7 +66,7 @@ const searchResultsStyles = `border: 1px solid var(--mb-color-border-neutral);border-radius: 6px;- box-shadow: 0 7px 20px var(--mb-color-shadow);+ box-shadow: 0 7px 20px var(--mb-color-shadow-default);pointer-events: all;`;diff --git a/frontend/src/metabase/data-grid/components/DataGrid/DataGrid.module.css b/frontend/src/metabase/data-grid/components/DataGrid/DataGrid.module.cssindex 6f5be73526c..3a45882a807 100644--- a/frontend/src/metabase/data-grid/components/DataGrid/DataGrid.module.css+++ b/frontend/src/metabase/data-grid/components/DataGrid/DataGrid.module.css@@ -105,7 +105,7 @@.focusedCell {user-select: text;- outline: 2px solid var(--mb-color-focus);+ outline: 2px solid var(--mb-color-input-focus);outline-offset: -2px;}diff --git a/frontend/src/metabase/data-studio/common/components/MoreMenu/MoreMenu.tsx b/frontend/src/metabase/data-studio/common/components/MoreMenu/MoreMenu.tsxindex 2aee0ac4720..3a40cc105fe 100644--- a/frontend/src/metabase/data-studio/common/components/MoreMenu/MoreMenu.tsx+++ b/frontend/src/metabase/data-studio/common/components/MoreMenu/MoreMenu.tsx@@ -56,7 +56,7 @@ export function MoreMenu({)}{onRemove && (<Menu.Item- c="danger"+ c="feedback-negative"leftSection={<Icon name="trash" />}onClick={openConfirm}>diff --git a/frontend/src/metabase/data-studio/components/RevisionHistory/RevisionDiff.tsx b/frontend/src/metabase/data-studio/components/RevisionHistory/RevisionDiff.tsxindex 043f5a6468a..0dd71ab7d0e 100644--- a/frontend/src/metabase/data-studio/components/RevisionHistory/RevisionDiff.tsx+++ b/frontend/src/metabase/data-studio/components/RevisionHistory/RevisionDiff.tsx@@ -62,9 +62,9 @@ function DiffIcon({ before, after }: { before: unknown; after: unknown }) {return <Icon name="pencil" size={12} c="text-secondary" />;}if (before != null) {- return <Icon name="dash" size={12} c="error" />;+ return <Icon name="dash" size={12} c="feedback-negative" />;}- return <Icon name="add" size={12} c="success" />;+ return <Icon name="add" size={12} c="feedback-positive" />;}function getPropertyLabel(property: string, definitionLabel: string): string {diff --git a/frontend/src/metabase/data-studio/data-model/components/DiscardTableFieldValuesButton/DiscardTableFieldValuesButton.tsx b/frontend/src/metabase/data-studio/data-model/components/DiscardTableFieldValuesButton/DiscardTableFieldValuesButton.tsxindex 3b466c07c6f..23da920dd3d 100644--- a/frontend/src/metabase/data-studio/data-model/components/DiscardTableFieldValuesButton/DiscardTableFieldValuesButton.tsx+++ b/frontend/src/metabase/data-studio/data-model/components/DiscardTableFieldValuesButton/DiscardTableFieldValuesButton.tsx@@ -39,7 +39,7 @@ export const DiscardTableFieldValuesButton = ({};return (- <Button c="error" variant="subtle" onClick={handleClick}>+ <Button c="feedback-negative" variant="subtle" onClick={handleClick}>{started ? t`Discard triggered!` : t`Discard cached field values`}</Button>);diff --git a/frontend/src/metabase/data-studio/data-model/components/TablePicker/components/TablePickerTreeTable.tsx b/frontend/src/metabase/data-studio/data-model/components/TablePicker/components/TablePickerTreeTable.tsxindex 208bcafb7ad..e0d65d48be8 100644--- a/frontend/src/metabase/data-studio/data-model/components/TablePicker/components/TablePickerTreeTable.tsx+++ b/frontend/src/metabase/data-studio/data-model/components/TablePicker/components/TablePickerTreeTable.tsx@@ -294,7 +294,7 @@ export function TablePickerTreeTable({<Center w="100%" data-testid="table-published"><Iconname="verified_round"- c="success"+ c="feedback-positive"aria-label={t`Published`}/></Center>diff --git a/frontend/src/metabase/data-studio/data-model/components/TableSection/components/TableAttributesEditSingle.tsx b/frontend/src/metabase/data-studio/data-model/components/TableSection/components/TableAttributesEditSingle.tsxindex 7a7b72bd2a0..548e5858484 100644--- a/frontend/src/metabase/data-studio/data-model/components/TableSection/components/TableAttributesEditSingle.tsx+++ b/frontend/src/metabase/data-studio/data-model/components/TableSection/components/TableAttributesEditSingle.tsx@@ -210,7 +210,7 @@ function TransformLink({ table }: { table: Table }) {if (!transform) {return (<Box- c="error"+ c="feedback-negative"className={S.transformLink}fz="sm">{t`Transform does not exist anymore`}</Box>diff --git a/frontend/src/metabase/databases/components/DatabaseConnectionUri/DatabaseConnectionStringField.tsx b/frontend/src/metabase/databases/components/DatabaseConnectionUri/DatabaseConnectionStringField.tsxindex a58974083fc..b80c1e14076 100644--- a/frontend/src/metabase/databases/components/DatabaseConnectionUri/DatabaseConnectionStringField.tsx+++ b/frontend/src/metabase/databases/components/DatabaseConnectionUri/DatabaseConnectionStringField.tsx@@ -179,13 +179,13 @@ function ConnectionStringDescription({style={styles}pos="absolute"top={0}- c="danger"+ c="feedback-negative"fw="bold"fz="sm"component="span"><Group gap="xs" component="span">- <Icon name="warning_round_filled" c="danger" />+ <Icon name="warning_round_filled" c="feedback-negative" />{t`Couldn’t use this connection string.`}</Group></Text>@@ -205,7 +205,7 @@ function ConnectionStringDescription({style={styles}pos="absolute"top={0}- c="success"+ c="feedback-positive"fw="bold"fz="sm"component="span"@@ -213,7 +213,7 @@ function ConnectionStringDescription({<Group gap="xs" component="span"><Iconname="check_filled"- style={{ color: "var(--mb-color-success)" }}+ style={{ color: "var(--mb-color-feedback-positive)" }}/>{t`Connection details pre-filled below.`}</Group>diff --git a/frontend/src/metabase/databases/components/DatabaseEngineList/DatabaseEngineList.tsx b/frontend/src/metabase/databases/components/DatabaseEngineList/DatabaseEngineList.tsxindex 94aaa48d3e8..17dc0ed1fd8 100644--- a/frontend/src/metabase/databases/components/DatabaseEngineList/DatabaseEngineList.tsx+++ b/frontend/src/metabase/databases/components/DatabaseEngineList/DatabaseEngineList.tsx@@ -232,7 +232,7 @@ const SampleDatabaseIndicator = () => {<Text inline c="text-disabled">{t`(by Metabase)`}</Text></Flex><Group gap="xs">- <Icon name="check_filled" c="success" />+ <Icon name="check_filled" c="feedback-positive" />{t`Included`}</Group></Flex>diff --git a/frontend/src/metabase/databases/components/DatabaseEngineWarning/DatabaseEngineWarning.tsx b/frontend/src/metabase/databases/components/DatabaseEngineWarning/DatabaseEngineWarning.tsxindex 6da761b3c46..b2bbea77f51 100644--- a/frontend/src/metabase/databases/components/DatabaseEngineWarning/DatabaseEngineWarning.tsx+++ b/frontend/src/metabase/databases/components/DatabaseEngineWarning/DatabaseEngineWarning.tsx@@ -76,7 +76,7 @@ const NewEngineWarning = ({ engineName, onChange }: NewEngineWarningProps) => (<Anchorcomponent="button"key="link"- c="brand"+ c="core-brand"fw={700}onClick={onChange}>@@ -101,7 +101,7 @@ const OldEngineWarning = ({ engineName, onChange }: OldEngineWarningProps) => (<Anchorcomponent="button"key="link"- c="brand"+ c="core-brand"fw={700}onClick={onChange}>diff --git a/frontend/src/metabase/documents/components/CommentsSidesheet/CommentsSidesheet.tsx b/frontend/src/metabase/documents/components/CommentsSidesheet/CommentsSidesheet.tsxindex 023700c395f..aca50216755 100644--- a/frontend/src/metabase/documents/components/CommentsSidesheet/CommentsSidesheet.tsx+++ b/frontend/src/metabase/documents/components/CommentsSidesheet/CommentsSidesheet.tsx@@ -180,7 +180,7 @@ export const CommentsSidesheet = ({ params, onClose }: Props) => {if (error) {sendToast({icon: "warning_triangle_filled",- iconColor: "warning",+ iconColor: "feedback-warning",message: t`Failed to send comment`,});} else {diff --git a/frontend/src/metabase/documents/components/DocumentHeader/DocumentPublicLinkPopover/DocumentPublicLinkPopoverContent.tsx b/frontend/src/metabase/documents/components/DocumentHeader/DocumentPublicLinkPopover/DocumentPublicLinkPopoverContent.tsxindex fc98f6f2d76..326e9f540ef 100644--- a/frontend/src/metabase/documents/components/DocumentHeader/DocumentPublicLinkPopover/DocumentPublicLinkPopoverContent.tsx+++ b/frontend/src/metabase/documents/components/DocumentHeader/DocumentPublicLinkPopover/DocumentPublicLinkPopoverContent.tsx@@ -126,7 +126,7 @@ export const DocumentPublicLinkPopoverContent = ({<Anchorcomponent="button"fz="sm"- c="error"+ c="feedback-negative"fw={700}onClick={onRemoveLink}className={S.removeLinkAnchor}diff --git a/frontend/src/metabase/documents/components/EmbedQuestionSettingsSidebar.tsx b/frontend/src/metabase/documents/components/EmbedQuestionSettingsSidebar.tsxindex 6dd0a7b4ab5..1472844de24 100644--- a/frontend/src/metabase/documents/components/EmbedQuestionSettingsSidebar.tsx+++ b/frontend/src/metabase/documents/components/EmbedQuestionSettingsSidebar.tsx@@ -116,7 +116,7 @@ export const EmbedQuestionSettingsSidebar = ({return (<Stack gap="lg" p="lg" className={S.errorContainer}><Box className={S.errorContent}>- <Text c="error">{t`Failed to load question`}</Text>+ <Text c="feedback-negative">{t`Failed to load question`}</Text></Box></Stack>);diff --git a/frontend/src/metabase/embedding-sdk/theme/embedding-color-palette.ts b/frontend/src/metabase/embedding-sdk/theme/embedding-color-palette.tsindex a1eacd8aa3d..0eb30962a4f 100644--- a/frontend/src/metabase/embedding-sdk/theme/embedding-color-palette.ts+++ b/frontend/src/metabase/embedding-sdk/theme/embedding-color-palette.ts@@ -45,14 +45,14 @@ export const SDK_TO_MAIN_APP_COLORS_MAPPING: Record<"background-hover": [],"background-disabled": ["background-disabled", "background_surface-disabled"],"background-light": ["background-secondary", "background_page-secondary"],- shadow: ["shadow"],- positive: ["success"],- negative: ["danger"],- "text-white": ["text-primary-inverse", "white"],- error: ["error"],+ shadow: ["shadow", "shadow-default"],+ positive: ["success", "feedback-positive"],+ negative: ["danger", "feedback-negative"],+ "text-white": ["text-primary-inverse", "white", "core-white"],+ error: ["error", "feedback-negative"],"background-error": ["background-error", "background_surface-error"],"text-hover": ["text-hover", "text-brand-hover"],- focus: ["focus"],+ focus: ["focus", "input-focus"],};/**@@ -69,7 +69,10 @@ export const SDK_MISSING_COLORS_FALLBACK: Partial<* These colors must never be changed.* For example, the blue Metabase brand color.**/-export const SDK_UNCHANGEABLE_COLORS: ColorName[] = ["metabase-brand"];+export const SDK_UNCHANGEABLE_COLORS: ColorName[] = [+ "metabase-brand",+ "core-metabase_brand",+];export const SDK_TO_MAIN_APP_TOOLTIP_COLORS_MAPPING: Record<keyof NonNullable<MetabaseComponentTheme["tooltip"]>,diff --git a/frontend/src/metabase/embedding/components/ArchiveButton.module.css b/frontend/src/metabase/embedding/components/ArchiveButton.module.cssindex 3d13bd67151..3a9d3ec22bb 100644--- a/frontend/src/metabase/embedding/components/ArchiveButton.module.css+++ b/frontend/src/metabase/embedding/components/ArchiveButton.module.css@@ -1,8 +1,8 @@.archiveMenuItem {- color: var(--mb-color-danger);+ color: var(--mb-color-feedback-negative);&:hover:not([data-css-specificity-hack]) {- color: var(--mb-color-danger);+ color: var(--mb-color-feedback-negative);background-color: var(--mb-color-background_surface-error);}}diff --git a/frontend/src/metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/EmbedModalContentStatusBar.tsx b/frontend/src/metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/EmbedModalContentStatusBar.tsxindex 05c2ada6631..a4f29bbe0b8 100644--- a/frontend/src/metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/EmbedModalContentStatusBar.tsx+++ b/frontend/src/metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/EmbedModalContentStatusBar.tsx@@ -55,7 +55,7 @@ export const EmbedModalContentStatusBar = ({) : (<Buttonvariant="subtle"- color="error"+ color="feedback-negative"loading={isUnpublishing || isFetching}onClick={() => {setIsUnpublishing(true);diff --git a/frontend/src/metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/ParametersSettings.tsx b/frontend/src/metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/ParametersSettings.tsxindex c02f6de2ec7..5cd9315de37 100644--- a/frontend/src/metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/ParametersSettings.tsx+++ b/frontend/src/metabase/embedding/components/EmbedModal/StaticEmbedSetupPane/ParametersSettings.tsx@@ -94,7 +94,7 @@ export const ParametersSettings = ({<h3>{parameter.name}{parameter.required && (- <Text color="error" component="span">+ <Text color="feedback-negative" component="span"> *</Text>)}diff --git a/frontend/src/metabase/embedding/components/LogoBadge/LogoBadge.module.css b/frontend/src/metabase/embedding/components/LogoBadge/LogoBadge.module.cssindex c3dcf9fffb0..04c676a47ca 100644--- a/frontend/src/metabase/embedding/components/LogoBadge/LogoBadge.module.css+++ b/frontend/src/metabase/embedding/components/LogoBadge/LogoBadge.module.css@@ -1,7 +1,7 @@.metabaseLink {/* SVG logo */--mb-color-logo-text: #5a6072;- --mb-color-logo-primary: var(--mb-color-metabase-brand);+ --mb-color-logo-primary: var(--mb-color-core-metabase_brand);--mb-color-logo-secondary: #c2daf0;display: flex;diff --git a/frontend/src/metabase/embedding/components/PublicLinkPopover/PublicLinkCopyPanel.tsx b/frontend/src/metabase/embedding/components/PublicLinkPopover/PublicLinkCopyPanel.tsxindex 2c657548c09..66dfbf40d63 100644--- a/frontend/src/metabase/embedding/components/PublicLinkPopover/PublicLinkCopyPanel.tsx+++ b/frontend/src/metabase/embedding/components/PublicLinkPopover/PublicLinkCopyPanel.tsx@@ -70,7 +70,7 @@ export const PublicLinkCopyPanel = ({component="button"style={{ whiteSpace: "nowrap" }}fz="sm"- c="error"+ c="feedback-negative"fw={700}onClick={onRemoveLink}>diff --git a/frontend/src/metabase/embedding/embedding-hub/components/EmbeddingHubXrayPickerModal.tsx b/frontend/src/metabase/embedding/embedding-hub/components/EmbeddingHubXrayPickerModal.tsxindex 9004969557e..3ec5f888879 100644--- a/frontend/src/metabase/embedding/embedding-hub/components/EmbeddingHubXrayPickerModal.tsx+++ b/frontend/src/metabase/embedding/embedding-hub/components/EmbeddingHubXrayPickerModal.tsx@@ -68,7 +68,7 @@ export const EmbeddingHubXrayPickerModal = ({} catch {sendToast({icon: "warning",- toastColor: "error",+ toastColor: "feedback-negative",message: t`Failed to create dashboard`,});}diff --git a/frontend/src/metabase/embedding/embedding-hub/components/SetupPermissionsAndTenantsPage/ConnectionImpersonationStepContent.tsx b/frontend/src/metabase/embedding/embedding-hub/components/SetupPermissionsAndTenantsPage/ConnectionImpersonationStepContent.tsxindex 7fc7bbfa6ec..f095c255e40 100644--- a/frontend/src/metabase/embedding/embedding-hub/components/SetupPermissionsAndTenantsPage/ConnectionImpersonationStepContent.tsx+++ b/frontend/src/metabase/embedding/embedding-hub/components/SetupPermissionsAndTenantsPage/ConnectionImpersonationStepContent.tsx@@ -60,7 +60,7 @@ export const ConnectionImpersonationStepContent = ({t`Failed to configure connection impersonation`,);- sendToast({ icon: "warning", toastColor: "error", message });+ sendToast({ icon: "warning", toastColor: "feedback-negative", message });} finally {setUpdatingPermissions(false);}diff --git a/frontend/src/metabase/embedding/embedding-hub/components/SetupPermissionsAndTenantsPage/EnableTenantsStepContent.tsx b/frontend/src/metabase/embedding/embedding-hub/components/SetupPermissionsAndTenantsPage/EnableTenantsStepContent.tsxindex f91acd8996d..7067a906077 100644--- a/frontend/src/metabase/embedding/embedding-hub/components/SetupPermissionsAndTenantsPage/EnableTenantsStepContent.tsx+++ b/frontend/src/metabase/embedding/embedding-hub/components/SetupPermissionsAndTenantsPage/EnableTenantsStepContent.tsx@@ -53,7 +53,7 @@ export const EnableTenantsStepContent = ({} catch (error) {sendToast({icon: "warning",- toastColor: "error",+ toastColor: "feedback-negative",message: getErrorMessage(error,t`Failed to enable tenants and create shared collection`,diff --git a/frontend/src/metabase/embedding/embedding-hub/components/SetupPermissionsAndTenantsPage/MoveDashboardStepContent.tsx b/frontend/src/metabase/embedding/embedding-hub/components/SetupPermissionsAndTenantsPage/MoveDashboardStepContent.tsxindex 8dd5ee886bd..b67e8403849 100644--- a/frontend/src/metabase/embedding/embedding-hub/components/SetupPermissionsAndTenantsPage/MoveDashboardStepContent.tsx+++ b/frontend/src/metabase/embedding/embedding-hub/components/SetupPermissionsAndTenantsPage/MoveDashboardStepContent.tsx@@ -59,7 +59,7 @@ export const MoveDashboardStepContent = ({} catch (error) {sendToast({icon: "warning",- toastColor: "error",+ toastColor: "feedback-negative",message: getErrorMessage(error,t`Failed to move dashboard to the shared collection`,@@ -85,7 +85,7 @@ export const MoveDashboardStepContent = ({} catch (error) {sendToast({icon: "warning",- toastColor: "error",+ toastColor: "feedback-negative",message: getErrorMessage(error, t`Failed to create a sample dashboard`),});}diff --git a/frontend/src/metabase/embedding/embedding-hub/components/SetupPermissionsAndTenantsPage/RlsDataSelector/RlsDataSelector.tsx b/frontend/src/metabase/embedding/embedding-hub/components/SetupPermissionsAndTenantsPage/RlsDataSelector/RlsDataSelector.tsxindex 8292dc48c3a..0150d3500b7 100644--- a/frontend/src/metabase/embedding/embedding-hub/components/SetupPermissionsAndTenantsPage/RlsDataSelector/RlsDataSelector.tsx+++ b/frontend/src/metabase/embedding/embedding-hub/components/SetupPermissionsAndTenantsPage/RlsDataSelector/RlsDataSelector.tsx@@ -62,7 +62,7 @@ export const RlsDataSelector = ({} catch (error) {sendToast({icon: "warning",- toastColor: "error",+ toastColor: "feedback-negative",message: getErrorMessage(error,t`Failed to configure row-level security`,diff --git a/frontend/src/metabase/embedding/embedding-hub/components/SetupSsoPage/SetupJwtStep.tsx b/frontend/src/metabase/embedding/embedding-hub/components/SetupSsoPage/SetupJwtStep.tsxindex 0f814e06181..9a3badb1116 100644--- a/frontend/src/metabase/embedding/embedding-hub/components/SetupSsoPage/SetupJwtStep.tsx+++ b/frontend/src/metabase/embedding/embedding-hub/components/SetupSsoPage/SetupJwtStep.tsx@@ -40,7 +40,7 @@ export const SetupJwtStep = ({ onSuccess }: { onSuccess: () => void }) => {} catch (error) {sendToast({icon: "warning",- toastColor: "error",+ toastColor: "feedback-negative",message: t`Failed to enable JWT authentication`,});}diff --git a/frontend/src/metabase/embedding/embedding-hub/components/SetupSsoPage/TestJwtStep.tsx b/frontend/src/metabase/embedding/embedding-hub/components/SetupSsoPage/TestJwtStep.tsxindex 7f8b8bb607b..e3df2fa37a1 100644--- a/frontend/src/metabase/embedding/embedding-hub/components/SetupSsoPage/TestJwtStep.tsx+++ b/frontend/src/metabase/embedding/embedding-hub/components/SetupSsoPage/TestJwtStep.tsx@@ -25,7 +25,7 @@ export const TestJwtStep = () => {} catch (error) {sendToast({icon: "warning",- toastColor: "error",+ toastColor: "feedback-negative",message: t`Failed to save SSO test status`,});}diff --git a/frontend/src/metabase/embedding/embedding-hub/components/StepperWithCards/StepperWithCards.module.css b/frontend/src/metabase/embedding/embedding-hub/components/StepperWithCards/StepperWithCards.module.cssindex ba19358ced0..7348b561c14 100644--- a/frontend/src/metabase/embedding/embedding-hub/components/StepperWithCards/StepperWithCards.module.css+++ b/frontend/src/metabase/embedding/embedding-hub/components/StepperWithCards/StepperWithCards.module.css@@ -20,12 +20,12 @@.step:not(.stepDone) .stepIcon {color: var(--mb-color-text-primary);border-color: transparent;- background: var(--mb-color-focus);+ background: var(--mb-color-input-focus);}.step.stepDone .stepIcon {color: var(--mb-color-background_page-primary);- background: var(--mb-color-success-secondary);+ background: var(--mb-color-feedback-positive-selected);/** Prevent blue border color from affecting the done icon */border-color: transparent;@@ -71,7 +71,7 @@}.stepCard.nextStepCard {- border: 1px solid var(--mb-color-metabase-brand) !important;+ border: 1px solid var(--mb-color-core-metabase_brand) !important;}.infoAlertWrapper {diff --git a/frontend/src/metabase/embedding/embedding-hub/components/StepperWithCards/StepperWithCards.tsx b/frontend/src/metabase/embedding/embedding-hub/components/StepperWithCards/StepperWithCards.tsxindex 557c030566c..b90a3421e1e 100644--- a/frontend/src/metabase/embedding/embedding-hub/components/StepperWithCards/StepperWithCards.tsx+++ b/frontend/src/metabase/embedding/embedding-hub/components/StepperWithCards/StepperWithCards.tsx@@ -147,10 +147,13 @@ export const StepperWithCards = ({ steps }: { steps: StepperStep[] }) => {<Group gap="xs"><Iconname="check"- c="success-secondary"+ c="feedback-positive-selected"size={12}/>- <Text size="sm" c="success-secondary">+ <Text+ size="sm"+ c="feedback-positive-selected"+ >{t`Done`}</Text></Group>diff --git a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/SdkIframeEmbedSiteUrlMismatchError.tsx b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/SdkIframeEmbedSiteUrlMismatchError.tsxindex d953bbf7a73..c58dbe98718 100644--- a/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/SdkIframeEmbedSiteUrlMismatchError.tsx+++ b/frontend/src/metabase/embedding/embedding-iframe-sdk-setup/components/SdkIframeEmbedSiteUrlMismatchError.tsx@@ -32,7 +32,7 @@ export const SdkIframeEmbedSiteUrlMismatchError = ({mx="auto"p="xl">- <Icon name="warning" size={48} c="warning" />+ <Icon name="warning" size={48} c="feedback-warning" /><Text fw="bold" size="lg" ta="center">{t`The preview can't load because the Site URL doesn't match the host you're using.`}diff --git a/frontend/src/metabase/embedding/mcp/ChartTypePicker/ChartTypePicker.module.css b/frontend/src/metabase/embedding/mcp/ChartTypePicker/ChartTypePicker.module.cssindex a1ac75000c6..afd6644c5c8 100644--- a/frontend/src/metabase/embedding/mcp/ChartTypePicker/ChartTypePicker.module.css+++ b/frontend/src/metabase/embedding/mcp/ChartTypePicker/ChartTypePicker.module.css@@ -1,3 +1,3 @@.selected {- box-shadow: 0 1px 2px var(--mb-color-shadow);+ box-shadow: 0 1px 2px var(--mb-color-shadow-default);}diff --git a/frontend/src/metabase/forms/components/FormErrorMessage/FormErrorMessage.tsx b/frontend/src/metabase/forms/components/FormErrorMessage/FormErrorMessage.tsxindex 0f4c5fdd8f0..23a76144123 100644--- a/frontend/src/metabase/forms/components/FormErrorMessage/FormErrorMessage.tsx+++ b/frontend/src/metabase/forms/components/FormErrorMessage/FormErrorMessage.tsx@@ -18,7 +18,13 @@ export const FormErrorMessage = forwardRef(function FormErrorMessage(}return (- <Text {...props} role="alert" aria-label={message} ref={ref} c="error">+ <Text+ {...props}+ role="alert"+ aria-label={message}+ ref={ref}+ c="feedback-negative"+ >{message}</Text>);diff --git a/frontend/src/metabase/forms/components/FormField/FormField.tsx b/frontend/src/metabase/forms/components/FormField/FormField.tsxindex 76e2949860d..3e1698eadfb 100644--- a/frontend/src/metabase/forms/components/FormField/FormField.tsx+++ b/frontend/src/metabase/forms/components/FormField/FormField.tsx@@ -42,14 +42,14 @@ export const FormField = forwardRef(function FormField({hasTitle && (<Textcomponent="label"- c={hasError ? "error" : "text-primary"}+ c={hasError ? "feedback-negative" : "text-primary"}htmlFor={htmlFor}fw="bold"fz="md">{title}{hasError && (- <Text component="span" c="error" role="alert">+ <Text component="span" c="feedback-negative" role="alert">: {error}</Text>)}diff --git a/frontend/src/metabase/forms/components/FormMessage/FormMessage.styled.tsx b/frontend/src/metabase/forms/components/FormMessage/FormMessage.styled.tsxindex 3dba947eeb8..0f0bca051d6 100644--- a/frontend/src/metabase/forms/components/FormMessage/FormMessage.styled.tsx+++ b/frontend/src/metabase/forms/components/FormMessage/FormMessage.styled.tsx@@ -11,7 +11,9 @@ export const FormMessageStyled = styled.span<{noPadding?: boolean;}>`color: ${({ hasSucceeded }) =>- hasSucceeded ? "var(--mb-color-success)" : color("error")};+ hasSucceeded+ ? "var(--mb-color-feedback-positive)"+ : color("feedback-negative")};float: left;opacity: 0;padding-bottom: ${({ noPadding }) =>diff --git a/frontend/src/metabase/forms/components/FormSecretKey/FormSecretKey.tsx b/frontend/src/metabase/forms/components/FormSecretKey/FormSecretKey.tsxindex ca579cbdc29..1ea30832218 100644--- a/frontend/src/metabase/forms/components/FormSecretKey/FormSecretKey.tsx+++ b/frontend/src/metabase/forms/components/FormSecretKey/FormSecretKey.tsx@@ -63,7 +63,7 @@ export const FormSecretKey = forwardRef(function FormSecretKey(}}{...generateSecretButtonProps}/>- {!!error && <Text c="error">{error}</Text>}+ {!!error && <Text c="feedback-negative">{error}</Text>}</Stack>{showModal && (<SetupKeyModaldiff --git a/frontend/src/metabase/forms/components/FormSubmitButton/FormSubmitButton.tsx b/frontend/src/metabase/forms/components/FormSubmitButton/FormSubmitButton.tsxindex e9915b571a2..d2392e037b7 100644--- a/frontend/src/metabase/forms/components/FormSubmitButton/FormSubmitButton.tsx+++ b/frontend/src/metabase/forms/components/FormSubmitButton/FormSubmitButton.tsx@@ -61,9 +61,9 @@ const getSubmitButtonColor = () => {switch (status) {case "fulfilled":- return "success";+ return "feedback-positive";case "rejected":- return "error";+ return "feedback-negative";default:return color;}diff --git a/frontend/src/metabase/home/components/HomeCard/HomeCard.styled.tsx b/frontend/src/metabase/home/components/HomeCard/HomeCard.styled.tsxindex 4415a07c3af..ea1d00afb3e 100644--- a/frontend/src/metabase/home/components/HomeCard/HomeCard.styled.tsx+++ b/frontend/src/metabase/home/components/HomeCard/HomeCard.styled.tsx@@ -15,7 +15,7 @@ export const CardRoot = styled(Link)`border: 1px solid var(--mb-color-border-neutral);border-radius: 0.5rem;background-color: var(--mb-color-background_page-primary);- box-shadow: 0 7px 20px var(--mb-color-shadow);+ box-shadow: 0 7px 20px var(--mb-color-shadow-default);max-width: 100%;${breakpointMinSmall} {@@ -27,6 +27,6 @@ export const CardRoot = styled(Link)`}&:hover {- box-shadow: 0 10px 22px ${() => alpha("shadow", 0.09)};+ box-shadow: 0 10px 22px ${() => alpha("shadow-default", 0.09)};}`;diff --git a/frontend/src/metabase/home/components/HomeXraySection/HomeXraySection.styled.tsx b/frontend/src/metabase/home/components/HomeXraySection/HomeXraySection.styled.tsxindex 87cb179b358..c183ef763a1 100644--- a/frontend/src/metabase/home/components/HomeXraySection/HomeXraySection.styled.tsx+++ b/frontend/src/metabase/home/components/HomeXraySection/HomeXraySection.styled.tsx@@ -17,7 +17,7 @@ export const DatabaseLink = styled(Link)``;export const DatabaseLinkIcon = styled(Icon)`- color: var(--mb-color-focus);+ color: var(--mb-color-input-focus);width: 1rem;height: 1rem;margin-right: 0.25rem;diff --git a/frontend/src/metabase/home/components/Onboarding/Onboarding.tsx b/frontend/src/metabase/home/components/Onboarding/Onboarding.tsxindex b17ccebbad4..a3e5825171e 100644--- a/frontend/src/metabase/home/components/Onboarding/Onboarding.tsx+++ b/frontend/src/metabase/home/components/Onboarding/Onboarding.tsx@@ -339,7 +339,7 @@ export const Onboarding = () => {<Text>{jt`Hover over a table and click the yellow lightning bolt ${(<Icon- c="warning"+ c="feedback-warning"className={S.inlineIcon}key="bolt_icon"name="bolt_filled"diff --git a/frontend/src/metabase/metabot/components/AIProviderConfigurationForm/AIProviderConfigurationForm.tsx b/frontend/src/metabase/metabot/components/AIProviderConfigurationForm/AIProviderConfigurationForm.tsxindex 38b925953d9..cffcb2be797 100644--- a/frontend/src/metabase/metabot/components/AIProviderConfigurationForm/AIProviderConfigurationForm.tsx+++ b/frontend/src/metabase/metabot/components/AIProviderConfigurationForm/AIProviderConfigurationForm.tsx@@ -130,7 +130,7 @@ export function AIProviderConfigurationForm({sendToast({message,icon: "warning",- toastColor: "error",+ toastColor: "feedback-negative",});}} catch (error) {@@ -142,7 +142,7 @@ export function AIProviderConfigurationForm({sendToast({message,icon: "warning",- toastColor: "error",+ toastColor: "feedback-negative",});}}, [@@ -296,7 +296,7 @@ export function AIProviderConfigurationForm({{ isCurrentConfigured: true, isConnectButtonEnabled: false },() => (<Button- c="danger"+ c="feedback-negative"loading={isMutating}disabled={isMutating}onClick={handleDisconnect}diff --git a/frontend/src/metabase/metabot/components/AIProviderConfigurationForm/ApiKeyProviderFields.tsx b/frontend/src/metabase/metabot/components/AIProviderConfigurationForm/ApiKeyProviderFields.tsxindex 2fb23c776b7..6f113b9fb48 100644--- a/frontend/src/metabase/metabot/components/AIProviderConfigurationForm/ApiKeyProviderFields.tsx+++ b/frontend/src/metabase/metabot/components/AIProviderConfigurationForm/ApiKeyProviderFields.tsx@@ -110,7 +110,7 @@ export const ApiKeyProviderFields = ({)}{updateMetabotSettingsResult.error && (- <Text size="sm" c="error">+ <Text size="sm" c="feedback-negative">{getErrorMessage(updateMetabotSettingsResult.error,t`Unable to save provider settings.`,diff --git a/frontend/src/metabase/metabot/components/AIProviderConfigurationForm/BedrockProviderFields.tsx b/frontend/src/metabase/metabot/components/AIProviderConfigurationForm/BedrockProviderFields.tsxindex 9a05c4059ee..8da3a99daee 100644--- a/frontend/src/metabase/metabot/components/AIProviderConfigurationForm/BedrockProviderFields.tsx+++ b/frontend/src/metabase/metabot/components/AIProviderConfigurationForm/BedrockProviderFields.tsx@@ -158,7 +158,7 @@ const BedrockCredentialFields = ({/>{accessKeyIdEnvName && <SetByEnvVar varName={accessKeyIdEnvName} />}{credentialsError && (- <Text size="sm" c="error" role="alert">+ <Text size="sm" c="feedback-negative" role="alert">{credentialsError}</Text>)}diff --git a/frontend/src/metabase/metabot/components/AIProviderConfigurationNotice.tsx b/frontend/src/metabase/metabot/components/AIProviderConfigurationNotice.tsxindex 3b1afd9fe5d..966661d8707 100644--- a/frontend/src/metabase/metabot/components/AIProviderConfigurationNotice.tsx+++ b/frontend/src/metabase/metabot/components/AIProviderConfigurationNotice.tsx@@ -86,7 +86,7 @@ export const getMetabotNotConfiguredToastProps = ({dark: false,icon: "metabot" as const,iconColor: "core-brand" as const,- toastColor: "error",+ toastColor: "feedback-negative" as const,dismissIconColor: "text-secondary" as const,timeout: 0,style: {diff --git a/frontend/src/metabase/metabot/components/FixSqlQueryButton/FixSqlQueryButton.tsx b/frontend/src/metabase/metabot/components/FixSqlQueryButton/FixSqlQueryButton.tsxindex d57a3f13f8f..8915f08a658 100644--- a/frontend/src/metabase/metabot/components/FixSqlQueryButton/FixSqlQueryButton.tsx+++ b/frontend/src/metabase/metabot/components/FixSqlQueryButton/FixSqlQueryButton.tsx@@ -55,7 +55,7 @@ export function FixSqlQueryButton() {sendToast({icon: "warning",- toastColor: "error",+ toastColor: "feedback-negative",message: action.payload.error?.message ?? METABOT_ERR_MSG.default,});};diff --git a/frontend/src/metabase/metabot/components/MetabotAsk/MetabotGreeting.module.css b/frontend/src/metabase/metabot/components/MetabotAsk/MetabotGreeting.module.cssindex 99f09a9bd2a..8429040f982 100644--- a/frontend/src/metabase/metabot/components/MetabotAsk/MetabotGreeting.module.css+++ b/frontend/src/metabase/metabot/components/MetabotAsk/MetabotGreeting.module.css@@ -64,9 +64,9 @@&:disabled,&:disabled:hover {- background-color: var(--mb-color-brand);+ background-color: var(--mb-color-core-brand);color: var(--mb-color-text-primary-inverse);- border-color: var(--mb-color-brand);+ border-color: var(--mb-color-core-brand);opacity: 0.35;}}diff --git a/frontend/src/metabase/metabot/components/MetabotChat/MetabotAgentDataPartMessage.module.css b/frontend/src/metabase/metabot/components/MetabotChat/MetabotAgentDataPartMessage.module.cssindex e05397fbeb6..0ba5dc71938 100644--- a/frontend/src/metabase/metabot/components/MetabotChat/MetabotAgentDataPartMessage.module.css+++ b/frontend/src/metabase/metabot/components/MetabotChat/MetabotAgentDataPartMessage.module.css@@ -8,7 +8,7 @@}.sourceDataHeader:focus-visible {- outline: 2px solid var(--mb-color-focus);+ outline: 2px solid var(--mb-color-input-focus);outline-offset: -2px;}@@ -36,6 +36,6 @@}.sourceItemLink:focus-visible {- outline: 2px solid var(--mb-color-focus);+ outline: 2px solid var(--mb-color-input-focus);outline-offset: 2px;}diff --git a/frontend/src/metabase/metabot/components/MetabotChat/MetabotAgentSuggestionMessage.module.css b/frontend/src/metabase/metabot/components/MetabotChat/MetabotAgentSuggestionMessage.module.cssindex fec0101d519..394406375c7 100644--- a/frontend/src/metabase/metabot/components/MetabotChat/MetabotAgentSuggestionMessage.module.css+++ b/frontend/src/metabase/metabot/components/MetabotChat/MetabotAgentSuggestionMessage.module.css@@ -19,7 +19,11 @@}.suggestionEditorOnlyNew {- background: color-mix(in srgb, var(--mb-color-success) 11%, transparent);+ background: color-mix(+ in srgb,+ var(--mb-color-feedback-positive) 11%,+ transparent+ );:global {.cm-gutters {diff --git a/frontend/src/metabase/metabot/components/MetabotChat/MetabotAgentSuggestionMessage.tsx b/frontend/src/metabase/metabot/components/MetabotChat/MetabotAgentSuggestionMessage.tsxindex 14433e61a6e..0f6da0bb874 100644--- a/frontend/src/metabase/metabot/components/MetabotChat/MetabotAgentSuggestionMessage.tsx+++ b/frontend/src/metabase/metabot/components/MetabotChat/MetabotAgentSuggestionMessage.tsx@@ -236,7 +236,10 @@ export const AgentSuggestionMessage = ({align="center"gap="sm">- <Text mb="1px" c="danger">{t`Failed to load preview`}</Text>+ <Text+ mb="1px"+ c="feedback-negative"+ >{t`Failed to load preview`}</Text></Flex>)).with({ isLoading: true }, () => (@@ -278,7 +281,9 @@ export const AgentSuggestionMessage = ({variant="subtle"fw="normal"fz="sm"- c={canApply && !readonly ? "success" : "text-disabled"}+ c={+ canApply && !readonly ? "feedback-positive" : "text-disabled"+ }disabled={!canApply || readonly}onClick={handleApply}>diff --git a/frontend/src/metabase/metabot/components/MetabotChat/MetabotAgentTodoMessage.tsx b/frontend/src/metabase/metabot/components/MetabotChat/MetabotAgentTodoMessage.tsxindex 39fb1dd19c9..ec182347c7d 100644--- a/frontend/src/metabase/metabot/components/MetabotChat/MetabotAgentTodoMessage.tsx+++ b/frontend/src/metabase/metabot/components/MetabotChat/MetabotAgentTodoMessage.tsx@@ -80,7 +80,7 @@ export const AgentTodoListMessage = ({justify="center"mr="sm">- <Icon name="check" size=".7rem" c="white" />+ <Icon name="check" size=".7rem" c="core-white" /></Flex>)).with("in_progress", () => (@@ -90,7 +90,7 @@ export const AgentTodoListMessage = ({justify="center"mr="sm">- <Icon name="arrow_right" size=".6rem" c="white" />+ <Icon name="arrow_right" size=".6rem" c="core-white" /></Flex>)).with("cancelled", () => (@@ -101,7 +101,7 @@ export const AgentTodoListMessage = ({justify="center"mr="sm">- <Icon name="close" size=".7rem" c="white" />+ <Icon name="close" size=".7rem" c="core-white" /></Flex>)).exhaustive()}diff --git a/frontend/src/metabase/metabot/components/MetabotChat/MetabotAgentToolCallMessage.tsx b/frontend/src/metabase/metabot/components/MetabotChat/MetabotAgentToolCallMessage.tsxindex 4f03c5b2432..66eb3492840 100644--- a/frontend/src/metabase/metabot/components/MetabotChat/MetabotAgentToolCallMessage.tsx+++ b/frontend/src/metabase/metabot/components/MetabotChat/MetabotAgentToolCallMessage.tsx@@ -87,7 +87,11 @@ const ToolCallDetailsModal = ({<Flex align="center"><Text fw="bold">{t`Response`}</Text>{message.is_error && (- <Badge ml="sm" bg="danger" c="text-primary-inverse">+ <Badge+ ml="sm"+ bg="feedback-negative"+ c="text-primary-inverse"+ >{t`Errored`}</Badge>)}diff --git a/frontend/src/metabase/metabot/components/MetabotChat/MetabotChatMessage.tsx b/frontend/src/metabase/metabot/components/MetabotChat/MetabotChatMessage.tsxindex cd3df81e7af..644792d4762 100644--- a/frontend/src/metabase/metabot/components/MetabotChat/MetabotChatMessage.tsx+++ b/frontend/src/metabase/metabot/components/MetabotChat/MetabotChatMessage.tsx@@ -297,7 +297,7 @@ const AgentTurnAlert = ({<Flex align="center" gap="sm"><Iconname={variant === "error" ? "warning" : "info"}- c={variant === "error" ? "error" : "text-secondary"}+ c={variant === "error" ? "feedback-negative" : "text-secondary"}size="1rem"flex="0 0 auto"/>diff --git a/frontend/src/metabase/metabot/components/MetabotChat/MetabotInlineChart.module.css b/frontend/src/metabase/metabot/components/MetabotChat/MetabotInlineChart.module.cssindex db1e8fcced1..7214f0d6a90 100644--- a/frontend/src/metabase/metabot/components/MetabotChat/MetabotInlineChart.module.css+++ b/frontend/src/metabase/metabot/components/MetabotChat/MetabotInlineChart.module.css@@ -14,7 +14,7 @@text-decoration: none;&:hover {- color: var(--mb-color-brand);+ color: var(--mb-color-core-brand);text-decoration: none;}}diff --git a/frontend/src/metabase/metabot/components/MetabotInlineSQLPrompt/MetabotInlineSQLPrompt.tsx b/frontend/src/metabase/metabot/components/MetabotInlineSQLPrompt/MetabotInlineSQLPrompt.tsxindex 1cf36a5859b..83749663307 100644--- a/frontend/src/metabase/metabot/components/MetabotInlineSQLPrompt/MetabotInlineSQLPrompt.tsx+++ b/frontend/src/metabase/metabot/components/MetabotInlineSQLPrompt/MetabotInlineSQLPrompt.tsx@@ -117,7 +117,12 @@ export const MetabotInlineSQLPrompt = ({)}<Flex justify="space-between" align="center" gap="sm" mt="xs">- <Box data-testid="metabot-inline-sql-error" w="100%" fz="sm" c="error">+ <Box+ data-testid="metabot-inline-sql-error"+ w="100%"+ fz="sm"+ c="feedback-negative"+ >{error?.type === "locked" ? (<MetabotManagedProviderLimitHoverCard />) : (diff --git a/frontend/src/metabase/metabot/components/MetabotManagedProviderLimit.tsx b/frontend/src/metabase/metabot/components/MetabotManagedProviderLimit.tsxindex 44192521d20..d01706cf11e 100644--- a/frontend/src/metabase/metabot/components/MetabotManagedProviderLimit.tsx+++ b/frontend/src/metabase/metabot/components/MetabotManagedProviderLimit.tsx@@ -183,7 +183,7 @@ export const getMetabotManagedProviderLimitToastProps = () => ({id: METABOT_MANAGED_PROVIDER_LIMIT_TOAST_ID,dark: false,icon: null,- toastColor: "error",+ toastColor: "feedback-negative" as const,dismissIconColor: "text-secondary" as const,timeout: 0,style: {diff --git a/frontend/src/metabase/metadata/components/DiscardFieldValuesButton/DiscardFieldValuesButton.tsx b/frontend/src/metabase/metadata/components/DiscardFieldValuesButton/DiscardFieldValuesButton.tsxindex eb70d8cf46c..0a8f72204bb 100644--- a/frontend/src/metabase/metadata/components/DiscardFieldValuesButton/DiscardFieldValuesButton.tsx+++ b/frontend/src/metabase/metadata/components/DiscardFieldValuesButton/DiscardFieldValuesButton.tsx@@ -26,7 +26,7 @@ export const DiscardFieldValuesButton = ({ fieldId }: Props) => {};return (- <Button c="error" variant="subtle" onClick={handleClick}>+ <Button c="feedback-negative" variant="subtle" onClick={handleClick}>{started ? t`Discard triggered!` : t`Discard cached field values`}</Button>);diff --git a/frontend/src/metabase/metadata/components/DiscardTableFieldValuesButton/DiscardTableFieldValuesButton.tsx b/frontend/src/metabase/metadata/components/DiscardTableFieldValuesButton/DiscardTableFieldValuesButton.tsxindex 10132c55a84..54788080f9d 100644--- a/frontend/src/metabase/metadata/components/DiscardTableFieldValuesButton/DiscardTableFieldValuesButton.tsx+++ b/frontend/src/metabase/metadata/components/DiscardTableFieldValuesButton/DiscardTableFieldValuesButton.tsx@@ -26,7 +26,7 @@ export const DiscardTableFieldValuesButton = ({ tableId }: Props) => {};return (- <Button c="error" variant="subtle" onClick={handleClick}>+ <Button c="feedback-negative" variant="subtle" onClick={handleClick}>{started ? t`Discard triggered!` : t`Discard cached field values`}</Button>);diff --git a/frontend/src/metabase/metadata/hooks/useMetadataToasts.ts b/frontend/src/metabase/metadata/hooks/useMetadataToasts.tsindex 41f0015e097..e97e7e62bcb 100644--- a/frontend/src/metabase/metadata/hooks/useMetadataToasts.ts+++ b/frontend/src/metabase/metadata/hooks/useMetadataToasts.ts@@ -22,7 +22,7 @@ export const useMetadataToasts = () => {(message: string) => {sendToast({icon: "warning_triangle_filled",- iconColor: "warning",+ iconColor: "feedback-warning",message,});},diff --git a/frontend/src/metabase/metadata/pages/DataModelV1/components/TablePicker/components/Results.module.css b/frontend/src/metabase/metadata/pages/DataModelV1/components/TablePicker/components/Results.module.cssindex e51334dd781..9f073d7e5cb 100644--- a/frontend/src/metabase/metadata/pages/DataModelV1/components/TablePicker/components/Results.module.css+++ b/frontend/src/metabase/metadata/pages/DataModelV1/components/TablePicker/components/Results.module.css@@ -15,7 +15,7 @@&:focus-visible,&.selected {- outline: 2px solid var(--mb-color-focus);+ outline: 2px solid var(--mb-color-input-focus);}&:hover {diff --git a/frontend/src/metabase/metrics-viewer/components/MetricControls/CenterControls/components/ControlsContent/ControlsContent.tsx b/frontend/src/metabase/metrics-viewer/components/MetricControls/CenterControls/components/ControlsContent/ControlsContent.tsxindex 7578ca11eb2..c1f0876da97 100644--- a/frontend/src/metabase/metrics-viewer/components/MetricControls/CenterControls/components/ControlsContent/ControlsContent.tsx+++ b/frontend/src/metabase/metrics-viewer/components/MetricControls/CenterControls/components/ControlsContent/ControlsContent.tsx@@ -125,7 +125,11 @@ export function ControlsContent(props: ControlsContentProps) {color="text-primary"leftSection={columnPickerIcon ? (- <Icon c="brand" name={columnPickerIcon} size={16} />+ <Icon+ c="core-brand"+ name={columnPickerIcon}+ size={16}+ />) : undefined}onClick={handleOpenSidebar}diff --git a/frontend/src/metabase/metrics-viewer/components/MetricControls/CenterControls/components/NoBreakoutControls.tsx b/frontend/src/metabase/metrics-viewer/components/MetricControls/CenterControls/components/NoBreakoutControls.tsxindex b7cb3da7a53..1c2d7f4bc2a 100644--- a/frontend/src/metabase/metrics-viewer/components/MetricControls/CenterControls/components/NoBreakoutControls.tsx+++ b/frontend/src/metabase/metrics-viewer/components/MetricControls/CenterControls/components/NoBreakoutControls.tsx@@ -19,7 +19,7 @@ export function NoBreakoutControls() {aria-label={t`No breakout`}variant="subtle"color="text-primary"- leftSection={<Icon c="brand" name="unreferenced" size={16} />}+ leftSection={<Icon c="core-brand" name="unreferenced" size={16} />}onClick={openSidebar}>{t`No breakout`}diff --git a/frontend/src/metabase/metrics-viewer/components/MetricControls/LeftControls/ChartLayoutPicker/ChartLayoutPicker.module.css b/frontend/src/metabase/metrics-viewer/components/MetricControls/LeftControls/ChartLayoutPicker/ChartLayoutPicker.module.cssindex 5108f8e181e..e67d37405dd 100644--- a/frontend/src/metabase/metrics-viewer/components/MetricControls/LeftControls/ChartLayoutPicker/ChartLayoutPicker.module.css+++ b/frontend/src/metabase/metrics-viewer/components/MetricControls/LeftControls/ChartLayoutPicker/ChartLayoutPicker.module.css@@ -7,5 +7,5 @@}.selected {- box-shadow: 0 1px 2px var(--mb-color-shadow);+ box-shadow: 0 1px 2px var(--mb-color-shadow-default);}diff --git a/frontend/src/metabase/metrics-viewer/components/MetricControls/LeftControls/ChartTypePicker/ChartTypePicker.module.css b/frontend/src/metabase/metrics-viewer/components/MetricControls/LeftControls/ChartTypePicker/ChartTypePicker.module.cssindex 986ec69c794..cc0f2c4f99f 100644--- a/frontend/src/metabase/metrics-viewer/components/MetricControls/LeftControls/ChartTypePicker/ChartTypePicker.module.css+++ b/frontend/src/metabase/metrics-viewer/components/MetricControls/LeftControls/ChartTypePicker/ChartTypePicker.module.css@@ -7,5 +7,5 @@}.selected {- box-shadow: 0 1px 2px var(--mb-color-shadow);+ box-shadow: 0 1px 2px var(--mb-color-shadow-default);}diff --git a/frontend/src/metabase/metrics-viewer/components/MetricControls/LeftControls/LeftControls.module.css b/frontend/src/metabase/metrics-viewer/components/MetricControls/LeftControls/LeftControls.module.cssindex 0e39e368164..ae0a01ca9a4 100644--- a/frontend/src/metabase/metrics-viewer/components/MetricControls/LeftControls/LeftControls.module.css+++ b/frontend/src/metabase/metrics-viewer/components/MetricControls/LeftControls/LeftControls.module.css@@ -39,7 +39,7 @@.compactChartMenuItemSelected,.compactChartMenuItemSelected.compactChartMenuItem:hover {background-color: var(--mb-color-background_surface-selected);- color: var(--mb-color-brand);+ color: var(--mb-color-core-brand);}@container metric-controls (max-width: 56rem) {diff --git a/frontend/src/metabase/metrics-viewer/components/MetricControls/LeftControls/LeftControls.tsx b/frontend/src/metabase/metrics-viewer/components/MetricControls/LeftControls/LeftControls.tsxindex 261ba196068..90bf549294e 100644--- a/frontend/src/metabase/metrics-viewer/components/MetricControls/LeftControls/LeftControls.tsx+++ b/frontend/src/metabase/metrics-viewer/components/MetricControls/LeftControls/LeftControls.tsx@@ -109,7 +109,7 @@ export function LeftControls({ showStackSeries }: LeftControlsProps) {<Iconaria-hiddenname={icon}- c={value === type ? "brand" : "text-primary"}+ c={value === type ? "core-brand" : "text-primary"}/>}onClick={() => handleDisplayTypeChange(type)}@@ -131,7 +131,7 @@ export function LeftControls({ showStackSeries }: LeftControlsProps) {<Iconaria-hiddenname="chart_layout_default"- c={!isStacked ? "brand" : "text-primary"}+ c={!isStacked ? "core-brand" : "text-primary"}/>}onClick={() => handleSplitChannelsChange(false)}@@ -146,7 +146,7 @@ export function LeftControls({ showStackSeries }: LeftControlsProps) {<Iconaria-hiddenname="chart_layout_stack"- c={isStacked ? "brand" : "text-primary"}+ c={isStacked ? "core-brand" : "text-primary"}/>}onClick={() => {diff --git a/frontend/src/metabase/metrics-viewer/components/MetricSearch/MetricSearchInput/MetricSearchInput.module.css b/frontend/src/metabase/metrics-viewer/components/MetricSearch/MetricSearchInput/MetricSearchInput.module.cssindex c4fe5f1c9d3..12c30cfd69f 100644--- a/frontend/src/metabase/metrics-viewer/components/MetricSearch/MetricSearchInput/MetricSearchInput.module.css+++ b/frontend/src/metabase/metrics-viewer/components/MetricSearch/MetricSearchInput/MetricSearchInput.module.css@@ -32,16 +32,16 @@.cmErrorUnderline {text-decoration: underline wavy;- text-decoration-color: var(--mb-color-error);+ text-decoration-color: var(--mb-color-feedback-negative);text-decoration-skip-ink: none;}.cmErrorTooltip {padding: 4px 8px;font-size: 0.75rem;- color: var(--mb-color-error);+ color: var(--mb-color-feedback-negative);background: var(--mb-color-background_page-primary);- border: 1px solid var(--mb-color-error);+ border: 1px solid var(--mb-color-feedback-negative);border-radius: var(--mantine-radius-sm, 4px);max-width: 20rem;white-space: normal;diff --git a/frontend/src/metabase/metrics-viewer/components/MetricSearchPanel/MetricSearchPanel.module.css b/frontend/src/metabase/metrics-viewer/components/MetricSearchPanel/MetricSearchPanel.module.cssindex 586d706ae48..77dcc77d0ee 100644--- a/frontend/src/metabase/metrics-viewer/components/MetricSearchPanel/MetricSearchPanel.module.css+++ b/frontend/src/metabase/metrics-viewer/components/MetricSearchPanel/MetricSearchPanel.module.css@@ -5,7 +5,7 @@}.container:has([data-has-error]) {- box-shadow: inset 0 0 0 1px var(--mb-color-error);+ box-shadow: inset 0 0 0 1px var(--mb-color-feedback-negative);}.filterPillsSection {diff --git a/frontend/src/metabase/metrics-viewer/hooks/use-viewer-url.ts b/frontend/src/metabase/metrics-viewer/hooks/use-viewer-url.tsindex 3f77bb3d260..cc08240a6a4 100644--- a/frontend/src/metabase/metrics-viewer/hooks/use-viewer-url.ts+++ b/frontend/src/metabase/metrics-viewer/hooks/use-viewer-url.ts@@ -145,7 +145,7 @@ export function useViewerUrl(setInitialLoadComplete(true);sendToast({icon: "warning_triangle_filled",- iconColor: "warning",+ iconColor: "feedback-warning",message: t`There was a problem restoring the page state`,});}diff --git a/frontend/src/metabase/models/components/NewModelOption.module.css b/frontend/src/metabase/models/components/NewModelOption.module.cssindex c707f9b5f13..c9e220dfab4 100644--- a/frontend/src/metabase/models/components/NewModelOption.module.css+++ b/frontend/src/metabase/models/components/NewModelOption.module.css@@ -24,5 +24,5 @@}.linkWrapper:hover .modelTitle {- color: var(--mb-color-brand);+ color: var(--mb-color-core-brand);}diff --git a/frontend/src/metabase/monitor/tools/components/LogLevelsModal/LogLevelsForm.module.css b/frontend/src/metabase/monitor/tools/components/LogLevelsModal/LogLevelsForm.module.cssindex bd1fa0760c4..31a3e61e8a2 100644--- a/frontend/src/metabase/monitor/tools/components/LogLevelsModal/LogLevelsForm.module.css+++ b/frontend/src/metabase/monitor/tools/components/LogLevelsModal/LogLevelsForm.module.css@@ -1,7 +1,7 @@.codeContainer {border: var(--border-size) var(--border-style) var(--mb-color-border-neutral);border-radius: var(--default-border-radius);- box-shadow: 0 2px 2px var(--mb-color-shadow);+ box-shadow: 0 2px 2px var(--mb-color-shadow-default);}.code {diff --git a/frontend/src/metabase/monitor/tools/components/LogLevelsModal/LogLevelsForm.tsx b/frontend/src/metabase/monitor/tools/components/LogLevelsModal/LogLevelsForm.tsxindex bb04b9c2cec..1cd2eea0e4d 100644--- a/frontend/src/metabase/monitor/tools/components/LogLevelsModal/LogLevelsForm.tsx+++ b/frontend/src/metabase/monitor/tools/components/LogLevelsModal/LogLevelsForm.tsx@@ -67,7 +67,7 @@ export const LogLevelsForm = ({ presets }: Props) => {</Box>{error && (- <Text aria-label={error} c="error" mt="md" role="alert">+ <Text aria-label={error} c="feedback-negative" mt="md" role="alert">{error}</Text>)}diff --git a/frontend/src/metabase/monitor/tools/components/TaskDetailsPage/TaskDetailsPage.module.css b/frontend/src/metabase/monitor/tools/components/TaskDetailsPage/TaskDetailsPage.module.cssindex e7539be8b17..a38323bd214 100644--- a/frontend/src/metabase/monitor/tools/components/TaskDetailsPage/TaskDetailsPage.module.css+++ b/frontend/src/metabase/monitor/tools/components/TaskDetailsPage/TaskDetailsPage.module.css@@ -1,6 +1,6 @@.codeContainer {border: var(--border-size) var(--border-style) var(--mb-color-border-neutral);border-radius: var(--default-border-radius);- box-shadow: 0 2px 2px var(--mb-color-shadow);+ box-shadow: 0 2px 2px var(--mb-color-shadow-default);overflow: hidden;}diff --git a/frontend/src/metabase/monitor/tools/notifications/NotificationDetailSidebar/NotificationRunSummaryLog.tsx b/frontend/src/metabase/monitor/tools/notifications/NotificationDetailSidebar/NotificationRunSummaryLog.tsxindex 8c9ed3124c6..185b15d7dad 100644--- a/frontend/src/metabase/monitor/tools/notifications/NotificationDetailSidebar/NotificationRunSummaryLog.tsx+++ b/frontend/src/metabase/monitor/tools/notifications/NotificationDetailSidebar/NotificationRunSummaryLog.tsx@@ -64,7 +64,7 @@ export const NotificationRunSummaryLog = ({</Tooltip><Tooltip label={run.error} disabled={!hasError}><Badge- color={isFailing ? "error" : undefined}+ color={isFailing ? "feedback-negative" : undefined}variant={isFailing ? "light" : "outline"}radius="lg"tt="none"diff --git a/frontend/src/metabase/monitor/tools/notifications/NotificationDetailSidebar/SidebarHeader.tsx b/frontend/src/metabase/monitor/tools/notifications/NotificationDetailSidebar/SidebarHeader.tsxindex 727940df026..79f75abbe9f 100644--- a/frontend/src/metabase/monitor/tools/notifications/NotificationDetailSidebar/SidebarHeader.tsx+++ b/frontend/src/metabase/monitor/tools/notifications/NotificationDetailSidebar/SidebarHeader.tsx@@ -100,7 +100,7 @@ export const SidebarHeader = ({</Menu.Item>{notification?.active && (<Menu.Item- c="danger"+ c="feedback-negative"leftSection={<Icon name="trash" />}onClick={() => onDelete(notification)}>diff --git a/frontend/src/metabase/monitor/tools/notifications/NotificationSummary/NotificationSummary.tsx b/frontend/src/metabase/monitor/tools/notifications/NotificationSummary/NotificationSummary.tsxindex e3a885a2e45..b10d2ea0ec1 100644--- a/frontend/src/metabase/monitor/tools/notifications/NotificationSummary/NotificationSummary.tsx+++ b/frontend/src/metabase/monitor/tools/notifications/NotificationSummary/NotificationSummary.tsx@@ -28,18 +28,18 @@ export const NotificationSummary = ({ run, isCompact }: Props) => {</Tooltip>{isCompact && isFailing && (<Tooltip label={error} disabled={!error}>- <Icon name="warning_round" c="error" />+ <Icon name="warning_round" c="feedback-negative" /></Tooltip>)}</Flex>{!isCompact && isFailing && (<Flex align="center" gap="xs">{error && (- <Text size="sm" c="error">+ <Text size="sm" c="feedback-negative">{error}</Text>)}- <Icon name="warning_round" c="error" />+ <Icon name="warning_round" c="feedback-negative" /></Flex>)}</Stack>diff --git a/frontend/src/metabase/monitor/tools/notifications/NotificationsAdminPage/NotificationsAdminPage.tsx b/frontend/src/metabase/monitor/tools/notifications/NotificationsAdminPage/NotificationsAdminPage.tsxindex dbd6066e4ad..74f735c71ba 100644--- a/frontend/src/metabase/monitor/tools/notifications/NotificationsAdminPage/NotificationsAdminPage.tsx+++ b/frontend/src/metabase/monitor/tools/notifications/NotificationsAdminPage/NotificationsAdminPage.tsx@@ -245,7 +245,7 @@ export const NotificationsAdminPage = ({title: count === 1 ? t`Delete 1 alert?` : t`Delete ${count} alerts?`,message: t`Recipients will stop receiving these alerts.`,confirmButtonText: t`Delete`,- confirmButtonProps: { color: "danger" },+ confirmButtonProps: { color: "feedback-negative" },size: "md",onConfirm: () =>deleteNotifications(@@ -261,7 +261,7 @@ export const NotificationsAdminPage = ({title: t`Delete this alert?`,message: t`Recipients will stop receiving this alert.`,confirmButtonText: t`Delete`,- confirmButtonProps: { color: "danger" },+ confirmButtonProps: { color: "feedback-negative" },onConfirm: () => deleteNotifications([id], "detail_sidebar"),});},diff --git a/frontend/src/metabase/nav/components/AdminNavbar/AdminNavLink.tsx b/frontend/src/metabase/nav/components/AdminNavbar/AdminNavLink.tsxindex 95370259c5e..068dd9ad739 100644--- a/frontend/src/metabase/nav/components/AdminNavbar/AdminNavLink.tsx+++ b/frontend/src/metabase/nav/components/AdminNavbar/AdminNavLink.tsx@@ -23,7 +23,7 @@ export const AdminNavLink = ({to={to}className={S.AdminNavLink}data-selected={isSelected || undefined}- bg={isSelected ? "admin-navbar-inverse" : undefined}+ bg={isSelected ? "navbar-admin-inverse" : undefined}style={{ overflow: isInMobileNav ? "visible" : "hidden" }}>{children}diff --git a/frontend/src/metabase/nav/components/AdminNavbar/AdminNavbar.module.css b/frontend/src/metabase/nav/components/AdminNavbar/AdminNavbar.module.cssindex 5e5f4a8e205..faaf8a789b9 100644--- a/frontend/src/metabase/nav/components/AdminNavbar/AdminNavbar.module.css+++ b/frontend/src/metabase/nav/components/AdminNavbar/AdminNavbar.module.css@@ -33,6 +33,6 @@}&:hover {- background-color: var(--mb-color-admin-navbar-inverse);+ background-color: var(--mb-color-navbar-admin-inverse);}}diff --git a/frontend/src/metabase/nav/components/AdminNavbar/AdminNavbar.tsx b/frontend/src/metabase/nav/components/AdminNavbar/AdminNavbar.tsxindex e17922fc6b4..c81561783c5 100644--- a/frontend/src/metabase/nav/components/AdminNavbar/AdminNavbar.tsx+++ b/frontend/src/metabase/nav/components/AdminNavbar/AdminNavbar.tsx@@ -64,7 +64,7 @@ export const AdminNavbar = ({align="center"justify="space-between"h={ADMIN_NAVBAR_HEIGHT}- bg="admin-navbar"+ bg="navbar-admin"fz="0.85rem"px="1rem"py="0.5rem"@@ -156,7 +156,7 @@ const MobileNavbar = ({ adminPaths, currentPath }: AdminMobileNavbarProps) => {pos="fixed"top={ADMIN_NAVBAR_HEIGHT}right={0}- bg="admin-navbar"+ bg="navbar-admin"mah={`calc(100vh - ${ADMIN_NAVBAR_HEIGHT})`}bdrs="0 0 0 0.5rem"style={{ overflowY: "auto" }}diff --git a/frontend/src/metabase/nav/components/DevModeBanner/DevModeBanner.tsx b/frontend/src/metabase/nav/components/DevModeBanner/DevModeBanner.tsxindex 39350f8cddc..06a366de1a3 100644--- a/frontend/src/metabase/nav/components/DevModeBanner/DevModeBanner.tsx+++ b/frontend/src/metabase/nav/components/DevModeBanner/DevModeBanner.tsx@@ -6,7 +6,7 @@ import { Text } from "metabase/ui";export const DevModeBanner = () => {return (<Banner- bg="warning"+ bg="feedback-warning"body={<Text fw="bold" c="text-primary">{t`This instance is in development mode. It is not allowed to be used for production purposes. All content is watermarked.`}diff --git a/frontend/src/metabase/nav/components/ReadOnlyBanner/ReadOnlyBanner.tsx b/frontend/src/metabase/nav/components/ReadOnlyBanner/ReadOnlyBanner.tsxindex 9b4d8a5f08c..60559c97d9a 100644--- a/frontend/src/metabase/nav/components/ReadOnlyBanner/ReadOnlyBanner.tsx+++ b/frontend/src/metabase/nav/components/ReadOnlyBanner/ReadOnlyBanner.tsx@@ -6,7 +6,7 @@ import { Text } from "metabase/ui";export const ReadOnlyBanner = () => {return (<Banner- bg="warning"+ bg="feedback-warning"body={<Text fw="bold" c="text-primary">{/* eslint-disable-next-line metabase/no-literal-metabase-strings -- correct usage */}diff --git a/frontend/src/metabase/nav/components/StoreLink/StoreLink.module.css b/frontend/src/metabase/nav/components/StoreLink/StoreLink.module.cssindex bf0b7df9dd6..c32ea09f23d 100644--- a/frontend/src/metabase/nav/components/StoreLink/StoreLink.module.css+++ b/frontend/src/metabase/nav/components/StoreLink/StoreLink.module.css@@ -13,7 +13,7 @@&:hover {color: var(--mb-color-text-primary-inverse);- background-color: var(--mb-color-admin-navbar-inverse);+ background-color: var(--mb-color-navbar-admin-inverse);}@media (prefers-reduced-motion) {diff --git a/frontend/src/metabase/nav/components/TrialBanner/TrialBanner.tsx b/frontend/src/metabase/nav/components/TrialBanner/TrialBanner.tsxindex 9f11c9a0f79..7ff44de96dc 100644--- a/frontend/src/metabase/nav/components/TrialBanner/TrialBanner.tsx+++ b/frontend/src/metabase/nav/components/TrialBanner/TrialBanner.tsx@@ -19,7 +19,7 @@ export const TrialBanner = ({return (<Bannericon="warning_round_filled"- bg="warning"+ bg="feedback-warning"body={<Flex align="center" gap="xs">{/* Text and ExternalLink originally have different line-heights that we need to marry. */}diff --git a/frontend/src/metabase/nav/containers/MainNavbar/MainNavbarContainer/MainNavbarContainer.tsx b/frontend/src/metabase/nav/containers/MainNavbar/MainNavbarContainer/MainNavbarContainer.tsxindex 3b4bf32e318..8a54a2a5e2c 100644--- a/frontend/src/metabase/nav/containers/MainNavbar/MainNavbarContainer/MainNavbarContainer.tsx+++ b/frontend/src/metabase/nav/containers/MainNavbar/MainNavbarContainer/MainNavbarContainer.tsx@@ -166,7 +166,7 @@ function MainNavbarContainer({dispatch(addUndo({icon: "warning",- toastColor: "error",+ toastColor: "feedback-negative",message: t`Something went wrong`,}),);diff --git a/frontend/src/metabase/nav/containers/MainNavbar/SidebarItems/SidebarItems.styled.tsx b/frontend/src/metabase/nav/containers/MainNavbar/SidebarItems/SidebarItems.styled.tsxindex 31f53b2f408..77e229c49b4 100644--- a/frontend/src/metabase/nav/containers/MainNavbar/SidebarItems/SidebarItems.styled.tsx+++ b/frontend/src/metabase/nav/containers/MainNavbar/SidebarItems/SidebarItems.styled.tsx@@ -56,7 +56,7 @@ export const NodeRoot = styled(TreeNode.Root)<NodeRootProps>`border-radius: 4px;&:focus-within {- outline: 2px solid var(--mb-color-focus);+ outline: 2px solid var(--mb-color-input-focus);outline-offset: -2px;}diff --git a/frontend/src/metabase/notifications/channels/RecipientPicker.module.css b/frontend/src/metabase/notifications/channels/RecipientPicker.module.cssindex f004501a8b9..f6ccc10f2d6 100644--- a/frontend/src/metabase/notifications/channels/RecipientPicker.module.css+++ b/frontend/src/metabase/notifications/channels/RecipientPicker.module.css@@ -3,6 +3,6 @@}.ErrorMessage {- color: var(--mb-color-error);+ color: var(--mb-color-feedback-negative);margin-top: 0.5rem;}diff --git a/frontend/src/metabase/notifications/modals/CreateOrEditQuestionAlertModal/AlertTriggerIcon.tsx b/frontend/src/metabase/notifications/modals/CreateOrEditQuestionAlertModal/AlertTriggerIcon.tsxindex 1c533f933d2..4fcd466d5fe 100644--- a/frontend/src/metabase/notifications/modals/CreateOrEditQuestionAlertModal/AlertTriggerIcon.tsx+++ b/frontend/src/metabase/notifications/modals/CreateOrEditQuestionAlertModal/AlertTriggerIcon.tsx@@ -11,7 +11,7 @@ export const AlertTriggerIcon = () => {borderRadius: "100%",}}>- <Icon name="alert" c="white" />+ <Icon name="alert" c="core-white" /></Center>);};diff --git a/frontend/src/metabase/notifications/modals/CreateOrEditQuestionAlertModal/CreateOrEditQuestionAlertModal.tsx b/frontend/src/metabase/notifications/modals/CreateOrEditQuestionAlertModal/CreateOrEditQuestionAlertModal.tsxindex a94f80ff4af..ea81bbdca7a 100644--- a/frontend/src/metabase/notifications/modals/CreateOrEditQuestionAlertModal/CreateOrEditQuestionAlertModal.tsx+++ b/frontend/src/metabase/notifications/modals/CreateOrEditQuestionAlertModal/CreateOrEditQuestionAlertModal.tsx@@ -215,7 +215,7 @@ export const CreateOrEditQuestionAlertModal = ({dispatch(addUndo({icon: "warning",- toastColor: "error",+ toastColor: "feedback-negative",message: t`Failed save alert. ${errorText}`,}),);@@ -247,7 +247,7 @@ export const CreateOrEditQuestionAlertModal = ({dispatch(addUndo({icon: "warning",- toastColor: "error",+ toastColor: "feedback-negative",message: t`Failed to send test alert. ${getResponseErrorMessage(result.error) ?? t`An error occurred`}`,}),);@@ -443,7 +443,7 @@ export const CreateOrEditQuestionAlertModal = ({<Button onClick={onClose}>{t`Cancel`}</Button><Buttonvariant="filled"- bg={hasError ? "error" : "core-brand"}+ bg={hasError ? "feedback-negative" : "core-brand"}disabled={!isValid || isCreating || isUpdating}loading={isCreating || isUpdating}onClick={onCreateOrEditAlert}diff --git a/frontend/src/metabase/notifications/modals/DeleteAlertConfirmModal.tsx b/frontend/src/metabase/notifications/modals/DeleteAlertConfirmModal.tsxindex d869c2c21df..8aa9fd73988 100644--- a/frontend/src/metabase/notifications/modals/DeleteAlertConfirmModal.tsx+++ b/frontend/src/metabase/notifications/modals/DeleteAlertConfirmModal.tsx@@ -25,7 +25,7 @@ export const DeleteAlertConfirmModal = ({<Button onClick={onClose}>{t`Cancel`}</Button><Buttonvariant="filled"- color="error"+ color="feedback-negative"onClick={onConfirm}>{t`Delete it`}</Button></Flex>diff --git a/frontend/src/metabase/notifications/modals/QuestionAlertListModal/QuestionAlertListModal.tsx b/frontend/src/metabase/notifications/modals/QuestionAlertListModal/QuestionAlertListModal.tsxindex 1b23672c078..8b53f834783 100644--- a/frontend/src/metabase/notifications/modals/QuestionAlertListModal/QuestionAlertListModal.tsx+++ b/frontend/src/metabase/notifications/modals/QuestionAlertListModal/QuestionAlertListModal.tsx@@ -96,7 +96,7 @@ export const QuestionAlertListModal = ({if (result.error) {sendToast({icon: "warning",- toastColor: "error",+ toastColor: "feedback-negative",message: t`An error occurred`,});return;@@ -119,7 +119,7 @@ export const QuestionAlertListModal = ({if (result.error) {sendToast({icon: "warning",- toastColor: "error",+ toastColor: "feedback-negative",message: t`An error occurred`,});return;diff --git a/frontend/src/metabase/notifications/modals/UnsubscribeConfirmModal.tsx b/frontend/src/metabase/notifications/modals/UnsubscribeConfirmModal.tsxindex 1adfe49ea64..856e7e8fbf2 100644--- a/frontend/src/metabase/notifications/modals/UnsubscribeConfirmModal.tsx+++ b/frontend/src/metabase/notifications/modals/UnsubscribeConfirmModal.tsx@@ -23,7 +23,7 @@ export const UnsubscribeConfirmModal = ({<Button onClick={onClose}>{t`Cancel`}</Button><Buttonvariant="filled"- color="error"+ color="feedback-negative"onClick={onConfirm}>{t`Unsubscribe`}</Button></Flex>diff --git a/frontend/src/metabase/notifications/pulse/actions.ts b/frontend/src/metabase/notifications/pulse/actions.tsindex 1ddcee93376..755bddf5325 100644--- a/frontend/src/metabase/notifications/pulse/actions.ts+++ b/frontend/src/metabase/notifications/pulse/actions.ts@@ -58,7 +58,7 @@ export const saveEditingPulse = createThunkAction(dispatch(addUndo({icon: "warning",- toastColor: "error",+ toastColor: "feedback-negative",message: isEdit? t`Cannot edit subscription. ${errorMessage} Please contact your administrator.`: t`Cannot create subscription. ${errorMessage} Please contact your administrator.`,diff --git a/frontend/src/metabase/parameters/components/ValuesSourceModal/ValuesSourceTypeModal.module.css b/frontend/src/metabase/parameters/components/ValuesSourceModal/ValuesSourceTypeModal.module.cssindex a274fc11dc6..43c0c97fb1d 100644--- a/frontend/src/metabase/parameters/components/ValuesSourceModal/ValuesSourceTypeModal.module.css+++ b/frontend/src/metabase/parameters/components/ValuesSourceModal/ValuesSourceTypeModal.module.css@@ -44,7 +44,7 @@.ModalErrorMessage {color: var(--mb-color-text-secondary);padding: 1rem;- border: 1px solid var(--mb-color-error);+ border: 1px solid var(--mb-color-feedback-negative);border-radius: 0.5rem;}diff --git a/frontend/src/metabase/public/components/EmbedFrame/EmbedFrame.styled.tsx b/frontend/src/metabase/public/components/EmbedFrame/EmbedFrame.styled.tsxindex bac6cb30329..bdf53590115 100644--- a/frontend/src/metabase/public/components/EmbedFrame/EmbedFrame.styled.tsx+++ b/frontend/src/metabase/public/components/EmbedFrame/EmbedFrame.styled.tsx@@ -36,7 +36,7 @@ export const Root = styled.div<{css`border: 1px solid var(--mb-color-border-neutral);border-radius: 8px;- box-shadow: 0 2px 2px var(--mb-color-shadow);+ box-shadow: 0 2px 2px var(--mb-color-shadow-default);`}${(props) =>diff --git a/frontend/src/metabase/query_builder/components/chart-type-selector/ChartTypeOption/ChartTypeOption.tsx b/frontend/src/metabase/query_builder/components/chart-type-selector/ChartTypeOption/ChartTypeOption.tsxindex dd2edeb6a40..033addd6e15 100644--- a/frontend/src/metabase/query_builder/components/chart-type-selector/ChartTypeOption/ChartTypeOption.tsx+++ b/frontend/src/metabase/query_builder/components/chart-type-selector/ChartTypeOption/ChartTypeOption.tsx@@ -69,7 +69,7 @@ export const ChartTypeOption = ({name={iconName ?? "unknown"}iconUrl={visualization?.iconUrl}alt={displayName}- color={isSelected ? "white" : "core-brand"}+ color={isSelected ? "core-white" : "core-brand"}size={20}style={hasCustomIcon && isSelecteddiff --git a/frontend/src/metabase/query_builder/components/view/QuestionDisplayToggle/QuestionDisplayToggle.module.css b/frontend/src/metabase/query_builder/components/view/QuestionDisplayToggle/QuestionDisplayToggle.module.cssindex 8062ca217e2..ae60c9ee06d 100644--- a/frontend/src/metabase/query_builder/components/view/QuestionDisplayToggle/QuestionDisplayToggle.module.css+++ b/frontend/src/metabase/query_builder/components/view/QuestionDisplayToggle/QuestionDisplayToggle.module.css@@ -16,7 +16,7 @@}&:focus-visible {- outline: 2px solid var(--mb-color-focus);+ outline: 2px solid var(--mb-color-input-focus);outline-offset: 1px;}}diff --git a/frontend/src/metabase/query_builder/components/view/ViewHeader/ViewTitleHeader.module.css b/frontend/src/metabase/query_builder/components/view/ViewHeader/ViewTitleHeader.module.cssindex de6eac7d624..094f6a9bbe8 100644--- a/frontend/src/metabase/query_builder/components/view/ViewHeader/ViewTitleHeader.module.css+++ b/frontend/src/metabase/query_builder/components/view/ViewHeader/ViewTitleHeader.module.css@@ -9,12 +9,12 @@background-color: color-mix(in srgb,var(--mb-color-core-filter) 10%,- var(--mb-color-white)+ var(--mb-color-core-white));border-color: color-mix(in srgb,var(--mb-color-core-filter) 40%,- var(--mb-color-white)+ var(--mb-color-core-white));}@@ -51,12 +51,12 @@background-color: color-mix(in srgb,var(--mb-color-core-filter) 10%,- var(--mb-color-white)+ var(--mb-color-core-white));border-color: color-mix(in srgb,var(--mb-color-core-filter) 40%,- var(--mb-color-white)+ var(--mb-color-core-white));}@@ -79,7 +79,7 @@background-color: color-mix(in srgb,var(--mb-color-core-filter) 15%,- var(--mb-color-white)+ var(--mb-color-core-white));}@@ -93,12 +93,12 @@border-color: color-mix(in srgb,var(--mb-color-core-summarize) 40%,- var(--mb-color-white)+ var(--mb-color-core-white));background-color: color-mix(in srgb,var(--mb-color-core-summarize) 15%,- var(--mb-color-white)+ var(--mb-color-core-white));}}@@ -113,12 +113,12 @@border-color: color-mix(in srgb,var(--mb-color-core-brand) 40%,- var(--mb-color-white)+ var(--mb-color-core-white));background-color: color-mix(in srgb,var(--mb-color-core-brand) 15%,- var(--mb-color-white)+ var(--mb-color-core-white));}}diff --git a/frontend/src/metabase/query_builder/components/view/ViewHeader/components/QuestionDataSource/SourceModelBreadcrumbs.tsx b/frontend/src/metabase/query_builder/components/view/ViewHeader/components/QuestionDataSource/SourceModelBreadcrumbs.tsxindex a992d6aac63..a959efea74a 100644--- a/frontend/src/metabase/query_builder/components/view/ViewHeader/components/QuestionDataSource/SourceModelBreadcrumbs.tsx+++ b/frontend/src/metabase/query_builder/components/view/ViewHeader/components/QuestionDataSource/SourceModelBreadcrumbs.tsx@@ -53,7 +53,7 @@ export function SourceModelBreadcrumbs({<span><HeadBreadcrumbs.Breadcrumbicon="warning"- iconColor="danger"+ iconColor="feedback-negative"to={Urls.card(question.card())}>{question.displayName()}diff --git a/frontend/src/metabase/query_builder/components/view/sidebars/DatasetManagementSection/DatasetMetadataStrengthIndicator/DatasetMetadataStrengthIndicator.tsx b/frontend/src/metabase/query_builder/components/view/sidebars/DatasetManagementSection/DatasetMetadataStrengthIndicator/DatasetMetadataStrengthIndicator.tsxindex 99c661774fe..21404aa6f96 100644--- a/frontend/src/metabase/query_builder/components/view/sidebars/DatasetManagementSection/DatasetMetadataStrengthIndicator/DatasetMetadataStrengthIndicator.tsx+++ b/frontend/src/metabase/query_builder/components/view/sidebars/DatasetManagementSection/DatasetMetadataStrengthIndicator/DatasetMetadataStrengthIndicator.tsx@@ -12,12 +12,12 @@ import DatasetMetadataStrengthIndicatorS from "./DatasetMetadataStrengthIndicatofunction getIndicationColor(percentage: number, isHovered: boolean): ColorName {if (percentage <= 0.5) {- return "danger";+ return "feedback-negative";}if (!isHovered) {return "text-secondary";}- return percentage >= 0.9 ? "success" : "warning";+ return percentage >= 0.9 ? "feedback-positive" : "feedback-warning";}function getTooltipMessage(percentage: number) {diff --git a/frontend/src/metabase/query_builder/components/view/sidebars/ModelCacheManagementSection/ModelCacheManagementSection.tsx b/frontend/src/metabase/query_builder/components/view/sidebars/ModelCacheManagementSection/ModelCacheManagementSection.tsxindex 7c0d4bdb2da..1fe94726447 100644--- a/frontend/src/metabase/query_builder/components/view/sidebars/ModelCacheManagementSection/ModelCacheManagementSection.tsx+++ b/frontend/src/metabase/query_builder/components/view/sidebars/ModelCacheManagementSection/ModelCacheManagementSection.tsx@@ -85,7 +85,7 @@ export function ModelCacheManagementSection({ model }: Props) {<Box><Flex align="center" fw="bold" gap="sm">{statusMessage}- {isError && <Icon name="warning" c="error" ml="sm" />}+ {isError && <Icon name="warning" c="feedback-negative" ml="sm" />}</Flex>{isError && <Box pt="sm">{lastRefreshLabel}</Box>}</Box>diff --git a/frontend/src/metabase/querying/components/CodeMirrorEditor/CodeMirrorEditor.module.css b/frontend/src/metabase/querying/components/CodeMirrorEditor/CodeMirrorEditor.module.cssindex 7a2bc4ca2ee..25676d0ea4e 100644--- a/frontend/src/metabase/querying/components/CodeMirrorEditor/CodeMirrorEditor.module.css+++ b/frontend/src/metabase/querying/components/CodeMirrorEditor/CodeMirrorEditor.module.css@@ -1,7 +1,7 @@.editor {- --change: var(--mb-color-success);+ --change: var(--mb-color-feedback-positive);--change-light: color-mix(in srgb, var(--change) 11%, transparent);- --remove: var(--mb-color-danger);+ --remove: var(--mb-color-feedback-negative);--remove-mid: color-mix(in srgb, var(--remove) 25%, transparent);--remove-light: color-mix(in srgb, var(--remove) 11%, transparent);diff --git a/frontend/src/metabase/querying/components/DataReference/NodeList.module.css b/frontend/src/metabase/querying/components/DataReference/NodeList.module.cssindex f2f7a50b785..8775ca5417f 100644--- a/frontend/src/metabase/querying/components/DataReference/NodeList.module.css+++ b/frontend/src/metabase/querying/components/DataReference/NodeList.module.css@@ -3,7 +3,7 @@}.NodeListItemIcon {- color: var(--mb-color-focus);+ color: var(--mb-color-input-focus);margin-top: 1px;width: 1rem;diff --git a/frontend/src/metabase/querying/components/DataReference/ResourceTreeNode.module.css b/frontend/src/metabase/querying/components/DataReference/ResourceTreeNode.module.cssindex 8227cda5134..d624a8a43af 100644--- a/frontend/src/metabase/querying/components/DataReference/ResourceTreeNode.module.css+++ b/frontend/src/metabase/querying/components/DataReference/ResourceTreeNode.module.css@@ -3,7 +3,7 @@margin-left: 32px;& svg {- color: var(--mb-color-focus);+ color: var(--mb-color-input-focus);}& svg[data-role="chevron"] {diff --git a/frontend/src/metabase/querying/components/NativeQueryEditor/NativeQueryEditorRoot.tsx b/frontend/src/metabase/querying/components/NativeQueryEditor/NativeQueryEditorRoot.tsxindex bef2933c728..091ad901066 100644--- a/frontend/src/metabase/querying/components/NativeQueryEditor/NativeQueryEditorRoot.tsx+++ b/frontend/src/metabase/querying/components/NativeQueryEditor/NativeQueryEditorRoot.tsx@@ -386,7 +386,7 @@ export const NativeQueryEditorRoot = forwardRef<<Buttondata-testid="accept-proposed-changes-button"variant="filled"- bg="success"+ bg="feedback-positive"px="0"w="2.5rem"onClick={() => {@@ -410,7 +410,7 @@ export const NativeQueryEditorRoot = forwardRef<w="2.5rem"px="0"variant="filled"- bg="danger"+ bg="feedback-negative"onClick={onRejectProposed}><Icon name="close" />diff --git a/frontend/src/metabase/querying/components/QueryVisualization/QueryVisualization.module.css b/frontend/src/metabase/querying/components/QueryVisualization/QueryVisualization.module.cssindex e13bc785d71..61d7d62613c 100644--- a/frontend/src/metabase/querying/components/QueryVisualization/QueryVisualization.module.css+++ b/frontend/src/metabase/querying/components/QueryVisualization/QueryVisualization.module.css@@ -30,5 +30,5 @@}.shadowed {- box-shadow: 0 2px 2px var(--mb-color-shadow);+ box-shadow: 0 2px 2px var(--mb-color-shadow-default);}diff --git a/frontend/src/metabase/querying/components/QueryVisualization/QueryVisualization.tsx b/frontend/src/metabase/querying/components/QueryVisualization/QueryVisualization.tsxindex dd536cb785c..10024917099 100644--- a/frontend/src/metabase/querying/components/QueryVisualization/QueryVisualization.tsx+++ b/frontend/src/metabase/querying/components/QueryVisualization/QueryVisualization.tsx@@ -130,13 +130,13 @@ export function VisualizationRunningState({return (<FlexclassName={cx(className, QueryBuilderS.Overlay)}- c="brand"+ c="core-brand"direction="column"justify="center"align="center"><LoadingSpinner />- <Title c="brand" order={3} mt="lg">+ <Title c="core-brand" order={3} mt="lg">{message}</Title></Flex>diff --git a/frontend/src/metabase/querying/components/QueryVisualization/VisualizationError/VisualizationError.module.css b/frontend/src/metabase/querying/components/QueryVisualization/VisualizationError/VisualizationError.module.cssindex 0f2c43d40c8..f48ab94e488 100644--- a/frontend/src/metabase/querying/components/QueryVisualization/VisualizationError/VisualizationError.module.css+++ b/frontend/src/metabase/querying/components/QueryVisualization/VisualizationError/VisualizationError.module.css@@ -8,7 +8,7 @@.QueryErrorIcon {flex: 0 0 auto;- color: var(--mb-color-error);+ color: var(--mb-color-feedback-negative);width: 1rem;height: 1rem;margin-right: 0.75rem;diff --git a/frontend/src/metabase/querying/components/expressions/Editor/Editor.module.css b/frontend/src/metabase/querying/components/expressions/Editor/Editor.module.cssindex 47047f78fe1..bec098daa80 100644--- a/frontend/src/metabase/querying/components/expressions/Editor/Editor.module.css+++ b/frontend/src/metabase/querying/components/expressions/Editor/Editor.module.css@@ -10,7 +10,7 @@}.error {- color: var(--mb-color-error);+ color: var(--mb-color-feedback-negative);margin: 0.5rem 0;white-space: pre-wrap;}diff --git a/frontend/src/metabase/querying/components/expressions/Editor/Errors/Errors.module.css b/frontend/src/metabase/querying/components/expressions/Editor/Errors/Errors.module.cssindex 24ae5f5a2e2..96c966edcd2 100644--- a/frontend/src/metabase/querying/components/expressions/Editor/Errors/Errors.module.css+++ b/frontend/src/metabase/querying/components/expressions/Editor/Errors/Errors.module.css@@ -5,5 +5,5 @@}.icon {- color: var(--mb-color-error);+ color: var(--mb-color-feedback-negative);}diff --git a/frontend/src/metabase/querying/components/expressions/Editor/HelpText/HelpText.module.css b/frontend/src/metabase/querying/components/expressions/Editor/HelpText/HelpText.module.cssindex 0ada48a6927..926ce8b13a7 100644--- a/frontend/src/metabase/querying/components/expressions/Editor/HelpText/HelpText.module.css+++ b/frontend/src/metabase/querying/components/expressions/Editor/HelpText/HelpText.module.css@@ -1,7 +1,7 @@.usage {padding: 0.25rem 0;padding-left: 0.5rem;- background-color: var(--mb-color-white);+ background-color: var(--mb-color-core-white);color: var(--mb-color-text-secondary);cursor: pointer;font-family: var(--mb-default-monospace-font-family);diff --git a/frontend/src/metabase/querying/components/expressions/Editor/Listbox/Listbox.module.css b/frontend/src/metabase/querying/components/expressions/Editor/Listbox/Listbox.module.cssindex 8c2fd2988f4..cc458c0cec8 100644--- a/frontend/src/metabase/querying/components/expressions/Editor/Listbox/Listbox.module.css+++ b/frontend/src/metabase/querying/components/expressions/Editor/Listbox/Listbox.module.css@@ -18,7 +18,7 @@&:hover,&[aria-selected="true"] {color: inherit;- background-color: var(--mb-color-focus);+ background-color: var(--mb-color-input-focus);}.icon {diff --git a/frontend/src/metabase/querying/components/expressions/FunctionBrowser/FunctionBrowser.module.css b/frontend/src/metabase/querying/components/expressions/FunctionBrowser/FunctionBrowser.module.cssindex eca59d4b7ae..f61b06e4502 100644--- a/frontend/src/metabase/querying/components/expressions/FunctionBrowser/FunctionBrowser.module.css+++ b/frontend/src/metabase/querying/components/expressions/FunctionBrowser/FunctionBrowser.module.css@@ -29,7 +29,7 @@cursor: pointer;&:hover {- background-color: var(--mb-color-focus);+ background-color: var(--mb-color-input-focus);}}diff --git a/frontend/src/metabase/querying/components/template_tags/TagEditorParamParts/FieldMappingSelect.tsx b/frontend/src/metabase/querying/components/template_tags/TagEditorParamParts/FieldMappingSelect.tsxindex a6150f3e422..69725d98b20 100644--- a/frontend/src/metabase/querying/components/template_tags/TagEditorParamParts/FieldMappingSelect.tsx+++ b/frontend/src/metabase/querying/components/template_tags/TagEditorParamParts/FieldMappingSelect.tsx@@ -28,7 +28,7 @@ export function FieldMappingSelect({<ContainerLabel>{t`Field to map to`}{tag.dimension == null && (- <Text c="error" component="span" ml="xs">+ <Text c="feedback-negative" component="span" ml="xs">{t`(required)`}</Text>)}diff --git a/frontend/src/metabase/querying/components/template_tags/TagEditorParamParts/TagEditorParam.module.css b/frontend/src/metabase/querying/components/template_tags/TagEditorParamParts/TagEditorParam.module.cssindex 2b6d16d1001..2eafbdf9f45 100644--- a/frontend/src/metabase/querying/components/template_tags/TagEditorParamParts/TagEditorParam.module.css+++ b/frontend/src/metabase/querying/components/template_tags/TagEditorParamParts/TagEditorParam.module.css@@ -6,7 +6,7 @@}.ErrorSpan {- color: var(--mb-color-error);+ color: var(--mb-color-feedback-negative);}.DefaultParameterValueWidget {diff --git a/frontend/src/metabase/querying/notebook/components/NativeQueryPreview/NativeQueryPreview.tsx b/frontend/src/metabase/querying/notebook/components/NativeQueryPreview/NativeQueryPreview.tsxindex 058a643ab8a..87542878094 100644--- a/frontend/src/metabase/querying/notebook/components/NativeQueryPreview/NativeQueryPreview.tsx+++ b/frontend/src/metabase/querying/notebook/components/NativeQueryPreview/NativeQueryPreview.tsx@@ -43,7 +43,7 @@ export function NativeQueryPreview({<Stack>{formattedError && (<Flex gap="sm">- <Icon name="warning" c="error" />+ <Icon name="warning" c="feedback-negative" />{t`An error occurred in your query`}</Flex>)}diff --git a/frontend/src/metabase/querying/notebook/components/NotebookNativePreview/NotebookNativePreview.tsx b/frontend/src/metabase/querying/notebook/components/NotebookNativePreview/NotebookNativePreview.tsxindex 1cf87f85ccc..c6e54f96545 100644--- a/frontend/src/metabase/querying/notebook/components/NotebookNativePreview/NotebookNativePreview.tsx+++ b/frontend/src/metabase/querying/notebook/components/NotebookNativePreview/NotebookNativePreview.tsx@@ -114,7 +114,7 @@ export const NotebookNativePreview = ({{showEmptySidebar}{showError && (<Flex align="center" justify="center" h="100%" direction="column">- <Icon name="warning" size="2rem" c="error" />+ <Icon name="warning" size="2rem" c="feedback-negative" />{t`Error generating the query.`}<Box mt="sm">{getErrorMessage(error)}</Box></Flex>diff --git a/frontend/src/metabase/querying/segments/components/revisions/RevisionDiff.styled.tsx b/frontend/src/metabase/querying/segments/components/revisions/RevisionDiff.styled.tsxindex 261d4ffba31..c34b333749e 100644--- a/frontend/src/metabase/querying/segments/components/revisions/RevisionDiff.styled.tsx+++ b/frontend/src/metabase/querying/segments/components/revisions/RevisionDiff.styled.tsx@@ -8,7 +8,7 @@ export const EditIcon = styled(Icon)``;export const ErrorIcon = styled(Icon)`- color: var(--mb-color-error);+ color: var(--mb-color-feedback-negative);`;export const SuccessIcon = styled(Icon)`diff --git a/frontend/src/metabase/redux/store/undo.ts b/frontend/src/metabase/redux/store/undo.tsindex 56d625b463d..0abe0d514b3 100644--- a/frontend/src/metabase/redux/store/undo.ts+++ b/frontend/src/metabase/redux/store/undo.ts@@ -13,7 +13,7 @@ export interface Undo {actions?: (() => void)[];showProgress?: boolean;icon?: IconName | null;- toastColor?: string;+ toastColor?: ColorName;dark?: boolean;iconColor?: ColorName;style?: CSSProperties;diff --git a/frontend/src/metabase/rich_text_editing/tiptap/components/EditorBubbleMenu/EditorBubbleMenu.module.css b/frontend/src/metabase/rich_text_editing/tiptap/components/EditorBubbleMenu/EditorBubbleMenu.module.cssindex d47ca1e2e4e..d3ffe963991 100644--- a/frontend/src/metabase/rich_text_editing/tiptap/components/EditorBubbleMenu/EditorBubbleMenu.module.css+++ b/frontend/src/metabase/rich_text_editing/tiptap/components/EditorBubbleMenu/EditorBubbleMenu.module.css@@ -1,6 +1,6 @@.bubbleMenu {border: 1px solid var(--mb-color-border-neutral);border-radius: var(--mantine-radius-sm);- box-shadow: 0 2px 12px var(--mb-color-shadow);+ box-shadow: 0 2px 12px var(--mb-color-shadow-default);background: var(--mb-color-background_page-primary);}diff --git a/frontend/src/metabase/rich_text_editing/tiptap/extensions/LinkHoverMenu/LinkHoverMenu.tsx b/frontend/src/metabase/rich_text_editing/tiptap/extensions/LinkHoverMenu/LinkHoverMenu.tsxindex e164ba43704..4b5fadf35e7 100644--- a/frontend/src/metabase/rich_text_editing/tiptap/extensions/LinkHoverMenu/LinkHoverMenu.tsx+++ b/frontend/src/metabase/rich_text_editing/tiptap/extensions/LinkHoverMenu/LinkHoverMenu.tsx@@ -109,7 +109,7 @@ export const LinkHoverMenu = ({ editor, editable }: LinkHoverMenuProps) => {onMouseLeave={() => startHoverTimeout()}><Card- shadow="0 2px 8px var(--mb-color-shadow)"+ shadow="0 2px 8px var(--mb-color-shadow-default)"bd="1px solid var(--mb-color-border-neutral)"bdrs="sm"px="sm"diff --git a/frontend/src/metabase/rich_text_editing/tiptap/extensions/suggestionRenderer.tsx b/frontend/src/metabase/rich_text_editing/tiptap/extensions/suggestionRenderer.tsxindex f4f53eb1c8a..099aeca3724 100644--- a/frontend/src/metabase/rich_text_editing/tiptap/extensions/suggestionRenderer.tsx+++ b/frontend/src/metabase/rich_text_editing/tiptap/extensions/suggestionRenderer.tsx@@ -97,7 +97,7 @@ export const createSuggestionRenderer = <I = unknown, TSelected = unknown>(backgroundColor: "var(--mb-color-background_page-primary)",border: "1px solid var(--mb-color-border-neutral)",borderRadius: "8px",- boxShadow: "0 4px 10px var(--mb-color-shadow)",+ boxShadow: "0 4px 10px var(--mb-color-shadow-default)",width: "320px",padding: "0.75rem",boxSizing: "border-box",diff --git a/frontend/src/metabase/setup/components/DataUsageStep/DataUsageStep.styled.tsx b/frontend/src/metabase/setup/components/DataUsageStep/DataUsageStep.styled.tsxindex 4daab5712e1..841d4a45b7a 100644--- a/frontend/src/metabase/setup/components/DataUsageStep/DataUsageStep.styled.tsx+++ b/frontend/src/metabase/setup/components/DataUsageStep/DataUsageStep.styled.tsx@@ -34,6 +34,6 @@ export const StepInfoList = styled.ul``;export const StepError = styled.div`- color: var(--mb-color-error);+ color: var(--mb-color-feedback-negative);margin-top: 0.5rem;`;diff --git a/frontend/src/metabase/setup/components/InactiveStep/InactiveStep.styled.tsx b/frontend/src/metabase/setup/components/InactiveStep/InactiveStep.styled.tsxindex 92eade6a366..cf0fbaeea8f 100644--- a/frontend/src/metabase/setup/components/InactiveStep/InactiveStep.styled.tsx+++ b/frontend/src/metabase/setup/components/InactiveStep/InactiveStep.styled.tsx@@ -19,7 +19,7 @@ export const StepRoot = styled.section<Props>`export const StepTitle = styled.div<Props>`color: ${(props) =>- props.isCompleted ? color("success") : color("core-brand")};+ props.isCompleted ? color("feedback-positive") : color("core-brand")};font-size: 1rem;font-weight: 700;margin: 0.5rem 0;@@ -37,10 +37,12 @@ export const StepLabel = styled.div<Props>`height: 2.625rem;border: 1px solid${(props) =>- props.isCompleted ? color("success") : color("border-neutral")};+ props.isCompleted ? color("feedback-positive") : color("border-neutral")};border-radius: 50%;background-color: ${(props) =>- props.isCompleted ? color("success") : color("background_page-primary")};+ props.isCompleted+ ? color("feedback-positive")+ : color("background_page-primary")};`;export const StepLabelText = styled.span`diff --git a/frontend/src/metabase/setup/components/LanguageStep/LanguageStep.styled.tsx b/frontend/src/metabase/setup/components/LanguageStep/LanguageStep.styled.tsxindex 85e63b736d3..8596e14561d 100644--- a/frontend/src/metabase/setup/components/LanguageStep/LanguageStep.styled.tsx+++ b/frontend/src/metabase/setup/components/LanguageStep/LanguageStep.styled.tsx@@ -41,7 +41,7 @@ export const LocaleButton = styled.span<LocaleContainerProps>`background-color: ${(props) =>props.checked ? color("core-brand") : color("background_page-primary")};font-weight: 700;- border: 2px solid var(--mb-color-white);+ border: 2px solid var(--mb-color-core-white);&:hover {color: var(--mb-color-text-primary-inverse);diff --git a/frontend/src/metabase/static-viz/components/Gauge/Gauge.tsx b/frontend/src/metabase/static-viz/components/Gauge/Gauge.tsxindex 30bdd0d7154..24d3ce2f31e 100644--- a/frontend/src/metabase/static-viz/components/Gauge/Gauge.tsx+++ b/frontend/src/metabase/static-viz/components/Gauge/Gauge.tsx@@ -67,7 +67,7 @@ export default function Gauge({formattedValue,GAUGE_INNER_RADIUS,);- const outlineColor = getColor("white");+ const outlineColor = getColor("core-white");return (<svgdiff --git a/frontend/src/metabase/static-viz/components/Gauge/utils.unit.spec.ts b/frontend/src/metabase/static-viz/components/Gauge/utils.unit.spec.tsindex fe9507dd6cb..fdf15469865 100644--- a/frontend/src/metabase/static-viz/components/Gauge/utils.unit.spec.ts+++ b/frontend/src/metabase/static-viz/components/Gauge/utils.unit.spec.ts@@ -208,17 +208,17 @@ describe("Static gauge utils", () => {});it("handles CSS variable color for error", () => {- const arcDatum = createPieArcDatum("var(--mb-color-error)");+ const arcDatum = createPieArcDatum("var(--mb-color-feedback-negative)");expect(colorGetter(arcDatum, getColor)).toMatch(/^#[0-9A-F]{6}$/i);});it("handles CSS variable color for warning", () => {- const arcDatum = createPieArcDatum("var(--mb-color-warning)");+ const arcDatum = createPieArcDatum("var(--mb-color-feedback-warning)");expect(colorGetter(arcDatum, getColor)).toMatch(/^#[0-9A-F]{6}$/i);});it("handles CSS variable color for success", () => {- const arcDatum = createPieArcDatum("var(--mb-color-success)");+ const arcDatum = createPieArcDatum("var(--mb-color-feedback-positive)");expect(colorGetter(arcDatum, getColor)).toMatch(/^#[0-9A-F]{6}$/i);});});diff --git a/frontend/src/metabase/status/components/StatusLarge/StatusLarge.styled.tsx b/frontend/src/metabase/status/components/StatusLarge/StatusLarge.styled.tsxindex 4a5ec5b8b64..cb31bbefd7a 100644--- a/frontend/src/metabase/status/components/StatusLarge/StatusLarge.styled.tsx+++ b/frontend/src/metabase/status/components/StatusLarge/StatusLarge.styled.tsx@@ -9,7 +9,7 @@ export const StatusRoot = styled.div`width: 16rem;border-radius: 6px;background-color: var(--mb-color-background_page-primary);- box-shadow: 0 1px 12px var(--mb-color-shadow);+ box-shadow: 0 1px 12px var(--mb-color-shadow-default);overflow: hidden;margin-top: 1rem;border: 1px solid var(--mb-color-border-neutral);@@ -101,5 +101,5 @@ export const StatusCardIconContainer = styled.div<StatusCardIconContainerProps>`border-radius: 1rem;color: var(--mb-color-text-primary-inverse);background-color: ${(props) =>- props.isError ? color("error") : color("success")};+ props.isError ? color("feedback-negative") : color("feedback-positive")};`;diff --git a/frontend/src/metabase/status/components/StatusSmall/StatusSmall.module.css b/frontend/src/metabase/status/components/StatusSmall/StatusSmall.module.cssindex 6381639f29a..9481ba1f562 100644--- a/frontend/src/metabase/status/components/StatusSmall/StatusSmall.module.css+++ b/frontend/src/metabase/status/components/StatusSmall/StatusSmall.module.css@@ -10,12 +10,12 @@.Root[data-status="complete"] {--border-color: var(--mb-color-core-brand);- --background-color: var(--mb-color-success);+ --background-color: var(--mb-color-feedback-positive);--icon-color: var(--mb-color-text-primary-inverse);}.Root[data-status="loading"] {- --background-color: var(--mb-color-error);+ --background-color: var(--mb-color-feedback-negative);--icon-color: var(--mb-color-text-primary-inverse);}@@ -26,7 +26,7 @@border: 0.375rem solid var(--border-color);border-radius: 50%;background-color: var(--mb-color-background_surface-brand-subtle);- box-shadow: 0 1px 12px var(--mb-color-shadow);+ box-shadow: 0 1px 12px var(--mb-color-shadow-default);}.StatusIconContainer {diff --git a/frontend/src/metabase/timelines/common/components/DeleteEventModal/DeleteEventModal.tsx b/frontend/src/metabase/timelines/common/components/DeleteEventModal/DeleteEventModal.tsxindex 6256ce58460..031e5864dd6 100644--- a/frontend/src/metabase/timelines/common/components/DeleteEventModal/DeleteEventModal.tsx+++ b/frontend/src/metabase/timelines/common/components/DeleteEventModal/DeleteEventModal.tsx@@ -34,7 +34,7 @@ const DeleteEventModal = ({<Button onClick={onClose}>{t`Cancel`}</Button><Buttonvariant="filled"- color="error"+ color="feedback-negative"onClick={handleSubmit}>{t`Delete`}</Button></ModalFooter>diff --git a/frontend/src/metabase/timelines/common/components/DeleteTimelineModal/DeleteTimelineModal.tsx b/frontend/src/metabase/timelines/common/components/DeleteTimelineModal/DeleteTimelineModal.tsxindex 314a834e142..332ff41642d 100644--- a/frontend/src/metabase/timelines/common/components/DeleteTimelineModal/DeleteTimelineModal.tsx+++ b/frontend/src/metabase/timelines/common/components/DeleteTimelineModal/DeleteTimelineModal.tsx@@ -30,7 +30,11 @@ const DeleteTimelineModal = ({<ModalHeader title={t`Delete ${timeline?.name}?`} onClose={onClose} /><ModalFooter hasPadding><Button onClick={onClose}>{t`Cancel`}</Button>- <Button variant="filled" color="error" onClick={handleSubmit}>+ <Button+ variant="filled"+ color="feedback-negative"+ onClick={handleSubmit}+ >{t`Delete`}</Button></ModalFooter>diff --git a/frontend/src/metabase/timelines/common/components/FormArchiveButton/FormArchiveButton.tsx b/frontend/src/metabase/timelines/common/components/FormArchiveButton/FormArchiveButton.tsxindex 744df502b91..91a99585eca 100644--- a/frontend/src/metabase/timelines/common/components/FormArchiveButton/FormArchiveButton.tsx+++ b/frontend/src/metabase/timelines/common/components/FormArchiveButton/FormArchiveButton.tsx@@ -18,7 +18,7 @@ const FormArchiveButton = ({className={S.archiveButton}type="button"variant="subtle"- color="danger"+ color="feedback-negative"px={0}onClick={onClick}>diff --git a/frontend/src/metabase/transforms/components/JobEditor/TransformsSection/utils.tsx b/frontend/src/metabase/transforms/components/JobEditor/TransformsSection/utils.tsxindex f3f4049bcae..02e4d1a8314 100644--- a/frontend/src/metabase/transforms/components/JobEditor/TransformsSection/utils.tsx+++ b/frontend/src/metabase/transforms/components/JobEditor/TransformsSection/utils.tsx@@ -25,7 +25,7 @@ function FreshnessNote({ transform }: { transform: Transform }) {return (<Flex align="center" c="text-secondary" fz="sm" gap="xs" miw={0}>{isUnscheduledDependency(transform) && (- <Icon c="warning" name="warning" size={12} />+ <Icon c="feedback-warning" name="warning" size={12} />)}<Ellipsified>{note}</Ellipsified></Flex>diff --git a/frontend/src/metabase/transforms/components/JobMoreMenu/DeleteJobModal/DeleteJobModal.tsx b/frontend/src/metabase/transforms/components/JobMoreMenu/DeleteJobModal/DeleteJobModal.tsxindex 8bda328ecd8..33fc5691859 100644--- a/frontend/src/metabase/transforms/components/JobMoreMenu/DeleteJobModal/DeleteJobModal.tsx+++ b/frontend/src/metabase/transforms/components/JobMoreMenu/DeleteJobModal/DeleteJobModal.tsx@@ -62,7 +62,7 @@ function DeleteJobForm({ job, onDelete, onClose }: DeleteJobFormProps) {<FormSubmitButtonlabel={t`Delete job`}variant="filled"- color="error"+ color="feedback-negative"/></Group></Stack>diff --git a/frontend/src/metabase/transforms/components/RunButton/RunButton.tsx b/frontend/src/metabase/transforms/components/RunButton/RunButton.tsxindex b175bf1bee5..19ecad2798c 100644--- a/frontend/src/metabase/transforms/components/RunButton/RunButton.tsx+++ b/frontend/src/metabase/transforms/components/RunButton/RunButton.tsx@@ -151,7 +151,7 @@ function getRunButtonInfo({if (run.status === "succeeded") {return {label: t`Ran successfully`,- color: "success",+ color: "feedback-positive",leftSection: <Icon name="check" aria-hidden />,isDisabled,};@@ -160,15 +160,15 @@ function getRunButtonInfo({if (run.status === "canceled") {return {label: t`Canceled`,- color: "warning",- leftSection: <Icon name="close" c="white" aria-hidden />,+ color: "feedback-warning",+ leftSection: <Icon name="close" c="core-white" aria-hidden />,isDisabled,};}return {label: t`Run failed`,- color: "error",+ color: "feedback-negative",leftSection: <Icon name="warning" aria-hidden />,isDisabled,};diff --git a/frontend/src/metabase/transforms/components/RunInfo/RunInfo.module.css b/frontend/src/metabase/transforms/components/RunInfo/RunInfo.module.cssindex e7539be8b17..a38323bd214 100644--- a/frontend/src/metabase/transforms/components/RunInfo/RunInfo.module.css+++ b/frontend/src/metabase/transforms/components/RunInfo/RunInfo.module.css@@ -1,6 +1,6 @@.codeContainer {border: var(--border-size) var(--border-style) var(--mb-color-border-neutral);border-radius: var(--default-border-radius);- box-shadow: 0 2px 2px var(--mb-color-shadow);+ box-shadow: 0 2px 2px var(--mb-color-shadow-default);overflow: hidden;}diff --git a/frontend/src/metabase/transforms/components/RunStatus/RunStatus.tsx b/frontend/src/metabase/transforms/components/RunStatus/RunStatus.tsxindex 4568b3c0e50..b8bf9592558 100644--- a/frontend/src/metabase/transforms/components/RunStatus/RunStatus.tsx+++ b/frontend/src/metabase/transforms/components/RunStatus/RunStatus.tsx@@ -56,7 +56,7 @@ export function RunStatus({case "succeeded":return (<Group gap="sm" data-testid="run-status">- <Icon c="success" name="check_filled" />+ <Icon c="feedback-positive" name="check_filled" /><Box>{endTimeText? t`Last ran ${endTimeText} successfully.`@@ -68,7 +68,7 @@ export function RunStatus({case "failed":return (<Group gap={0} data-testid="run-status">- <Icon c="error" name="warning" mr="sm" />+ <Icon c="feedback-negative" name="warning" mr="sm" /><Box mr={errorInfo ? "xs" : "sm"}>{endTimeText? t`Last run failed ${endTimeText}.`@@ -99,7 +99,7 @@ export function RunStatus({case "timeout":return (<Group gap={0} data-testid="run-status">- <Icon c="error" name="warning" mr="sm" />+ <Icon c="feedback-negative" name="warning" mr="sm" /><Box mr={errorInfo ? "xs" : "sm"}>{endTimeText? t`Last run timed out ${endTimeText}.`diff --git a/frontend/src/metabase/transforms/components/RunStatusInfo/RunStatusInfo.tsx b/frontend/src/metabase/transforms/components/RunStatusInfo/RunStatusInfo.tsxindex f635c9ba320..04370415732 100644--- a/frontend/src/metabase/transforms/components/RunStatusInfo/RunStatusInfo.tsx+++ b/frontend/src/metabase/transforms/components/RunStatusInfo/RunStatusInfo.tsx@@ -24,7 +24,9 @@ export function RunStatusInfo({return (<Group gap="xs" className={S.runStatusInfo} wrap="nowrap">- <Box c={isError ? "error" : undefined}>{formatStatus(status)}</Box>+ <Box c={isError ? "feedback-negative" : undefined}>+ {formatStatus(status)}+ </Box>{isError && message != null && (<RunInfo status={status} message={message} endTime={endTime} />)}diff --git a/frontend/src/metabase/transforms/components/TagMultiSelect/DeleteTagModal/DeleteTagModal.tsx b/frontend/src/metabase/transforms/components/TagMultiSelect/DeleteTagModal/DeleteTagModal.tsxindex f5336078e86..ddd17f004f6 100644--- a/frontend/src/metabase/transforms/components/TagMultiSelect/DeleteTagModal/DeleteTagModal.tsx+++ b/frontend/src/metabase/transforms/components/TagMultiSelect/DeleteTagModal/DeleteTagModal.tsx@@ -61,7 +61,7 @@ function DeleteTagForm({ tag, onDelete, onClose }: DeleteTagFormProps) {<FormSubmitButtonlabel={t`Delete tag`}variant="filled"- color="error"+ color="feedback-negative"/></Group></Stack>diff --git a/frontend/src/metabase/transforms/components/TransformHeader/TransformMoreMenu/DeleteTransformModal/TransformDeleteModal.tsx b/frontend/src/metabase/transforms/components/TransformHeader/TransformMoreMenu/DeleteTransformModal/TransformDeleteModal.tsxindex 322f94786dd..6999d09b5d2 100644--- a/frontend/src/metabase/transforms/components/TransformHeader/TransformMoreMenu/DeleteTransformModal/TransformDeleteModal.tsx+++ b/frontend/src/metabase/transforms/components/TransformHeader/TransformMoreMenu/DeleteTransformModal/TransformDeleteModal.tsx@@ -116,7 +116,7 @@ function DeleteTransformForm({<FormSubmitButtonlabel={getSubmitButtonLabel(transform, shouldDeleteTarget)}variant="filled"- color="error"+ color="feedback-negative"/></Group></Stack>diff --git a/frontend/src/metabase/transforms/pages/RunListPage/RunSidebar/CancelationSection/CancelationSection.tsx b/frontend/src/metabase/transforms/pages/RunListPage/RunSidebar/CancelationSection/CancelationSection.tsxindex a9fdf3640e6..0e1ed0dfa3b 100644--- a/frontend/src/metabase/transforms/pages/RunListPage/RunSidebar/CancelationSection/CancelationSection.tsx+++ b/frontend/src/metabase/transforms/pages/RunListPage/RunSidebar/CancelationSection/CancelationSection.tsx@@ -33,7 +33,7 @@ export function CancelationSection({ run }: CancelationSectionProps) {<div><Buttonvariant="filled"- color="error"+ color="feedback-negative"disabled={isCanceling}onClick={openModal}>diff --git a/frontend/src/metabase/transforms/pages/TransformListPage/utils.ts b/frontend/src/metabase/transforms/pages/TransformListPage/utils.tsindex 2c092e94dd6..0c52f5b1d9f 100644--- a/frontend/src/metabase/transforms/pages/TransformListPage/utils.ts+++ b/frontend/src/metabase/transforms/pages/TransformListPage/utils.ts@@ -198,11 +198,11 @@ const COLLECTION_MODEL = "collection" satisfies RemoteSyncEntityModel;const PYTHON_LIBRARY_MODEL = "pythonlibrary" satisfies RemoteSyncEntityModel;const SYNC_STATUS_COLOR: Record<RemoteSyncEntityStatus, ColorName> = {- create: "success",- update: "warning",- touch: "warning",- delete: "danger",- removed: "danger",+ create: "feedback-positive",+ update: "feedback-warning",+ touch: "feedback-warning",+ delete: "feedback-negative",+ removed: "feedback-negative",};export function getSyncColorForEntities(diff --git a/frontend/src/metabase/transforms/pages/TransformListPage/utils.unit.spec.ts b/frontend/src/metabase/transforms/pages/TransformListPage/utils.unit.spec.tsindex 9674a13ee08..e6fff94b712 100644--- a/frontend/src/metabase/transforms/pages/TransformListPage/utils.unit.spec.ts+++ b/frontend/src/metabase/transforms/pages/TransformListPage/utils.unit.spec.ts@@ -185,16 +185,22 @@ describe("getSyncColorForEntities", () => {expect(getSyncColorForEntities([])).toBeUndefined();});- it("colors a created entity green (success)", () => {- expect(getSyncColorForEntities([dirtyEntity("create")])).toBe("success");+ it("colors a created entity green (feedback-positive)", () => {+ expect(getSyncColorForEntities([dirtyEntity("create")])).toBe(+ "feedback-positive",+ );});- it("colors an updated entity amber (warning)", () => {- expect(getSyncColorForEntities([dirtyEntity("update")])).toBe("warning");+ it("colors an updated entity amber (feedback-warning)", () => {+ expect(getSyncColorForEntities([dirtyEntity("update")])).toBe(+ "feedback-warning",+ );});- it("colors a removed entity red (danger)", () => {- expect(getSyncColorForEntities([dirtyEntity("removed")])).toBe("danger");+ it("colors a removed entity red (feedback-negative)", () => {+ expect(getSyncColorForEntities([dirtyEntity("removed")])).toBe(+ "feedback-negative",+ );});});@@ -215,22 +221,26 @@ describe("getFolderSyncColor", () => {});it("colors a brand-new folder green", () => {- expect(getFolderSyncColor([collection(1, "create")], 1)).toBe("success");+ expect(getFolderSyncColor([collection(1, "create")], 1)).toBe(+ "feedback-positive",+ );});it("colors a renamed or moved folder amber, not green", () => {- expect(getFolderSyncColor([collection(1, "update")], 1)).toBe("warning");+ expect(getFolderSyncColor([collection(1, "update")], 1)).toBe(+ "feedback-warning",+ );});it("colors an existing folder amber when it only contains new children", () => {expect(getFolderSyncColor([childTransform(1, "create")], 1)).toBe(- "warning",+ "feedback-warning",);});it("colors an existing folder amber when a child was removed", () => {expect(getFolderSyncColor([childTransform(1, "removed")], 1)).toBe(- "warning",+ "feedback-warning",);});@@ -240,7 +250,7 @@ describe("getFolderSyncColor", () => {[collection(1, "create"), childTransform(1, "create")],1,),- ).toBe("success");+ ).toBe("feedback-positive");});it("keeps nested brand-new folders green (new folder > new folder > new transform)", () => {@@ -249,13 +259,13 @@ describe("getFolderSyncColor", () => {collection(2, "create"),childTransform(2, "create"),];- expect(getFolderSyncColor(subtree, 1)).toBe("success");+ expect(getFolderSyncColor(subtree, 1)).toBe("feedback-positive");expect(getFolderSyncColor([collection(2, "create"), childTransform(2, "create")],2,),- ).toBe("success");+ ).toBe("feedback-positive");});});diff --git a/frontend/src/metabase/ui/Theme.module.css b/frontend/src/metabase/ui/Theme.module.cssindex 006c3e6fe64..c014b389438 100644--- a/frontend/src/metabase/ui/Theme.module.css+++ b/frontend/src/metabase/ui/Theme.module.css@@ -1,3 +1,3 @@.focus:focus-visible {- outline-color: var(--mb-color-focus);+ outline-color: var(--mb-color-input-focus);}diff --git a/frontend/src/metabase/ui/colors/charts.unit.spec.ts b/frontend/src/metabase/ui/colors/charts.unit.spec.tsindex 2f94719d4d3..fd8489f5ecd 100644--- a/frontend/src/metabase/ui/colors/charts.unit.spec.ts+++ b/frontend/src/metabase/ui/colors/charts.unit.spec.ts@@ -12,7 +12,7 @@ describe("charts", () => {expect(newMapping).toEqual({count: color("accent1"), // existing colors are not changed- profit: color("success"), // a preferred color+ profit: color("feedback-positive"), // a preferred colorsum_2: color("accent6"), // only accent colors are used for other keys});});@@ -25,7 +25,7 @@ describe("charts", () => {expect(newMapping).toEqual({count: color("accent1"), // existing colors are not changed- profit: color("success"), // a preferred color+ profit: color("feedback-positive"), // a preferred colordistinct: color("accent4"), // some color based on the hashsum_2: color("accent6"), // the same color is used despite different keys count});@@ -40,7 +40,7 @@ describe("charts", () => {expect(newMapping).toMatchObject({count: color("accent1"), // existing colors are not changedsum: color("accent0"), // a color from the palette because accent1 would be preferred, but it's already used- profit: color("success"), // a preferred color+ profit: color("feedback-positive"), // a preferred colorS0: color("accent0-dark"), // the next color from paletteS1: color("accent1-dark"), // only dark accents are used when there are <= 16 keysS2: color("accent2"),@@ -58,7 +58,7 @@ describe("charts", () => {expect(newMapping).toMatchObject({count: color("accent1"), // existing colors are not changedsum: color("accent0"), // a color from the palette because accent1 would be preferred, but it's already used- profit: color("success"), // a preferred color+ profit: color("feedback-positive"), // a preferred colorS0: color("accent0-light"), // the next color from paletteS1: color("accent0-dark"), // both light and dark accents are used when there are > 16 seriesS2: color("accent1-light"),diff --git a/frontend/src/metabase/ui/colors/constants/themes/dark.ts b/frontend/src/metabase/ui/colors/constants/themes/dark.tsindex 8088eaaeedd..ae168fbe92b 100644--- a/frontend/src/metabase/ui/colors/constants/themes/dark.ts+++ b/frontend/src/metabase/ui/colors/constants/themes/dark.ts@@ -71,9 +71,6 @@ const deprecatedColors = {"border-strong": baseColors.orionAlphaInverse[30],"border-stronger": baseColors.orionAlphaInverse[50],"border-subtle": baseColors.orionAlphaInverse[10],- copper: "#B87333",- bronze: "#CD7F32",- silver: "#C0C0C0",gold: "#FFD700","upsell-primary": baseColors.ocean[30],"upsell-secondary": baseColors.ocean[80],diff --git a/frontend/src/metabase/ui/colors/constants/themes/light.ts b/frontend/src/metabase/ui/colors/constants/themes/light.tsindex 53fac1d7f55..4dd4e90f382 100644--- a/frontend/src/metabase/ui/colors/constants/themes/light.ts+++ b/frontend/src/metabase/ui/colors/constants/themes/light.ts@@ -71,9 +71,6 @@ const deprecatedColors = {"border-strong": baseColors.orionAlpha[30],"border-stronger": baseColors.orionAlpha[50],"border-subtle": baseColors.orionAlpha[10],- copper: "#B87333",- bronze: "#CD7F32",- silver: "#C0C0C0",gold: "#FFD700","upsell-primary": baseColors.ocean[70],"upsell-secondary": baseColors.ocean[20],diff --git a/frontend/src/metabase/ui/colors/formatting-colors.ts b/frontend/src/metabase/ui/colors/formatting-colors.tsindex 0c63bfecf6f..d68a5a02b44 100644--- a/frontend/src/metabase/ui/colors/formatting-colors.ts+++ b/frontend/src/metabase/ui/colors/formatting-colors.ts@@ -6,7 +6,7 @@ export function assignUserColors(colors = [color("core-brand"),color("accent2"),- color("error"),+ color("feedback-negative"),color("accent1"),color("accent4"),color("background_page-tertiary"),diff --git a/frontend/src/metabase/ui/colors/formatting-colors.unit.spec.ts b/frontend/src/metabase/ui/colors/formatting-colors.unit.spec.tsindex df23e30735c..25962c3325a 100644--- a/frontend/src/metabase/ui/colors/formatting-colors.unit.spec.ts+++ b/frontend/src/metabase/ui/colors/formatting-colors.unit.spec.ts@@ -11,7 +11,7 @@ describe("lib/formatting/colors", () => {const expectedAssignedColors = {"1": color("core-brand"),"2": color("accent2"),- "3": color("error"),+ "3": color("feedback-negative"),};expect(userColors).toMatchObject(expectedAssignedColors);@@ -25,7 +25,7 @@ describe("lib/formatting/colors", () => {const expectedAssignedColors = {"1": color("accent2"),- "2": color("error"),+ "2": color("feedback-negative"),"3": color("accent1"),};diff --git a/frontend/src/metabase/ui/colors/groups.ts b/frontend/src/metabase/ui/colors/groups.tsindex 92abb77427a..f1702edd990 100644--- a/frontend/src/metabase/ui/colors/groups.ts+++ b/frontend/src/metabase/ui/colors/groups.ts@@ -70,8 +70,12 @@ export const getDarkAccentColors = (export const getStatusColorRanges = (): string[][] => {return [- [color("error"), "transparent", color("success")],- [color("error"), color("warning"), color("success")],+ [color("feedback-negative"), "transparent", color("feedback-positive")],+ [+ color("feedback-negative"),+ color("feedback-warning"),+ color("feedback-positive"),+ ],];};@@ -87,7 +91,7 @@ export const getPreferredColor = (key: string, palette?: ColorPalette) => {case "accepted":case "active":case "profit":- return color("success", palette);+ return color("feedback-positive", palette);case "cancel":case "canceled":case "cancelled":@@ -103,12 +107,12 @@ export const getPreferredColor = (key: string, palette?: ColorPalette) => {case "cost":case "deleted":case "pending":- return color("error", palette);+ return color("feedback-negative", palette);case "warn":case "warning":case "incomplete":case "unstable":- return color("warning", palette);+ return color("feedback-warning", palette);case "count":return color("accent0", palette);case "sum":diff --git a/frontend/src/metabase/ui/colors/harmonies.ts b/frontend/src/metabase/ui/colors/harmonies.tsindex 2b3ae29b890..f19425939e2 100644--- a/frontend/src/metabase/ui/colors/harmonies.ts+++ b/frontend/src/metabase/ui/colors/harmonies.ts@@ -29,8 +29,8 @@ const normalize = (cssColor: string) => toHex(Color(cssColor));const FALLBACK: HarmonyColors = {filter: normalize(METABASE_LIGHT_THEME.colors.filter),summarize: normalize(METABASE_LIGHT_THEME.colors.summarize),- positive: normalize(METABASE_LIGHT_THEME.colors.success),- negative: normalize(METABASE_LIGHT_THEME.colors.danger),+ positive: normalize(METABASE_LIGHT_THEME.colors["feedback-positive"]),+ negative: normalize(METABASE_LIGHT_THEME.colors["feedback-negative"]),charts: DEFAULT_ACCENT_COLORS.flatMap((c) => {if (c == null) {return [];diff --git a/frontend/src/metabase/ui/colors/types/color-keys.ts b/frontend/src/metabase/ui/colors/types/color-keys.tsindex 53f822a840a..24ec64bf9a0 100644--- a/frontend/src/metabase/ui/colors/types/color-keys.ts+++ b/frontend/src/metabase/ui/colors/types/color-keys.ts@@ -8,6 +8,11 @@ import type { ALL_ACCENT_COLOR_NAMES } from "../constants/accents";** Both the light and dark theme must define all of these colors.*+ * Token names follow `[category]-[property]-[variant?]-[state?]`. Parts are+ * joined with `-`; when a single part is two words we join those words+ * with `_` so it reads as one unit. E.g. background_surface-brand-strong`+ * is category `background_surface`, property `brand`, variant `strong`.+ ** @inline* @category Theming*/@@ -41,8 +46,6 @@ export type MetabaseColorKey =| "border-subtle"| "brand"| "brand-hover"- | "bronze"- | "copper"| "danger"| "error"| "filter"@@ -62,7 +65,6 @@ export type MetabaseColorKey =| "saturated-red"| "saturated-yellow"| "shadow"- | "silver"| "success"| "success-secondary"| "summarize"diff --git a/frontend/src/metabase/ui/components/buttons/ActionIcon/ActionIcon.module.css b/frontend/src/metabase/ui/components/buttons/ActionIcon/ActionIcon.module.cssindex 6e10d09eaa6..2e4f0855acb 100644--- a/frontend/src/metabase/ui/components/buttons/ActionIcon/ActionIcon.module.css+++ b/frontend/src/metabase/ui/components/buttons/ActionIcon/ActionIcon.module.css@@ -27,7 +27,7 @@}&[data-variant="warning"] {- color: var(--mb-color-warning);+ color: var(--mb-color-feedback-warning);background-color: transparent;&:hover,@@ -38,7 +38,7 @@}&[data-variant="error"] {- color: var(--mb-color-error);+ color: var(--mb-color-feedback-negative);background-color: transparent;&:hover,diff --git a/frontend/src/metabase/ui/components/buttons/Button/Button.stories.tsx b/frontend/src/metabase/ui/components/buttons/Button/Button.stories.tsxindex 85ae9572e05..8a68b85227b 100644--- a/frontend/src/metabase/ui/components/buttons/Button/Button.stories.tsx+++ b/frontend/src/metabase/ui/components/buttons/Button/Button.stories.tsx@@ -21,7 +21,11 @@ const argTypes = {control: { type: "inline-radio" },},color: {- options: { default: undefined, success: "success", error: "error" },+ options: {+ default: undefined,+ "feedback-positive": "feedback-positive",+ "feedback-negative": "feedback-negative",+ },control: { type: "inline-radio" },},size: {@@ -152,7 +156,7 @@ export const DefaultSizeCustomColor = {render: GridTemplate,name: "Default size, custom color",args: {- color: "error",+ color: "feedback-negative",},};@@ -210,7 +214,7 @@ export const CompactSizeCustomColor = {render: GridTemplate,name: "Compact size, custom color",args: {- color: "error",+ color: "feedback-negative",size: "compact-md",},play: async ({ canvasElement }: { canvasElement: HTMLCanvasElement }) => {diff --git a/frontend/src/metabase/ui/components/data-display/Avatar/Avatar.config.ts b/frontend/src/metabase/ui/components/data-display/Avatar/Avatar.config.tsindex cac726ac5a9..eebfe9bc6c8 100644--- a/frontend/src/metabase/ui/components/data-display/Avatar/Avatar.config.ts+++ b/frontend/src/metabase/ui/components/data-display/Avatar/Avatar.config.ts@@ -4,7 +4,7 @@ import type { ColorName } from "metabase/ui/colors/types";const avatarColors: ColorName[] = ["core-brand",- "error",+ "feedback-negative","accent1","accent2","accent3",diff --git a/frontend/src/metabase/ui/components/data-display/TreeTable/ExpandButton/ExpandButton.module.css b/frontend/src/metabase/ui/components/data-display/TreeTable/ExpandButton/ExpandButton.module.cssindex 8d5e24e26e9..d117f0c8f92 100644--- a/frontend/src/metabase/ui/components/data-display/TreeTable/ExpandButton/ExpandButton.module.css+++ b/frontend/src/metabase/ui/components/data-display/TreeTable/ExpandButton/ExpandButton.module.css@@ -12,7 +12,7 @@cursor: pointer;&:focus-visible {- outline: 2px solid var(--mb-color-focus);+ outline: 2px solid var(--mb-color-input-focus);outline-offset: 1px;border-radius: 2px;}diff --git a/frontend/src/metabase/ui/components/data-display/TreeTable/TreeTableRow/TreeTableRow.module.css b/frontend/src/metabase/ui/components/data-display/TreeTable/TreeTableRow/TreeTableRow.module.cssindex 6418941139c..d24ecd5c5e7 100644--- a/frontend/src/metabase/ui/components/data-display/TreeTable/TreeTableRow/TreeTableRow.module.css+++ b/frontend/src/metabase/ui/components/data-display/TreeTable/TreeTableRow/TreeTableRow.module.css@@ -41,7 +41,7 @@}&:focus-visible {- box-shadow: inset 0 0 0 2px var(--mb-color-focus);+ box-shadow: inset 0 0 0 2px var(--mb-color-input-focus);}}diff --git a/frontend/src/metabase/ui/components/feedback/Alert/Alert.config.tsx b/frontend/src/metabase/ui/components/feedback/Alert/Alert.config.tsxindex 02b70931d8a..c53ba881a6e 100644--- a/frontend/src/metabase/ui/components/feedback/Alert/Alert.config.tsx+++ b/frontend/src/metabase/ui/components/feedback/Alert/Alert.config.tsx@@ -13,6 +13,14 @@ const ALERT_BACKGROUND_COLORS: Record<string, ColorName> = {success: "background_surface-success",};+const ALERT_TEXT_COLORS: Record<string, ColorName> = {+ "core-brand": "core-brand",+ warning: "feedback-warning",+ error: "feedback-negative",+ info: "core-info",+ success: "feedback-positive",+};+export const alertOverrides: MantineThemeOverride["components"] = {Alert: Alert.extend({defaultProps: {@@ -23,13 +31,16 @@ export const alertOverrides: MantineThemeOverride["components"] = {title: AlertStyles.title,},vars: (_theme, props) => {+ const textColor = props.color+ ? ALERT_TEXT_COLORS[props.color]+ : undefined;const bgColor = props.color? ALERT_BACKGROUND_COLORS[props.color]: undefined;- if (isColorName(props.color) && isColorName(bgColor)) {+ if (isColorName(textColor) && isColorName(bgColor)) {return {root: {- "--alert-color": color(props.color),+ "--alert-color": color(textColor),"--alert-bg": color(bgColor),},};diff --git a/frontend/src/metabase/ui/components/inputs/Input/Input.module.css b/frontend/src/metabase/ui/components/inputs/Input/Input.module.cssindex 8135ec098a5..5788757db4c 100644--- a/frontend/src/metabase/ui/components/inputs/Input/Input.module.css+++ b/frontend/src/metabase/ui/components/inputs/Input/Input.module.css@@ -43,16 +43,16 @@}&[data-error] {- border-color: var(--mb-color-error);+ border-color: var(--mb-color-feedback-negative);}}&[data-error] {- color: var(--mb-color-error);- border-color: var(--mb-color-error);+ color: var(--mb-color-feedback-negative);+ border-color: var(--mb-color-feedback-negative);&::placeholder {- color: var(--mb-color-error);+ color: var(--mb-color-feedback-negative);}}}@@ -77,7 +77,7 @@}.error {- color: var(--mb-color-error);+ color: var(--mb-color-feedback-negative);font-size: var(--mantine-font-size-sm);line-height: var(--mantine-line-height-sm);margin-top: var(--mantine-spacing-sm);@@ -88,5 +88,5 @@}.required {- color: var(--mb-color-error);+ color: var(--mb-color-feedback-negative);}diff --git a/frontend/src/metabase/ui/components/inputs/Select/Select.module.css b/frontend/src/metabase/ui/components/inputs/Select/Select.module.cssindex fcb4e08b23f..e32970a31b8 100644--- a/frontend/src/metabase/ui/components/inputs/Select/Select.module.css+++ b/frontend/src/metabase/ui/components/inputs/Select/Select.module.css@@ -16,7 +16,7 @@}svg[data-error] {- color: var(--mb-color-error);+ color: var(--mb-color-feedback-negative);}&:has([data-position]) {diff --git a/frontend/src/metabase/ui/components/inputs/Switch/Switch.module.css b/frontend/src/metabase/ui/components/inputs/Switch/Switch.module.cssindex 394c8d28e73..a8b0b7d1bd8 100644--- a/frontend/src/metabase/ui/components/inputs/Switch/Switch.module.css+++ b/frontend/src/metabase/ui/components/inputs/Switch/Switch.module.css@@ -70,7 +70,7 @@padding: 0;margin-top: 0.5rem;font-size: 0.75rem;- color: var(--mb-color-error);+ color: var(--mb-color-feedback-negative);}.track {diff --git a/frontend/src/metabase/ui/components/navigation/Tabs/Tab.module.css b/frontend/src/metabase/ui/components/navigation/Tabs/Tab.module.cssindex b54e5364adc..7ddc815b743 100644--- a/frontend/src/metabase/ui/components/navigation/Tabs/Tab.module.css+++ b/frontend/src/metabase/ui/components/navigation/Tabs/Tab.module.css@@ -41,7 +41,7 @@}&:focus-visible {- outline: 2px solid var(--mb-color-focus);+ outline: 2px solid var(--mb-color-input-focus);}&:disabled {diff --git a/frontend/src/metabase/ui/components/overlays/Modal/Modal.module.css b/frontend/src/metabase/ui/components/overlays/Modal/Modal.module.cssindex ac33eaf0ab2..92d3022a414 100644--- a/frontend/src/metabase/ui/components/overlays/Modal/Modal.module.css+++ b/frontend/src/metabase/ui/components/overlays/Modal/Modal.module.css@@ -12,7 +12,7 @@}.overlay {- background-color: var(--mb-color-overlay);+ background-color: var(--mb-color-modal-overlay);padding: 11px;}diff --git a/frontend/src/metabase/ui/components/overlays/Modal/Modal.stories.tsx b/frontend/src/metabase/ui/components/overlays/Modal/Modal.stories.tsxindex 2b539219e29..6b5df9eefc2 100644--- a/frontend/src/metabase/ui/components/overlays/Modal/Modal.stories.tsx+++ b/frontend/src/metabase/ui/components/overlays/Modal/Modal.stories.tsx@@ -74,7 +74,12 @@ const ConfirmationTemplate = (args: ModalProps) => {<Button type="submit" ml="sm">Cancel</Button>- <Button type="submit" variant="filled" color="error" ml="sm">+ <Button+ type="submit"+ variant="filled"+ color="feedback-negative"+ ml="sm"+ >Delete</Button></Flex>diff --git a/frontend/src/metabase/ui/theme.ts b/frontend/src/metabase/ui/theme.tsindex 03de43759e1..d0a9f9ecf4e 100644--- a/frontend/src/metabase/ui/theme.ts+++ b/frontend/src/metabase/ui/theme.ts@@ -86,7 +86,7 @@ export const getThemeOverrides = (colorScheme,},shadows: {- xs: "0 0 0 0.5px var(--mb-color-border-neutral), 0 1px 2px 0 var(--mb-color-shadow)",+ xs: "0 0 0 0.5px var(--mb-color-border-neutral), 0 1px 2px 0 var(--mb-color-shadow-default)",// eslint-disable-next-line metabase/no-color-literalssm: "0px 1px 4px 2px rgba(0, 0, 0, 0.08)",// eslint-disable-next-line metabase/no-color-literalsdiff --git a/frontend/src/metabase/visualizations/components/ClickActions/ClickActionControl.module.css b/frontend/src/metabase/visualizations/components/ClickActions/ClickActionControl.module.cssindex bdff4242b4f..28f3751a03f 100644--- a/frontend/src/metabase/visualizations/components/ClickActions/ClickActionControl.module.css+++ b/frontend/src/metabase/visualizations/components/ClickActions/ClickActionControl.module.css@@ -24,13 +24,13 @@border-radius: 100px;height: 1.4rem;padding-bottom: 0.125rem;- border: 1px solid var(--mb-color-focus);+ border: 1px solid var(--mb-color-input-focus);}.tokenFilterActionTokenButton {border-radius: 100px;padding: 0.3125rem 0.875rem;- border: 1px solid var(--mb-color-focus);+ border: 1px solid var(--mb-color-input-focus);}.clickActionButtonTextIcon {diff --git a/frontend/src/metabase/visualizations/components/LeafletGridHeatMap.tsx b/frontend/src/metabase/visualizations/components/LeafletGridHeatMap.tsxindex d0c34d5ce90..5922e50f31b 100644--- a/frontend/src/metabase/visualizations/components/LeafletGridHeatMap.tsx+++ b/frontend/src/metabase/visualizations/components/LeafletGridHeatMap.tsx@@ -76,8 +76,8 @@ export class LeafletGridHeatMap extends LeafletMap<LeafletGridHeatMapProps> {const { latitudeIndex, longitudeIndex } = this._getLatLonIndexes();- const successColor = d3.rgb(color("success"));- const errorColor = d3.rgb(color("error"));+ const successColor = d3.rgb(color("feedback-positive"));+ const errorColor = d3.rgb(color("feedback-negative"));const colorScale =min == null || max == nulldiff --git a/frontend/src/metabase/visualizations/components/ObjectDetail/DeleteObjectModal.tsx b/frontend/src/metabase/visualizations/components/ObjectDetail/DeleteObjectModal.tsxindex 738ad8b013c..2445c021b0a 100644--- a/frontend/src/metabase/visualizations/components/ObjectDetail/DeleteObjectModal.tsx+++ b/frontend/src/metabase/visualizations/components/ObjectDetail/DeleteObjectModal.tsx@@ -43,12 +43,12 @@ export const DeleteObjectModal: FunctionComponent<Props> = ({}).unwrap();const message = t`Successfully deleted`;- sendToast({ message, toastColor: "success" });+ sendToast({ message, toastColor: "feedback-positive" });onClose();onSuccess();} catch (error) {const message = getActionErrorMessage(error);- sendToast({ icon: "warning", toastColor: "error", message });+ sendToast({ icon: "warning", toastColor: "feedback-negative", message });}};@@ -61,7 +61,7 @@ export const DeleteObjectModal: FunctionComponent<Props> = ({<Buttonkey="delete"variant="filled"- color="error"+ color="feedback-negative"disabled={typeof actionId === "undefined" ||typeof objectId === "undefined" ||diff --git a/frontend/src/metabase/visualizations/components/TableInteractive/cells/MiniBarCell.tsx b/frontend/src/metabase/visualizations/components/TableInteractive/cells/MiniBarCell.tsxindex 9f8690871bb..a776acdb622 100644--- a/frontend/src/metabase/visualizations/components/TableInteractive/cells/MiniBarCell.tsx+++ b/frontend/src/metabase/visualizations/components/TableInteractive/cells/MiniBarCell.tsx@@ -69,7 +69,7 @@ export const MiniBarCell = <TValue,>({const resolvedMax = resolveMax(min, max, columnSettings["number_style"]);const barPercent =(Math.abs(value) / Math.max(Math.abs(min), Math.abs(resolvedMax))) * 100;- const barVizColor = isNegative ? color("error") : barColor;+ const barVizColor = isNegative ? color("feedback-negative") : barColor;const barStyle = !hasNegative? {@@ -149,7 +149,7 @@ export const MiniBarCell = <TValue,>({left: "50%",top: 0,bottom: 0,- borderLeft: `1px solid ${color("white")}`,+ borderLeft: `1px solid ${color("core-white")}`,}}/>)}diff --git a/frontend/src/metabase/visualizations/components/TrendInfo/TrendInfo.module.css b/frontend/src/metabase/visualizations/components/TrendInfo/TrendInfo.module.cssindex d83b518494d..ea49eb79801 100644--- a/frontend/src/metabase/visualizations/components/TrendInfo/TrendInfo.module.css+++ b/frontend/src/metabase/visualizations/components/TrendInfo/TrendInfo.module.css@@ -4,9 +4,9 @@}.increase {- color: var(--mb-color-success);+ color: var(--mb-color-feedback-positive);}.decrease {- color: var(--mb-color-error);+ color: var(--mb-color-feedback-negative);}diff --git a/frontend/src/metabase/visualizations/components/settings/ChartSettingSegmentsEditor/ChartSettingSegmentsEditor.tsx b/frontend/src/metabase/visualizations/components/settings/ChartSettingSegmentsEditor/ChartSettingSegmentsEditor.tsxindex 58427771bc3..8066b7e2509 100644--- a/frontend/src/metabase/visualizations/components/settings/ChartSettingSegmentsEditor/ChartSettingSegmentsEditor.tsx+++ b/frontend/src/metabase/visualizations/components/settings/ChartSettingSegmentsEditor/ChartSettingSegmentsEditor.tsx@@ -138,9 +138,9 @@ export const ChartSettingSegmentsEditor = ({function getColorPalette() {return [...getAccentColors(),- Color(color("error")).hex(),- Color(color("warning")).hex(),- Color(color("success")).hex(),+ Color(color("feedback-negative")).hex(),+ Color(color("feedback-warning")).hex(),+ Color(color("feedback-positive")).hex(),Color(color("background_page-tertiary")).hex(),];}diff --git a/frontend/src/metabase/visualizations/echarts/graph/treemap/option/option.ts b/frontend/src/metabase/visualizations/echarts/graph/treemap/option/option.tsindex 68779b5fc41..16df27088d4 100644--- a/frontend/src/metabase/visualizations/echarts/graph/treemap/option/option.ts+++ b/frontend/src/metabase/visualizations/echarts/graph/treemap/option/option.ts@@ -149,7 +149,7 @@ function createSeriesBuildConfig({tree,formatPercent,),- headerTintTarget: renderingContext.getColor("white"),+ headerTintTarget: renderingContext.getColor("core-white"),renderingContext,};}diff --git a/frontend/src/metabase/visualizations/echarts/graph/treemap/option/option.unit.spec.ts b/frontend/src/metabase/visualizations/echarts/graph/treemap/option/option.unit.spec.tsindex a4311d19894..becdda22378 100644--- a/frontend/src/metabase/visualizations/echarts/graph/treemap/option/option.unit.spec.ts+++ b/frontend/src/metabase/visualizations/echarts/graph/treemap/option/option.unit.spec.ts@@ -13,6 +13,7 @@ const MOCK_COLORS: Record<string, string> = {"text-primary-inverse": "#ffffff","text-secondary": "#949aab",white: "#ffffff",+ "core-white": "#ffffff",};const renderingContext: RenderingContext = {diff --git a/frontend/src/metabase/visualizations/echarts/graph/treemap/style.rich.ts b/frontend/src/metabase/visualizations/echarts/graph/treemap/style.rich.tsindex ec39eff855a..e74fa18855e 100644--- a/frontend/src/metabase/visualizations/echarts/graph/treemap/style.rich.ts+++ b/frontend/src/metabase/visualizations/echarts/graph/treemap/style.rich.ts@@ -7,7 +7,7 @@ export function getLeafLabelStyle(renderingContext: RenderingContext,textColor?: string,) {- const color = textColor ?? renderingContext.getColor("white");+ const color = textColor ?? renderingContext.getColor("core-white");return {color,rich: getRichLeafLabel(renderingContext, textColor),@@ -18,7 +18,7 @@ export function getRichLeafLabel(renderingContext: RenderingContext,textColor?: string,) {- const color = textColor ?? renderingContext.getColor("white");+ const color = textColor ?? renderingContext.getColor("core-white");const base = {fontFamily: renderingContext.fontFamily,color,diff --git a/frontend/src/metabase/visualizations/shared/components/RowChart/RowChart.stories.tsx b/frontend/src/metabase/visualizations/shared/components/RowChart/RowChart.stories.tsxindex 7cf375018d9..f2190efc6f9 100644--- a/frontend/src/metabase/visualizations/shared/components/RowChart/RowChart.stories.tsx+++ b/frontend/src/metabase/visualizations/shared/components/RowChart/RowChart.stories.tsx@@ -16,7 +16,7 @@ export default {const Template: StoryFn<RowChartProps<any>> = (args) => {return (- <Box h={600} bg="white" p="8px">+ <Box h={600} bg="core-white" p="8px"><RowChart {...args} /></Box>);@@ -90,7 +90,7 @@ const ThemedRowChart = () => {const theme = useRowChartTheme("Lato", false);return (- <Box h={600} bg="white" p="8px">+ <Box h={600} bg="core-white" p="8px"><RowChart {...DEFAULT_ROW_CHART_ARGS} theme={theme} stackOffset={null} /></Box>);diff --git a/frontend/src/metabase/visualizations/visualizations/List/components/ListView/ListViewConfiguration.tsx b/frontend/src/metabase/visualizations/visualizations/List/components/ListView/ListViewConfiguration.tsxindex 80ada9f292e..3fca3541ba1 100644--- a/frontend/src/metabase/visualizations/visualizations/List/components/ListView/ListViewConfiguration.tsx+++ b/frontend/src/metabase/visualizations/visualizations/List/components/ListView/ListViewConfiguration.tsx@@ -246,7 +246,7 @@ export const ListViewConfiguration = ({style={{backgroundColor: iconConfig.entityIconEnabled? getIconBackground(iconConfig.selectedIconColor)- : "var(--mb-color-white)",+ : "var(--mb-color-core-white)",}}>{iconConfig.useImageColumn &&diff --git a/frontend/src/metabase/visualizations/visualizations/List/components/ListView/styling.ts b/frontend/src/metabase/visualizations/visualizations/List/components/ListView/styling.tsindex 9fcf11c553c..8bb4e78548c 100644--- a/frontend/src/metabase/visualizations/visualizations/List/components/ListView/styling.ts+++ b/frontend/src/metabase/visualizations/visualizations/List/components/ListView/styling.ts@@ -41,12 +41,12 @@ export const ENTITY_ICON_COLORS: ColorName[] = [// otherwise derive transparent background from custom color.export function getIconBackground(iconColor?: string) {if (!iconColor) {- return "var(--mb-color-white)";+ return "var(--mb-color-core-white)";}return iconColor !== color("text-primary")? `color-mix(in srgb, ${maybeColor(iconColor)}, transparent 88%)`- : "var(--mb-color-white)";+ : "var(--mb-color-core-white)";}const CATEGORY_COLORS = [diff --git a/frontend/src/metabase/visualizations/visualizations/SmartScalar/PreviousValueComparison/PreviousValueComparisonTooltip.tsx b/frontend/src/metabase/visualizations/visualizations/SmartScalar/PreviousValueComparison/PreviousValueComparisonTooltip.tsxindex cd6b1d7da6d..9b4a8c1ef5d 100644--- a/frontend/src/metabase/visualizations/visualizations/SmartScalar/PreviousValueComparison/PreviousValueComparisonTooltip.tsx+++ b/frontend/src/metabase/visualizations/visualizations/SmartScalar/PreviousValueComparison/PreviousValueComparisonTooltip.tsx@@ -35,7 +35,7 @@ export function PreviousValueComparisonTooltip({</VariationPercent><VariationDetails><DetailCandidate- color="white"+ color="core-white"comparison={comparison}valueFormatted={valueCandidates[0]}/>diff --git a/frontend/src/metabase/visualizations/visualizations/SmartScalar/compute.ts b/frontend/src/metabase/visualizations/visualizations/SmartScalar/compute.tsindex fd55dbd6487..f5e796653ff 100644--- a/frontend/src/metabase/visualizations/visualizations/SmartScalar/compute.ts+++ b/frontend/src/metabase/visualizations/visualizations/SmartScalar/compute.ts@@ -796,12 +796,12 @@ function getArrowColor() {const arrowIconColorNames = shouldSwitchPositiveNegative? {- [CHANGE_ARROW_ICONS.ARROW_DOWN]: getColor("success"),- [CHANGE_ARROW_ICONS.ARROW_UP]: getColor("error"),+ [CHANGE_ARROW_ICONS.ARROW_DOWN]: getColor("feedback-positive"),+ [CHANGE_ARROW_ICONS.ARROW_UP]: getColor("feedback-negative"),}: {- [CHANGE_ARROW_ICONS.ARROW_DOWN]: getColor("error"),- [CHANGE_ARROW_ICONS.ARROW_UP]: getColor("success"),+ [CHANGE_ARROW_ICONS.ARROW_DOWN]: getColor("feedback-negative"),+ [CHANGE_ARROW_ICONS.ARROW_UP]: getColor("feedback-positive"),};return arrowIconColorNames[changeArrowIconName];diff --git a/frontend/src/metabase/visualizations/visualizations/SmartScalar/compute.unit.spec.ts b/frontend/src/metabase/visualizations/visualizations/SmartScalar/compute.unit.spec.tsindex ffdfb284a16..eef6275c394 100644--- a/frontend/src/metabase/visualizations/visualizations/SmartScalar/compute.unit.spec.ts+++ b/frontend/src/metabase/visualizations/visualizations/SmartScalar/compute.unit.spec.ts@@ -2422,7 +2422,9 @@ function getComparisonChangeProperties({if (changeType === "decrease") {return {changeArrowIconName: CHANGE_ARROW_ICONS.ARROW_DOWN,- changeColor: flipColor ? colors.success : colors.error,+ changeColor: flipColor+ ? colors["feedback-positive"]+ : colors["feedback-negative"],changeType: CHANGE_TYPE_OPTIONS.CHANGED.CHANGE_TYPE,};}@@ -2430,7 +2432,9 @@ function getComparisonChangeProperties({if (changeType === "increase") {return {changeArrowIconName: CHANGE_ARROW_ICONS.ARROW_UP,- changeColor: flipColor ? colors.error : colors.success,+ changeColor: flipColor+ ? colors["feedback-negative"]+ : colors["feedback-positive"],changeType: CHANGE_TYPE_OPTIONS.CHANGED.CHANGE_TYPE,};}diff --git a/frontend/src/metabase/visualizations/visualizations/Table/Table.stories.tsx b/frontend/src/metabase/visualizations/visualizations/Table/Table.stories.tsxindex 94ed7e4f44e..d706ae6f5a4 100644--- a/frontend/src/metabase/visualizations/visualizations/Table/Table.stories.tsx+++ b/frontend/src/metabase/visualizations/visualizations/Table/Table.stories.tsx@@ -48,7 +48,7 @@ const DefaultTemplate: StoryFn<{}> = ({series,isDashboard,- bgColor = "white",+ bgColor = "core-white",theme,hasDevWatermark,}: {diff --git a/frontend/src/metabase/visualizer/components/DataImporter/ColumnsList/ColumnsListItem.tsx b/frontend/src/metabase/visualizer/components/DataImporter/ColumnsList/ColumnsListItem.tsxindex 1f54432a5e5..5e2c9c40a74 100644--- a/frontend/src/metabase/visualizer/components/DataImporter/ColumnsList/ColumnsListItem.tsx+++ b/frontend/src/metabase/visualizer/components/DataImporter/ColumnsList/ColumnsListItem.tsx@@ -39,7 +39,7 @@ export const ColumnsListItem = forwardRef<HTMLDivElement, ColumnsListItemProps>(return style;} else if (highlightedForDrag) {style.border = "2px solid var(--mb-color-core-brand)";- style.boxShadow = "0px 1px 4px 1px var(--mb-color-shadow)";+ style.boxShadow = "0px 1px 4px 1px var(--mb-color-shadow-default)";style.cursor = "grab";style.backgroundColor = "var(--mb-color-background_page-secondary)";style.borderRadius = "var(--default-border-radius)";diff --git a/frontend/src/metabase/visualizer/components/DataImporter/DatasetsList/DatasetsListItem.tsx b/frontend/src/metabase/visualizer/components/DataImporter/DatasetsList/DatasetsListItem.tsxindex 2ede62b0448..341a22880e6 100644--- a/frontend/src/metabase/visualizer/components/DataImporter/DatasetsList/DatasetsListItem.tsx+++ b/frontend/src/metabase/visualizer/components/DataImporter/DatasetsList/DatasetsListItem.tsx@@ -49,7 +49,7 @@ export const DatasetsListItem = (props: DatasetsListItemProps) => {><IconclassName={S.WarningIcon}- c="danger"+ c="feedback-negative"name="warning_round_filled"size={10}/>diff --git a/frontend/src/metabase/visualizer/components/VisualizationCanvas/VisualizationCanvas.tsx b/frontend/src/metabase/visualizer/components/VisualizationCanvas/VisualizationCanvas.tsxindex e4580bf673c..0ec612e621c 100644--- a/frontend/src/metabase/visualizer/components/VisualizationCanvas/VisualizationCanvas.tsx+++ b/frontend/src/metabase/visualizer/components/VisualizationCanvas/VisualizationCanvas.tsx@@ -148,7 +148,7 @@ export function VisualizationCanvas({ className }: VisualizationCanvasProps) {<Center className={S.SwapAffordanceIcon}><Stack align="center" gap="xs" p="xs"><Icon name="sync" />- <Text c="white" size="sm">+ <Text c="core-white" size="sm">{t`Replace`}</Text></Stack>diff --git a/frontend/src/metabase/visualizer/components/VisualizationCanvas/wells/WellItem.tsx b/frontend/src/metabase/visualizer/components/VisualizationCanvas/wells/WellItem.tsxindex 4b400b923a2..c80a0fb2ee1 100644--- a/frontend/src/metabase/visualizer/components/VisualizationCanvas/wells/WellItem.tsx+++ b/frontend/src/metabase/visualizer/components/VisualizationCanvas/wells/WellItem.tsx@@ -26,14 +26,14 @@ export const WellItem = forwardRef<HTMLDivElement, WellItemProps>(style={{borderRadius: "var(--border-radius-xl)",border: `1px solid var(--mb-color-border-neutral)`,- boxShadow: "0 0 1px var(--mb-color-shadow)",+ boxShadow: "0 0 1px var(--mb-color-shadow-default)",cursor: "grab",userSelect: "none",...(highlightedForDrag? {border: "2px solid var(--mb-color-core-brand)",- boxShadow: "0px 1px 4px 1px var(--mb-color-shadow)",+ boxShadow: "0px 1px 4px 1px var(--mb-color-shadow-default)",cursor: "grab",backgroundColor: "var(--mb-color-background_page-secondary)",borderRadius: "var(--border-radius-xl)",