Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Enable `check_snippet` endpoint (#69892)

lbrdnk370a4dff1439
diff --git a/enterprise/backend/src/metabase_enterprise/dependencies/api.clj b/enterprise/backend/src/metabase_enterprise/dependencies/api.clj
index e81a013ef0b..cd6d34e85a9 100644
--- a/enterprise/backend/src/metabase_enterprise/dependencies/api.clj
+++ b/enterprise/backend/src/metabase_enterprise/dependencies/api.clj
@@ -2,6 +2,7 @@
(:require
[clojure.set :as set]
[clojure.string :as str]
+ [medley.core :as m]
[metabase-enterprise.dependencies.core :as dependencies]
[metabase-enterprise.dependencies.dependency-types :as deps.dependency-types]
[metabase-enterprise.dependencies.models.analysis-finding-error :as analysis-finding-error]
@@ -128,7 +129,7 @@
"Check a proposed edit to a native snippet, and return the cards, etc. which will be broken."
[_route-params
_query-params
- {:keys [id], snippet-name :name}
+ {:keys [id content], snippet-name :name}
:- [:map
[:id {:optional false} ::lib.schema.id/snippet]
[:name {:optional true} native-query-snippets/NativeQuerySnippetName]
@@ -139,8 +140,14 @@
(not= snippet-name (:name original))
(t2/exists? :model/NativeQuerySnippet :name snippet-name))
(throw (ex-info (tru "A snippet with that name already exists. Please pick a different name.")
- {:status-code 400})))]
- (broken-cards-response {})))
+ {:status-code 400})))
+ snippet (cond-> (m/assoc-some original
+ :lib/type :metadata/native-query-snippet
+ :name snippet-name
+ :content content)
+ content native-query-snippets/add-template-tags)
+ breakages (dependencies/errors-from-proposed-edits {:snippet [snippet]} :include-native? true)]
+ (broken-cards-response breakages)))
(def ^:private entity-keys
{:table [:name :description :display_name :db_id :db :schema :fields :transform
diff --git a/enterprise/backend/test/metabase_enterprise/dependencies/api_test.clj b/enterprise/backend/test/metabase_enterprise/dependencies/api_test.clj
index 076e93d0ff1..e6e3cdc8fae 100644
--- a/enterprise/backend/test/metabase_enterprise/dependencies/api_test.clj
+++ b/enterprise/backend/test/metabase_enterprise/dependencies/api_test.clj
@@ -333,8 +333,8 @@
(is (= {:bad_cards [], :bad_transforms [], :success true}
response)))))))
-(deftest check-snippet-content-change-doest-not-break-cards-test
- (testing "POST /api/ee/dependencies/check-snippet doesn't catch when a change would break a card, because native query validation is disabled"
+(deftest check-snippet-content-change-doest-break-cards-test
+ (testing "POST /api/ee/dependencies/check-snippet catches when a change would break a card"
(mt/dataset test-data
(mt/with-premium-features #{:dependencies}
(mt/with-temp [:model/User user {:email "[email protected]"}
@@ -349,17 +349,17 @@
:type :snippet
:snippet-name snippet-name
:snippet-id snippet-id}}))
- _card (card/create-card! {:name "Card using snippet"
- :dataset_query native-query
- :display :table
- :visualization_settings {}}
- user)
+ card (card/create-card! {:name "Card using snippet"
+ :dataset_query native-query
+ :display :table
+ :visualization_settings {}}
+ user)
proposed-content "WHERE NONEXISTENT_COLUMN > 100"
response (mt/user-http-request :rasta :post 200 "ee/dependencies/check-snippet"
{:id snippet-id
:content proposed-content})]
- (is (=? {:success true
- :bad_cards []
+ (is (=? {:success false
+ :bad_cards [{:id (:id card)}]
:bad_transforms []}
response)))))))))