The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
fix: dashboard card becomes uneditable after reordering funnel steps (#69242)
Maksym Yakubych378a6384d720
diff --git a/e2e/test/scenarios/dashboard/visualizer/funnel-title-navigation.cy.spec.ts b/e2e/test/scenarios/dashboard/visualizer/funnel-title-navigation.cy.spec.tsnew file mode 100644index 00000000000..53bbbfd88ca--- /dev/null+++ b/e2e/test/scenarios/dashboard/visualizer/funnel-title-navigation.cy.spec.ts@@ -0,0 +1,100 @@+export {};++const { H } = cy;++describe("scenarios > dashboard > visualizer > funnel title navigation", () => {+ beforeEach(() => {+ H.restore();++ cy.intercept("POST", "/api/dashboard/*/dashcard/*/card/*/query").as(+ "dashcardQuery",+ );++ cy.signInAsNormalUser();+ });++ it("should open the underlying question when clicking the title of a single-question visualizer funnel (UXW-2692)", () => {+ const visualizerTitle = "UXW-2692 Visualizer Funnel";++ H.createNativeQuestion({+ name: "UXW-2692 Funnel Base",+ display: "funnel",+ native: {+ query: `+ SELECT 73 AS "Val", 'Downloads' AS "Step"+ UNION ALL+ SELECT 52 AS "Val", 'Followers' AS "Step"+ `,+ },+ visualization_settings: {+ "funnel.metric": "Val",+ "funnel.dimension": "Step",+ },+ }).then(({ body: { id: questionId } }) => {+ H.createDashboard({ name: "UXW-2692 Dashboard" }).then(+ ({ body: { id: dashboardId } }) => {+ cy.request("PUT", `/api/dashboard/${dashboardId}`, {+ dashcards: [+ {+ id: -1,+ card_id: questionId,+ dashboard_tab_id: null,+ row: 0,+ col: 0,+ size_x: 12,+ size_y: 8,+ visualization_settings: {+ visualization: {+ display: "funnel",+ columnValuesMapping: {+ COLUMN_1: [+ {+ name: "COLUMN_1",+ originalName: "Step",+ sourceId: `card:${questionId}`,+ },+ ],+ COLUMN_2: [+ {+ name: "COLUMN_2",+ originalName: "Val",+ sourceId: `card:${questionId}`,+ },+ ],+ },+ settings: {+ "card.title": visualizerTitle,+ "funnel.metric": "COLUMN_2",+ "funnel.dimension": "COLUMN_1",+ "funnel.rows": [+ {+ key: "Followers",+ name: "Followers",+ enabled: true,+ },+ {+ key: "Downloads",+ name: "Downloads",+ enabled: true,+ },+ ],+ },+ },+ },+ },+ ],+ });++ H.visitDashboard(dashboardId);++ cy.wait("@dashcardQuery");+ H.getDashboardCard(0).findByTestId("funnel-chart").should("exist");++ H.clickOnCardTitle(0);++ cy.location("pathname").should("contain", `/question/${questionId}`);+ },+ );+ });+ });+});diff --git a/frontend/src/metabase/visualizations/visualizations/Funnel/Funnel.tsx b/frontend/src/metabase/visualizations/visualizations/Funnel/Funnel.tsxindex 871f4a553ea..c70958742df 100644--- a/frontend/src/metabase/visualizations/visualizations/Funnel/Funnel.tsx+++ b/frontend/src/metabase/visualizations/visualizations/Funnel/Funnel.tsx@@ -195,6 +195,7 @@ export function Funnel(props: VisualizationProps) {className,onChangeCardAndRun,rawSeries,+ visualizerRawSeries,fontFamily,getHref,isDashboard,@@ -232,6 +233,7 @@ export function Funnel(props: VisualizationProps) {{hasTitle && (<ChartCaptionseries={groupedRawSeries}+ visualizerRawSeries={visualizerRawSeries}settings={settings}icon={headerIcon}getHref={canSelectTitle ? getHref : undefined}