Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Upgrade clickhouse jdbc driver to 0.9.8 (#73404)

Riley Thompson37b72f94e44d
diff --git a/modules/drivers/clickhouse/deps.edn b/modules/drivers/clickhouse/deps.edn
index fa9e443c128..04842aa1abc 100644
--- a/modules/drivers/clickhouse/deps.edn
+++ b/modules/drivers/clickhouse/deps.edn
@@ -1,6 +1,6 @@
{:paths ["src" "resources"]
:deps
- {com.clickhouse/clickhouse-jdbc {:mvn/version "0.9.7"
+ {com.clickhouse/clickhouse-jdbc {:mvn/version "0.9.8"
:exclusions [org.apache.commons/commons-lang3
org.lz4/lz4-java]}
;; pinned: clickhouse-jdbc pulls httpcore5-h2 5.3.4
diff --git a/modules/drivers/clickhouse/test/metabase/driver/clickhouse_substitution_test.clj b/modules/drivers/clickhouse/test/metabase/driver/clickhouse_substitution_test.clj
index e520da21b3f..e0d08aeef2a 100644
--- a/modules/drivers/clickhouse/test/metabase/driver/clickhouse_substitution_test.clj
+++ b/modules/drivers/clickhouse/test/metabase/driver/clickhouse_substitution_test.clj
@@ -373,7 +373,7 @@
:id uuid}]}]
(is (= [[1 1574982000000 "Event A"]
[2 1575068400000 "Event B"]]
- (mt/rows (qp/process-query query)))))))))))
+ (mt/formatted-rows [int long str] (qp/process-query query)))))))))))
(deftest clickhouse-native-query-with-uuid-filter-test
(mt/test-driver :clickhouse
diff --git a/modules/drivers/clickhouse/test/metabase/driver/clickhouse_test.clj b/modules/drivers/clickhouse/test/metabase/driver/clickhouse_test.clj
index 998ebef9350..29c074ad8d4 100644
--- a/modules/drivers/clickhouse/test/metabase/driver/clickhouse_test.clj
+++ b/modules/drivers/clickhouse/test/metabase/driver/clickhouse_test.clj
@@ -488,6 +488,24 @@
(qp/process-query)
(mt/rows))))))))))
+(deftest ^:parallel recursive-cte-native-query-test
+ (mt/test-driver :clickhouse
+ (testing "can execute a native query with a recursive CTE (#73161)"
+ (is (= [[1] [2] [3]]
+ (->> "WITH RECURSIVE t AS ( SELECT 1 AS n UNION ALL SELECT n + 1 FROM t WHERE n < 3 ) SELECT * FROM t;"
+ (lib/native-query (mt/metadata-provider))
+ (qp/process-query)
+ (mt/formatted-rows [int])))))))
+
+(deftest ^:parallel query-with-boolean-setting-test
+ (mt/test-driver :clickhouse
+ (testing "can execute a query with settings set to a boolean (#73431)"
+ (is (= [[2]]
+ (->> "select 2 SETTINGS use_query_cache = true"
+ (lib/native-query (mt/metadata-provider))
+ (qp/process-query)
+ (mt/rows)))))))
+
(defn- check-legacy-dbname [dbname exp-name]
(let [details (assoc (:details (mt/db)) :dbname dbname)
spec (sql-jdbc.conn/connection-details->spec :clickhouse details)]