Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Replace @sinonjs/fake-timers with a local Date mock (#80930)

Andrei Chernykh3ac0958c5066
diff --git a/bun.lock b/bun.lock
index 5b4cf1db090..a3f5f104572 100644
--- a/bun.lock
+++ b/bun.lock
@@ -187,7 +187,6 @@
"@rspack/core": "^2.0.3",
"@rspack/dev-server": "^2.0.1",
"@rspack/plugin-react-refresh": "^2.0.0",
- "@sinonjs/fake-timers": "^9.1.2",
"@stardazed/streams-text-encoding": "^1.0.2",
"@storybook/addon-a11y": "^8.5.0",
"@storybook/addon-actions": "^8.5.0",
@@ -244,7 +243,6 @@
"@types/react-virtualized": "^9.22.2",
"@types/redux-actions": "^2.6.5",
"@types/semver": "^7.7.1",
- "@types/sinonjs__fake-timers": "^15.0.1",
"@types/underscore": "^1.13.0",
"@vitejs/plugin-react": "^6.0.2",
"ajv": "^8.5.0",
@@ -1484,9 +1482,9 @@
"@sinclair/typebox": ["@sinclair/[email protected]", "", {}, "sha512-kKJTNuK3AQOrgjjotVxMrCn1sUJwM76wMszfq1kdU4uYVJjvEWuFQ6HgvLt4Xz3fSmZlTOxJ/Ie13KnIcWQXFA=="],
- "@sinonjs/commons": ["@sinonjs/[email protected]", "", { "dependencies": { "type-detect": "4.0.8" } }, "sha512-xkNcLAn/wZaX14RPlwizcKicDk9G3F8m2nU3L7Ukm5zBgTwiT0wsoFAHx9Jq56fJA1z/7uKGtCRu16sOUCLIHQ=="],
+ "@sinonjs/commons": ["@sinonjs/[email protected]", "", { "dependencies": { "type-detect": "4.0.8" } }, "sha512-K3mCHKQ9sVh8o1C9cxkwxaOmXoAMlDxC1mYyHrjqOWEcBjYr76t96zL2zlj5dUGZ3HSw240X1qgH3Mjf1yJWpQ=="],
- "@sinonjs/fake-timers": ["@sinonjs/[email protected]", "", { "dependencies": { "@sinonjs/commons": "^1.7.0" } }, "sha512-BPS4ynJW/o92PUR4wgriz2Ud5gpST5vz6GQfMixEDK0Z8ZCUv2M7SkBLykH56T++Xs+8ln9zTGbOvNGIe02/jw=="],
+ "@sinonjs/fake-timers": ["@sinonjs/[email protected]", "", { "dependencies": { "@sinonjs/commons": "^3.0.1" } }, "sha512-36/hTbH2uaWuGVERyC6da9YwGWnzUZXuPro/F2LfsdOsLnCojz/iSH8MxUt/FD2S5XBSVPhmArFUXcpCQ2Hkiw=="],
"@snowplow/browser-tracker": ["@snowplow/[email protected]", "", { "dependencies": { "@snowplow/browser-tracker-core": "3.2.0", "@snowplow/tracker-core": "3.2.0", "tslib": "^2.3.0" } }, "sha512-k9oabjXpM7qIYM5CnMu1EZ/CbbffBKBK1TJTMJaf2k1F3Xplbyqx9DssN1NzgX+lH9Gc22n+yow+czRyppZOCg=="],
@@ -1956,7 +1954,7 @@
"@types/serve-static": ["@types/[email protected]", "", { "dependencies": { "@types/http-errors": "*", "@types/node": "*", "@types/send": "*" } }, "sha512-W8Ym+h8nhuRwaKPaDw34QUkwsGi6Rc4yYqvKFo5rm2FUEhCFbzVWrxXUxuKK8TASjWsysJY0nsmNCGhCOIsrOw=="],
- "@types/sinonjs__fake-timers": ["@types/[email protected]", "", {}, "sha512-Ko2tjWJq8oozHzHV+reuvS5KYIRAokHnGbDwGh/J64LntgpbuylF74ipEL24HCyRjf9FOlBiBHWBR1RlVKsI1w=="],
+ "@types/sinonjs__fake-timers": ["@types/[email protected]", "", {}, "sha512-0kSuKjAS0TrGLJ0M/+8MaFkGsQhZpB6pxOmvS3K8FYI72K//YmdfoW9X2qPsAKh1mkwxGD5zib9s1FIFed6E8g=="],
"@types/sizzle": ["@types/[email protected]", "", {}, "sha512-tAe4Q+OLFOA/AMD+0lq8ovp8t3ysxAOeaScnfNdZpUxaGl51ZMDEITxkvFl1STudQ58mz6gzVGl9VhMKhwRnZQ=="],
@@ -5666,8 +5664,6 @@
"@jest/create-cache-key-function/@jest/types": ["@jest/[email protected]", "", { "dependencies": { "@jest/pattern": "30.4.0", "@jest/schemas": "30.4.1", "@types/istanbul-lib-coverage": "^2.0.6", "@types/istanbul-reports": "^3.0.4", "@types/node": "*", "@types/yargs": "^17.0.33", "chalk": "^4.1.2" } }, "sha512-f1x/vJXIfjOlEmejYpbkbgw1gOqpPECwMvMEtBqe47j7H2Hg8h8w3o3ikhSXq3MI15kg+oQ0exWO0uCtTNJLoQ=="],
- "@jest/fake-timers/@sinonjs/fake-timers": ["@sinonjs/[email protected]", "", { "dependencies": { "@sinonjs/commons": "^3.0.1" } }, "sha512-36/hTbH2uaWuGVERyC6da9YwGWnzUZXuPro/F2LfsdOsLnCojz/iSH8MxUt/FD2S5XBSVPhmArFUXcpCQ2Hkiw=="],
-
"@jest/reporters/@jridgewell/trace-mapping": ["@jridgewell/[email protected]", "", { "dependencies": { "@jridgewell/resolve-uri": "^3.1.0", "@jridgewell/sourcemap-codec": "^1.4.14" } }, "sha512-uw6guiW/gcAGPDhLmd77/6lW8QLeiV5RUTsAX46Db6oLhGaVj4lhnPwb184s1bkc8kdVg/+h988dro8GRDpmYQ=="],
"@jest/reporters/glob": ["[email protected]", "", { "dependencies": { "foreground-child": "^3.1.0", "jackspeak": "^3.1.2", "minimatch": "^9.0.4", "minipass": "^7.1.2", "package-json-from-dist": "^1.0.0", "path-scurry": "^1.11.1" }, "bin": { "glob": "dist/esm/bin.mjs" } }, "sha512-DfXN8DfhJ7NH3Oe7cFmu3NCu1wKbkReJ8TorzSAFbSKrlNaQSKfIzqYqVY8zlbs2NLBbWpRiU52GX2PbaBVNkg=="],
@@ -6126,8 +6122,6 @@
"csso/css-tree": ["[email protected]", "", { "dependencies": { "mdn-data": "2.0.28", "source-map-js": "^1.0.1" } }, "sha512-OA0mILzGc1kCOCSJerOeqDxDQ4HOh+G8NbOJFOTgOCzpw7fCBubk0fEyxp8AgOL/jvLgYA/uV0cMbe43ElF1JA=="],
- "cypress/@types/sinonjs__fake-timers": ["@types/[email protected]", "", {}, "sha512-0kSuKjAS0TrGLJ0M/+8MaFkGsQhZpB6pxOmvS3K8FYI72K//YmdfoW9X2qPsAKh1mkwxGD5zib9s1FIFed6E8g=="],
-
"cypress/buffer": ["[email protected]", "", { "dependencies": { "base64-js": "^1.3.1", "ieee754": "^1.1.13" } }, "sha512-EHcyIPBQ4BSGlvjB16k5KgAJ27CIsHY/2JBmCRReo48y9rQ3MaUzWX3KVlBa4U7MyX02HdVj0K7C3WaB3ju7FQ=="],
"cypress/commander": ["[email protected]", "", {}, "sha512-U7VdrJFnJgo4xjrHpTzu0yrHPGImdsmD95ZlgYSEajAn2JKzDhDTPG9kBTefmObL2w/ngeZnilk+OV9CG3d7UA=="],
@@ -7252,8 +7246,6 @@
"@jest/create-cache-key-function/@jest/types/@jest/schemas": ["@jest/[email protected]", "", { "dependencies": { "@sinclair/typebox": "^0.34.0" } }, "sha512-i6b4qw5qnP8c5FEeBJg/uZQ4ddrkN6Ca8qISJh0pr7a5hfn3h3v5x60BEbOC7OYAGZNMs1LfFLwnW2CuK8F57Q=="],
- "@jest/fake-timers/@sinonjs/fake-timers/@sinonjs/commons": ["@sinonjs/[email protected]", "", { "dependencies": { "type-detect": "4.0.8" } }, "sha512-K3mCHKQ9sVh8o1C9cxkwxaOmXoAMlDxC1mYyHrjqOWEcBjYr76t96zL2zlj5dUGZ3HSw240X1qgH3Mjf1yJWpQ=="],
-
"@jest/reporters/@jridgewell/trace-mapping/@jridgewell/resolve-uri": ["@jridgewell/[email protected]", "", {}, "sha512-bRISgCIjP20/tbWSPWMEi54QVPRZExkuD9lJL+UIxUKtwVJA8wW1Trb1jMs1RFXo1CBTNZ/5hpC9QvmKWdopKw=="],
"@jest/reporters/@jridgewell/trace-mapping/@jridgewell/sourcemap-codec": ["@jridgewell/[email protected]", "", {}, "sha512-eF2rxCRulEKXHTRiDrDy6erMYWqNw4LPdQ8UQA4huuxaQsVeRPFl2oM8oDGxMFhJUWZf9McpLtJasDDZb/Bpeg=="],
diff --git a/frontend/src/metabase/querying/common/components/DatePicker/DatePicker.stories.tsx b/frontend/src/metabase/querying/common/components/DatePicker/DatePicker.stories.tsx
index 8eb59bcf530..038856dfc14 100644
--- a/frontend/src/metabase/querying/common/components/DatePicker/DatePicker.stories.tsx
+++ b/frontend/src/metabase/querying/common/components/DatePicker/DatePicker.stories.tsx
@@ -1,5 +1,4 @@
import type { Store } from "@reduxjs/toolkit";
-import FakeTimers from "@sinonjs/fake-timers";
import type { Meta, StoryFn } from "@storybook/react";
import { userEvent, within } from "@storybook/test";
import { merge } from "icepick";
@@ -39,20 +38,24 @@ export default {
decorators: [ReduxDecorator],
} as Meta<typeof DatePicker>;
-let clock: FakeTimers.InstalledClock | undefined;
+const MOCKED_NOW = new Date("2025-01-01T00:00:00.000Z").getTime();
+const OriginalDate = Date;
+
+const MockedDate: DateConstructor = new Proxy(OriginalDate, {
+ construct: (target, args: unknown[]) =>
+ Reflect.construct(target, args.length ? args : [MOCKED_NOW]),
+ get: (target, property, receiver) =>
+ property === "now"
+ ? () => MOCKED_NOW
+ : Reflect.get(target, property, receiver),
+});
+
function WithMockDate(StoryFn: StoryFn) {
- if (!clock) {
- clock = FakeTimers.install({
- toFake: ["Date"],
- // Happy new year 2025! 🥳
- now: new Date("2025-01-01T00:00:00.000Z"),
- });
- }
+ window.Date = MockedDate;
useEffect(() => {
return () => {
- clock?.uninstall();
- clock = undefined;
+ window.Date = OriginalDate;
};
}, []);
diff --git a/package.json b/package.json
index 780f7ff7914..2fd446afe92 100644
--- a/package.json
+++ b/package.json
@@ -196,7 +196,6 @@
"@rspack/core": "^2.0.3",
"@rspack/dev-server": "^2.0.1",
"@rspack/plugin-react-refresh": "^2.0.0",
- "@sinonjs/fake-timers": "^9.1.2",
"@stardazed/streams-text-encoding": "^1.0.2",
"@storybook/addon-a11y": "^8.5.0",
"@storybook/addon-actions": "^8.5.0",
@@ -253,7 +252,6 @@
"@types/react-virtualized": "^9.22.2",
"@types/redux-actions": "^2.6.5",
"@types/semver": "^7.7.1",
- "@types/sinonjs__fake-timers": "^15.0.1",
"@types/underscore": "^1.13.0",
"@vitejs/plugin-react": "^6.0.2",
"ajv": "^8.5.0",