Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

GDGT-3188 Remove unintended elevation styles (#81958)

Stas Gavrylov3c07580bcc1a
diff --git a/frontend/src/metabase/ui/components/buttons/ActionIcon/ActionIcon.module.css b/frontend/src/metabase/ui/components/buttons/ActionIcon/ActionIcon.module.css
index d11e7ce941f..19877cda0bc 100644
--- a/frontend/src/metabase/ui/components/buttons/ActionIcon/ActionIcon.module.css
+++ b/frontend/src/metabase/ui/components/buttons/ActionIcon/ActionIcon.module.css
@@ -82,7 +82,3 @@
}
}
}
-
-.root[data-variant="filled"] {
- box-shadow: var(--mantine-shadow-xs);
-}
diff --git a/frontend/src/metabase/ui/components/buttons/Button/Button.module.css b/frontend/src/metabase/ui/components/buttons/Button/Button.module.css
index fe59c89a107..5f0e10e0872 100644
--- a/frontend/src/metabase/ui/components/buttons/Button/Button.module.css
+++ b/frontend/src/metabase/ui/components/buttons/Button/Button.module.css
@@ -165,11 +165,6 @@
}
}
-.root[data-variant="default"],
-.root[data-variant="filled"] {
- box-shadow: var(--mantine-shadow-xs);
-}
-
.label {
height: auto;
display: inline-block;
diff --git a/frontend/src/metabase/ui/components/feedback/Alert/Alert.module.css b/frontend/src/metabase/ui/components/feedback/Alert/Alert.module.css
index 27e63bcdcdc..316b97202f9 100644
--- a/frontend/src/metabase/ui/components/feedback/Alert/Alert.module.css
+++ b/frontend/src/metabase/ui/components/feedback/Alert/Alert.module.css
@@ -6,7 +6,6 @@
var(--mantine-spacing-xl) var(--mantine-spacing-xl);
border-radius: 12px;
overflow: hidden;
- box-shadow: var(--mantine-shadow-xs);
}
.wrapper {
@@ -89,6 +88,10 @@
}
}
+.root[data-variant="default"][data-color="default"] {
+ box-shadow: var(--mantine-shadow-xs);
+}
+
.root[data-variant="default"],
.root[data-variant="light"]:not([data-color="default"]),
[data-mantine-color-scheme="dark"] .root {
diff --git a/frontend/src/metabase/ui/components/inputs/SegmentedControl/SegmentedControl.module.css b/frontend/src/metabase/ui/components/inputs/SegmentedControl/SegmentedControl.module.css
index 9aae7c25475..67b5e0fb9c9 100644
--- a/frontend/src/metabase/ui/components/inputs/SegmentedControl/SegmentedControl.module.css
+++ b/frontend/src/metabase/ui/components/inputs/SegmentedControl/SegmentedControl.module.css
@@ -1,6 +1,5 @@
.SegmentedControl {
background-color: var(--sc-background-color);
- box-shadow: var(--mantine-shadow-xs_outline);
}
.SegmentedControlLabel {
diff --git a/frontend/src/metabase/ui/theme.unit.spec.ts b/frontend/src/metabase/ui/theme.unit.spec.ts
index c8ef77b353d..df5f9bd5f78 100644
--- a/frontend/src/metabase/ui/theme.unit.spec.ts
+++ b/frontend/src/metabase/ui/theme.unit.spec.ts
@@ -203,25 +203,11 @@ describe("theme scales", () => {
}
const expectedCssElevations = [
- {
- componentName: "ActionIcon",
- slot: "root",
- file: "frontend/src/metabase/ui/components/buttons/ActionIcon/ActionIcon.module.css",
- selector: '.root[data-variant="filled"]',
- shadow: "xs",
- },
- {
- componentName: "Button",
- slot: "root",
- file: "frontend/src/metabase/ui/components/buttons/Button/Button.module.css",
- selector: '.root[data-variant="filled"]',
- shadow: "xs",
- },
{
componentName: "Alert",
slot: "root",
file: "frontend/src/metabase/ui/components/feedback/Alert/Alert.module.css",
- selector: ".root",
+ selector: '.root[data-variant="default"][data-color="default"]',
shadow: "xs",
},
{
@@ -259,13 +245,6 @@ describe("theme scales", () => {
selector: ".card",
shadow: "xs",
},
- {
- componentName: "SegmentedControl",
- slot: "root",
- file: "frontend/src/metabase/ui/components/inputs/SegmentedControl/SegmentedControl.module.css",
- selector: ".SegmentedControl",
- shadow: "xs_outline",
- },
{
componentName: "Switch",
slot: "thumb",