The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Revert "only publish Github release for major and gold releases" (#80220)
Chris Vandoodewaard3c70c4753829
diff --git a/release/src/release-notes.ts b/release/src/release-notes.tsindex 66db1927ba8..b8e1ad3ff2f 100644--- a/release/src/release-notes.ts+++ b/release/src/release-notes.ts@@ -258,14 +258,6 @@ export async function publishRelease({if (!isValidVersionString(version)) {throw new Error(`Invalid version string: ${version}`);}-- const minorVersion = getMinorVersion(version);- if (Number(minorVersion) > 1) {- // just print a warning since this shouldn't fail the workflow calling this function- console.warn("Skipping Github release as these are only published for major or gold releases (ex. v0.58.0 or v0.58.1).");- return;- }-const payload = {owner,repo,diff --git a/release/src/release-notes.unit.spec.ts b/release/src/release-notes.unit.spec.tsindex 33f9604ae89..e9197d7eacc 100644--- a/release/src/release-notes.unit.spec.ts+++ b/release/src/release-notes.unit.spec.ts@@ -1,5 +1,3 @@-import type { Octokit } from "@octokit/rest";-import {categorizeIssues,generateReleaseNotes,@@ -7,7 +5,6 @@ import {getReleaseTitle,getWebsiteChangelog,markdownIssueLinks,- publishRelease,} from "./release-notes";import {githubReleaseTemplate,@@ -512,78 +509,6 @@ describe("Release Notes", () => {});});- describe("publishRelease", () => {- const buildGithub = () => ({- rest: {- repos: {- createRelease: jest.fn().mockResolvedValue({ data: {} }),- },- },- });-- const publish = (version: string, github: ReturnType<typeof buildGithub>) =>- publishRelease({- version,- owner: "metabase",- repo: "metabase",- // publishRelease only reaches rest.repos.createRelease, so the stub- // above is the whole surface it uses; a full Octokit is unnecessary.- github: github as unknown as Octokit,- });-- it("should create a draft release for a major release", async () => {- const github = buildGithub();-- await publish("v0.58.0-beta", github);-- expect(github.rest.repos.createRelease).toHaveBeenCalledWith(- expect.objectContaining({- owner: "metabase",- repo: "metabase",- tag_name: "v0.58.0-beta",- name: "Metabase 58.0-beta",- draft: true,- prerelease: true,- }),- );- });-- it("should create a draft release for a gold release", async () => {- const github = buildGithub();-- await publish("v1.58.1", github);-- expect(github.rest.repos.createRelease).toHaveBeenCalledWith(- expect.objectContaining({- tag_name: "v0.58.1",- name: "Metabase 58.1",- draft: true,- }),- );- });-- it.each(["v0.58.2", "v1.57.16", "v0.62.20"])(- "should skip %s since it is neither a major nor a gold release",- async (version) => {- const github = buildGithub();-- await expect(publish(version, github)).resolves.toBeUndefined();-- expect(github.rest.repos.createRelease).not.toHaveBeenCalled();- },- );-- it("should still reject an invalid version string that reaches the release step", async () => {- const github = buildGithub();-- await expect(publish("v2.58.0", github)).rejects.toThrow(- "Invalid version string: v2.58.0",- );-- expect(github.rest.repos.createRelease).not.toHaveBeenCalled();- });- });-it.each([["v0.53.2", "53#metabase-532"],["v1.53.0", "53#metabase-530"],