Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Move dev instances upsell down on embedding settings pages (#64099)

Jakub Chodorowicz3e646a69f3e1
diff --git a/enterprise/frontend/src/metabase-enterprise/embedding/components/InteractiveEmbeddingSettings.tsx b/enterprise/frontend/src/metabase-enterprise/embedding/components/InteractiveEmbeddingSettings.tsx
index eb5caf5c25e..c3ead455ec2 100644
--- a/enterprise/frontend/src/metabase-enterprise/embedding/components/InteractiveEmbeddingSettings.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/embedding/components/InteractiveEmbeddingSettings.tsx
@@ -37,7 +37,6 @@ export function InteractiveEmbeddingSettings() {
return (
<SettingsPageWrapper title={t`Interactive embedding`}>
- <UpsellDevInstances location="embedding-page" />
<SettingsSection>
<EmbeddingToggle
settingKey="enable-embedding-interactive"
@@ -68,6 +67,8 @@ export function InteractiveEmbeddingSettings() {
<RelatedSettingsSection
items={getInteractiveEmbeddingRelatedSettingItems()}
/>
+
+ <UpsellDevInstances location="embedding-page" />
</SettingsPageWrapper>
);
}
diff --git a/frontend/src/metabase/admin/settings/components/EmbeddingSettings/EmbeddingSdkSettings/EmbeddingSdkSettings.tsx b/frontend/src/metabase/admin/settings/components/EmbeddingSettings/EmbeddingSdkSettings/EmbeddingSdkSettings.tsx
index 023a91ef940..6ffdd79d32b 100644
--- a/frontend/src/metabase/admin/settings/components/EmbeddingSettings/EmbeddingSdkSettings/EmbeddingSdkSettings.tsx
+++ b/frontend/src/metabase/admin/settings/components/EmbeddingSettings/EmbeddingSdkSettings/EmbeddingSdkSettings.tsx
@@ -139,8 +139,6 @@ export function EmbeddingSdkSettings() {
return (
<SettingsPageWrapper title={t`Modular embedding`}>
- <UpsellDevInstances location="embedding-page" />
-
<SdkSettingsCard
title={t`Embedded Analytics JS`}
description={t`An easy-to-use library that lets you embed Metabase entities like charts, dashboards, or even the query builder into your own application using customizable components.`}
@@ -268,6 +266,8 @@ export function EmbeddingSdkSettings() {
<RelatedSettingsSection
items={getModularEmbeddingRelatedSettingItems()}
/>
+
+ <UpsellDevInstances location="embedding-page" />
</SettingsPageWrapper>
);
}
diff --git a/frontend/src/metabase/admin/settings/components/EmbeddingSettings/StaticEmbeddingSettings.tsx b/frontend/src/metabase/admin/settings/components/EmbeddingSettings/StaticEmbeddingSettings.tsx
index fdade89637c..b023a10e64a 100644
--- a/frontend/src/metabase/admin/settings/components/EmbeddingSettings/StaticEmbeddingSettings.tsx
+++ b/frontend/src/metabase/admin/settings/components/EmbeddingSettings/StaticEmbeddingSettings.tsx
@@ -24,7 +24,6 @@ export function StaticEmbeddingSettings() {
return (
<SettingsPageWrapper title={t`Static embedding`}>
- <UpsellDevInstances location="embedding-page" />
<SettingsSection>
<EmbeddingToggle
settingKey="enable-embedding-static"
@@ -42,6 +41,7 @@ export function StaticEmbeddingSettings() {
<PLUGIN_CONTENT_TRANSLATION.ContentTranslationConfiguration />
<RelatedSettingsSection items={getStaticEmbeddingRelatedSettingItems()} />
+ <UpsellDevInstances location="embedding-page" />
</SettingsPageWrapper>
);
}