The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Added new `strong-enough` password type (#75104)
Benoit Vinay3eb882a625a0
diff --git a/docs/configuring-metabase/environment-variables.md b/docs/configuring-metabase/environment-variables.mdindex 2dd814e02a2..f5b7f253a41 100644--- a/docs/configuring-metabase/environment-variables.md+++ b/docs/configuring-metabase/environment-variables.md@@ -2782,7 +2782,7 @@ Comma-separated namespaces to trace. **WARNING:** Could log sensitive informatio### `MB_PASSWORD_COMPLEXITY`-Type: string (`"weak"`, `"normal"`, `"strong"`)<br>+Type: string (`"weak"`, `"normal"`, `"strong"`, `"strong-enough"`)<br>Default: `"normal"`Enforce a password complexity rule to increase security for regular logins. This only applies to new users or users that are changing their password. Related [MB_PASSWORD_LENGTH](#mb_password_length)@@ -2790,6 +2790,7 @@ Enforce a password complexity rule to increase security for regular logins. This- `weak` no character constraints- `normal` at least 1 digit- `strong` minimum 8 characters w/ 2 lowercase, 2 uppercase, 1 digit, and 1 special character+- `strong-enough` minimum 15 characters### `MB_PASSWORD_LENGTH`diff --git a/docs/people-and-groups/changing-password-complexity.md b/docs/people-and-groups/changing-password-complexity.mdindex 7895ac98edf..5f785a27092 100644--- a/docs/people-and-groups/changing-password-complexity.md+++ b/docs/people-and-groups/changing-password-complexity.md@@ -20,6 +20,7 @@ The settings above can be used independently, so it's fine to use only one or th- `weak` = no character constraints- `normal` = at least 1 digit- `strong` = minimum 8 characters w/ 2 lowercase, 2 uppercase, 1 digit, and 1 special character+- `strong-enough` = minimum 15 charactersBy default, Metabase also prevents users from setting passwords that are in a list of common passwords (like `qwerty123` and`passw0rd`). Changing the complexity requirement to `weak` disables this behavior.diff --git a/src/metabase/cmd/resources/other-env-vars.md b/src/metabase/cmd/resources/other-env-vars.mdindex 264bf2e4a21..277510696db 100644--- a/src/metabase/cmd/resources/other-env-vars.md+++ b/src/metabase/cmd/resources/other-env-vars.md@@ -452,7 +452,7 @@ Comma-separated namespaces to trace. **WARNING:** Could log sensitive informatio### `MB_PASSWORD_COMPLEXITY`-Type: string (`"weak"`, `"normal"`, `"strong"`)<br>+Type: string (`"weak"`, `"normal"`, `"strong"`, `"strong-enough"`)<br>Default: `"normal"`Enforce a password complexity rule to increase security for regular logins. This only applies to new users or users that are changing their password. Related [MB_PASSWORD_LENGTH](#mb_password_length)@@ -460,6 +460,7 @@ Enforce a password complexity rule to increase security for regular logins. This- `weak` no character constraints- `normal` at least 1 digit- `strong` minimum 8 characters w/ 2 lowercase, 2 uppercase, 1 digit, and 1 special character+- `strong-enough` minimum 15 characters### `MB_PASSWORD_LENGTH`diff --git a/src/metabase/util/password.clj b/src/metabase/util/password.cljindex 7c27987ca8a..2c4dfc965e3 100644--- a/src/metabase/util/password.clj+++ b/src/metabase/util/password.clj@@ -27,14 +27,15 @@(def ^:private ^:const complexity->char-type->min"Minimum counts of each class of character a password should have for a given password complexity level."- {:weak {:total 6} ; total here effectively means the same thing as a minimum password length- :normal {:total 6- :digit 1}- :strong {:total 8- :lower 2- :upper 2- :digit 1- :special 1}})+ {:weak {:total 6} ; total here effectively means the same thing as a minimum password length+ :normal {:total 6+ :digit 1}+ :strong {:total 8+ :lower 2+ :upper 2+ :digit 1+ :special 1}+ :strong-enough {:total 15}})(defn- password-has-char-counts?"Check that PASSWORD satisfies the minimum count requirements for each character class.diff --git a/test/metabase/util/password_test.clj b/test/metabase/util/password_test.cljindex a9319fcb11e..879c69247b0 100644--- a/test/metabase/util/password_test.clj+++ b/test/metabase/util/password_test.clj@@ -1,6 +1,8 @@(ns metabase.util.password-test(:require[clojure.test :refer :all]+ [environ.core :as env]+ [metabase.config.core :as config][metabase.test :as mt][metabase.test.fixtures :as fixtures][metabase.util.password :as u.password]))@@ -69,6 +71,11 @@(is (= expected(u.password/is-valid? input)))))))+(deftest default-password-complexity-config-test+ (testing "When MB_PASSWORD_COMPLEXITY is unset, default is :normal"+ (with-redefs [env/env (dissoc env/env :mb-password-complexity)]+ (is (= :normal (config/config-kw :mb-password-complexity))))))+(deftest is-valid?-weak-test(testing "Do some tests with password complexity requirements set to :weak.Common password list should not be checked."@@ -81,6 +88,19 @@(is (= expected(u.password/is-valid? input))))))))+(deftest is-valid?-strong-enough-test+ (testing "Do some tests with password complexity requirements set to :strong-enough."+ (mt/with-temp-env-var-value! [:mb-password-complexity "strong-enough"]+ (doseq [[input expected] {"ABC" false+ "ABCDEFGHIJKLM" false+ "abcdefghijklmno" true+ "123456789012345" true+ "unc0mmonpw12345" true+ "123456789987654321" false}]+ (testing (pr-str (list 'is-valid? input))+ (is (= expected+ (u.password/is-valid? input))))))))+(deftest passsword-length-test(testing "Password length can be set by the env variable MB_PASSWORD_LENGTH"(mt/with-temp-env-var-value! [:mb-password-length 3