Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Test for mongo multi column aggregation on joined models (#81079)

Riley Thompson3ecdab5ea77e
diff --git a/modules/drivers/mongo/test/metabase/driver/mongo/query_processor_test.clj b/modules/drivers/mongo/test/metabase/driver/mongo/query_processor_test.clj
index e81efee3efc..de567c08ff8 100644
--- a/modules/drivers/mongo/test/metabase/driver/mongo/query_processor_test.clj
+++ b/modules/drivers/mongo/test/metabase/driver/mongo/query_processor_test.clj
@@ -13,6 +13,7 @@
[metabase.lib.schema.mbql-clause :as lib.schema.mbql-clause]
[metabase.lib.test-metadata :as meta]
[metabase.lib.test-util :as lib.tu]
+ [metabase.lib.test-util.notebook-helpers :as lib.tu.notebook]
[metabase.query-processor.alternative-date-test :as qp.alternative-date-test]
[metabase.query-processor.compile :as qp.compile]
[metabase.query-processor.date-time-zone-functions-test :as qp.datetime-test]
@@ -871,3 +872,36 @@
;; match the entire `BsonXxx` wrapper-class family, not just a hand-picked subset.
(is (not (re-find #"Bson[A-Z]\w*"
(pr-str (:query compiled)))))))))))
+
+(deftest ^:parallel multi-column-aggregation-on-join-models-test
+ (mt/test-driver :mongo
+ (testing "Aggregating with multiple columns after joining two models works correctly (#70459)"
+ (let [mp (mt/metadata-provider)
+ venues-query (lib/query mp (lib.metadata/table mp (mt/id :venues)))
+ categories-query (lib/query mp (lib.metadata/table mp (mt/id :categories)))]
+ (mt/with-temp [:model/Card venues-model {:name "Venues Model"
+ :type :model
+ :dataset_query venues-query}
+ :model/Card categories-model {:name "Categories Model"
+ :type :model
+ :dataset_query categories-query}]
+ (let [venues-card (lib.metadata/card mp (:id venues-model))
+ categories-card (lib.metadata/card mp (:id categories-model))
+ query (as-> (lib/query mp venues-card) q
+ (lib/join q (lib/join-clause
+ categories-card
+ [(lib/= (lib.tu.notebook/find-col-with-spec
+ q (lib/join-condition-lhs-columns q categories-card nil nil)
+ {:is-main-group true} "Category ID")
+ (lib.tu.notebook/find-col-with-spec
+ q (lib/join-condition-rhs-columns q categories-card nil nil)
+ "Categories Model" "ID"))]))
+ (lib.tu.notebook/add-breakout q "Categories Model" "Categories Model - Category → Name")
+ (lib.tu.notebook/add-breakout q "Venues Model" "Price")
+ (lib/aggregate q (lib/count))
+ (lib.tu.notebook/add-order-by q "Categories Model" "Categories Model - Category → Name")
+ (lib/limit q 3))]
+ (is (= [["American" 2 4]
+ ["American" 3 4]
+ ["Artisan" 2 2]]
+ (mt/rows (qp/process-query query))))))))))