The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Move dashboard-only components into dashboard (#72595)
Fraser3f89706bb775
diff --git a/frontend/src/metabase/metabot/components/AIDashboardAnalysisSidebar/AIDashboardAnalysisSidebar.tsx b/frontend/src/metabase/dashboard/components/AIDashboardAnalysisSidebar/AIDashboardAnalysisSidebar.tsxsimilarity index 76%rename from frontend/src/metabase/metabot/components/AIDashboardAnalysisSidebar/AIDashboardAnalysisSidebar.tsxrename to frontend/src/metabase/dashboard/components/AIDashboardAnalysisSidebar/AIDashboardAnalysisSidebar.tsxindex 1457a9e8747..4863f15f82b 100644--- a/frontend/src/metabase/metabot/components/AIDashboardAnalysisSidebar/AIDashboardAnalysisSidebar.tsx+++ b/frontend/src/metabase/dashboard/components/AIDashboardAnalysisSidebar/AIDashboardAnalysisSidebar.tsx@@ -1,12 +1,12 @@import { t } from "ttag";import { Sidebar } from "metabase/common/components/Sidebar";-import { useDashboardContext } from "metabase/dashboard/context";-import { getIsDashCardsLoadingComplete } from "metabase/dashboard/selectors";+import { AIAnalysisContentWrapper } from "metabase/metabot/components/AIAnalysisContentWrapper/AIAnalysisContentWrapper";+import { useDashCardAnalysis } from "metabase/metabot/hooks/useDashCardAnalysis";import { useSelector } from "metabase/utils/redux";-import { useDashCardAnalysis } from "../../hooks/useDashCardAnalysis";-import { AIAnalysisContentWrapper } from "../AIAnalysisContentWrapper/AIAnalysisContentWrapper";+import { useDashboardContext } from "../../context";+import { getIsDashCardsLoadingComplete } from "../../selectors";export function AIDashboardAnalysisSidebar() {const { sidebar, closeSidebar } = useDashboardContext();diff --git a/frontend/src/metabase/metabot/components/AIDashboardAnalysisSidebar/AIDashboardAnalysisSidebar.unit.spec.tsx b/frontend/src/metabase/dashboard/components/AIDashboardAnalysisSidebar/AIDashboardAnalysisSidebar.unit.spec.tsxsimilarity index 100%rename from frontend/src/metabase/metabot/components/AIDashboardAnalysisSidebar/AIDashboardAnalysisSidebar.unit.spec.tsxrename to frontend/src/metabase/dashboard/components/AIDashboardAnalysisSidebar/AIDashboardAnalysisSidebar.unit.spec.tsxdiff --git a/frontend/src/metabase/dashboard/components/AddFilterParameterMenu/AddFilterParameterMenu.tsx b/frontend/src/metabase/dashboard/components/AddFilterParameterMenu/AddFilterParameterMenu.tsxindex 7736d7d902f..70f185f9d09 100644--- a/frontend/src/metabase/dashboard/components/AddFilterParameterMenu/AddFilterParameterMenu.tsx+++ b/frontend/src/metabase/dashboard/components/AddFilterParameterMenu/AddFilterParameterMenu.tsx@@ -1,14 +1,15 @@import { type ReactNode, useLayoutEffect, useRef, useState } from "react";import { t } from "ttag";+import type { NewParameterOpts } from "metabase/parameters/utils/dashboards";+import { getParameterIconName } from "metabase/parameters/utils/ui";+import { Icon, Menu, type MenuProps, Text } from "metabase/ui";+import {type ParameterSection,getDashboardParameterSections,getDefaultOptionForParameterSectionMap,-} from "metabase/parameters/utils/dashboard-options";-import type { NewParameterOpts } from "metabase/parameters/utils/dashboards";-import { getParameterIconName } from "metabase/parameters/utils/ui";-import { Icon, Menu, type MenuProps, Text } from "metabase/ui";+} from "../../utils/dashboard-options";interface AddFilterParameterMenuProps extends MenuProps {children: ReactNode; // trigger contentdiff --git a/frontend/src/metabase/dashboard/components/Dashboard/Dashboard.tsx b/frontend/src/metabase/dashboard/components/Dashboard/Dashboard.tsxindex 7a47c08d06d..42ea8f04fa8 100644--- a/frontend/src/metabase/dashboard/components/Dashboard/Dashboard.tsx+++ b/frontend/src/metabase/dashboard/components/Dashboard/Dashboard.tsx@@ -3,7 +3,6 @@ import { useMemo } from "react";import { t } from "ttag";import { PLUGIN_NOTIFICATIONS_SDK } from "embedding-sdk-bundle/components/public/notifications";-import { DashboardArchivedEntityBanner } from "metabase/archive/components/ArchivedEntityBanner/DashboardArchivedEntityBanner";import DashboardS from "metabase/css/dashboard.module.css";import { DashboardHeader } from "metabase/dashboard/components/DashboardHeader";import { useDashboardContext } from "metabase/dashboard/context";@@ -17,6 +16,7 @@ import { useSelector } from "metabase/utils/redux";import type { DashboardCard } from "metabase-types/api";import { DASHBOARD_PDF_EXPORT_ROOT_ID } from "../../constants";+import { DashboardArchivedEntityBanner } from "../DashboardArchivedEntityBanner";import {DashboardInfoButton,ExportAsPdfButton,diff --git a/frontend/src/metabase/archive/components/ArchivedEntityBanner/DashboardArchivedEntityBanner.tsx b/frontend/src/metabase/dashboard/components/DashboardArchivedEntityBanner.tsxsimilarity index 88%rename from frontend/src/metabase/archive/components/ArchivedEntityBanner/DashboardArchivedEntityBanner.tsxrename to frontend/src/metabase/dashboard/components/DashboardArchivedEntityBanner.tsxindex ee4560aaa67..30398c5f3e0 100644--- a/frontend/src/metabase/archive/components/ArchivedEntityBanner/DashboardArchivedEntityBanner.tsx+++ b/frontend/src/metabase/dashboard/components/DashboardArchivedEntityBanner.tsx@@ -1,9 +1,9 @@-import { useDashboardContext } from "metabase/dashboard/context";+import { ArchivedEntityBanner } from "metabase/archive/components/ArchivedEntityBanner/ArchivedEntityBanner";import { Bookmarks } from "metabase/entities/bookmarks";import { Dashboards } from "metabase/entities/dashboards";import { useDispatch } from "metabase/utils/redux";-import { ArchivedEntityBanner } from "./ArchivedEntityBanner";+import { useDashboardContext } from "../context";export const DashboardArchivedEntityBanner = () => {const {diff --git a/frontend/src/metabase/dashboard/components/DashboardSidebars.tsx b/frontend/src/metabase/dashboard/components/DashboardSidebars.tsxindex 1346e7a2e56..f54905b4610 100644--- a/frontend/src/metabase/dashboard/components/DashboardSidebars.tsx+++ b/frontend/src/metabase/dashboard/components/DashboardSidebars.tsx@@ -1,14 +1,14 @@import { SIDEBAR_NAME } from "metabase/dashboard/constants";import { useDashboardContext } from "metabase/dashboard/context";-import { AIDashboardAnalysisSidebar } from "metabase/metabot/components/AIDashboardAnalysisSidebar/AIDashboardAnalysisSidebar";-import DashboardSubscriptionsSidebar from "metabase/notifications/DashboardSubscriptionsSidebar";-import { ParameterSidebar } from "metabase/parameters/components/ParameterSidebar";+import { AIDashboardAnalysisSidebar } from "./AIDashboardAnalysisSidebar/AIDashboardAnalysisSidebar";import { ActionSidebar } from "./ActionSidebar";import { AddCardSidebar } from "./AddCardSidebar";import { ClickBehaviorSidebar } from "./ClickBehaviorSidebar/ClickBehaviorSidebar";import { DashboardInfoSidebar } from "./DashboardInfoSidebar";import { DashboardSettingsSidebar } from "./DashboardSettingsSidebar";+import DashboardSubscriptionsSidebar from "./DashboardSubscriptionsSidebar";+import { ParameterSidebar } from "./ParameterSidebar";export function DashboardSidebars() {const { isFullscreen, sidebar } = useDashboardContext();diff --git a/frontend/src/metabase/notifications/AddEditSidebar/AddEditEmailSidebar.tsx b/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/AddEditSidebar/AddEditEmailSidebar.tsxsimilarity index 100%rename from frontend/src/metabase/notifications/AddEditSidebar/AddEditEmailSidebar.tsxrename to frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/AddEditSidebar/AddEditEmailSidebar.tsxdiff --git a/frontend/src/metabase/notifications/AddEditSidebar/AddEditSidebar.tsx b/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/AddEditSidebar/AddEditSidebar.tsxsimilarity index 87%rename from frontend/src/metabase/notifications/AddEditSidebar/AddEditSidebar.tsxrename to frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/AddEditSidebar/AddEditSidebar.tsxindex 4233ddc4f2b..0531f27c862 100644--- a/frontend/src/metabase/notifications/AddEditSidebar/AddEditSidebar.tsx+++ b/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/AddEditSidebar/AddEditSidebar.tsx@@ -1,10 +1,8 @@-import {- getParameters,- getTabHiddenParameterSlugs,-} from "metabase/dashboard/selectors";import type { State } from "metabase/redux/store";import { connect } from "metabase/utils/redux";+import { getParameters, getTabHiddenParameterSlugs } from "../../../selectors";+import { AddEditEmailSidebar as AddEditEmailSidebarComponent } from "./AddEditEmailSidebar";import { AddEditSlackSidebar as AddEditSlackSidebarComponent } from "./AddEditSlackSidebar";diff --git a/frontend/src/metabase/notifications/AddEditSidebar/AddEditSlackSidebar.tsx b/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/AddEditSidebar/AddEditSlackSidebar.tsxsimilarity index 100%rename from frontend/src/metabase/notifications/AddEditSidebar/AddEditSlackSidebar.tsxrename to frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/AddEditSidebar/AddEditSlackSidebar.tsxdiff --git a/frontend/src/metabase/notifications/AddEditSidebar/CaveatMessage/CaveatMessage.module.css b/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/AddEditSidebar/CaveatMessage/CaveatMessage.module.csssimilarity index 100%rename from frontend/src/metabase/notifications/AddEditSidebar/CaveatMessage/CaveatMessage.module.cssrename to frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/AddEditSidebar/CaveatMessage/CaveatMessage.module.cssdiff --git a/frontend/src/metabase/notifications/AddEditSidebar/CaveatMessage/CaveatMessage.tsx b/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/AddEditSidebar/CaveatMessage/CaveatMessage.tsxsimilarity index 100%rename from frontend/src/metabase/notifications/AddEditSidebar/CaveatMessage/CaveatMessage.tsxrename to frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/AddEditSidebar/CaveatMessage/CaveatMessage.tsxdiff --git a/frontend/src/metabase/notifications/AddEditSidebar/CaveatMessage/index.ts b/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/AddEditSidebar/CaveatMessage/index.tssimilarity index 100%rename from frontend/src/metabase/notifications/AddEditSidebar/CaveatMessage/index.tsrename to frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/AddEditSidebar/CaveatMessage/index.tsdiff --git a/frontend/src/metabase/notifications/AddEditSidebar/CaveatMessage/tests/common.unit.spec.ts b/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/AddEditSidebar/CaveatMessage/tests/common.unit.spec.tssimilarity index 100%rename from frontend/src/metabase/notifications/AddEditSidebar/CaveatMessage/tests/common.unit.spec.tsrename to frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/AddEditSidebar/CaveatMessage/tests/common.unit.spec.tsdiff --git a/frontend/src/metabase/notifications/AddEditSidebar/CaveatMessage/tests/enterprise.unit.spec.ts b/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/AddEditSidebar/CaveatMessage/tests/enterprise.unit.spec.tssimilarity index 100%rename from frontend/src/metabase/notifications/AddEditSidebar/CaveatMessage/tests/enterprise.unit.spec.tsrename to frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/AddEditSidebar/CaveatMessage/tests/enterprise.unit.spec.tsdiff --git a/frontend/src/metabase/notifications/AddEditSidebar/CaveatMessage/tests/premium.unit.spec.ts b/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/AddEditSidebar/CaveatMessage/tests/premium.unit.spec.tssimilarity index 100%rename from frontend/src/metabase/notifications/AddEditSidebar/CaveatMessage/tests/premium.unit.spec.tsrename to frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/AddEditSidebar/CaveatMessage/tests/premium.unit.spec.tsdiff --git a/frontend/src/metabase/notifications/AddEditSidebar/CaveatMessage/tests/setup.tsx b/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/AddEditSidebar/CaveatMessage/tests/setup.tsxsimilarity index 100%rename from frontend/src/metabase/notifications/AddEditSidebar/CaveatMessage/tests/setup.tsxrename to frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/AddEditSidebar/CaveatMessage/tests/setup.tsxdiff --git a/frontend/src/metabase/notifications/AddEditSidebar/DefaultParametersSection.tsx b/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/AddEditSidebar/DefaultParametersSection.tsxsimilarity index 100%rename from frontend/src/metabase/notifications/AddEditSidebar/DefaultParametersSection.tsxrename to frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/AddEditSidebar/DefaultParametersSection.tsxdiff --git a/frontend/src/metabase/notifications/AddEditSidebar/DefaultParametersSection.unit.spec.jsx b/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/AddEditSidebar/DefaultParametersSection.unit.spec.jsxsimilarity index 100%rename from frontend/src/metabase/notifications/AddEditSidebar/DefaultParametersSection.unit.spec.jsxrename to frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/AddEditSidebar/DefaultParametersSection.unit.spec.jsxdiff --git a/frontend/src/metabase/notifications/AddEditSidebar/DeleteSubscriptionAction.tsx b/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/AddEditSidebar/DeleteSubscriptionAction.tsxsimilarity index 100%rename from frontend/src/metabase/notifications/AddEditSidebar/DeleteSubscriptionAction.tsxrename to frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/AddEditSidebar/DeleteSubscriptionAction.tsxdiff --git a/frontend/src/metabase/notifications/AddEditSidebar/constants.ts b/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/AddEditSidebar/constants.tssimilarity index 100%rename from frontend/src/metabase/notifications/AddEditSidebar/constants.tsrename to frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/AddEditSidebar/constants.tsdiff --git a/frontend/src/metabase/notifications/DashboardSubscriptionsSidebar/DashboardSubscriptionsSidebar.tsx b/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/DashboardSubscriptionsSidebar.tsxsimilarity index 98%rename from frontend/src/metabase/notifications/DashboardSubscriptionsSidebar/DashboardSubscriptionsSidebar.tsxrename to frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/DashboardSubscriptionsSidebar.tsxindex 09303a41127..3cab6494c65 100644--- a/frontend/src/metabase/notifications/DashboardSubscriptionsSidebar/DashboardSubscriptionsSidebar.tsx+++ b/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/DashboardSubscriptionsSidebar.tsx@@ -4,15 +4,8 @@ import _ from "underscore";import { LoadingAndErrorWrapper } from "metabase/common/components/LoadingAndErrorWrapper";import type { ScheduleChangeProp } from "metabase/common/components/SchedulePicker";import { Sidebar } from "metabase/common/components/Sidebar";-import { useDashboardContext } from "metabase/dashboard/context";import { isEmbeddingSdk } from "metabase/embedding-sdk/config";import { Pulses } from "metabase/entities/pulses";-import {- AddEditEmailSidebar,- AddEditSlackSidebar,-} from "metabase/notifications/AddEditSidebar/AddEditSidebar";-import { NewPulseSidebar } from "metabase/notifications/NewPulseSidebar";-import { PulsesListSidebar } from "metabase/notifications/PulsesListSidebar";import {cancelEditingPulse,fetchPulseFormInput,@@ -47,6 +40,14 @@ import type {User,} from "metabase-types/api";+import { useDashboardContext } from "../../context";++import {+ AddEditEmailSidebar,+ AddEditSlackSidebar,+} from "./AddEditSidebar/AddEditSidebar";+import { NewPulseSidebar } from "./NewPulseSidebar";+import { PulsesListSidebar } from "./PulsesListSidebar";import { getSupportedCardsForSubscriptions } from "./get-supported-cards-for-subscriptions";const EDITING_MODES = {diff --git a/frontend/src/metabase/notifications/NewPulseSidebar.tsx b/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/NewPulseSidebar.tsxsimilarity index 100%rename from frontend/src/metabase/notifications/NewPulseSidebar.tsxrename to frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/NewPulseSidebar.tsxdiff --git a/frontend/src/metabase/notifications/PulsesListSidebar.styled.tsx b/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/PulsesListSidebar.styled.tsxsimilarity index 100%rename from frontend/src/metabase/notifications/PulsesListSidebar.styled.tsxrename to frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/PulsesListSidebar.styled.tsxdiff --git a/frontend/src/metabase/notifications/PulsesListSidebar.tsx b/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/PulsesListSidebar.tsxsimilarity index 99%rename from frontend/src/metabase/notifications/PulsesListSidebar.tsxrename to frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/PulsesListSidebar.tsxindex b380e3e3e75..80862ec8245 100644--- a/frontend/src/metabase/notifications/PulsesListSidebar.tsx+++ b/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/PulsesListSidebar.tsx@@ -6,7 +6,6 @@ import { Sidebar } from "metabase/common/components/Sidebar";import { Label } from "metabase/common/components/type/Label";import { Subhead } from "metabase/common/components/type/Subhead";import CS from "metabase/css/core/index.css";-import { getParameters } from "metabase/dashboard/selectors";import { formatDateValue } from "metabase/parameters/utils/date-formatting";import type { State } from "metabase/redux/store";import { Button, Icon, Tooltip } from "metabase/ui";@@ -26,6 +25,8 @@ import type {DashboardSubscription,} from "metabase-types/api";+import { getParameters } from "../../selectors";+import { PulseCard, SidebarActions } from "./PulsesListSidebar.styled";type PulsesListSidebarOwnProps = {diff --git a/frontend/src/metabase/notifications/DashboardSubscriptionsSidebar/get-supported-cards-for-subscriptions.tsx b/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/get-supported-cards-for-subscriptions.tsxsimilarity index 100%rename from frontend/src/metabase/notifications/DashboardSubscriptionsSidebar/get-supported-cards-for-subscriptions.tsxrename to frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/get-supported-cards-for-subscriptions.tsxdiff --git a/frontend/src/metabase/notifications/DashboardSubscriptionsSidebar/get-supported-cards-for-subscriptions.unit.spec.ts b/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/get-supported-cards-for-subscriptions.unit.spec.tssimilarity index 100%rename from frontend/src/metabase/notifications/DashboardSubscriptionsSidebar/get-supported-cards-for-subscriptions.unit.spec.tsrename to frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/get-supported-cards-for-subscriptions.unit.spec.tsdiff --git a/frontend/src/metabase/notifications/DashboardSubscriptionsSidebar/index.tsx b/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/index.tsxsimilarity index 100%rename from frontend/src/metabase/notifications/DashboardSubscriptionsSidebar/index.tsxrename to frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/index.tsxdiff --git a/frontend/src/metabase/notifications/DashboardSubscriptionsSidebar/tests/common.unit.spec.ts b/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/tests/common.unit.spec.tssimilarity index 100%rename from frontend/src/metabase/notifications/DashboardSubscriptionsSidebar/tests/common.unit.spec.tsrename to frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/tests/common.unit.spec.tsdiff --git a/frontend/src/metabase/notifications/DashboardSubscriptionsSidebar/tests/enterprise.unit.spec.ts b/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/tests/enterprise.unit.spec.tssimilarity index 100%rename from frontend/src/metabase/notifications/DashboardSubscriptionsSidebar/tests/enterprise.unit.spec.tsrename to frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/tests/enterprise.unit.spec.tsdiff --git a/frontend/src/metabase/notifications/DashboardSubscriptionsSidebar/tests/premium.unit.spec.ts b/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/tests/premium.unit.spec.tssimilarity index 100%rename from frontend/src/metabase/notifications/DashboardSubscriptionsSidebar/tests/premium.unit.spec.tsrename to frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/tests/premium.unit.spec.tsdiff --git a/frontend/src/metabase/notifications/DashboardSubscriptionsSidebar/tests/setup.tsx b/frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/tests/setup.tsxsimilarity index 100%rename from frontend/src/metabase/notifications/DashboardSubscriptionsSidebar/tests/setup.tsxrename to frontend/src/metabase/dashboard/components/DashboardSubscriptionsSidebar/tests/setup.tsxdiff --git a/frontend/src/metabase/parameters/components/ParameterLinkedFilters/ParameterLinkedFilters.module.css b/frontend/src/metabase/dashboard/components/ParameterLinkedFilters/ParameterLinkedFilters.module.csssimilarity index 100%rename from frontend/src/metabase/parameters/components/ParameterLinkedFilters/ParameterLinkedFilters.module.cssrename to frontend/src/metabase/dashboard/components/ParameterLinkedFilters/ParameterLinkedFilters.module.cssdiff --git a/frontend/src/metabase/parameters/components/ParameterLinkedFilters/ParameterLinkedFilters.tsx b/frontend/src/metabase/dashboard/components/ParameterLinkedFilters/ParameterLinkedFilters.tsxsimilarity index 99%rename from frontend/src/metabase/parameters/components/ParameterLinkedFilters/ParameterLinkedFilters.tsxrename to frontend/src/metabase/dashboard/components/ParameterLinkedFilters/ParameterLinkedFilters.tsxindex d95733ec9a6..9bcf8347662 100644--- a/frontend/src/metabase/parameters/components/ParameterLinkedFilters/ParameterLinkedFilters.tsx+++ b/frontend/src/metabase/dashboard/components/ParameterLinkedFilters/ParameterLinkedFilters.tsx@@ -9,6 +9,7 @@ import {import { ExternalLink } from "metabase/common/components/ExternalLink";import { LoadingAndErrorWrapper } from "metabase/common/components/LoadingAndErrorWrapper";import { useDocsUrl, useLearnUrl } from "metabase/common/hooks";+import { usableAsLinkedFilter } from "metabase/parameters/utils/linked-filters";import { showAddParameterPopover } from "metabase/redux/dashboard";import {Box,@@ -26,8 +27,6 @@ import { useDispatch } from "metabase/utils/redux";import type { UiParameter } from "metabase-lib/v1/parameters/types";import type { FieldId, ParameterId } from "metabase-types/api";-import { usableAsLinkedFilter } from "../../utils/linked-filters";-import S from "./ParameterLinkedFilters.module.css";import type { ParameterInfo } from "./types";import { getFilterFieldsRequest, getParametersInfo } from "./utils";diff --git a/frontend/src/metabase/parameters/components/ParameterLinkedFilters/ParameterLinkedFilters.unit.spec.tsx b/frontend/src/metabase/dashboard/components/ParameterLinkedFilters/ParameterLinkedFilters.unit.spec.tsxsimilarity index 100%rename from frontend/src/metabase/parameters/components/ParameterLinkedFilters/ParameterLinkedFilters.unit.spec.tsxrename to frontend/src/metabase/dashboard/components/ParameterLinkedFilters/ParameterLinkedFilters.unit.spec.tsxdiff --git a/frontend/src/metabase/parameters/components/ParameterLinkedFilters/index.ts b/frontend/src/metabase/dashboard/components/ParameterLinkedFilters/index.tssimilarity index 100%rename from frontend/src/metabase/parameters/components/ParameterLinkedFilters/index.tsrename to frontend/src/metabase/dashboard/components/ParameterLinkedFilters/index.tsdiff --git a/frontend/src/metabase/parameters/components/ParameterLinkedFilters/types.ts b/frontend/src/metabase/dashboard/components/ParameterLinkedFilters/types.tssimilarity index 100%rename from frontend/src/metabase/parameters/components/ParameterLinkedFilters/types.tsrename to frontend/src/metabase/dashboard/components/ParameterLinkedFilters/types.tsdiff --git a/frontend/src/metabase/parameters/components/ParameterLinkedFilters/utils.ts b/frontend/src/metabase/dashboard/components/ParameterLinkedFilters/utils.tssimilarity index 100%rename from frontend/src/metabase/parameters/components/ParameterLinkedFilters/utils.tsrename to frontend/src/metabase/dashboard/components/ParameterLinkedFilters/utils.tsdiff --git a/frontend/src/metabase/parameters/components/ParameterLinkedFilters/utils.unit.spec.ts b/frontend/src/metabase/dashboard/components/ParameterLinkedFilters/utils.unit.spec.tssimilarity index 100%rename from frontend/src/metabase/parameters/components/ParameterLinkedFilters/utils.unit.spec.tsrename to frontend/src/metabase/dashboard/components/ParameterLinkedFilters/utils.unit.spec.tsdiff --git a/frontend/src/metabase/parameters/components/ParameterSettings/MoveParameterMenu/MoveParameterMenu.module.css b/frontend/src/metabase/dashboard/components/ParameterSettings/MoveParameterMenu/MoveParameterMenu.module.csssimilarity index 100%rename from frontend/src/metabase/parameters/components/ParameterSettings/MoveParameterMenu/MoveParameterMenu.module.cssrename to frontend/src/metabase/dashboard/components/ParameterSettings/MoveParameterMenu/MoveParameterMenu.module.cssdiff --git a/frontend/src/metabase/parameters/components/ParameterSettings/MoveParameterMenu/MoveParameterMenu.tsx b/frontend/src/metabase/dashboard/components/ParameterSettings/MoveParameterMenu/MoveParameterMenu.tsxsimilarity index 96%rename from frontend/src/metabase/parameters/components/ParameterSettings/MoveParameterMenu/MoveParameterMenu.tsxrename to frontend/src/metabase/dashboard/components/ParameterSettings/MoveParameterMenu/MoveParameterMenu.tsxindex a1591b1aed7..af0a22d818a 100644--- a/frontend/src/metabase/parameters/components/ParameterSettings/MoveParameterMenu/MoveParameterMenu.tsx+++ b/frontend/src/metabase/dashboard/components/ParameterSettings/MoveParameterMenu/MoveParameterMenu.tsx@@ -4,18 +4,19 @@ import { t } from "ttag";import _ from "underscore";import CS from "metabase/css/core/index.css";-import { moveParameter } from "metabase/dashboard/actions";-import { getCurrentDashcards, getTabs } from "metabase/dashboard/selectors";-import {- findDashCardForInlineParameter,- isHeadingDashCard,-} from "metabase/dashboard/utils";import { Flex, Group, Icon, type IconName, Select, Text } from "metabase/ui";import { isQuestionDashCard } from "metabase/utils/dashboard";import { useDispatch, useSelector } from "metabase/utils/redux";import visualizations from "metabase/visualizations";import type { BaseDashboardCard, ParameterId } from "metabase-types/api";+import { moveParameter } from "../../../actions";+import { getCurrentDashcards, getTabs } from "../../../selectors";+import {+ findDashCardForInlineParameter,+ isHeadingDashCard,+} from "../../../utils";+import S from "./MoveParameterMenu.module.css";type MoveParameterMenuProps = {diff --git a/frontend/src/metabase/parameters/components/ParameterSettings/MoveParameterMenu/MoveParameterMenu.unit.spec.tsx b/frontend/src/metabase/dashboard/components/ParameterSettings/MoveParameterMenu/MoveParameterMenu.unit.spec.tsxsimilarity index 100%rename from frontend/src/metabase/parameters/components/ParameterSettings/MoveParameterMenu/MoveParameterMenu.unit.spec.tsxrename to frontend/src/metabase/dashboard/components/ParameterSettings/MoveParameterMenu/MoveParameterMenu.unit.spec.tsxdiff --git a/frontend/src/metabase/parameters/components/ParameterSettings/MoveParameterMenu/index.ts b/frontend/src/metabase/dashboard/components/ParameterSettings/MoveParameterMenu/index.tssimilarity index 100%rename from frontend/src/metabase/parameters/components/ParameterSettings/MoveParameterMenu/index.tsrename to frontend/src/metabase/dashboard/components/ParameterSettings/MoveParameterMenu/index.tsdiff --git a/frontend/src/metabase/parameters/components/ParameterSettings/ParameterSettings.module.css b/frontend/src/metabase/dashboard/components/ParameterSettings/ParameterSettings.module.csssimilarity index 100%rename from frontend/src/metabase/parameters/components/ParameterSettings/ParameterSettings.module.cssrename to frontend/src/metabase/dashboard/components/ParameterSettings/ParameterSettings.module.cssdiff --git a/frontend/src/metabase/parameters/components/ParameterSettings/ParameterSettings.tsx b/frontend/src/metabase/dashboard/components/ParameterSettings/ParameterSettings.tsxsimilarity index 94%rename from frontend/src/metabase/parameters/components/ParameterSettings/ParameterSettings.tsxrename to frontend/src/metabase/dashboard/components/ParameterSettings/ParameterSettings.tsxindex 1427eb57b02..bacfc0997aa 100644--- a/frontend/src/metabase/parameters/components/ParameterSettings/ParameterSettings.tsx+++ b/frontend/src/metabase/dashboard/components/ParameterSettings/ParameterSettings.tsx@@ -7,11 +7,11 @@ import {} from "react";import { t } from "ttag";-import { resetParameterMapping } from "metabase/dashboard/actions";-import {- getDashboardParameterSections,- getDefaultOptionForParameterSectionMap,-} from "metabase/parameters/utils/dashboard-options";+import { ParameterValueWidget } from "metabase/parameters/components/ParameterValueWidget";+import { RequiredParamToggle } from "metabase/parameters/components/RequiredParamToggle";+import { TemporalUnitSettings } from "metabase/parameters/components/TemporalUnitSettings";+import { ValuesSourceSettings } from "metabase/parameters/components/ValuesSourceSettings";+import { isSingleOrMultiSelectable } from "metabase/parameters/utils/parameter-type";import type { EmbeddingParameterVisibility } from "metabase/public/lib/types";import {Box,@@ -41,14 +41,14 @@ import type {ValuesSourceType,} from "metabase-types/api";-import { isSingleOrMultiSelectable } from "../../utils/parameter-type";-import { ParameterValueWidget } from "../ParameterValueWidget";-import { RequiredParamToggle } from "../RequiredParamToggle";-import { ValuesSourceSettings } from "../ValuesSourceSettings";+import { resetParameterMapping } from "../../actions";+import {+ getDashboardParameterSections,+ getDefaultOptionForParameterSectionMap,+} from "../../utils/dashboard-options";import { MoveParameterMenu } from "./MoveParameterMenu";import S from "./ParameterSettings.module.css";-import { TemporalUnitSettings } from "./TemporalUnitSettings";export interface ParameterSettingsProps {parameter: Parameter;diff --git a/frontend/src/metabase/parameters/components/ParameterSettings/ParameterSettings.unit.spec.tsx b/frontend/src/metabase/dashboard/components/ParameterSettings/ParameterSettings.unit.spec.tsxsimilarity index 100%rename from frontend/src/metabase/parameters/components/ParameterSettings/ParameterSettings.unit.spec.tsxrename to frontend/src/metabase/dashboard/components/ParameterSettings/ParameterSettings.unit.spec.tsxdiff --git a/frontend/src/metabase/parameters/components/ParameterSettings/index.ts b/frontend/src/metabase/dashboard/components/ParameterSettings/index.tssimilarity index 100%rename from frontend/src/metabase/parameters/components/ParameterSettings/index.tsrename to frontend/src/metabase/dashboard/components/ParameterSettings/index.tsdiff --git a/frontend/src/metabase/parameters/components/ParameterSidebar/ParameterSidebar.tsx b/frontend/src/metabase/dashboard/components/ParameterSidebar/ParameterSidebar.tsxsimilarity index 97%rename from frontend/src/metabase/parameters/components/ParameterSidebar/ParameterSidebar.tsxrename to frontend/src/metabase/dashboard/components/ParameterSidebar/ParameterSidebar.tsxindex 87ab2e21ea6..b567ed5268d 100644--- a/frontend/src/metabase/parameters/components/ParameterSidebar/ParameterSidebar.tsx+++ b/frontend/src/metabase/dashboard/components/ParameterSidebar/ParameterSidebar.tsx@@ -3,12 +3,8 @@ import { usePrevious } from "react-use";import { t } from "ttag";import { Sidebar } from "metabase/common/components/Sidebar";-import { useDashboardContext } from "metabase/dashboard/context";-import {- getEditingParameterInlineDashcard,- getEmbeddedParameterVisibility,-} from "metabase/dashboard/selectors";import { hasMapping } from "metabase/parameters/utils/dashboards";+import { canUseLinkedFilters } from "metabase/parameters/utils/linked-filters";import type { IconName } from "metabase/ui";import { Tabs } from "metabase/ui";import { slugify } from "metabase/utils/formatting";@@ -24,7 +20,11 @@ import type {ValuesSourceType,} from "metabase-types/api";-import { canUseLinkedFilters } from "../../utils/linked-filters";+import { useDashboardContext } from "../../context";+import {+ getEditingParameterInlineDashcard,+ getEmbeddedParameterVisibility,+} from "../../selectors";import { ParameterLinkedFilters } from "../ParameterLinkedFilters";import { ParameterSettings } from "../ParameterSettings";diff --git a/frontend/src/metabase/parameters/components/ParameterSidebar/ParameterSidebar.unit.spec.tsx b/frontend/src/metabase/dashboard/components/ParameterSidebar/ParameterSidebar.unit.spec.tsxsimilarity index 100%rename from frontend/src/metabase/parameters/components/ParameterSidebar/ParameterSidebar.unit.spec.tsxrename to frontend/src/metabase/dashboard/components/ParameterSidebar/ParameterSidebar.unit.spec.tsxdiff --git a/frontend/src/metabase/parameters/components/ParameterSidebar/index.ts b/frontend/src/metabase/dashboard/components/ParameterSidebar/index.tssimilarity index 100%rename from frontend/src/metabase/parameters/components/ParameterSidebar/index.tsrename to frontend/src/metabase/dashboard/components/ParameterSidebar/index.tsdiff --git a/frontend/src/metabase/parameters/utils/dashboard-options.ts b/frontend/src/metabase/dashboard/utils/dashboard-options.tssimilarity index 100%rename from frontend/src/metabase/parameters/utils/dashboard-options.tsrename to frontend/src/metabase/dashboard/utils/dashboard-options.tsdiff --git a/frontend/src/metabase/parameters/utils/dashboard-options.unit.spec.tsx b/frontend/src/metabase/dashboard/utils/dashboard-options.unit.spec.tsxsimilarity index 100%rename from frontend/src/metabase/parameters/utils/dashboard-options.unit.spec.tsxrename to frontend/src/metabase/dashboard/utils/dashboard-options.unit.spec.tsxdiff --git a/frontend/src/metabase/parameters/components/ParameterSettings/TemporalUnitSettings/TemporalUnitSettings.module.css b/frontend/src/metabase/parameters/components/TemporalUnitSettings/TemporalUnitSettings.module.csssimilarity index 100%rename from frontend/src/metabase/parameters/components/ParameterSettings/TemporalUnitSettings/TemporalUnitSettings.module.cssrename to frontend/src/metabase/parameters/components/TemporalUnitSettings/TemporalUnitSettings.module.cssdiff --git a/frontend/src/metabase/parameters/components/ParameterSettings/TemporalUnitSettings/TemporalUnitSettings.tsx b/frontend/src/metabase/parameters/components/TemporalUnitSettings/TemporalUnitSettings.tsxsimilarity index 100%rename from frontend/src/metabase/parameters/components/ParameterSettings/TemporalUnitSettings/TemporalUnitSettings.tsxrename to frontend/src/metabase/parameters/components/TemporalUnitSettings/TemporalUnitSettings.tsxdiff --git a/frontend/src/metabase/parameters/components/ParameterSettings/TemporalUnitSettings/TemporalUnitSettings.unit.spec.tsx b/frontend/src/metabase/parameters/components/TemporalUnitSettings/TemporalUnitSettings.unit.spec.tsxsimilarity index 100%rename from frontend/src/metabase/parameters/components/ParameterSettings/TemporalUnitSettings/TemporalUnitSettings.unit.spec.tsxrename to frontend/src/metabase/parameters/components/TemporalUnitSettings/TemporalUnitSettings.unit.spec.tsxdiff --git a/frontend/src/metabase/parameters/components/ParameterSettings/TemporalUnitSettings/index.ts b/frontend/src/metabase/parameters/components/TemporalUnitSettings/index.tssimilarity index 100%rename from frontend/src/metabase/parameters/components/ParameterSettings/TemporalUnitSettings/index.tsrename to frontend/src/metabase/parameters/components/TemporalUnitSettings/index.tsdiff --git a/frontend/src/metabase/public/containers/PublicOrEmbeddedDashboard/PublicOrEmbeddedDashboard.tsx b/frontend/src/metabase/public/containers/PublicOrEmbeddedDashboard/PublicOrEmbeddedDashboard.tsxdeleted file mode 100644index c78f309a336..00000000000--- a/frontend/src/metabase/public/containers/PublicOrEmbeddedDashboard/PublicOrEmbeddedDashboard.tsx+++ /dev/null@@ -1,59 +0,0 @@-import { PublicOrEmbeddedDashCardMenu } from "metabase/dashboard/components/DashCard/PublicOrEmbeddedDashCardMenu";-import { DASHBOARD_DISPLAY_ACTIONS } from "metabase/dashboard/components/DashboardHeader/DashboardHeaderButtonRow/constants";-import { DASHBOARD_ACTION } from "metabase/dashboard/components/DashboardHeader/DashboardHeaderButtonRow/dashboard-action-keys";-import {- type DashboardContextProps,- DashboardContextProvider,-} from "metabase/dashboard/context";-import type { EmbeddingAdditionalHashOptions } from "metabase/public/lib/types";-import { isActionDashCard, isQuestionCard } from "metabase/utils/dashboard";--import { PublicOrEmbeddedDashboardView } from "./PublicOrEmbeddedDashboardView";--export type PublicOrEmbeddedDashboardProps = Pick<- DashboardContextProps,- | "dashboardId"- | "background"- | "bordered"- | "titled"- | "theme"- | "hideParameters"- | "downloadsEnabled"- | "parameterQueryParams"- | "onLoad"- | "onLoadWithoutCards"- | "cardTitled"- | "withFooter"- | "onError"- | "getClickActionMode"- | "navigateToNewCardFromDashboard"- | "dashcardMenu"-> &- Pick<EmbeddingAdditionalHashOptions, "locale">;--export const PublicOrEmbeddedDashboard = ({- locale,- ...contextProps-}: PublicOrEmbeddedDashboardProps) => (- <DashboardContextProvider- {...contextProps}- isDashcardVisible={(dashcard) => !isActionDashCard(dashcard)}- dashcardMenu={- contextProps.dashcardMenu ??- (({ dashcard, result }) =>- contextProps.downloadsEnabled?.results &&- isQuestionCard(dashcard.card) &&- !!result?.data &&- !result?.error && (- <PublicOrEmbeddedDashCardMenu result={result} dashcard={dashcard} />- ))- }- dashboardActions={({ downloadsEnabled }) =>- downloadsEnabled.pdf- ? [...DASHBOARD_DISPLAY_ACTIONS, DASHBOARD_ACTION.DOWNLOAD_PDF]- : DASHBOARD_DISPLAY_ACTIONS- }- >- <PublicOrEmbeddedDashboardView />- </DashboardContextProvider>-);diff --git a/frontend/src/metabase/query_builder/components/template_tags/TagEditorParam.tsx b/frontend/src/metabase/query_builder/components/template_tags/TagEditorParam.tsxindex 346abf773b3..90668e9d0c3 100644--- a/frontend/src/metabase/query_builder/components/template_tags/TagEditorParam.tsx+++ b/frontend/src/metabase/query_builder/components/template_tags/TagEditorParam.tsx@@ -2,7 +2,7 @@ import { Component } from "react";import { t } from "ttag";import _ from "underscore";-import { TemporalUnitSettings } from "metabase/parameters/components/ParameterSettings/TemporalUnitSettings";+import { TemporalUnitSettings } from "metabase/parameters/components/TemporalUnitSettings";import { ValuesSourceSettings } from "metabase/parameters/components/ValuesSourceSettings";import { isSingleOrMultiSelectable } from "metabase/parameters/utils/parameter-type";import type { EmbeddingParameterVisibility } from "metabase/public/lib/types";