Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Delete `minimal-tests` workflow (#80029)

Nemanja Glumac3fdbcf9ac687
diff --git a/.github/workflows/minimal-tests.yml b/.github/workflows/minimal-tests.yml
deleted file mode 100644
index 95aa87d0cf6..00000000000
--- a/.github/workflows/minimal-tests.yml
+++ /dev/null
@@ -1,226 +0,0 @@
-name: Minimal Tests
-
-on:
- pull_request:
- types: [opened, synchronize, reopened, labeled]
-
-concurrency:
- group: ${{ github.workflow }}-${{ github.head_ref && github.ref || github.run_id }}
- cancel-in-progress: true
-
-permissions:
- contents: read
- checks: write
- actions: read
-
-jobs:
- # Only run if the PR has the minimal-tests label
- check-label:
- runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
- timeout-minutes: 1
- outputs:
- should-run: ${{ steps.check.outputs.result }}
- steps:
- - name: Check for minimal-tests label
- id: check
- run: |
- if [[ "${{ contains(github.event.pull_request.labels.*.name, 'minimal-tests') }}" == "true" ]]; then
- echo "result=true" >> "$GITHUB_OUTPUT"
- else
- echo "result=false" >> "$GITHUB_OUTPUT"
- fi
-
- # Postgres app-db tests - single version, single job
- postgres-app-db-test:
- needs: check-label
- if: needs.check-label.outputs.should-run == 'true'
- runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
- timeout-minutes: 40
- env:
- CI: "true"
- DRIVERS: postgres
- MB_DB_TYPE: postgres
- MB_DB_PORT: 5432
- MB_DB_HOST: localhost
- MB_DB_DBNAME: mb_test
- MB_DB_USER: mb_test
- MB_POSTGRESQL_TEST_USER: mb_test
- services:
- postgres:
- image: postgres:latest
- ports:
- - "5432:5432"
- env:
- POSTGRES_USER: mb_test
- POSTGRES_DB: mb_test
- POSTGRES_HOST_AUTH_METHOD: trust
- name: Postgres Latest EE App DB Tests (Part 1)
- steps:
- - uses: actions/checkout@v6
- - name: Test Postgres App DB
- id: test-driver
- uses: ./.github/actions/test-driver
- with:
- build-static-viz: true
- junit-name: "minimal-be-tests-postgres-ee"
- quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
- test-args: >-
- :only '["test" "enterprise/backend/test"]'
- :exclude-tags '[:mb/driver-tests :mb/transforms-python-test]'
- :partition/total 2
- :partition/index 0
-
- # Postgres driver tests
- postgres-driver-test:
- needs: check-label
- if: needs.check-label.outputs.should-run == 'true'
- runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
- timeout-minutes: 40
- env:
- CI: "true"
- DRIVERS: postgres
- MB_DB_TYPE: postgres
- MB_DB_PORT: 5432
- MB_DB_HOST: localhost
- MB_DB_DBNAME: mb_test
- MB_DB_USER: mb_test
- MB_POSTGRESQL_TEST_USER: mb_test
- services:
- postgres:
- image: postgres:latest
- ports:
- - "5432:5432"
- env:
- POSTGRES_USER: mb_test
- POSTGRES_DB: mb_test
- POSTGRES_HOST_AUTH_METHOD: trust
- name: Postgres Latest Driver Tests
- steps:
- - uses: actions/checkout@v6
- - name: Test Postgres Driver
- id: test-driver
- uses: ./.github/actions/test-driver
- with:
- junit-name: "minimal-be-tests-postgres-driver-ee"
- quarantine-engine: ${{ vars.QUARANTINE_ENGINE }}
- test-args: >-
- :only-tags [:mb/driver-tests]
- :exclude-tags [:mb/transforms-python-test]
-
- # Frontend unit tests
- frontend-unit-tests:
- needs: check-label
- if: needs.check-label.outputs.should-run == 'true'
- runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
- timeout-minutes: 30
- env:
- JEST_JUNIT_OUTPUT_DIR: ./target/junit
- JEST_JUNIT_OUTPUT_NAME: test-report-frontend-unit.xml
- name: Frontend Unit Tests
- steps:
- - uses: actions/checkout@v6
- - name: Prepare front-end environment
- uses: ./.github/actions/prepare-frontend
- - name: Prepare back-end environment
- uses: ./.github/actions/prepare-backend
- - name: Resolve current job id
- # Resolve JOB_ID before the long test step so the ci-conductor reporter
- # below can link failures to this exact job. Best-effort.
- uses: ./.github/actions/resolve-job-id
- - name: Run frontend unit tests
- id: run-tests
- run: bun run test-unit --silent
- # Keep this step continue-on-error because the quarantine logic controls whether it ultimately fails.
- continue-on-error: true
- - name: Report failed tests to ci-conductor
- if: ${{ !cancelled() && steps.run-tests.outcome == 'failure' }}
- # This step should NEVER fail the job!
- continue-on-error: true
- uses: ./.github/actions/report-failures-to-ci-conductor
- with:
- test-suite: fe-tests-unit
- adapter: frontend
- - name: Quarantine gate
- if: ${{ !cancelled() && steps.run-tests.outcome == 'failure' }}
- continue-on-error: ${{ vars.QUARANTINE_ENGINE != 'ci-conductor' }}
- timeout-minutes: 3
- uses: ./.github/actions/quarantine-gate
- with:
- adapter: frontend
- test-suite: fe-tests-unit
- enforce-quarantine: ${{ vars.QUARANTINE_ENGINE == 'ci-conductor' }}
-
- # Summary job
- minimal-tests-result:
- needs:
- - postgres-app-db-test
- - postgres-driver-test
- - frontend-unit-tests
- runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
- timeout-minutes: 5
- name: minimal-tests-result
- if: always() && !cancelled()
- steps:
- - name: Check job status
- uses: actions/github-script@v9
- env:
- needs: ${{ toJson(needs) }}
- with:
- script: | # js
- const needs = JSON.parse(process.env.needs);
-
- const jobs = Object.entries(needs).map(
- ([jobName, jobValues]) => ({
- name: jobName,
- result: jobValues.result
- }));
-
- // Check if all jobs either succeeded or were skipped
- // Skipped jobs are acceptable (they were intentionally skipped when the label is absent)
- const allPassedOrSkipped = jobs.every(job =>
- job.result === 'success' || job.result === 'skipped'
- );
-
- // Check if any jobs actually failed (not skipped, not cancelled)
- const anyFailed = jobs.some(job =>
- job.result === 'failure'
- );
-
- if (allPassedOrSkipped && !anyFailed) {
- console.log("");
- console.log(" _------. ");
- console.log(" / , \_ ");
- console.log(" / / /{}\ |o\_ ");
- console.log(" / \ `--' /-' \ ");
- console.log(" | \ \ | ");
- console.log(" | |`-, | ");
- console.log(" / /__/)/ ");
- console.log(" | | ");
- console.log("");
- console.log("All minimal tests have passed. Fast feedback achieved!");
- process.exit(0);
- }
-
- // otherwise, something failed
- console.log("");
- console.log(" .::::::::::. .::::::::::. ");
- console.log(" .::::''''''::::. .::::''''''::::. ");
- console.log(" .:::' `::::.... ....::::' `:::. ");
- console.log(" .::' `:::::::| |:::::::' `::. ");
- console.log(" .::| |::::::|_ ___ __|::::::| |::. ");
- console.log(" `--' |::::::|_()__()_|::::::| `--' ");
- console.log(" ::: |::-o::| |::o-::| ::: ");
- console.log(" `::. .|::::::| |::::::|. .::' ");
- console.log(" `:::. .::\-----' `-----/::. .:::' ");
- console.log(" `::::......::::' `::::......::::' ");
- console.log(" `::::::::::' `::::::::::' ");
- console.log("");
- console.log("Minimal tests have failed.");
-
- jobs.forEach((job) => {
- if (job.result !== 'success' && job.result !== 'skipped') {
- console.log(`${job.name} - ${job.result}`);
- }
- });
-
- process.exit(1);
diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml
index 2ff9731f8cd..6cbb199cf4e 100644
--- a/.github/workflows/run-tests.yml
+++ b/.github/workflows/run-tests.yml
@@ -20,7 +20,7 @@ permissions:
jobs:
create-test-plan:
- if: ${{ !contains(github.event.pull_request.labels.*.name,'ci skip') && !contains(github.event.pull_request.labels.*.name,'minimal-tests') }}
+ if: ${{ !contains(github.event.pull_request.labels.*.name,'ci skip') }}
name: Create test plan
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 5
@@ -121,7 +121,7 @@ jobs:
static-viz-files-changed:
name: Check whether static-viz files changed
- if: ${{ !contains(github.event.pull_request.labels.*.name,'ci skip') && !contains(github.event.pull_request.labels.*.name,'minimal-tests') }}
+ if: ${{ !contains(github.event.pull_request.labels.*.name,'ci skip') }}
runs-on: ${{ vars.DEFAULT_RUNNER_KEY }}
timeout-minutes: 10
outputs: