The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
GHY-3804 require superuser for remote-sync current-task endpoints (#75276)
Eric Normand40af443aaac2
diff --git a/enterprise/backend/src/metabase_enterprise/remote_sync/api.clj b/enterprise/backend/src/metabase_enterprise/remote_sync/api.cljindex 538a30e4720..6292b620e67 100644--- a/enterprise/backend/src/metabase_enterprise/remote_sync/api.clj+++ b/enterprise/backend/src/metabase_enterprise/remote_sync/api.clj@@ -131,12 +131,14 @@(api.macros/defendpoint :get "/current-task" :- [:maybe remote-sync.schema/SyncTask]"Get the current sync task"[]+ (api/check-superuser)(when-let [task (remote-sync.task/most-recent-task)](t2/hydrate task :status)))(api.macros/defendpoint :post "/current-task/cancel" :- remote-sync.schema/SyncTask"Cancels the current task if one is running"[]+ (api/check-superuser)(let [task (remote-sync.task/most-recent-task)](api/check-400 (and (some? task) (remote-sync.task/running? task)) "No active task to cancel")(remote-sync.task/cancel-sync-task! (:id task))diff --git a/enterprise/backend/test/metabase_enterprise/remote_sync/api_test.clj b/enterprise/backend/test/metabase_enterprise/remote_sync/api_test.cljindex 067b412013c..853274882e9 100644--- a/enterprise/backend/test/metabase_enterprise/remote_sync/api_test.clj+++ b/enterprise/backend/test/metabase_enterprise/remote_sync/api_test.clj@@ -391,6 +391,11 @@;;; ------------------------------------------------- Current Task Endpoint -------------------------------------------------+(deftest current-task-requires-superuser-test+ (testing "GET /api/ee/remote-sync/current-task requires superuser permissions (GHY-3804)"+ (is (= "You don't have permissions to do that."+ (mt/user-http-request :rasta :get 403 "ee/remote-sync/current-task")))))+(deftest current-task-returns-nil-when-no-tasks-test(testing "GET /api/ee/remote-sync/current-task returns nil when there are no tasks"(is (nil? (mt/user-http-request :crowberto :get 204 "ee/remote-sync/current-task")))))@@ -437,6 +442,16 @@;;; ------------------------------------------------- Cancel Task Endpoint -------------------------------------------------+(deftest cancel-task-requires-superuser-test+ (testing "POST /api/ee/remote-sync/current-task/cancel requires superuser permissions (GHY-3804)"+ (mt/with-temp [:model/RemoteSyncTask {id :id} {:sync_task_type "export"+ :last_progress_report_at :%now+ :started_at :%now}]+ (is (= "You don't have permissions to do that."+ (mt/user-http-request :rasta :post 403 "ee/remote-sync/current-task/cancel")))+ (testing "task is not cancelled by the non-superuser request"+ (is (not (remote-sync.task/cancelled? (t2/select-one :model/RemoteSyncTask :id id))))))))+(deftest cancel-task-errors-when-no-tasks-test(testing "POST /api/ee/remote-sync/current-task/cancel errors when there are no tasks"(is (= "No active task to cancel"