Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Add "New question" button to audit-view analytics pages (#83942)

Sébastien41cd466c1845
diff --git a/enterprise/frontend/src/metabase-enterprise/monitor/ai-auditing/cli-analytics/components/CliAnalyticsSectionLayout.tsx b/enterprise/frontend/src/metabase-enterprise/monitor/ai-auditing/cli-analytics/components/CliAnalyticsSectionLayout.tsx
index 47e68320709..7dec7492a16 100644
--- a/enterprise/frontend/src/metabase-enterprise/monitor/ai-auditing/cli-analytics/components/CliAnalyticsSectionLayout.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/monitor/ai-auditing/cli-analytics/components/CliAnalyticsSectionLayout.tsx
@@ -14,6 +14,7 @@ import {
import { useCliHasData } from "metabase-enterprise/monitor/ai-auditing/cli-analytics/hooks/useCliHasData";
import { cliUrlStateConfig } from "metabase-enterprise/monitor/ai-auditing/cli-analytics/url-state";
import { AiAnalyticsSectionLayout } from "metabase-enterprise/monitor/ai-auditing/components/AiAnalyticsSectionLayout";
+import { NewQuestionButton } from "metabase-enterprise/monitor/ai-auditing/components/NewQuestionButton";
import {
ConversationFilters as CliCallsFilter,
useFilterOptions,
@@ -125,6 +126,7 @@ export function CliAnalyticsSectionLayout() {
return (
<AiAnalyticsSectionLayout
title={t`CLI analytics`}
+ filtersAction={<NewQuestionButton viewName={VIEW_AGENT_API_CALLS} />}
tabs={tabs}
filters={
<CliCallsFilter
diff --git a/enterprise/frontend/src/metabase-enterprise/monitor/ai-auditing/components/AiAnalyticsSectionLayout/AiAnalyticsSectionLayout.tsx b/enterprise/frontend/src/metabase-enterprise/monitor/ai-auditing/components/AiAnalyticsSectionLayout/AiAnalyticsSectionLayout.tsx
index db62cf0f7f9..1166c219aff 100644
--- a/enterprise/frontend/src/metabase-enterprise/monitor/ai-auditing/components/AiAnalyticsSectionLayout/AiAnalyticsSectionLayout.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/monitor/ai-auditing/components/AiAnalyticsSectionLayout/AiAnalyticsSectionLayout.tsx
@@ -18,6 +18,7 @@ type AiAnalyticsSectionLayoutProps = {
isTableRoute: boolean;
showEmpty: boolean;
tabs: PillTab[];
+ filtersAction?: ReactNode;
title: string;
};
@@ -30,12 +31,16 @@ export function AiAnalyticsSectionLayout({
isTableRoute,
showEmpty,
tabs,
+ filtersAction,
title,
}: AiAnalyticsSectionLayoutProps) {
const sectionContent = (
<>
<PillTabNavigation tabs={tabs} />
- {filters}
+ <Flex justify="space-between" align="center" gap="md">
+ {filters}
+ {filtersAction}
+ </Flex>
<RouteContent
emptyState={emptyState}
error={error}
diff --git a/enterprise/frontend/src/metabase-enterprise/monitor/ai-auditing/components/NewQuestionButton/NewQuestionButton.tsx b/enterprise/frontend/src/metabase-enterprise/monitor/ai-auditing/components/NewQuestionButton/NewQuestionButton.tsx
new file mode 100644
index 00000000000..1ceba9297c7
--- /dev/null
+++ b/enterprise/frontend/src/metabase-enterprise/monitor/ai-auditing/components/NewQuestionButton/NewQuestionButton.tsx
@@ -0,0 +1,42 @@
+import { useMemo } from "react";
+import { t } from "ttag";
+
+import { ForwardRefLink } from "metabase/common/components/Link";
+import { Button, Icon } from "metabase/ui";
+import * as Urls from "metabase/urls";
+import { useAuditTable } from "metabase-enterprise/monitor/ai-auditing/metabot-analytics/hooks/useAuditTable";
+import * as Lib from "metabase-lib";
+
+type NewQuestionButtonProps = {
+ viewName: string;
+};
+
+export function NewQuestionButton({ viewName }: NewQuestionButtonProps) {
+ const { provider, table } = useAuditTable(viewName);
+
+ const url = useMemo(() => {
+ if (provider == null || table == null) {
+ return null;
+ }
+ const query = Lib.queryFromTableOrCardMetadata(provider, table);
+ return Urls.newQuestion({
+ dataset_query: Lib.toJsQuery(query),
+ mode: "notebook",
+ });
+ }, [provider, table]);
+
+ if (url == null) {
+ return null;
+ }
+
+ return (
+ <Button
+ component={ForwardRefLink}
+ to={url}
+ variant="default"
+ leftSection={<Icon name="insight" />}
+ >
+ {t`Query this data`}
+ </Button>
+ );
+}
diff --git a/enterprise/frontend/src/metabase-enterprise/monitor/ai-auditing/components/NewQuestionButton/NewQuestionButton.unit.spec.tsx b/enterprise/frontend/src/metabase-enterprise/monitor/ai-auditing/components/NewQuestionButton/NewQuestionButton.unit.spec.tsx
new file mode 100644
index 00000000000..f7c628f9f76
--- /dev/null
+++ b/enterprise/frontend/src/metabase-enterprise/monitor/ai-auditing/components/NewQuestionButton/NewQuestionButton.unit.spec.tsx
@@ -0,0 +1,50 @@
+import fetchMock from "fetch-mock";
+
+import { renderWithProviders, screen } from "__support__/ui";
+import { AUDIT_DB_ID } from "metabase-enterprise/monitor/ai-auditing/metabot-analytics/constants";
+import {
+ createMockDatabase,
+ createMockField,
+ createMockTable,
+} from "metabase-types/api/mocks";
+
+import { NewQuestionButton } from "./NewQuestionButton";
+
+const VIEW_NAME = "v_mcp_tool_calls";
+const TABLE_ID = 3001;
+
+const viewTable = createMockTable({
+ id: TABLE_ID,
+ db_id: AUDIT_DB_ID,
+ schema: "public",
+ name: VIEW_NAME,
+ display_name: VIEW_NAME,
+ fields: [
+ createMockField({ id: TABLE_ID * 100, table_id: TABLE_ID, name: "tool" }),
+ ],
+});
+
+const auditDatabase = createMockDatabase({
+ id: AUDIT_DB_ID,
+ tables: [viewTable],
+});
+
+function setup() {
+ fetchMock.get(`path:/api/database/${AUDIT_DB_ID}/metadata`, auditDatabase);
+ fetchMock.post("path:/api/dataset/query_metadata", {
+ databases: [auditDatabase],
+ tables: [viewTable],
+ fields: viewTable.fields ?? [],
+ });
+
+ renderWithProviders(<NewQuestionButton viewName={VIEW_NAME} />);
+}
+
+describe("NewQuestionButton", () => {
+ it("links to a notebook question on the view", async () => {
+ setup();
+
+ const link = await screen.findByRole("link", { name: /Query this data/ });
+ expect(link).toHaveAttribute("href", expect.stringContaining("/question"));
+ });
+});
diff --git a/enterprise/frontend/src/metabase-enterprise/monitor/ai-auditing/components/NewQuestionButton/index.ts b/enterprise/frontend/src/metabase-enterprise/monitor/ai-auditing/components/NewQuestionButton/index.ts
new file mode 100644
index 00000000000..db80e728351
--- /dev/null
+++ b/enterprise/frontend/src/metabase-enterprise/monitor/ai-auditing/components/NewQuestionButton/index.ts
@@ -0,0 +1 @@
+export { NewQuestionButton } from "./NewQuestionButton";
diff --git a/enterprise/frontend/src/metabase-enterprise/monitor/ai-auditing/mcp-analytics/components/McpAnalyticsSectionLayout.tsx b/enterprise/frontend/src/metabase-enterprise/monitor/ai-auditing/mcp-analytics/components/McpAnalyticsSectionLayout.tsx
index 9eae9c9e91e..c93a00678e7 100644
--- a/enterprise/frontend/src/metabase-enterprise/monitor/ai-auditing/mcp-analytics/components/McpAnalyticsSectionLayout.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/monitor/ai-auditing/mcp-analytics/components/McpAnalyticsSectionLayout.tsx
@@ -8,6 +8,7 @@ import { Outlet, useLocation } from "metabase/router";
import { useSetting } from "metabase/settings";
import * as Urls from "metabase/urls";
import { AiAnalyticsSectionLayout } from "metabase-enterprise/monitor/ai-auditing/components/AiAnalyticsSectionLayout";
+import { NewQuestionButton } from "metabase-enterprise/monitor/ai-auditing/components/NewQuestionButton";
import {
VIEW_GROUP_MEMBERS,
VIEW_MCP_TOOL_CALLS,
@@ -126,6 +127,7 @@ export function McpAnalyticsSectionLayout() {
<AiAnalyticsSectionLayout
title={t`MCP analytics`}
tabs={tabs}
+ filtersAction={<NewQuestionButton viewName={VIEW_MCP_TOOL_CALLS} />}
filters={
<McpToolCallsFilter
date={date}
diff --git a/enterprise/frontend/src/metabase-enterprise/monitor/api-key-usage/components/ApiKeyUsageSectionLayout.tsx b/enterprise/frontend/src/metabase-enterprise/monitor/api-key-usage/components/ApiKeyUsageSectionLayout.tsx
index 91a4deb22ed..2f13a0a9f61 100644
--- a/enterprise/frontend/src/metabase-enterprise/monitor/api-key-usage/components/ApiKeyUsageSectionLayout.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/monitor/api-key-usage/components/ApiKeyUsageSectionLayout.tsx
@@ -15,6 +15,7 @@ import { Outlet, useLocation } from "metabase/router";
import { useSetting } from "metabase/settings";
import { Flex, Loader, Stack } from "metabase/ui";
import * as Urls from "metabase/urls";
+import { NewQuestionButton } from "metabase-enterprise/monitor/ai-auditing/components/NewQuestionButton";
import {
ConversationFilters as ApiKeyUsageFilterBar,
parseId,
@@ -182,45 +183,48 @@ export function ApiKeyUsageSectionLayout() {
const tabsAndFilters = (
<>
<PillTabNavigation tabs={tabs} />
- <ApiKeyUsageFilterBar
- date={date}
- onDateChange={(val) => patchUrlState({ date: val, page: 0 })}
- user={user}
- onUserChange={(val) => patchUrlState({ user: val, page: 0 })}
- userOptions={userOptions}
- group={group}
- onGroupChange={(val) =>
- patchUrlState({
- group: val,
- // Like picking a new State: a key that isn't in the new group is cleared.
- ...(isKeyOutsideGroup(
- selectedApiKey,
- val == null ? null : Number(val),
- )
- ? { api_key: null }
- : {}),
- page: 0,
- })
- }
- groupOptions={groupOptions}
- groupNoFilterValue={groupNoFilterValue}
- // Tenants aren't a meaningful concept for API-key usage — see EMB-2391, which will make
- // this shared filter bar's tenant support properly optional instead of hardcoded off here.
- tenant={null}
- onTenantChange={() => {}}
- tenantOptions={[]}
- hasTenants={false}
- // The API key filter (below) is the primary way to scope this page; a separate user
- // filter is redundant now that "Created by" is just a column.
- hasUsers={false}
- extraFilter={
- <ApiKeyFilterSelect
- value={keyOutsideGroup ? null : api_key}
- onChange={(val) => patchUrlState({ api_key: val, page: 0 })}
- groupId={groupId}
- />
- }
- />
+ <Flex justify="space-between" align="center" gap="md">
+ <ApiKeyUsageFilterBar
+ date={date}
+ onDateChange={(val) => patchUrlState({ date: val, page: 0 })}
+ user={user}
+ onUserChange={(val) => patchUrlState({ user: val, page: 0 })}
+ userOptions={userOptions}
+ group={group}
+ onGroupChange={(val) =>
+ patchUrlState({
+ group: val,
+ // Like picking a new State: a key that isn't in the new group is cleared.
+ ...(isKeyOutsideGroup(
+ selectedApiKey,
+ val == null ? null : Number(val),
+ )
+ ? { api_key: null }
+ : {}),
+ page: 0,
+ })
+ }
+ groupOptions={groupOptions}
+ groupNoFilterValue={groupNoFilterValue}
+ // Tenants aren't a meaningful concept for API-key usage — see EMB-2391, which will make
+ // this shared filter bar's tenant support properly optional instead of hardcoded off here.
+ tenant={null}
+ onTenantChange={() => {}}
+ tenantOptions={[]}
+ hasTenants={false}
+ // The API key filter (below) is the primary way to scope this page; a separate user
+ // filter is redundant now that "Created by" is just a column.
+ hasUsers={false}
+ extraFilter={
+ <ApiKeyFilterSelect
+ value={keyOutsideGroup ? null : api_key}
+ onChange={(val) => patchUrlState({ api_key: val, page: 0 })}
+ groupId={groupId}
+ />
+ }
+ />
+ <NewQuestionButton viewName={VIEW_API_KEY_USAGE} />
+ </Flex>
</>
);