The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:
TypeScript analyticsbibusiness-intelligencebusinessintelligenceclojuredashboarddatadata-analysisdata-visualizationdatabasemetabasemysqlpostgrespostgresqlreportingslacksql-editorvisualization
Prevent driver tests (#66156)
dpsutton442fd726a333
diff --git a/.github/actions/prepare-backend/action.yml b/.github/actions/prepare-backend/action.ymlindex 47cd330ab42..147b8b25517 100644--- a/.github/actions/prepare-backend/action.yml+++ b/.github/actions/prepare-backend/action.yml@@ -25,11 +25,6 @@ runs:curl -O https://download.clojure.org/install/linux-install-${{ inputs.clojure-version }}.sh &&sudo bash ./linux-install-${{ inputs.clojure-version }}.sh- - name: Fetch CI config- shell: bash- run: |- curl -o ci-test-config.json https://raw.githubusercontent.com/metabase/metabase/refs/heads/master/ci-test-config.json-- name: Get M2 cache keyuses: ./.github/actions/get-cache-keysid: get-cache-keysdiff --git a/.github/actions/test-driver/action.yml b/.github/actions/test-driver/action.ymlindex 727299f3dac..cd07ffe9058 100644--- a/.github/actions/test-driver/action.yml+++ b/.github/actions/test-driver/action.yml@@ -10,21 +10,54 @@ inputs:required: truedefault: false+outputs:+ quarantine-skipped:+ description: Whether the driver test was skipped due to quarantine+ value: ${{ steps.check-driver.outputs.skip }}+runs:using: "composite"steps:+ - name: Check if driver is ignored+ id: check-driver+ shell: bash+ run: |+ # If DRIVERS env var is not set, proceed with tests+ if [ -z "$DRIVERS" ]; then+ echo "No DRIVERS env var set. Proceeding with tests."+ echo "skip=false" >> $GITHUB_OUTPUT+ exit 0+ fi++ # Fetch CI config and check if driver should be skipped+ curl -sSf -o ci-test-config.json https://raw.githubusercontent.com/metabase/ci-test-config/refs/heads/master/ci-test-config.json || true++ # Check if the driver is in the ignored list (gracefully handle missing/invalid config)+ IS_IGNORED=$(jq --arg driver "$DRIVERS" '.ignored.drivers // [] | contains([$driver])' ci-test-config.json 2>/dev/null || echo "false")++ if [ "$IS_IGNORED" = "true" ]; then+ echo "⚠️ Driver '$DRIVERS' is in the ignored list. Skipping tests."+ echo "View the ignored list here: https://github.com/metabase/ci-test-config/blob/master/ci-test-config.json"+ echo "skip=true" >> $GITHUB_OUTPUT+ else+ echo "Driver '$DRIVERS' is not ignored. Proceeding with tests."+ echo "skip=false" >> $GITHUB_OUTPUT+ fi+- name: Prepare back-end environment+ if: steps.check-driver.outputs.skip != 'true'uses: ./.github/actions/prepare-backend- name: Prepare front-end environment+ if: ${{ steps.check-driver.outputs.skip != 'true' && inputs.build-static-viz == 'true' }}uses: ./.github/actions/prepare-frontend- if: ${{ inputs.build-static-viz == 'true' }}- name: Build static viz frontend+ if: ${{ steps.check-driver.outputs.skip != 'true' && inputs.build-static-viz == 'true' }}run: yarn build-static-vizshell: bash- if: ${{ inputs.build-static-viz == 'true' }}env:MB_EDITION: ee- name: Test database driver+ if: steps.check-driver.outputs.skip != 'true'run: clojure -X:dev:ci:ee:ee-dev:drivers:drivers-dev:test ${{ inputs.test-args }}shell: bashid: run-test@@ -37,7 +70,7 @@ runs:# As per the documentation: https://docs.github.com/en/actions/reference/workflows-and-actions/contexts#steps-context# test.outcome gives us access to the result before `continue-on-error` overrides it and sets it to 'success'.# We want test reports even if the test step gets cancelled (e.g. times out), hence we match anything that is not a 'success'.- if: steps.run-test.outcome != 'success'+ if: ${{ steps.run-test.outcome != 'success' && steps.check-driver.outputs.skip != 'true' }}with:path: "target/junit/**/*_test.xml"name: JUnit Test Report ${{ inputs.junit-name }}@@ -46,7 +79,7 @@ runs:list-tests: failedfail-on-error: false- name: Upload Logs on Failure- if: always() && steps.run-test.outcome != 'success'+ if: always() && steps.run-test.outcome != 'success' && steps.check-driver.outputs.skip != 'true'uses: actions/upload-artifact@v4with:name: test-logs-${{ github.job }}diff --git a/.github/workflows/drivers.yml b/.github/workflows/drivers.ymlindex ccb408af037..19722da34f1 100644--- a/.github/workflows/drivers.yml+++ b/.github/workflows/drivers.yml@@ -67,6 +67,7 @@ jobs:steps:- uses: actions/checkout@v4- name: Test Athena driver+ id: test-driveruses: ./.github/actions/test-driverwith:junit-name: 'be-tests-athena-ee'@@ -75,7 +76,7 @@ jobs::exclude-tags [:mb/transforms-python-test]- name: Upload Test Resultsuses: ./.github/actions/upload-test-results- if: always()+ if: always() && steps.test-driver.outputs.quarantine-skipped != 'true'with:input-path: ./target/junit/output-name: ${{ github.job }}@@ -129,7 +130,7 @@ jobs:test-args: ${{ matrix.job.test-args }}- name: Upload Test Resultsuses: ./.github/actions/upload-test-results- if: always()+ if: always() && steps.test-driver.outputs.quarantine-skipped != 'true'with:input-path: ./target/junit/output-name: ${{ github.job }}@@ -200,7 +201,7 @@ jobs:test-args: ${{ matrix.job.test-args }}- name: Upload Test Resultsuses: ./.github/actions/upload-test-results- if: always()+ if: always() && steps.test-driver.outputs.quarantine-skipped != 'true'with:input-path: ./target/junit/output-name: ${{ github.job }}@@ -235,6 +236,7 @@ jobs:steps:- uses: actions/checkout@v4- name: Test Druid driver+ id: test-driveruses: ./.github/actions/test-driverwith:junit-name: 'be-tests-druid-ee'@@ -243,7 +245,7 @@ jobs::exclude-tags [:mb/transforms-python-test]- name: Upload Test Resultsuses: ./.github/actions/upload-test-results- if: always()+ if: always() && steps.test-driver.outputs.quarantine-skipped != 'true'with:input-path: ./target/junit/output-name: ${{ github.job }}@@ -272,6 +274,7 @@ jobs:steps:- uses: actions/checkout@v4- name: Test Druid JDBC driver+ id: test-driveruses: ./.github/actions/test-driverwith:junit-name: 'be-tests-druid-jdbc-ee'@@ -280,7 +283,7 @@ jobs::exclude-tags [:mb/transforms-python-test]- name: Upload Test Resultsuses: ./.github/actions/upload-test-results- if: always()+ if: always() && steps.test-driver.outputs.quarantine-skipped != 'true'with:input-path: ./target/junit/output-name: ${{ github.job }}@@ -309,6 +312,7 @@ jobs:steps:- uses: actions/checkout@v4- name: Test Databricks driver+ id: test-driveruses: ./.github/actions/test-driverwith:junit-name: 'be-tests-databricks-ee'@@ -317,7 +321,7 @@ jobs::exclude-tags [:mb/transforms-python-test]- name: Upload Test Resultsuses: ./.github/actions/upload-test-results- if: always()+ if: always() && steps.test-driver.outputs.quarantine-skipped != 'true'with:input-path: ./target/junit/output-name: ${{ github.job }}@@ -347,6 +351,7 @@ jobs:steps:- uses: actions/checkout@v4- name: Test Databricks driver with multi-catalog+ id: test-driveruses: ./.github/actions/test-driverwith:junit-name: 'be-tests-databricks-multi-catalog-ee'@@ -355,7 +360,7 @@ jobs::exclude-tags [:mb/transforms-python-test]- name: Upload Test Resultsuses: ./.github/actions/upload-test-results- if: always()+ if: always() && steps.test-driver.outputs.quarantine-skipped != 'true'with:input-path: ./target/junit/output-name: ${{ github.job }}@@ -384,7 +389,7 @@ jobs::exclude-tags [:mb/transforms-python-test]- name: Upload Test Resultsuses: ./.github/actions/upload-test-results- if: always()+ if: always() && steps.test-driver.outputs.quarantine-skipped != 'true'with:input-path: ./target/junit/output-name: ${{ github.job }}@@ -513,7 +518,7 @@ jobs::exclude-tags '[ ${{ matrix.job.exclude-tag }} ${{ env.__ADDITIONAL_EXCLUDED_TAG__ }}]'- name: Upload Test Resultsuses: ./.github/actions/upload-test-results- if: always()+ if: always() && steps.test-driver.outputs.quarantine-skipped != 'true'with:input-path: ./target/junit/output-name: ${{ github.job }}@@ -582,7 +587,7 @@ jobs:test-args: ${{ matrix.job.test-args }}- name: Upload Test Resultsuses: ./.github/actions/upload-test-results- if: always()+ if: always() && steps.test-driver.outputs.quarantine-skipped != 'true'with:input-path: ./target/junit/output-name: ${{ github.job }}@@ -645,6 +650,7 @@ jobs:curl https://raw.githubusercontent.com/metabase/metabase-qa/master/dbs/mongo/certificates/metaca.crt \-o ./test_resources/ssl/mongo/metaca.crt- name: Test ${{ matrix.version.name }}+ id: test-driveruses: ./.github/actions/test-driverwith:junit-name: ${{ matrix.version.junit-name }}@@ -653,7 +659,7 @@ jobs::only-tags [:mb/driver-tests]- name: Upload Test Resultsuses: ./.github/actions/upload-test-results- if: always()+ if: always() && steps.test-driver.outputs.quarantine-skipped != 'true'with:input-path: ./target/junit/output-name: ${{ github.job }}@@ -680,6 +686,7 @@ jobs:steps:- uses: actions/checkout@v4- name: Test MongoDB driver (Sharded cluster)+ id: test-driveruses: ./.github/actions/test-driverwith:junit-name: 'be-tests-mongo-sharded-cluster-ee'@@ -687,7 +694,7 @@ jobs::only metabase.driver.mongo.sharded-cluster-test- name: Upload Test Resultsuses: ./.github/actions/upload-test-results- if: always()+ if: always() && steps.test-driver.outputs.quarantine-skipped != 'true'with:input-path: ./target/junit/output-name: ${{ github.job }}@@ -752,6 +759,7 @@ jobs:steps:- uses: actions/checkout@v4- name: Test ${{ matrix.version.name }}+ id: test-driveruses: ./.github/actions/test-driverwith:junit-name: ${{ matrix.version.junit-name }}@@ -760,7 +768,7 @@ jobs::exclude-tags [:mb/transforms-python-test]- name: Upload Test Resultsuses: ./.github/actions/upload-test-results- if: always()+ if: always() && steps.test-driver.outputs.quarantine-skipped != 'true'with:input-path: ./target/junit/output-name: ${{ github.job }}@@ -863,7 +871,7 @@ jobs::exclude-tags '[ ${{ matrix.job.exclude-tag }} ${{ env.__ADDITIONAL_EXCLUDED_TAG__ }}]'- name: Upload Test Resultsuses: ./.github/actions/upload-test-results- if: always()+ if: always() && steps.test-driver.outputs.quarantine-skipped != 'true'with:input-path: ./target/junit/output-name: ${{ github.job }}@@ -931,6 +939,7 @@ jobs:-file /tmp/presto-ssl-ca.der-trustcacerts- name: Test Presto JDBC driver+ id: test-driveruses: ./.github/actions/test-driverwith:junit-name: 'be-tests-presto-jdbc-ee'@@ -939,7 +948,7 @@ jobs::exclude-tags [:mb/transforms-python-test]- name: Upload Test Resultsuses: ./.github/actions/upload-test-results- if: always()+ if: always() && steps.test-driver.outputs.quarantine-skipped != 'true'with:input-path: ./target/junit/output-name: ${{ github.job }}@@ -1002,7 +1011,7 @@ jobs:${{ matrix.job.test-args }}- name: Upload Test Resultsuses: ./.github/actions/upload-test-results- if: ${{ !matrix.job.skip && !cancelled() }}+ if: ${{ !matrix.job.skip && !cancelled() && steps.test-driver.outputs.quarantine-skipped != 'true' }}with:input-path: ./target/junit/output-name: ${{ github.job }}@@ -1019,7 +1028,8 @@ jobs:logs-artifact-suffix: ${{ matrix.job.name }} ${{ matrix.version.name }}be-tests-snowflake-ee:- if: ${{ !inputs.skip }}+ needs: determine-driver-skips+ if: ${{ !inputs.skip && !(needs.determine-driver-skips.outputs.skip == 'true') }}runs-on: ubuntu-latesttimeout-minutes: 60strategy:@@ -1071,7 +1081,7 @@ jobs:test-args: ${{ matrix.job.test-args }}- name: Upload Test Resultsuses: ./.github/actions/upload-test-results- if: always()+ if: always() && steps.test-driver.outputs.quarantine-skipped != 'true'with:input-path: ./target/junit/output-name: ${{ github.job }}@@ -1104,6 +1114,7 @@ jobs:steps:- uses: actions/checkout@v4- name: Test Spark driver+ id: test-driveruses: ./.github/actions/test-driverwith:junit-name: 'be-tests-sparksql-ee'@@ -1112,7 +1123,7 @@ jobs::exclude-tags [:mb/transforms-python-test]- name: Upload Test Resultsuses: ./.github/actions/upload-test-results- if: always()+ if: always() && steps.test-driver.outputs.quarantine-skipped != 'true'with:input-path: ./target/junit/output-name: ${{ github.job }}@@ -1134,6 +1145,7 @@ jobs:steps:- uses: actions/checkout@v4- name: Test SQLite driver+ id: test-driveruses: ./.github/actions/test-driverwith:junit-name: 'be-tests-sqlite-ee'@@ -1142,7 +1154,7 @@ jobs::exclude-tags [:mb/transforms-python-test]- name: Upload Test Resultsuses: ./.github/actions/upload-test-results- if: always()+ if: always() && steps.test-driver.outputs.quarantine-skipped != 'true'with:input-path: ./target/junit/output-name: ${{ github.job }}@@ -1207,7 +1219,7 @@ jobs:test-args: ${{ matrix.job.test-args }}- name: Upload Test Resultsuses: ./.github/actions/upload-test-results- if: always()+ if: always() && steps.test-driver.outputs.quarantine-skipped != 'true'with:input-path: ./target/junit/output-name: ${{ github.job }}@@ -1314,6 +1326,7 @@ jobs:- name: Make plugins directoryrun: mkdir plugins- name: Test Vertica driver+ id: test-driveruses: ./.github/actions/test-driverwith:junit-name: 'be-tests-vertica-ee'@@ -1322,7 +1335,7 @@ jobs::exclude-tags [:mb/transforms-python-test]- name: Upload Test Resultsuses: ./.github/actions/upload-test-results- if: always()+ if: always() && steps.test-driver.outputs.quarantine-skipped != 'true'with:input-path: ./target/junit/output-name: ${{ github.job }}diff --git a/modules/drivers/snowflake/test/metabase/driver/snowflake_test.clj b/modules/drivers/snowflake/test/metabase/driver/snowflake_test.cljindex 4b99ed28d28..497d031c936 100644--- a/modules/drivers/snowflake/test/metabase/driver/snowflake_test.clj+++ b/modules/drivers/snowflake/test/metabase/driver/snowflake_test.clj@@ -265,7 +265,7 @@(is (= [{:s schema}] (jdbc/query spec ["select CURRENT_SCHEMA() s"])))(is (= 1 (count (jdbc/query spec ["select * from \"TABLES\" limit 1"])))))))))-(deftest additional-options-test+(deftest ^:sequential additional-options-test(mt/test-driver:snowflake(let [existing-details (dissoc (:details (mt/db)) :password)]