Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

ellipisify table names, fix published table link (#67402)

Nick Fitzpatrick453478f9fb50
diff --git a/enterprise/frontend/src/metabase-enterprise/data-studio/data-model/components/TableSection/TableCollection.tsx b/enterprise/frontend/src/metabase-enterprise/data-studio/data-model/components/TableSection/TableCollection.tsx
index f9aa4425c77..00117a96f7d 100644
--- a/enterprise/frontend/src/metabase-enterprise/data-studio/data-model/components/TableSection/TableCollection.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/data-studio/data-model/components/TableSection/TableCollection.tsx
@@ -22,7 +22,7 @@ export function TableCollection({ table }: TableCollectionProps) {
<Box
className={S.link}
component={Link}
- to={Urls.dataStudioCollection(collection.id)}
+ to={Urls.dataStudioLibrary({ expandedIds: [collection.id] })}
fw="bold"
>
{collection.name}
diff --git a/enterprise/frontend/src/metabase-enterprise/data-studio/data-model/components/TableSection/TableMetadata.tsx b/enterprise/frontend/src/metabase-enterprise/data-studio/data-model/components/TableSection/TableMetadata.tsx
index 7d5090d8677..6ed8cf2417d 100644
--- a/enterprise/frontend/src/metabase-enterprise/data-studio/data-model/components/TableSection/TableMetadata.tsx
+++ b/enterprise/frontend/src/metabase-enterprise/data-studio/data-model/components/TableSection/TableMetadata.tsx
@@ -2,6 +2,7 @@ import type { ReactNode } from "react";
import { useId } from "react";
import { t } from "ttag";
+import { Ellipsified } from "metabase/common/components/Ellipsified";
import Link from "metabase/common/components/Link";
import { useNumberFormatter } from "metabase/common/hooks/use-number-formatter";
import { isNullOrUndefined } from "metabase/lib/types";
@@ -94,13 +95,18 @@ function MetadataRow({
}) {
const id = useId();
return (
- <Group justify="space-between">
- <Text size="md" c="text-primary" id={id}>
+ <Group justify="space-between" gap="lg" wrap="nowrap">
+ <Text size="md" c="text-primary" id={id} flex="1 0 auto">
{label}
</Text>
- <Text size="md" c="text-primary" aria-labelledby={id}>
+ <Ellipsified
+ size="md"
+ c="text-primary"
+ aria-labelledby={id}
+ tooltipProps={{ maw: "unset" }}
+ >
{value}
- </Text>
+ </Ellipsified>
</Group>
);
}
diff --git a/frontend/src/metabase/lib/urls/data-studio.ts b/frontend/src/metabase/lib/urls/data-studio.ts
index 905fa1cb77b..448e8566d14 100644
--- a/frontend/src/metabase/lib/urls/data-studio.ts
+++ b/frontend/src/metabase/lib/urls/data-studio.ts
@@ -215,10 +215,6 @@ export function dataStudioGlossary() {
return `${dataStudio()}/glossary`;
}
-export function dataStudioCollection(collectionId: CollectionId) {
- return `${dataStudioLibrary()}/collections/${collectionId}`;
-}
-
export function dataStudioSnippet(snippetId: NativeQuerySnippetId) {
return `${dataStudioLibrary()}/snippets/${snippetId}`;
}