Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Convert `common/hooks/use-scroll-on-mount` to TypeScript (#69440)

Fraser4568848fb0d0
diff --git a/frontend/src/metabase/common/components/tree/TreeNodeList.tsx b/frontend/src/metabase/common/components/tree/TreeNodeList.tsx
index cbd82b432a0..f660d3efc58 100644
--- a/frontend/src/metabase/common/components/tree/TreeNodeList.tsx
+++ b/frontend/src/metabase/common/components/tree/TreeNodeList.tsx
@@ -31,7 +31,7 @@ function BaseTreeNodeList<TData = unknown>({
role,
...boxProps
}: TreeNodeListProps<TData>) {
- const selectedRef = useScrollOnMount();
+ const selectedRef = useScrollOnMount<HTMLLIElement>();
return (
<Box component="ul" role={role} {...boxProps}>
diff --git a/frontend/src/metabase/common/hooks/use-scroll-on-mount.js b/frontend/src/metabase/common/hooks/use-scroll-on-mount.ts
similarity index 62%
rename from frontend/src/metabase/common/hooks/use-scroll-on-mount.js
rename to frontend/src/metabase/common/hooks/use-scroll-on-mount.ts
index 9d1044d1a12..3a1e5b17be2 100644
--- a/frontend/src/metabase/common/hooks/use-scroll-on-mount.js
+++ b/frontend/src/metabase/common/hooks/use-scroll-on-mount.ts
@@ -1,7 +1,7 @@
import { useEffect, useRef } from "react";
-export const useScrollOnMount = () => {
- const ref = useRef(null);
+export const useScrollOnMount = <T extends HTMLElement = HTMLElement>() => {
+ const ref = useRef<T>(null);
useEffect(() => {
if (ref.current) {
diff --git a/frontend/src/metabase/timelines/questions/components/EventCard/EventCard.tsx b/frontend/src/metabase/timelines/questions/components/EventCard/EventCard.tsx
index e407b5593ed..de3208e676f 100644
--- a/frontend/src/metabase/timelines/questions/components/EventCard/EventCard.tsx
+++ b/frontend/src/metabase/timelines/questions/components/EventCard/EventCard.tsx
@@ -48,7 +48,7 @@ const EventCard = ({
onShowTimelineEvents,
onHideTimelineEvents,
}: EventCardProps): JSX.Element => {
- const selectedRef = useScrollOnMount();
+ const selectedRef = useScrollOnMount<HTMLDivElement>();
const menuItems = getMenuItems(event, timeline, onEdit, onMove, onArchive);
const dateMessage = getDateMessage(event);
const creatorMessage = getCreatorMessage(event);