Skip to content

The easy-to-use open source Business Intelligence and Embedded Analytics tool that lets everyone work with data :bar_chart:

Fix broken e2e reproduction 63416 (#73289)

Nemanja Glumac4674bf002250
diff --git a/e2e/support/helpers/e2e-dashboard-helpers.ts b/e2e/support/helpers/e2e-dashboard-helpers.ts
index 680ebdc9432..26eedae39ce 100644
--- a/e2e/support/helpers/e2e-dashboard-helpers.ts
+++ b/e2e/support/helpers/e2e-dashboard-helpers.ts
@@ -52,6 +52,9 @@ export function getEmbeddedDashboardCardMenu(index = 0) {
}
export function getDashboardCardMenu(index = 0) {
+ cy.log("Wait for the card results to load");
+ getDashboardCard(index).findByTestId("loading-indicator").should("not.exist");
+ cy.log("Click on the card menu");
return getDashboardCard(index).findByTestId("dashcard-menu");
}
diff --git a/e2e/support/helpers/e2e-downloads-helpers.ts b/e2e/support/helpers/e2e-downloads-helpers.ts
index fa4b9e31207..defa99ef6c8 100644
--- a/e2e/support/helpers/e2e-downloads-helpers.ts
+++ b/e2e/support/helpers/e2e-downloads-helpers.ts
@@ -141,7 +141,7 @@ export function downloadAndAssert({
}
}
- cy.get("[aria-label='Download results']").click();
+ cy.findByLabelText("Download results").should("be.visible").click();
popover().within(() => {
cy.findByText(`.${fileType}`).click();
diff --git a/e2e/test/scenarios/dashboard-cards/dashboard-card-reproductions.cy.spec.js b/e2e/test/scenarios/dashboard-cards/dashboard-card-reproductions.cy.spec.js
index 716f74e9421..d4fa00c82ba 100644
--- a/e2e/test/scenarios/dashboard-cards/dashboard-card-reproductions.cy.spec.js
+++ b/e2e/test/scenarios/dashboard-cards/dashboard-card-reproductions.cy.spec.js
@@ -1636,20 +1636,20 @@ describe("issue 63416", () => {
],
});
+ cy.wrap(dashboard.id).as("dashboardId");
+
H.visitDashboard(dashboard.id);
});
});
- it("should download visualizer dashboard card without additional dataset with proper parameter values (metabase#63416)", () => {
+ it("should download visualizer dashboard card without additional dataset with proper parameter values (metabase#63416)", function () {
H.editDashboard();
H.showDashcardVisualizerModalSettings(0, {
isVisualizerCard: false,
});
- H.modal()
- .findByLabelText("Description")
- .type("Make this a visualizer card");
+ cy.log("Make this a visualizer card");
H.saveDashcardVisualizerModal();
H.saveDashboard();
@@ -1660,7 +1660,7 @@ describe("issue 63416", () => {
fileType: "csv",
isDashboard: true,
downloadMethod: "POST",
- downloadUrl: "/api/dashboard/10/dashcard/*/card/*/query/csv",
+ downloadUrl: `/api/dashboard/${this.dashboardId}/dashcard/*/card/*/query/csv`,
assertParameters: [{ type: "string/=", value: ["Doohickey"] }],
});
});